[INFO] cloning repository https://github.com/tialaramex/misfortunate [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tialaramex/misfortunate" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftialaramex%2Fmisfortunate", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftialaramex%2Fmisfortunate'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 07991f32826f6f96ef3e3bec70b2da42210a6aeb [INFO] linting tialaramex/misfortunate against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftialaramex%2Fmisfortunate" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tialaramex/misfortunate [INFO] finished tweaking git repo https://github.com/tialaramex/misfortunate [INFO] tweaked toml for git repo https://github.com/tialaramex/misfortunate written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tialaramex/misfortunate on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tialaramex/misfortunate already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b976e7155332accc04dded76b5e35b2ff3d03e820fe10d152eb1df800bcf598 [INFO] running `Command { std: "docker" "start" "-a" "3b976e7155332accc04dded76b5e35b2ff3d03e820fe10d152eb1df800bcf598", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b976e7155332accc04dded76b5e35b2ff3d03e820fe10d152eb1df800bcf598", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b976e7155332accc04dded76b5e35b2ff3d03e820fe10d152eb1df800bcf598", kill_on_drop: false }` [INFO] [stdout] 3b976e7155332accc04dded76b5e35b2ff3d03e820fe10d152eb1df800bcf598 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4efebec867fb6926c8eaf76e81418fcd28eadb09fae57af0ef9eba31f5edc7c5 [INFO] running `Command { std: "docker" "start" "-a" "4efebec867fb6926c8eaf76e81418fcd28eadb09fae57af0ef9eba31f5edc7c5", kill_on_drop: false }` [INFO] [stderr] Checking misfortunate v1.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/always.rs:88:15 [INFO] [stdout] | [INFO] [stdout] 88 | input.into_iter().map(wrapper).collect() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | assert!(5 > 1 && 5 > 3 && 3 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `5 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | assert!(5 > 1 && 5 > 3 && 3 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `5 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/always.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | assert!(5 > 1 && 5 > 3 && 3 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/always.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/always.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/always.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/funhouse.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | assert!(1 == 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/mirror.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | assert!(1 == 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/mirror.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | assert!(1 == 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/mirror.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | assert!(1 != 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/mirror.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert!(1 != 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 51 | make_oneway!(OnewayEqual, true, Equal); [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 68 | make_oneway!(OnewayGreater, false, Greater); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 85 | make_oneway!(OnewayLess, false, Less); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 106 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `3 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `3 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/oneway.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/oneway.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | assert!(1 != 3 && 3 != 5 && 1 != 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 != 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | assert!(1 != 3 && 3 != 5 && 1 != 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `1 != 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/oneway.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | assert!(1 != 3 && 3 != 5 && 1 != 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `3 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/oneway.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `3 > 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/oneway.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/oneway.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | assert!(3 > 1 && 5 > 3 && 5 > 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/oneway.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 136 | input.into_iter().map(wrapper).collect() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reverse.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reverse.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/reverse.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reverse.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reverse.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `1 < 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/reverse.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | assert!(1 < 3 && 3 < 5 && 1 < 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/nice.rs:92:38 [INFO] [stdout] | [INFO] [stdout] 92 | let a: u8 = words.iter().map(|w| Nice(w)).sum(); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple struct itself: `Nice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/nice.rs:94:43 [INFO] [stdout] | [INFO] [stdout] 94 | let b: u8 = words.into_iter().map(|w| Nice(w)).product(); [INFO] [stdout] | ^^^^^^^^^^^ help: replace the closure with the tuple struct itself: `Nice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/echo.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / impl PartialOrd for Echo { [INFO] [stdout] 45 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 46 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 47 | | Some(self.order.replace_with(|_| self.inner.cmp(&other.inner))) [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 47 - Some(self.order.replace_with(|_| self.inner.cmp(&other.inner))) [INFO] [stdout] 48 - } [INFO] [stdout] 46 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/echo.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 70 | input.into_iter().map(wrapper).collect() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/jumble.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / impl PartialOrd for Jumble { [INFO] [stdout] 54 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 55 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 56 | | Some(self.order.replace_with(|&mut o| jumble(o))) [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 55 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 56 - Some(self.order.replace_with(|&mut o| jumble(o))) [INFO] [stdout] 57 - } [INFO] [stdout] 55 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/jumble.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 79 | input.into_iter().map(wrapper).collect() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lapse.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | *n = *n + 2; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*n += 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lapse.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | *n = *n + 3; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*n += 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lapse.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | *n = *n + 4; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*n += 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lapse.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | *n = *n + 0; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `*n += 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lapse.rs:119:14 [INFO] [stdout] | [INFO] [stdout] 119 | *n = *n + 0; [INFO] [stdout] | ^^^^^^ help: consider reducing it to: `*n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 51 | make_oneway!(OnewayEqual, true, Equal); [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 68 | make_oneway!(OnewayGreater, false, Greater); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/oneway.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / impl PartialOrd for $class { [INFO] [stdout] 18 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 19 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 | | Some($order) [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 85 | make_oneway!(OnewayLess, false, Less); [INFO] [stdout] | ------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: this warning originates in the macro `make_oneway` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 20 - Some($order) [INFO] [stdout] 21 - } [INFO] [stdout] 19 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/echo.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / impl PartialOrd for Echo { [INFO] [stdout] 45 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 46 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 47 | | Some(self.order.replace_with(|_| self.inner.cmp(&other.inner))) [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 47 - Some(self.order.replace_with(|_| self.inner.cmp(&other.inner))) [INFO] [stdout] 48 - } [INFO] [stdout] 46 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/jumble.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | / impl PartialOrd for Jumble { [INFO] [stdout] 54 | | #[allow(clippy::non_canonical_partial_ord_impl)] [INFO] [stdout] 55 | | fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 56 | | Some(self.order.replace_with(|&mut o| jumble(o))) [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 55 - fn partial_cmp(&self, _other: &Self) -> Option { [INFO] [stdout] 56 - Some(self.order.replace_with(|&mut o| jumble(o))) [INFO] [stdout] 57 - } [INFO] [stdout] 55 + fn partial_cmp(&self, _other: &Self) -> Option { Some(self.cmp(_other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.78s [INFO] running `Command { std: "docker" "inspect" "4efebec867fb6926c8eaf76e81418fcd28eadb09fae57af0ef9eba31f5edc7c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4efebec867fb6926c8eaf76e81418fcd28eadb09fae57af0ef9eba31f5edc7c5", kill_on_drop: false }` [INFO] [stdout] 4efebec867fb6926c8eaf76e81418fcd28eadb09fae57af0ef9eba31f5edc7c5