[INFO] cloning repository https://github.com/tiagoavila/rust_text_editor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tiagoavila/rust_text_editor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiagoavila%2Frust_text_editor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiagoavila%2Frust_text_editor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3cd85fddc3efd660af576a4e4cebbee47d7ae175 [INFO] linting tiagoavila/rust_text_editor against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftiagoavila%2Frust_text_editor" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tiagoavila/rust_text_editor [INFO] finished tweaking git repo https://github.com/tiagoavila/rust_text_editor [INFO] tweaked toml for git repo https://github.com/tiagoavila/rust_text_editor written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tiagoavila/rust_text_editor on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tiagoavila/rust_text_editor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded signal-hook-registry v1.4.5 [INFO] [stderr] Downloaded errno v0.3.11 [INFO] [stderr] Downloaded signal-hook v0.3.17 [INFO] [stderr] Downloaded log v0.4.27 [INFO] [stderr] Downloaded document-features v0.2.11 [INFO] [stderr] Downloaded anstyle-query v1.1.3 [INFO] [stderr] Downloaded anstyle-wincon v3.0.9 [INFO] [stderr] Downloaded anstream v0.6.19 [INFO] [stderr] Downloaded clap_derive v4.5.40 [INFO] [stderr] Downloaded litrs v0.4.1 [INFO] [stderr] Downloaded clap v4.5.40 [INFO] [stderr] Downloaded derive_more v2.0.1 [INFO] [stderr] Downloaded mio v1.0.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.95 [INFO] [stderr] Downloaded crossterm v0.29.0 [INFO] [stderr] Downloaded clap_builder v4.5.40 [INFO] [stderr] Downloaded derive_more-impl v2.0.1 [INFO] [stderr] Downloaded smallvec v1.15.0 [INFO] [stderr] Downloaded unicode-ident v1.0.18 [INFO] [stderr] Downloaded bitflags v2.9.0 [INFO] [stderr] Downloaded convert_case v0.7.1 [INFO] [stderr] Downloaded redox_syscall v0.5.12 [INFO] [stderr] Downloaded syn v2.0.101 [INFO] [stderr] Downloaded rustix v1.0.7 [INFO] [stderr] Downloaded libc v0.2.172 [INFO] [stderr] Downloaded linux-raw-sys v0.9.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] df1ff83910f9a8bec10725b7945ecd00e69243b7d6f57a19da9139656dbc8e18 [INFO] running `Command { std: "docker" "start" "-a" "df1ff83910f9a8bec10725b7945ecd00e69243b7d6f57a19da9139656dbc8e18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "df1ff83910f9a8bec10725b7945ecd00e69243b7d6f57a19da9139656dbc8e18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df1ff83910f9a8bec10725b7945ecd00e69243b7d6f57a19da9139656dbc8e18", kill_on_drop: false }` [INFO] [stdout] df1ff83910f9a8bec10725b7945ecd00e69243b7d6f57a19da9139656dbc8e18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bc68d44b8cfc1b61e79fc45d8814df1a644b88a5f2a966dae9d8df83ece1f05 [INFO] running `Command { std: "docker" "start" "-a" "3bc68d44b8cfc1b61e79fc45d8814df1a644b88a5f2a966dae9d8df83ece1f05", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking rust_text_editor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `get_delete_size` is never used [INFO] [stdout] --> src/core/piece_table.rs:342:4 [INFO] [stdout] | [INFO] [stdout] 342 | fn get_delete_size(start: usize, end: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/core/editor.rs:239:40 [INFO] [stdout] | [INFO] [stdout] 239 | let _ = self.content.add_text(&format!("\n"), self.text_position); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/core/piece_table.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | result.push_str(&buffer[piece.start..(piece.start + piece.length)].to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&buffer[piece.start..(piece.start + piece.length)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_delete_size` is never used [INFO] [stdout] --> src/core/piece_table.rs:342:4 [INFO] [stdout] | [INFO] [stdout] 342 | fn get_delete_size(start: usize, end: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/core/editor.rs:239:40 [INFO] [stdout] | [INFO] [stdout] 239 | let _ = self.content.add_text(&format!("\n"), self.text_position); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/core/piece_table.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | result.push_str(&buffer[piece.start..(piece.start + piece.length)].to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&buffer[piece.start..(piece.start + piece.length)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ui/output_manager.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | Print(format!("{}", line)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `line.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/ui/output_manager.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | Print(format!("{}", line)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `line.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 68 | let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] 68 + let initial_text = if (args.file.is_none() || args.single) && (!args.multi || args.single) { [INFO] [stdout] | [INFO] [stdout] 68 - let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] 68 + let initial_text = if args.single || !args.multi && args.file.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:68:27 [INFO] [stdout] | [INFO] [stdout] 68 | let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 68 - let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] 68 + let initial_text = if (args.file.is_none() || args.single) && (!args.multi || args.single) { [INFO] [stdout] | [INFO] [stdout] 68 - let initial_text = if args.single || (!args.single && !args.multi && args.file.is_none()) { [INFO] [stdout] 68 + let initial_text = if args.single || !args.multi && args.file.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.50s [INFO] running `Command { std: "docker" "inspect" "3bc68d44b8cfc1b61e79fc45d8814df1a644b88a5f2a966dae9d8df83ece1f05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bc68d44b8cfc1b61e79fc45d8814df1a644b88a5f2a966dae9d8df83ece1f05", kill_on_drop: false }` [INFO] [stdout] 3bc68d44b8cfc1b61e79fc45d8814df1a644b88a5f2a966dae9d8df83ece1f05