[INFO] cloning repository https://github.com/thomas9911/aoc2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thomas9911/aoc2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthomas9911%2Faoc2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthomas9911%2Faoc2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 930682d540a5d45492ccd5f7329878ef59eaaea8 [INFO] linting thomas9911/aoc2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthomas9911%2Faoc2024" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thomas9911/aoc2024 [INFO] finished tweaking git repo https://github.com/thomas9911/aoc2024 [INFO] tweaked toml for git repo https://github.com/thomas9911/aoc2024 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thomas9911/aoc2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thomas9911/aoc2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dupe_derive v0.9.0 [INFO] [stderr] Downloaded annotate-snippets v0.9.2 [INFO] [stderr] Downloaded allocative_derive v0.3.3 [INFO] [stderr] Downloaded allocator-api2 v0.2.20 [INFO] [stderr] Downloaded schemafy_lib v0.5.2 [INFO] [stderr] Downloaded cmp_any v0.8.1 [INFO] [stderr] Downloaded schemafy_core v0.5.2 [INFO] [stderr] Downloaded display_container v0.9.0 [INFO] [stderr] Downloaded inventory v0.3.15 [INFO] [stderr] Downloaded fd-lock v3.0.13 [INFO] [stderr] Downloaded debugserver-types v0.5.0 [INFO] [stderr] Downloaded dupe v0.9.0 [INFO] [stderr] Downloaded schemafy v0.5.2 [INFO] [stderr] Downloaded starlark_derive v0.12.0 [INFO] [stderr] Downloaded starlark_map v0.12.0 [INFO] [stderr] Downloaded allocative v0.3.3 [INFO] [stderr] Downloaded rustyline v11.0.0 [INFO] [stderr] Downloaded starlark_syntax v0.12.0 [INFO] [stderr] Downloaded starlark v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23d831c61c3b51b3b236b71d0c2e36ef973c9a6b4cacad410939d041ffea435e [INFO] running `Command { std: "docker" "start" "-a" "23d831c61c3b51b3b236b71d0c2e36ef973c9a6b4cacad410939d041ffea435e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23d831c61c3b51b3b236b71d0c2e36ef973c9a6b4cacad410939d041ffea435e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23d831c61c3b51b3b236b71d0c2e36ef973c9a6b4cacad410939d041ffea435e", kill_on_drop: false }` [INFO] [stdout] 23d831c61c3b51b3b236b71d0c2e36ef973c9a6b4cacad410939d041ffea435e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a48cdc161777a3dcf244ee3a070aa9fc6c1a9abc4bc13dcf743d6227ad9f116 [INFO] running `Command { std: "docker" "start" "-a" "0a48cdc161777a3dcf244ee3a070aa9fc6c1a9abc4bc13dcf743d6227ad9f116", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling indexmap v2.6.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling allocative v0.3.3 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking allocator-api2 v0.2.20 [INFO] [stderr] Compiling rustix v0.38.41 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling starlark_map v0.12.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking annotate-snippets v0.9.2 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling starlark v0.12.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Checking display_container v0.9.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking cmp_any v0.8.1 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking rustyline v11.0.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling allocative_derive v0.3.3 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Compiling starlark_derive v0.12.0 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling schemafy_core v0.5.2 [INFO] [stderr] Compiling starlark_syntax v0.12.0 [INFO] [stderr] Compiling schemafy_lib v0.5.2 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Compiling schemafy v0.5.2 [INFO] [stderr] Checking debugserver-types v0.5.0 [INFO] [stderr] Checking aoc2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/day09.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | / loop { [INFO] [stdout] 21 | | if let Some(i) = layout.iter().position(|x| x == &None){ [INFO] [stdout] 22 | | if let Some(Some(x)) = layout.pop() { [INFO] [stdout] 23 | | layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |___^ help: try: `while let Some(i) = layout.iter().position(|x| x == &None) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day09.rs:21:49 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(i) = layout.iter().position(|x| x == &None){ [INFO] [stdout] | ^^^^^^^^^^ help: use `Option::is_none()` instead: `x.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/day09.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 23 - layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] 23 + if let Some(y) = layout.get_mut(i) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day09.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 40 | return score [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return score [INFO] [stdout] 40 + score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/bin/day09.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | / loop { [INFO] [stdout] 21 | | if let Some(i) = layout.iter().position(|x| x == &None){ [INFO] [stdout] 22 | | if let Some(Some(x)) = layout.pop() { [INFO] [stdout] 23 | | layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |___^ help: try: `while let Some(i) = layout.iter().position(|x| x == &None) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day02.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 - (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] 25 + !(!not_too_large || !increasing && !decreasing) [INFO] [stdout] | [INFO] [stdout] 25 - (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] 25 + (decreasing || increasing) && not_too_large [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/day09.rs:21:49 [INFO] [stdout] | [INFO] [stdout] 21 | if let Some(i) = layout.iter().position(|x| x == &None){ [INFO] [stdout] | ^^^^^^^^^^ help: use `Option::is_none()` instead: `x.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/day09.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 23 - layout.get_mut(i).map(|y| *y = Some(x)); [INFO] [stdout] 23 + if let Some(y) = layout.get_mut(i) { ... } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/day09.rs:40:3 [INFO] [stdout] | [INFO] [stdout] 40 | return score [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return score [INFO] [stdout] 40 + score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/bin/day02.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some(data) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for data in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/day02.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 - (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] 25 + !(!not_too_large || !increasing && !decreasing) [INFO] [stdout] | [INFO] [stdout] 25 - (increasing && not_too_large) || (decreasing && not_too_large) [INFO] [stdout] 25 + (decreasing || increasing) && not_too_large [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/bin/day02.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | while let Some(data) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for data in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if buffer.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if buffer.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:122:41 [INFO] [stdout] | [INFO] [stdout] 122 | let out = run_starlark("test.star", &content).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "0a48cdc161777a3dcf244ee3a070aa9fc6c1a9abc4bc13dcf743d6227ad9f116", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a48cdc161777a3dcf244ee3a070aa9fc6c1a9abc4bc13dcf743d6227ad9f116", kill_on_drop: false }` [INFO] [stdout] 0a48cdc161777a3dcf244ee3a070aa9fc6c1a9abc4bc13dcf743d6227ad9f116