[INFO] cloning repository https://github.com/thisLucio/rust-stely [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thisLucio/rust-stely" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FthisLucio%2Frust-stely", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FthisLucio%2Frust-stely'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 727f5f4be066dc4c47cbd5ffed9c3c2848a292f5 [INFO] linting thisLucio/rust-stely against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FthisLucio%2Frust-stely" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thisLucio/rust-stely [INFO] finished tweaking git repo https://github.com/thisLucio/rust-stely [INFO] tweaked toml for git repo https://github.com/thisLucio/rust-stely written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thisLucio/rust-stely on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thisLucio/rust-stely already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nom v4.2.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 78f5e5fd30bfdacae44cd72a8c637c1445b2716023d088406e132ee081464292 [INFO] running `Command { std: "docker" "start" "-a" "78f5e5fd30bfdacae44cd72a8c637c1445b2716023d088406e132ee081464292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "78f5e5fd30bfdacae44cd72a8c637c1445b2716023d088406e132ee081464292", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78f5e5fd30bfdacae44cd72a8c637c1445b2716023d088406e132ee081464292", kill_on_drop: false }` [INFO] [stdout] 78f5e5fd30bfdacae44cd72a8c637c1445b2716023d088406e132ee081464292 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92f75bf8b3bafa396377f4c121914e6bb2496678d4ec4f07dc31cb535fc05159 [INFO] running `Command { std: "docker" "start" "-a" "92f75bf8b3bafa396377f4c121914e6bb2496678d4ec4f07dc31cb535fc05159", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking stely v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | opcode: opcode [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Program` [INFO] [stdout] --> src/repl/mod.rs:9:41 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::assembler::program_parsers::{Program, program}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/opcode_parsers.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/register_parsers.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/operand_parsers.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | /// Example of instruction LOAD $0 #100 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | opcode: opcode [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Program` [INFO] [stdout] --> src/repl/mod.rs:9:41 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::assembler::program_parsers::{Program, program}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:62:1 [INFO] [stdout] | [INFO] [stdout] 62 | /// Example of instruction LOAD $0 #100 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parsers.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse_hex` is never used [INFO] [stdout] --> src/repl/mod.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl REPL { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | fn parse_hex(&mut self, i: &str) -> Result, ParseIntError>{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> VM { [INFO] [stdout] 14 | | VM { [INFO] [stdout] 15 | | registers: [0; 32], [INFO] [stdout] 16 | | program: vec![], [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for VM { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | / if register1 == register2 { [INFO] [stdout] 94 | | self.equal_flag = true; [INFO] [stdout] 95 | | } else { [INFO] [stdout] 96 | | self.equal_flag = false; [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | / if register1 != register2 { [INFO] [stdout] 104 | | self.equal_flag = true; [INFO] [stdout] 105 | | } else { [INFO] [stdout] 106 | | self.equal_flag = false; [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 != register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | / if register1 > register2 { [INFO] [stdout] 114 | | self.equal_flag = true; [INFO] [stdout] 115 | | } else { [INFO] [stdout] 116 | | self.equal_flag = false; [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 > register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | / if register1 >= register2 { [INFO] [stdout] 124 | | self.equal_flag = true [INFO] [stdout] 125 | | } else { [INFO] [stdout] 126 | | self.equal_flag = false [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 >= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | / if register1 < register2 { [INFO] [stdout] 134 | | self.equal_flag = true; [INFO] [stdout] 135 | | } else { [INFO] [stdout] 136 | | self.equal_flag = false; [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 < register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | / if register1 <= register2 { [INFO] [stdout] 144 | | self.equal_flag = true; [INFO] [stdout] 145 | | } else { [INFO] [stdout] 146 | | self.equal_flag = false; [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 <= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return opcode; [INFO] [stdout] 169 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return result; [INFO] [stdout] 175 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return result; [INFO] [stdout] 181 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> REPL { [INFO] [stdout] 19 | | REPL { [INFO] [stdout] 20 | | vm: VM::new(), [INFO] [stdout] 21 | | command_buffer: vec![] [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for REPL { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:86:43 [INFO] [stdout] | [INFO] [stdout] 86 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return results; [INFO] [stdout] 39 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | Token::Op { code } => match code { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 22 | | _ => { [INFO] [stdout] 23 | | results.push(code as u8); [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 21 ~ Token::Op { code } => { [INFO] [stdout] 22 + results.push(code as u8); [INFO] [stdout] 23 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / match operand { [INFO] [stdout] 34 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results), [INFO] [stdout] 35 | | None => {} [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | for operand in vec![&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand1, &self.operand2, &self.operand3]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `parse_hex` is never used [INFO] [stdout] --> src/repl/mod.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl REPL { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | fn parse_hex(&mut self, i: &str) -> Result, ParseIntError>{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn new() -> VM { [INFO] [stdout] 14 | | VM { [INFO] [stdout] 15 | | registers: [0; 32], [INFO] [stdout] 16 | | program: vec![], [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for VM { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 93 | / if register1 == register2 { [INFO] [stdout] 94 | | self.equal_flag = true; [INFO] [stdout] 95 | | } else { [INFO] [stdout] 96 | | self.equal_flag = false; [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 == register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | / if register1 != register2 { [INFO] [stdout] 104 | | self.equal_flag = true; [INFO] [stdout] 105 | | } else { [INFO] [stdout] 106 | | self.equal_flag = false; [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 != register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | / if register1 > register2 { [INFO] [stdout] 114 | | self.equal_flag = true; [INFO] [stdout] 115 | | } else { [INFO] [stdout] 116 | | self.equal_flag = false; [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 > register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | / if register1 >= register2 { [INFO] [stdout] 124 | | self.equal_flag = true [INFO] [stdout] 125 | | } else { [INFO] [stdout] 126 | | self.equal_flag = false [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 >= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | / if register1 < register2 { [INFO] [stdout] 134 | | self.equal_flag = true; [INFO] [stdout] 135 | | } else { [INFO] [stdout] 136 | | self.equal_flag = false; [INFO] [stdout] 137 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 < register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/vm.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | / if register1 <= register2 { [INFO] [stdout] 144 | | self.equal_flag = true; [INFO] [stdout] 145 | | } else { [INFO] [stdout] 146 | | self.equal_flag = false; [INFO] [stdout] 147 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `self.equal_flag = register1 <= register2;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return opcode; [INFO] [stdout] 169 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return result; [INFO] [stdout] 175 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return result; [INFO] [stdout] 181 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 296 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 296 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:299:9 [INFO] [stdout] | [INFO] [stdout] 299 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 299 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 299 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 309 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 309 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 312 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 312 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 312 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 322 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 322 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 325 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 325 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 328 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 328 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 328 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 338 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 338 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:341:9 [INFO] [stdout] | [INFO] [stdout] 341 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 341 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 341 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 344 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 344 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 344 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 354 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 354 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 357 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 357 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:360:9 [INFO] [stdout] | [INFO] [stdout] 360 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 360 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 360 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 370 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 370 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 373 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 373 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 376 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 376 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / pub fn new() -> REPL { [INFO] [stdout] 19 | | REPL { [INFO] [stdout] 20 | | vm: VM::new(), [INFO] [stdout] 21 | | command_buffer: vec![] [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for REPL { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 64 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/repl/mod.rs:86:43 [INFO] [stdout] | [INFO] [stdout] 86 | let byte = u8::from_str_radix(&hex_string, 16); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `hex_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parsers.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 19 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 19 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parsers.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 26 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 28 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parsers.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 32 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 25 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/operand_parsers.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 31 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 31 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return results; [INFO] [stdout] 39 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | Token::Op { code } => match code { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 22 | | _ => { [INFO] [stdout] 23 | | results.push(code as u8); [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 21 ~ Token::Op { code } => { [INFO] [stdout] 22 + results.push(code as u8); [INFO] [stdout] 23 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / match operand { [INFO] [stdout] 34 | | Some(t) => AssemblerInstruction::extract_operand(t, &mut results), [INFO] [stdout] 35 | | None => {} [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(t) = operand { AssemblerInstruction::extract_operand(t, &mut results) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 36 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 36 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parsers.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 48 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:32:24 [INFO] [stdout] | [INFO] [stdout] 32 | for operand in vec![&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[&self.operand1, &self.operand2, &self.operand3]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.02s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "92f75bf8b3bafa396377f4c121914e6bb2496678d4ec4f07dc31cb535fc05159", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92f75bf8b3bafa396377f4c121914e6bb2496678d4ec4f07dc31cb535fc05159", kill_on_drop: false }` [INFO] [stdout] 92f75bf8b3bafa396377f4c121914e6bb2496678d4ec4f07dc31cb535fc05159