[INFO] cloning repository https://github.com/third-act/availability [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/third-act/availability" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthird-act%2Favailability", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthird-act%2Favailability'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d9b6497fdeedc6ef0e4dea382bb00e22e964d076 [INFO] linting third-act/availability against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthird-act%2Favailability" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/third-act/availability [INFO] finished tweaking git repo https://github.com/third-act/availability [INFO] tweaked toml for git repo https://github.com/third-act/availability written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/third-act/availability on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/third-act/availability already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen v0.2.99 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.99 [INFO] [stderr] Downloaded js-sys v0.3.76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7acad17d880c2788fab1c422390474d5fcbc9f8d4aa7e40c8c7fde7c0215a9d [INFO] running `Command { std: "docker" "start" "-a" "c7acad17d880c2788fab1c422390474d5fcbc9f8d4aa7e40c8c7fde7c0215a9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7acad17d880c2788fab1c422390474d5fcbc9f8d4aa7e40c8c7fde7c0215a9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7acad17d880c2788fab1c422390474d5fcbc9f8d4aa7e40c8c7fde7c0215a9d", kill_on_drop: false }` [INFO] [stdout] c7acad17d880c2788fab1c422390474d5fcbc9f8d4aa7e40c8c7fde7c0215a9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ca0641ff350700b19ad832b27ac61fc098c20ab6ada5a5d97e59c0c7d004c03 [INFO] running `Command { std: "docker" "start" "-a" "9ca0641ff350700b19ad832b27ac61fc098c20ab6ada5a5d97e59c0c7d004c03", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling serde v1.0.216 [INFO] [stderr] Compiling serde_json v1.0.134 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking chrono v0.4.39 [INFO] [stderr] Compiling serde_derive v1.0.216 [INFO] [stderr] Checking availability v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 252 + frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | priority_frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 253 - priority_frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 253 + priority_frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 319 - frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 319 + frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 252 - frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 252 + frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | priority_frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 253 - priority_frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 253 + priority_frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/availability.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 319 - frames.sort_by(|a, b| a.start.cmp(&b.start)); [INFO] [stdout] 319 + frames.sort_by_key(|a| a.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/availability.rs:843:9 [INFO] [stdout] | [INFO] [stdout] 843 | assert_eq!(rule.is_relative(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 843 - assert_eq!(rule.is_relative(), true); [INFO] [stdout] 843 + assert!(rule.is_relative()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/availability.rs:850:9 [INFO] [stdout] | [INFO] [stdout] 850 | assert_eq!(rule.is_absolute(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 850 - assert_eq!(rule.is_absolute(), true); [INFO] [stdout] 850 + assert!(rule.is_absolute()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rulebuilder.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | assert!(!parse_datetime("2024-01-01 09:00:60").is_err()); // Chrono allows leap seconds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_datetime("2024-01-01 09:00:60").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.11s [INFO] running `Command { std: "docker" "inspect" "9ca0641ff350700b19ad832b27ac61fc098c20ab6ada5a5d97e59c0c7d004c03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ca0641ff350700b19ad832b27ac61fc098c20ab6ada5a5d97e59c0c7d004c03", kill_on_drop: false }` [INFO] [stdout] 9ca0641ff350700b19ad832b27ac61fc098c20ab6ada5a5d97e59c0c7d004c03