[INFO] cloning repository https://github.com/thijsheijden/aoc-2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thijsheijden/aoc-2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthijsheijden%2Faoc-2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthijsheijden%2Faoc-2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ad958e08d8ee9fa7e6c2b4e815d55b57ed36c5c3 [INFO] linting thijsheijden/aoc-2022 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthijsheijden%2Faoc-2022" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thijsheijden/aoc-2022 [INFO] finished tweaking git repo https://github.com/thijsheijden/aoc-2022 [INFO] tweaked toml for git repo https://github.com/thijsheijden/aoc-2022 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thijsheijden/aoc-2022 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thijsheijden/aoc-2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f1d2342c072b42115013d8258cffc051e98188a947f7548b1982bd6ec8a058d2 [INFO] running `Command { std: "docker" "start" "-a" "f1d2342c072b42115013d8258cffc051e98188a947f7548b1982bd6ec8a058d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f1d2342c072b42115013d8258cffc051e98188a947f7548b1982bd6ec8a058d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1d2342c072b42115013d8258cffc051e98188a947f7548b1982bd6ec8a058d2", kill_on_drop: false }` [INFO] [stdout] f1d2342c072b42115013d8258cffc051e98188a947f7548b1982bd6ec8a058d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c104700f74c05d4edfe71b2ee9012ab818de785641f3fc8951cf28cfe32f9418 [INFO] running `Command { std: "docker" "start" "-a" "c104700f74c05d4edfe71b2ee9012ab818de785641f3fc8951cf28cfe32f9418", kill_on_drop: false }` [INFO] [stderr] Checking aoc-2022 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `hash_set::Intersection` [INFO] [stdout] --> src/days/day_3.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{collections::{HashSet, hash_set::Intersection}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash_set::Intersection` [INFO] [stdout] --> src/days/day_3.rs:2:34 [INFO] [stdout] | [INFO] [stdout] 2 | use std::{collections::{HashSet, hash_set::Intersection}}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/days/day_2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/days/day_2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 51 | Move::Rock => return 1, [INFO] [stdout] | ---------- matches some of the same values [INFO] [stdout] 52 | Move::Paper => return 2, [INFO] [stdout] | ----------- matches some of the same values [INFO] [stdout] 53 | Move::Scissors => return 3, [INFO] [stdout] | -------------- matches some of the same values [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/days/day_5.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | for i in 0..instruction_numbers[0] { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_6.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | let mut window: &str = ""; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window` [INFO] [stdout] --> src/days/day_6.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | let mut window: &str = ""; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_6.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | let mut window: &str = ""; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window` [INFO] [stdout] --> src/days/day_6.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | let mut window: &str = ""; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_1.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_1.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_1.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_2.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_2.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_2.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `score_for_move` is never used [INFO] [stdout] --> src/days/day_2.rs:49:4 [INFO] [stdout] | [INFO] [stdout] 49 | fn score_for_move(m: Move) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GameResult` is never used [INFO] [stdout] --> src/days/day_2.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | enum GameResult { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Move` is never used [INFO] [stdout] --> src/days/day_2.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | enum Move { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `win_game` is never used [INFO] [stdout] --> src/days/day_2.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn win_game(m: (Move, Move)) -> GameResult { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `game_result_to_score` is never used [INFO] [stdout] --> src/days/day_2.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn game_result_to_score(result: GameResult) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `char_to_move` is never used [INFO] [stdout] --> src/days/day_2.rs:95:4 [INFO] [stdout] | [INFO] [stdout] 95 | fn char_to_move(m: char) -> Move { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `char_to_game_result` is never used [INFO] [stdout] --> src/days/day_2.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn char_to_game_result(c: char) -> GameResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_to_get_game_result` is never used [INFO] [stdout] --> src/days/day_2.rs:115:4 [INFO] [stdout] | [INFO] [stdout] 115 | fn move_to_get_game_result(result: GameResult, opponent_move: Move) -> Move { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_3.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_3.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_3.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_4.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_4.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_4.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_elf_ranges` is never used [INFO] [stdout] --> src/days/day_4.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 48 | fn get_elf_ranges(input: &str) -> Vec>> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_5.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STACKS` is never used [INFO] [stdout] --> src/days/day_5.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const STACKS: usize = 9; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_5.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_5.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/input.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 4 | return fs::read_to_string(file_path).expect("Should have been able to read file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return fs::read_to_string(file_path).expect("Should have been able to read file"); [INFO] [stdout] 4 + fs::read_to_string(file_path).expect("Should have been able to read file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/day_2.rs:20:53 [INFO] [stdout] | [INFO] [stdout] 20 | let the_moves: Vec = m.split(" ").map(|x| x.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `x.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/day_2.rs:36:53 [INFO] [stdout] | [INFO] [stdout] 36 | let the_moves: Vec = m.split(" ").map(|x| x.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `x.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | Move::Rock => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - Move::Rock => return 1, [INFO] [stdout] 51 + Move::Rock => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | Move::Paper => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Move::Paper => return 2, [INFO] [stdout] 52 + Move::Paper => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | Move::Scissors => return 3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Move::Scissors => return 3, [INFO] [stdout] 53 + Move::Scissors => 3, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - _ => return 0, [INFO] [stdout] 54 + _ => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | (a, b) if a == b => return GameResult::Draw, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - (a, b) if a == b => return GameResult::Draw, [INFO] [stdout] 76 + (a, b) if a == b => GameResult::Draw, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | (Move::Rock, Move::Paper) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - (Move::Rock, Move::Paper) => return GameResult::Win, [INFO] [stdout] 77 + (Move::Rock, Move::Paper) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | (Move::Rock, Move::Scissors) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - (Move::Rock, Move::Scissors) => return GameResult::Lose, [INFO] [stdout] 78 + (Move::Rock, Move::Scissors) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:79:34 [INFO] [stdout] | [INFO] [stdout] 79 | (Move::Paper, Move::Rock) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - (Move::Paper, Move::Rock) => return GameResult::Lose, [INFO] [stdout] 79 + (Move::Paper, Move::Rock) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | (Move::Paper, Move::Scissors) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - (Move::Paper, Move::Scissors) => return GameResult::Win, [INFO] [stdout] 80 + (Move::Paper, Move::Scissors) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:81:37 [INFO] [stdout] | [INFO] [stdout] 81 | (Move::Scissors, Move::Rock) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - (Move::Scissors, Move::Rock) => return GameResult::Win, [INFO] [stdout] 81 + (Move::Scissors, Move::Rock) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:82:38 [INFO] [stdout] | [INFO] [stdout] 82 | (Move::Scissors, Move::Paper) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - (Move::Scissors, Move::Paper) => return GameResult::Lose, [INFO] [stdout] 82 + (Move::Scissors, Move::Paper) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | _ => return GameResult::Lose [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - _ => return GameResult::Lose [INFO] [stdout] 83 + _ => GameResult::Lose [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | 'A'|'X' => return Move::Rock, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - 'A'|'X' => return Move::Rock, [INFO] [stdout] 97 + 'A'|'X' => Move::Rock, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | 'B'|'Y' => return Move::Paper, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - 'B'|'Y' => return Move::Paper, [INFO] [stdout] 98 + 'B'|'Y' => Move::Paper, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | 'C'|'Z' => return Move::Scissors, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - 'C'|'Z' => return Move::Scissors, [INFO] [stdout] 99 + 'C'|'Z' => Move::Scissors, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:100:10 [INFO] [stdout] | [INFO] [stdout] 100 | _ => return Move::Rock, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - _ => return Move::Rock, [INFO] [stdout] 100 + _ => Move::Rock, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_4.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | return section_start_end_per_pair; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return section_start_end_per_pair; [INFO] [stdout] 72 + section_start_end_per_pair [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_5.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !top_crate_char.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `top_crate_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_crate_char` after checking its variant with `is_none` [INFO] [stdout] --> src/days/day_5.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 61 | if !top_crate_char.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 62 | answer.push(*top_crate_char.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/days/day_2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/days/day_2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 51 | Move::Rock => return 1, [INFO] [stdout] | ---------- matches some of the same values [INFO] [stdout] 52 | Move::Paper => return 2, [INFO] [stdout] | ----------- matches some of the same values [INFO] [stdout] 53 | Move::Scissors => return 3, [INFO] [stdout] | -------------- matches some of the same values [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_5.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if !top_crate_char.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `top_crate_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_crate_char` after checking its variant with `is_none` [INFO] [stdout] --> src/days/day_5.rs:128:26 [INFO] [stdout] | [INFO] [stdout] 127 | if !top_crate_char.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 128 | answer.push(*top_crate_char.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/days/day_6.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / match unique_chars(window) { [INFO] [stdout] 24 | | None => break, [INFO] [stdout] 25 | | Some(_) => (), [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ help: try: `if unique_chars(window) == None { break }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/days/day_6.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / match unique_chars(window) { [INFO] [stdout] 46 | | None => break, [INFO] [stdout] 47 | | Some(_) => (), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ help: try: `if unique_chars(window) == None { break }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/days/day_5.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | for i in 0..instruction_numbers[0] { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_6.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | let mut window: &str = ""; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window` [INFO] [stdout] --> src/days/day_6.rs:15:7 [INFO] [stdout] | [INFO] [stdout] 15 | let mut window: &str = ""; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day_6.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | let mut window: &str = ""; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window` [INFO] [stdout] --> src/days/day_6.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | let mut window: &str = ""; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_1.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_1.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_1.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_2.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_2.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_2.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `score_for_move` is never used [INFO] [stdout] --> src/days/day_2.rs:49:4 [INFO] [stdout] | [INFO] [stdout] 49 | fn score_for_move(m: Move) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GameResult` is never used [INFO] [stdout] --> src/days/day_2.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 60 | enum GameResult { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Move` is never used [INFO] [stdout] --> src/days/day_2.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | enum Move { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `win_game` is never used [INFO] [stdout] --> src/days/day_2.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn win_game(m: (Move, Move)) -> GameResult { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `game_result_to_score` is never used [INFO] [stdout] --> src/days/day_2.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn game_result_to_score(result: GameResult) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `char_to_move` is never used [INFO] [stdout] --> src/days/day_2.rs:95:4 [INFO] [stdout] | [INFO] [stdout] 95 | fn char_to_move(m: char) -> Move { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `char_to_game_result` is never used [INFO] [stdout] --> src/days/day_2.rs:104:4 [INFO] [stdout] | [INFO] [stdout] 104 | fn char_to_game_result(c: char) -> GameResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_to_get_game_result` is never used [INFO] [stdout] --> src/days/day_2.rs:115:4 [INFO] [stdout] | [INFO] [stdout] 115 | fn move_to_get_game_result(result: GameResult, opponent_move: Move) -> Move { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_3.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_3.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_3.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_4.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_4.rs:13:4 [INFO] [stdout] | [INFO] [stdout] 13 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_4.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_elf_ranges` is never used [INFO] [stdout] --> src/days/day_4.rs:48:4 [INFO] [stdout] | [INFO] [stdout] 48 | fn get_elf_ranges(input: &str) -> Vec>> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/days/day_5.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn solve(test_input: bool) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STACKS` is never used [INFO] [stdout] --> src/days/day_5.rs:13:7 [INFO] [stdout] | [INFO] [stdout] 13 | const STACKS: usize = 9; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_1` is never used [INFO] [stdout] --> src/days/day_5.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn solve_1(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve_2` is never used [INFO] [stdout] --> src/days/day_5.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn solve_2(input: &str) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers/input.rs:4:3 [INFO] [stdout] | [INFO] [stdout] 4 | return fs::read_to_string(file_path).expect("Should have been able to read file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return fs::read_to_string(file_path).expect("Should have been able to read file"); [INFO] [stdout] 4 + fs::read_to_string(file_path).expect("Should have been able to read file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/day_2.rs:20:53 [INFO] [stdout] | [INFO] [stdout] 20 | let the_moves: Vec = m.split(" ").map(|x| x.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `x.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/day_2.rs:36:53 [INFO] [stdout] | [INFO] [stdout] 36 | let the_moves: Vec = m.split(" ").map(|x| x.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `x.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 51 | Move::Rock => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - Move::Rock => return 1, [INFO] [stdout] 51 + Move::Rock => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | Move::Paper => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Move::Paper => return 2, [INFO] [stdout] 52 + Move::Paper => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | Move::Scissors => return 3, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Move::Scissors => return 3, [INFO] [stdout] 53 + Move::Scissors => 3, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 54 | _ => return 0, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - _ => return 0, [INFO] [stdout] 54 + _ => 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | (a, b) if a == b => return GameResult::Draw, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - (a, b) if a == b => return GameResult::Draw, [INFO] [stdout] 76 + (a, b) if a == b => GameResult::Draw, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | (Move::Rock, Move::Paper) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - (Move::Rock, Move::Paper) => return GameResult::Win, [INFO] [stdout] 77 + (Move::Rock, Move::Paper) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | (Move::Rock, Move::Scissors) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - (Move::Rock, Move::Scissors) => return GameResult::Lose, [INFO] [stdout] 78 + (Move::Rock, Move::Scissors) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:79:34 [INFO] [stdout] | [INFO] [stdout] 79 | (Move::Paper, Move::Rock) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - (Move::Paper, Move::Rock) => return GameResult::Lose, [INFO] [stdout] 79 + (Move::Paper, Move::Rock) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | (Move::Paper, Move::Scissors) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - (Move::Paper, Move::Scissors) => return GameResult::Win, [INFO] [stdout] 80 + (Move::Paper, Move::Scissors) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:81:37 [INFO] [stdout] | [INFO] [stdout] 81 | (Move::Scissors, Move::Rock) => return GameResult::Win, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - (Move::Scissors, Move::Rock) => return GameResult::Win, [INFO] [stdout] 81 + (Move::Scissors, Move::Rock) => GameResult::Win, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:82:38 [INFO] [stdout] | [INFO] [stdout] 82 | (Move::Scissors, Move::Paper) => return GameResult::Lose, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - (Move::Scissors, Move::Paper) => return GameResult::Lose, [INFO] [stdout] 82 + (Move::Scissors, Move::Paper) => GameResult::Lose, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | _ => return GameResult::Lose [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - _ => return GameResult::Lose [INFO] [stdout] 83 + _ => GameResult::Lose [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:97:16 [INFO] [stdout] | [INFO] [stdout] 97 | 'A'|'X' => return Move::Rock, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - 'A'|'X' => return Move::Rock, [INFO] [stdout] 97 + 'A'|'X' => Move::Rock, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:98:16 [INFO] [stdout] | [INFO] [stdout] 98 | 'B'|'Y' => return Move::Paper, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - 'B'|'Y' => return Move::Paper, [INFO] [stdout] 98 + 'B'|'Y' => Move::Paper, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | 'C'|'Z' => return Move::Scissors, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - 'C'|'Z' => return Move::Scissors, [INFO] [stdout] 99 + 'C'|'Z' => Move::Scissors, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_2.rs:100:10 [INFO] [stdout] | [INFO] [stdout] 100 | _ => return Move::Rock, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - _ => return Move::Rock, [INFO] [stdout] 100 + _ => Move::Rock, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day_4.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | return section_start_end_per_pair; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return section_start_end_per_pair; [INFO] [stdout] 72 + section_start_end_per_pair [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_5.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if !top_crate_char.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `top_crate_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_crate_char` after checking its variant with `is_none` [INFO] [stdout] --> src/days/day_5.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 61 | if !top_crate_char.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 62 | answer.push(*top_crate_char.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day_5.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 127 | if !top_crate_char.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `top_crate_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_crate_char` after checking its variant with `is_none` [INFO] [stdout] --> src/days/day_5.rs:128:26 [INFO] [stdout] | [INFO] [stdout] 127 | if !top_crate_char.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 128 | answer.push(*top_crate_char.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/days/day_6.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / match unique_chars(window) { [INFO] [stdout] 24 | | None => break, [INFO] [stdout] 25 | | Some(_) => (), [INFO] [stdout] 26 | | } [INFO] [stdout] | |_____^ help: try: `if unique_chars(window) == None { break }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/days/day_6.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / match unique_chars(window) { [INFO] [stdout] 46 | | None => break, [INFO] [stdout] 47 | | Some(_) => (), [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ help: try: `if unique_chars(window) == None { break }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "c104700f74c05d4edfe71b2ee9012ab818de785641f3fc8951cf28cfe32f9418", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c104700f74c05d4edfe71b2ee9012ab818de785641f3fc8951cf28cfe32f9418", kill_on_drop: false }` [INFO] [stdout] c104700f74c05d4edfe71b2ee9012ab818de785641f3fc8951cf28cfe32f9418