[INFO] cloning repository https://github.com/thewarsawpakt/barneshutt3d [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thewarsawpakt/barneshutt3d" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthewarsawpakt%2Fbarneshutt3d", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthewarsawpakt%2Fbarneshutt3d'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa442c7640d1feec6ecf6eb359c895c88ccaf510 [INFO] linting thewarsawpakt/barneshutt3d against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthewarsawpakt%2Fbarneshutt3d" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thewarsawpakt/barneshutt3d [INFO] finished tweaking git repo https://github.com/thewarsawpakt/barneshutt3d [INFO] tweaked toml for git repo https://github.com/thewarsawpakt/barneshutt3d written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thewarsawpakt/barneshutt3d on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thewarsawpakt/barneshutt3d already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f68c7eea9e8dd8226b443a02748ccd735d7787cc5e16d77ad9658566a2491bd [INFO] running `Command { std: "docker" "start" "-a" "1f68c7eea9e8dd8226b443a02748ccd735d7787cc5e16d77ad9658566a2491bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f68c7eea9e8dd8226b443a02748ccd735d7787cc5e16d77ad9658566a2491bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f68c7eea9e8dd8226b443a02748ccd735d7787cc5e16d77ad9658566a2491bd", kill_on_drop: false }` [INFO] [stdout] 1f68c7eea9e8dd8226b443a02748ccd735d7787cc5e16d77ad9658566a2491bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1cde852898e1a75ec7b68511d5e9b0d32fae5ef64052f4b606830a529552a6ad [INFO] running `Command { std: "docker" "start" "-a" "1cde852898e1a75ec7b68511d5e9b0d32fae5ef64052f4b606830a529552a6ad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking barneshutt3d v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `simulation` [INFO] [stdout] --> src/main.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let simulation = Simulation::new(bodies, space); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_simulation` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mass` is never read [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | struct Body { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 20 | mass: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Body` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `tree` is never read [INFO] [stdout] --> src/main.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 166 | struct Simulation { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 167 | tree: OctreeNode [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | end: self.x.start + (x_sign + 1.) as f64 * (x_mid - self.x.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((x_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 69 | end: self.y.start + (y_sign + 1.) as f64 * (y_mid - self.y.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((y_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | end: self.z.start + (z_sign + 1.) as f64 * (z_mid - self.z.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((z_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 122 | if !self.body.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.body.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a new box [INFO] [stdout] --> src/main.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | self.children[cuboid_idx] = Box::new(Some(octant.into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*self.children[cuboid_idx] = Some(octant.into())` [INFO] [stdout] | [INFO] [stdout] = note: this creates a needless allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box [INFO] [stdout] = note: `#[warn(clippy::replace_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | / return OctreeNode { [INFO] [stdout] 145 | | body: None, [INFO] [stdout] 146 | | children: std::array::from_fn(|_| Box::new(None)), [INFO] [stdout] 147 | | bounding_box: value [INFO] [stdout] 148 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 ~ OctreeNode { [INFO] [stdout] 145 + body: None, [INFO] [stdout] 146 + children: std::array::from_fn(|_| Box::new(None)), [INFO] [stdout] 147 + bounding_box: value [INFO] [stdout] 148 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `Body` [INFO] [stdout] --> src/main.rs:174:25 [INFO] [stdout] | [INFO] [stdout] 174 | root.insert(body.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `simulation` [INFO] [stdout] --> src/main.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | let simulation = Simulation::new(bodies, space); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_simulation` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `mass` is never read [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | struct Body { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 20 | mass: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Body` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `tree` is never read [INFO] [stdout] --> src/main.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 166 | struct Simulation { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 167 | tree: OctreeNode [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | end: self.x.start + (x_sign + 1.) as f64 * (x_mid - self.x.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((x_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 69 | end: self.y.start + (y_sign + 1.) as f64 * (y_mid - self.y.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((y_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/main.rs:73:41 [INFO] [stdout] | [INFO] [stdout] 73 | end: self.z.start + (z_sign + 1.) as f64 * (z_mid - self.z.start), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `((z_sign + 1.))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 122 | if !self.body.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.body.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a new box [INFO] [stdout] --> src/main.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | self.children[cuboid_idx] = Box::new(Some(octant.into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*self.children[cuboid_idx] = Some(octant.into())` [INFO] [stdout] | [INFO] [stdout] = note: this creates a needless allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#replace_box [INFO] [stdout] = note: `#[warn(clippy::replace_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | / return OctreeNode { [INFO] [stdout] 145 | | body: None, [INFO] [stdout] 146 | | children: std::array::from_fn(|_| Box::new(None)), [INFO] [stdout] 147 | | bounding_box: value [INFO] [stdout] 148 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 ~ OctreeNode { [INFO] [stdout] 145 + body: None, [INFO] [stdout] 146 + children: std::array::from_fn(|_| Box::new(None)), [INFO] [stdout] 147 + bounding_box: value [INFO] [stdout] 148 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `Body` [INFO] [stdout] --> src/main.rs:174:25 [INFO] [stdout] | [INFO] [stdout] 174 | root.insert(body.into()); [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `Command { std: "docker" "inspect" "1cde852898e1a75ec7b68511d5e9b0d32fae5ef64052f4b606830a529552a6ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cde852898e1a75ec7b68511d5e9b0d32fae5ef64052f4b606830a529552a6ad", kill_on_drop: false }` [INFO] [stdout] 1cde852898e1a75ec7b68511d5e9b0d32fae5ef64052f4b606830a529552a6ad