[INFO] cloning repository https://github.com/the-wondersmith/pinnothera [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/the-wondersmith/pinnothera" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthe-wondersmith%2Fpinnothera", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthe-wondersmith%2Fpinnothera'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4400bb5a781830a2af98212a55dc782c62988c6b [INFO] linting the-wondersmith/pinnothera against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthe-wondersmith%2Fpinnothera" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/the-wondersmith/pinnothera [INFO] finished tweaking git repo https://github.com/the-wondersmith/pinnothera [INFO] tweaked toml for git repo https://github.com/the-wondersmith/pinnothera written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/the-wondersmith/pinnothera on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/the-wondersmith/pinnothera already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror v1.0.34 [INFO] [stderr] Downloaded aws-smithy-async v0.48.0 [INFO] [stderr] Downloaded serde v1.0.144 [INFO] [stderr] Downloaded aws-sig-auth v0.48.0 [INFO] [stderr] Downloaded kube-core v0.74.0 [INFO] [stderr] Downloaded aws-smithy-xml v0.48.0 [INFO] [stderr] Downloaded kube v0.74.0 [INFO] [stderr] Downloaded easy-error v1.0.0 [INFO] [stderr] Downloaded pem v1.1.0 [INFO] [stderr] Downloaded aws-endpoint v0.48.0 [INFO] [stderr] Downloaded aws-smithy-http-tower v0.48.0 [INFO] [stderr] Downloaded aws-smithy-query v0.48.0 [INFO] [stderr] Downloaded atomicell v0.1.6 [INFO] [stderr] Downloaded thiserror-impl v1.0.34 [INFO] [stderr] Downloaded once_cell v1.14.0 [INFO] [stderr] Downloaded aws-sdk-sso v0.18.0 [INFO] [stderr] Downloaded aws-smithy-json v0.48.0 [INFO] [stderr] Downloaded aws-sigv4 v0.48.0 [INFO] [stderr] Downloaded xmlparser v0.13.3 [INFO] [stderr] Downloaded ct-logs v0.8.0 [INFO] [stderr] Downloaded rustls-native-certs v0.5.0 [INFO] [stderr] Downloaded aws-http v0.48.0 [INFO] [stderr] Downloaded aws-types v0.48.0 [INFO] [stderr] Downloaded iana-time-zone v0.1.47 [INFO] [stderr] Downloaded serde_derive v1.0.144 [INFO] [stderr] Downloaded aws-smithy-http v0.48.0 [INFO] [stderr] Downloaded aws-smithy-client v0.48.0 [INFO] [stderr] Downloaded unsafe-libyaml v0.2.2 [INFO] [stderr] Downloaded bytes-utils v0.1.3 [INFO] [stderr] Downloaded aws-smithy-types v0.48.0 [INFO] [stderr] Downloaded serde_yaml v0.9.11 [INFO] [stderr] Downloaded aws-sdk-sts v0.18.0 [INFO] [stderr] Downloaded kube-client v0.74.0 [INFO] [stderr] Downloaded time v0.3.14 [INFO] [stderr] Downloaded aws-config v0.48.0 [INFO] [stderr] Downloaded aws-sdk-sqs v0.18.0 [INFO] [stderr] Downloaded aws-sdk-sns v0.18.0 [INFO] [stderr] Downloaded clap v3.2.20 [INFO] [stderr] Downloaded jsonpath_lib v0.3.0 [INFO] [stderr] Downloaded tokio v1.23.1 [INFO] [stderr] Downloaded k8s-openapi v0.15.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f985aef1405b42765991c44b7deb4a5faa90a3e5ff7e6cfd697f43119be9e52 [INFO] running `Command { std: "docker" "start" "-a" "0f985aef1405b42765991c44b7deb4a5faa90a3e5ff7e6cfd697f43119be9e52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f985aef1405b42765991c44b7deb4a5faa90a3e5ff7e6cfd697f43119be9e52", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f985aef1405b42765991c44b7deb4a5faa90a3e5ff7e6cfd697f43119be9e52", kill_on_drop: false }` [INFO] [stdout] 0f985aef1405b42765991c44b7deb4a5faa90a3e5ff7e6cfd697f43119be9e52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71a524c6af121f916a7fc689955f4b08b950ee5af6761675b0b029212e175cc7 [INFO] running `Command { std: "docker" "start" "-a" "71a524c6af121f916a7fc689955f4b08b950ee5af6761675b0b029212e175cc7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking memchr v2.5.0 [INFO] [stderr] Compiling tokio v1.23.1 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tower-layer v0.3.1 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling semver v1.0.13 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking bytes-utils v0.1.3 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking time v0.3.14 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking xmlparser v0.13.3 [INFO] [stderr] Checking urlencoding v2.1.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking ordered-float v2.10.0 [INFO] [stderr] Checking iana-time-zone v0.1.47 [INFO] [stderr] Compiling k8s-openapi v0.15.0 [INFO] [stderr] Checking aws-smithy-xml v0.48.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking rustls-pemfile v1.0.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking http-range-header v0.3.0 [INFO] [stderr] Checking pem v1.1.0 [INFO] [stderr] Compiling aws-types v0.48.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking easy-error v1.0.0 [INFO] [stderr] Checking atomicell v0.1.6 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking aws-smithy-types v0.48.0 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking aws-smithy-query v0.48.0 [INFO] [stderr] Checking aws-smithy-json v0.48.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking ct-logs v0.8.0 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Compiling pin-project-internal v1.0.12 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Checking thiserror v1.0.34 [INFO] [stderr] Checking rustls-native-certs v0.5.0 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking pin-project v1.0.12 [INFO] [stderr] Checking clap v3.2.20 [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking tower-http v0.3.4 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stderr] Checking aws-smithy-async v0.48.0 [INFO] [stderr] Checking h2 v0.3.14 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking serde_yaml v0.9.11 [INFO] [stderr] Checking jsonpath_lib v0.3.0 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking aws-smithy-http v0.48.0 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking hyper-rustls v0.23.0 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking aws-smithy-http-tower v0.48.0 [INFO] [stderr] Checking aws-sigv4 v0.48.0 [INFO] [stderr] Checking aws-smithy-client v0.48.0 [INFO] [stderr] Checking aws-sig-auth v0.48.0 [INFO] [stderr] Checking aws-http v0.48.0 [INFO] [stderr] Checking aws-endpoint v0.48.0 [INFO] [stderr] Checking aws-sdk-sso v0.18.0 [INFO] [stderr] Checking aws-sdk-sts v0.18.0 [INFO] [stderr] Checking aws-sdk-sns v0.18.0 [INFO] [stderr] Checking aws-sdk-sqs v0.18.0 [INFO] [stderr] Checking aws-config v0.48.0 [INFO] [stderr] Checking kube-core v0.74.0 [INFO] [stderr] Checking kube-client v0.74.0 [INFO] [stderr] Checking kube v0.74.0 [INFO] [stderr] Checking pinnothera v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use clap; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use clap; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 164 | if !args.aws_access_key_id.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.aws_access_key_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | } else if !args.aws_secret_access_key.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.aws_secret_access_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.aws_access_key_id` after checking its variant with `is_some` [INFO] [stdout] --> src/cli.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 164 | if !args.aws_access_key_id.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 174 | access_key_id: args.aws_access_key_id.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/types.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / impl Default for EnvName { [INFO] [stdout] 78 | | fn default() -> Self { [INFO] [stdout] 79 | | Self::Unknown [INFO] [stdout] 80 | | } [INFO] [stdout] 81 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub(crate) enum EnvName { [INFO] [stdout] 28 | QA, [INFO] [stdout] ... [INFO] [stdout] 34 | Preview, [INFO] [stdout] 35 ~ #[default] [INFO] [stdout] 36 ~ Unknown, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/types.rs:179:53 [INFO] [stdout] | [INFO] [stdout] 179 | let annotations: BTreeMap = match pinn_confmap.metadata.annotations { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 180 | | Some(obj) => obj, [INFO] [stdout] 181 | | None => BTreeMap::new(), [INFO] [stdout] 182 | | }; [INFO] [stdout] | |_________^ help: replace it with: `pinn_confmap.metadata.annotations.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | return Err(error.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Err(error.into()); [INFO] [stdout] 262 + Err(error.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/main.rs:365:23 [INFO] [stdout] | [INFO] [stdout] 365 | Err(_) => 1 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `1_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/main.rs:461:23 [INFO] [stdout] | [INFO] [stdout] 461 | Err(_) => 1 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `1_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 164 | if !args.aws_access_key_id.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.aws_access_key_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | } else if !args.aws_secret_access_key.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.aws_secret_access_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.aws_access_key_id` after checking its variant with `is_some` [INFO] [stdout] --> src/cli.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 164 | if !args.aws_access_key_id.is_some() { [INFO] [stdout] | -------------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 174 | access_key_id: args.aws_access_key_id.as_ref().unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/types.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | / impl Default for EnvName { [INFO] [stdout] 78 | | fn default() -> Self { [INFO] [stdout] 79 | | Self::Unknown [INFO] [stdout] 80 | | } [INFO] [stdout] 81 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub(crate) enum EnvName { [INFO] [stdout] 28 | QA, [INFO] [stdout] ... [INFO] [stdout] 34 | Preview, [INFO] [stdout] 35 ~ #[default] [INFO] [stdout] 36 ~ Unknown, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/types.rs:179:53 [INFO] [stdout] | [INFO] [stdout] 179 | let annotations: BTreeMap = match pinn_confmap.metadata.annotations { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 180 | | Some(obj) => obj, [INFO] [stdout] 181 | | None => BTreeMap::new(), [INFO] [stdout] 182 | | }; [INFO] [stdout] | |_________^ help: replace it with: `pinn_confmap.metadata.annotations.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:262:5 [INFO] [stdout] | [INFO] [stdout] 262 | return Err(error.into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 - return Err(error.into()); [INFO] [stdout] 262 + Err(error.into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/main.rs:365:23 [INFO] [stdout] | [INFO] [stdout] 365 | Err(_) => 1 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `1_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/main.rs:461:23 [INFO] [stdout] | [INFO] [stdout] 461 | Err(_) => 1 as u8, [INFO] [stdout] | ^^^^^^^ help: try: `1_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.47s [INFO] running `Command { std: "docker" "inspect" "71a524c6af121f916a7fc689955f4b08b950ee5af6761675b0b029212e175cc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71a524c6af121f916a7fc689955f4b08b950ee5af6761675b0b029212e175cc7", kill_on_drop: false }` [INFO] [stdout] 71a524c6af121f916a7fc689955f4b08b950ee5af6761675b0b029212e175cc7