[INFO] cloning repository https://github.com/thane98/exalt-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thane98/exalt-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthane98%2Fexalt-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthane98%2Fexalt-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e87594a539860db64eeb603b3ce7952ba32b3ae3 [INFO] linting thane98/exalt-rs/e87594a539860db64eeb603b3ce7952ba32b3ae3 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthane98%2Fexalt-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thane98/exalt-rs [INFO] finished tweaking git repo https://github.com/thane98/exalt-rs [INFO] tweaked toml for git repo https://github.com/thane98/exalt-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thane98/exalt-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thane98/exalt-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strum_macros v0.24.0 [INFO] [stderr] Downloaded normpath v0.3.2 [INFO] [stderr] Downloaded beef v0.5.2 [INFO] [stderr] Downloaded logos v0.12.0 [INFO] [stderr] Downloaded utf8-ranges v1.0.5 [INFO] [stderr] Downloaded logos-derive v0.12.0 [INFO] [stderr] Downloaded rustversion v1.0.6 [INFO] [stderr] Downloaded itoa v1.0.2 [INFO] [stderr] Downloaded clap_lex v0.2.0 [INFO] [stderr] Downloaded derive-new v0.5.9 [INFO] [stderr] Downloaded strum v0.24.0 [INFO] [stderr] Downloaded semver v1.0.9 [INFO] [stderr] Downloaded serde_yaml v0.8.24 [INFO] [stderr] Downloaded textwrap v0.15.0 [INFO] [stderr] Downloaded anyhow v1.0.57 [INFO] [stderr] Downloaded indexmap v1.8.2 [INFO] [stderr] Downloaded clap_derive v3.1.18 [INFO] [stderr] Downloaded syn v1.0.95 [INFO] [stderr] Downloaded os_str_bytes v6.0.1 [INFO] [stderr] Downloaded serde_json v1.0.81 [INFO] [stderr] Downloaded clap v3.1.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a249556f92ec391d8730f301af334d7bba95c289b655cf83a2b7efce9b19d2f9 [INFO] running `Command { std: "docker" "start" "-a" "a249556f92ec391d8730f301af334d7bba95c289b655cf83a2b7efce9b19d2f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a249556f92ec391d8730f301af334d7bba95c289b655cf83a2b7efce9b19d2f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a249556f92ec391d8730f301af334d7bba95c289b655cf83a2b7efce9b19d2f9", kill_on_drop: false }` [INFO] [stdout] a249556f92ec391d8730f301af334d7bba95c289b655cf83a2b7efce9b19d2f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76669fa9db83dedabc7544654cbed522e773d3064774a9aab88d536db91a9007 [INFO] running `Command { std: "docker" "start" "-a" "76669fa9db83dedabc7544654cbed522e773d3064774a9aab88d536db91a9007", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking strum v0.24.0 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling utf8-ranges v1.0.5 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling regex-syntax v0.6.26 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking normpath v0.3.2 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.0.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling strum_macros v0.24.0 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling logos-derive v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling clap_derive v3.1.18 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking logos v0.12.0 [INFO] [stderr] Checking exalt-lir v0.1.0 (/opt/rustwide/workdir/exalt-lir) [INFO] [stderr] Checking exalt-assembler v0.1.0 (/opt/rustwide/workdir/exalt-assembler) [INFO] [stderr] Checking exalt-disassembler v0.1.0 (/opt/rustwide/workdir/exalt-disassembler) [INFO] [stderr] Checking exalt-ast v0.1.0 (/opt/rustwide/workdir/exalt-ast) [INFO] [stderr] Checking clap v3.1.18 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking ron v0.7.0 [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/args.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | while (raw.len() + function.prefix.len()) % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!(raw.len() + function.prefix.len()).is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/function.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | while (bytes.len() + function.prefix.len()) % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!(bytes.len() + function.prefix.len()).is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> exalt-assembler/src/function.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | Some(extended_header_address as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `extended_header_address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking exalt-decompiler v0.1.0 (/opt/rustwide/workdir/exalt-decompiler) [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> exalt-assembler/src/function.rs:145:16 [INFO] [stdout] | [INFO] [stdout] 145 | raw.extend((header.frame_size as u16).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ header.frame_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> exalt-assembler/src/function.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | raw.extend((base_address as u32).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `{ base_address }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> exalt-assembler/src/header.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | raw.extend((global_frame_size as u16).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ global_frame_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/header.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 40 | while raw.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!raw.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> exalt-assembler/src/types.rs:130:42 [INFO] [stdout] | [INFO] [stdout] 130 | self.raw_text.extend(bytes.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 130 - self.raw_text.extend(bytes.into_iter()); [INFO] [stdout] 130 + self.raw_text.extend(bytes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/lib.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | while raw.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!raw.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `init_function_index` is never read [INFO] [stdout] --> exalt-disassembler/src/types.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CmbHeader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub init_function_index: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmbHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> exalt-disassembler/src/types.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct CommonFunctionHeader { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommonFunctionHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-disassembler/src/lib.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | while cursor.position() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!cursor.position().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/args.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 24 | while (raw.len() + function.prefix.len()) % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!(raw.len() + function.prefix.len()).is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/function.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | while (bytes.len() + function.prefix.len()) % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!(bytes.len() + function.prefix.len()).is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> exalt-assembler/src/function.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | Some(extended_header_address as u32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `extended_header_address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> exalt-assembler/src/function.rs:145:16 [INFO] [stdout] | [INFO] [stdout] 145 | raw.extend((header.frame_size as u16).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ header.frame_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> exalt-assembler/src/function.rs:157:16 [INFO] [stdout] | [INFO] [stdout] 157 | raw.extend((base_address as u32).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `{ base_address }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> exalt-assembler/src/header.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | raw.extend((global_frame_size as u16).to_le_bytes().iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ global_frame_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/header.rs:40:11 [INFO] [stdout] | [INFO] [stdout] 40 | while raw.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!raw.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> exalt-assembler/src/types.rs:130:42 [INFO] [stdout] | [INFO] [stdout] 130 | self.raw_text.extend(bytes.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 130 - self.raw_text.extend(bytes.into_iter()); [INFO] [stdout] 130 + self.raw_text.extend(bytes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-assembler/src/lib.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 18 | while raw.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!raw.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking exalt-compiler v0.1.0 (/opt/rustwide/workdir/exalt-compiler) [INFO] [stdout] warning: field `init_function_index` is never read [INFO] [stdout] --> exalt-disassembler/src/types.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct CmbHeader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub init_function_index: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmbHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> exalt-disassembler/src/types.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct CommonFunctionHeader { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommonFunctionHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> exalt-disassembler/src/lib.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | while cursor.position() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!cursor.position().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `done_label` after checking its variant with `is_none` [INFO] [stdout] --> exalt-decompiler/src/lib.rs:605:44 [INFO] [stdout] | [INFO] [stdout] 593 | if done_label.is_none() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = done_label` [INFO] [stdout] ... [INFO] [stdout] 605 | decompile_until(state, done_label.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-decompiler/src/data_structures.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn top(&self) -> Option<&'a Expr> { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 10 | pub fn top(&self) -> Option<&'a Expr<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `done_label` after checking its variant with `is_none` [INFO] [stdout] --> exalt-decompiler/src/lib.rs:605:44 [INFO] [stdout] | [INFO] [stdout] 593 | if done_label.is_none() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = done_label` [INFO] [stdout] ... [INFO] [stdout] 605 | decompile_until(state, done_label.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-decompiler/src/data_structures.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn top(&self) -> Option<&'a Expr> { [INFO] [stdout] | ^^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 10 | pub fn top(&self) -> Option<&'a Expr<'_>> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 94 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 166 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:337:20 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 337 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:504:20 [INFO] [stdout] | [INFO] [stdout] 504 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 504 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 94 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 166 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:337:20 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 337 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> exalt-compiler/src/reporting.rs:504:20 [INFO] [stdout] | [INFO] [stdout] 504 | pub fn message(&self) -> Cow { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 504 | pub fn message(&self) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking exalt-cli v0.1.0 (/opt/rustwide/workdir/exalt-cli) [INFO] [stderr] Checking exalt-testing v0.1.0 (/opt/rustwide/workdir/exalt-testing) [INFO] [stderr] Checking exalt-completions v0.1.0 (/opt/rustwide/workdir/exalt-completions) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.20s [INFO] running `Command { std: "docker" "inspect" "76669fa9db83dedabc7544654cbed522e773d3064774a9aab88d536db91a9007", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76669fa9db83dedabc7544654cbed522e773d3064774a9aab88d536db91a9007", kill_on_drop: false }` [INFO] [stdout] 76669fa9db83dedabc7544654cbed522e773d3064774a9aab88d536db91a9007