[INFO] cloning repository https://github.com/thaliaarchi/omniwsa [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/thaliaarchi/omniwsa" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthaliaarchi%2Fomniwsa", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthaliaarchi%2Fomniwsa'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 391f32a39b8ee165e23d84164140197ae1ccad2f [INFO] linting thaliaarchi/omniwsa against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fthaliaarchi%2Fomniwsa" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/thaliaarchi/omniwsa [INFO] finished tweaking git repo https://github.com/thaliaarchi/omniwsa [INFO] tweaked toml for git repo https://github.com/thaliaarchi/omniwsa written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/thaliaarchi/omniwsa on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/thaliaarchi/omniwsa already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fluent-uri v0.1.4 [INFO] [stderr] Downloaded lsp-server v0.7.7 [INFO] [stderr] Downloaded lsp-types v0.97.0 [INFO] [stderr] Downloaded bstr v1.11.0 [INFO] [stderr] Downloaded rug v1.26.1 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.6.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e58c0f1ed961c7f041ea32d046d72ff8909d352341eae2b5fe3a493c6d8b720 [INFO] running `Command { std: "docker" "start" "-a" "1e58c0f1ed961c7f041ea32d046d72ff8909d352341eae2b5fe3a493c6d8b720", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e58c0f1ed961c7f041ea32d046d72ff8909d352341eae2b5fe3a493c6d8b720", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e58c0f1ed961c7f041ea32d046d72ff8909d352341eae2b5fe3a493c6d8b720", kill_on_drop: false }` [INFO] [stdout] 1e58c0f1ed961c7f041ea32d046d72ff8909d352341eae2b5fe3a493c6d8b720 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5280963d04d8ece73dbfbd76edc5bc9bac53c4d6a84ceb3cfeceb57def9ccba [INFO] running `Command { std: "docker" "start" "-a" "f5280963d04d8ece73dbfbd76edc5bc9bac53c4d6a84ceb3cfeceb57def9ccba", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Compiling gmp-mpfr-sys v1.6.4 [INFO] [stderr] Compiling libc v0.2.167 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Compiling rug v1.26.1 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking fluent-uri v0.1.4 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking bstr v1.11.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking serde v1.0.215 [INFO] [stderr] Checking serde_json v1.0.133 [INFO] [stderr] Checking lsp-server v0.7.7 [INFO] [stderr] Checking lsp-types v0.97.0 [INFO] [stderr] Checking omniwsa v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/dialects/voliva/lex.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / match ch { [INFO] [stdout] 110 | | '\t' | '\u{000b}' | '\u{000c}' | '\r' | ' ' | '\u{00a0}' | '\u{1680}' | '\u{2000}' [INFO] [stdout] 111 | | | '\u{2001}' | '\u{2002}' | '\u{2003}' | '\u{2004}' | '\u{2005}' | '\u{2006}' [INFO] [stdout] 112 | | | '\u{2007}' | '\u{2008}' | '\u{2009}' | '\u{200a}' | '\u{2028}' | '\u{2029}' [INFO] [stdout] 113 | | | '\u{202f}' | '\u{205f}' | '\u{3000}' | '\u{feff}' => true, [INFO] [stdout] 114 | | _ => false, [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 109 ~ matches!(ch, '\t' | '\u{000b}' | '\u{000c}' | '\r' | ' ' | '\u{00a0}' | '\u{1680}' | '\u{2000}' [INFO] [stdout] 110 + | '\u{2001}' | '\u{2002}' | '\u{2003}' | '\u{2004}' | '\u{2005}' | '\u{2006}' [INFO] [stdout] 111 + | '\u{2007}' | '\u{2008}' | '\u{2009}' | '\u{200a}' | '\u{2028}' | '\u{2029}' [INFO] [stdout] 112 + | '\u{202f}' | '\u{205f}' | '\u{3000}' | '\u{feff}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lex/byte_trie.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | / if let Some((&b, text)) = text.split_first() { [INFO] [stdout] 159 | | if sparse.contains(b) { [INFO] [stdout] 160 | | dense[sparse.dense_index(b)].get_prefix(text, last_match); [INFO] [stdout] 161 | | } [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if let Some((&b, text)) = text.split_first() [INFO] [stdout] 159 ~ && sparse.contains(b) { [INFO] [stdout] 160 | dense[sparse.dense_index(b)].get_prefix(text, last_match); [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokens/integer/convert.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / !(from.sign_style == SignStyle::Haskell [INFO] [stdout] 48 | | && !BaseStyle::suffix_family().contains(self.base_style) [INFO] [stdout] 49 | | || to.sign_style == SignStyle::Haskell [INFO] [stdout] 50 | | && !to.base_styles.is_disjoint(BaseStyle::suffix_family())) [INFO] [stdout] | |_______________________________________________________________________________^ help: try: `(to.base_styles.is_disjoint(BaseStyle::suffix_family()) || to.sign_style != SignStyle::Haskell) && (BaseStyle::suffix_family().contains(self.base_style) || from.sign_style != SignStyle::Haskell)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/tokens/integer/convert.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | new_literal.extend(iter::repeat(b'0').take(new_leading_zeros - self.leading_zeros)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(b'0', new_leading_zeros - self.leading_zeros)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/tokens/integer/convert.rs:134:32 [INFO] [stdout] | [INFO] [stdout] 134 | new_literal.extend(iter::repeat(b'0').take(new_leading_zeros)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(b'0', new_leading_zeros)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/dialects/voliva/lex.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / match ch { [INFO] [stdout] 110 | | '\t' | '\u{000b}' | '\u{000c}' | '\r' | ' ' | '\u{00a0}' | '\u{1680}' | '\u{2000}' [INFO] [stdout] 111 | | | '\u{2001}' | '\u{2002}' | '\u{2003}' | '\u{2004}' | '\u{2005}' | '\u{2006}' [INFO] [stdout] 112 | | | '\u{2007}' | '\u{2008}' | '\u{2009}' | '\u{200a}' | '\u{2028}' | '\u{2029}' [INFO] [stdout] 113 | | | '\u{202f}' | '\u{205f}' | '\u{3000}' | '\u{feff}' => true, [INFO] [stdout] 114 | | _ => false, [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 109 ~ matches!(ch, '\t' | '\u{000b}' | '\u{000c}' | '\r' | ' ' | '\u{00a0}' | '\u{1680}' | '\u{2000}' [INFO] [stdout] 110 + | '\u{2001}' | '\u{2002}' | '\u{2003}' | '\u{2004}' | '\u{2005}' | '\u{2006}' [INFO] [stdout] 111 + | '\u{2007}' | '\u{2008}' | '\u{2009}' | '\u{200a}' | '\u{2028}' | '\u{2029}' [INFO] [stdout] 112 + | '\u{202f}' | '\u{205f}' | '\u{3000}' | '\u{feff}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lex/byte_trie.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | / if let Some((&b, text)) = text.split_first() { [INFO] [stdout] 159 | | if sparse.contains(b) { [INFO] [stdout] 160 | | dense[sparse.dense_index(b)].get_prefix(text, last_match); [INFO] [stdout] 161 | | } [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ if let Some((&b, text)) = text.split_first() [INFO] [stdout] 159 ~ && sparse.contains(b) { [INFO] [stdout] 160 | dense[sparse.dense_index(b)].get_prefix(text, last_match); [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:90:33 [INFO] [stdout] | [INFO] [stdout] 90 | let cst = dialect.parse(&src); [INFO] [stdout] | ^^^^ help: change this to: `src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests.rs:97:26 [INFO] [stdout] | [INFO] [stdout] 97 | DebugStl(&ws_expect), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `ws_expect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tokens/integer/convert.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / !(from.sign_style == SignStyle::Haskell [INFO] [stdout] 48 | | && !BaseStyle::suffix_family().contains(self.base_style) [INFO] [stdout] 49 | | || to.sign_style == SignStyle::Haskell [INFO] [stdout] 50 | | && !to.base_styles.is_disjoint(BaseStyle::suffix_family())) [INFO] [stdout] | |_______________________________________________________________________________^ help: try: `(to.base_styles.is_disjoint(BaseStyle::suffix_family()) || to.sign_style != SignStyle::Haskell) && (BaseStyle::suffix_family().contains(self.base_style) || from.sign_style != SignStyle::Haskell)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/tokens/integer/convert.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | new_literal.extend(iter::repeat(b'0').take(new_leading_zeros - self.leading_zeros)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(b'0', new_leading_zeros - self.leading_zeros)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/tokens/integer/convert.rs:134:32 [INFO] [stdout] | [INFO] [stdout] 134 | new_literal.extend(iter::repeat(b'0').take(new_leading_zeros)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(b'0', new_leading_zeros)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/transform/visit.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | block.end.as_mut().map(|end| visitor.visit_inst(end)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 31 - block.end.as_mut().map(|end| visitor.visit_inst(end)); [INFO] [stdout] 31 + if let Some(end) = block.end.as_mut() { visitor.visit_inst(end) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking omniwsa-ls v0.1.0 (/opt/rustwide/workdir/omniwsa-ls) [INFO] [stdout] warning: useless conversion to the same type: `tokens::token::Token<'_>` [INFO] [stdout] --> src/transform/norm_strange.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | / ... Token::from(Token::Integer(IntegerToken { [INFO] [stdout] 107 | | ... literal: b"42".into(), [INFO] [stdout] 108 | | ... value: Integer::from(42), [INFO] [stdout] 109 | | ... sign: Sign::None, [INFO] [stdout] ... | [INFO] [stdout] 113 | | ... errors: EnumSet::empty(), [INFO] [stdout] 114 | | ... })), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `Token::from()` [INFO] [stdout] | [INFO] [stdout] 106 ~ Token::Integer(IntegerToken { [INFO] [stdout] 107 + literal: b"42".into(), [INFO] [stdout] 108 + value: Integer::from(42), [INFO] [stdout] 109 + sign: Sign::None, [INFO] [stdout] 110 + base_style: BaseStyle::Decimal, [INFO] [stdout] 111 + leading_zeros: 0, [INFO] [stdout] 112 + has_digit_seps: false, [INFO] [stdout] 113 + errors: EnumSet::empty(), [INFO] [stdout] 114 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/transform/visit.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | block.end.as_mut().map(|end| visitor.visit_inst(end)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 31 - block.end.as_mut().map(|end| visitor.visit_inst(end)); [INFO] [stdout] 31 + if let Some(end) = block.end.as_mut() { visitor.visit_inst(end) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> omniwsa-ls/src/main.rs:45:39 [INFO] [stdout] | [INFO] [stdout] 45 | let server_capabilities = to_json(&server_capabilities())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `server_capabilities()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> omniwsa-ls/src/main.rs:45:39 [INFO] [stdout] | [INFO] [stdout] 45 | let server_capabilities = to_json(&server_capabilities())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `server_capabilities()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 20s [INFO] running `Command { std: "docker" "inspect" "f5280963d04d8ece73dbfbd76edc5bc9bac53c4d6a84ceb3cfeceb57def9ccba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5280963d04d8ece73dbfbd76edc5bc9bac53c4d6a84ceb3cfeceb57def9ccba", kill_on_drop: false }` [INFO] [stdout] f5280963d04d8ece73dbfbd76edc5bc9bac53c4d6a84ceb3cfeceb57def9ccba