[INFO] cloning repository https://github.com/terry-u16/rco-contest-2017-qual [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/terry-u16/rco-contest-2017-qual" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fterry-u16%2Frco-contest-2017-qual", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fterry-u16%2Frco-contest-2017-qual'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6e6a0d73707a85a040e3b8beeddd1455d19ac5e7 [INFO] linting terry-u16/rco-contest-2017-qual against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fterry-u16%2Frco-contest-2017-qual" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/terry-u16/rco-contest-2017-qual [INFO] finished tweaking git repo https://github.com/terry-u16/rco-contest-2017-qual [INFO] tweaked toml for git repo https://github.com/terry-u16/rco-contest-2017-qual written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/terry-u16/rco-contest-2017-qual on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/terry-u16/rco-contest-2017-qual already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proconio v0.4.5 [INFO] [stderr] Downloaded num-integer v0.1.42 [INFO] [stderr] Downloaded amplify v3.14.2 [INFO] [stderr] Downloaded bitset-fixed v0.1.0 [INFO] [stderr] Downloaded proconio-derive v0.2.1 [INFO] [stderr] Downloaded rand_hc v0.3.2 [INFO] [stderr] Downloaded ordered-float v3.7.0 [INFO] [stderr] Downloaded glidesort v0.1.2 [INFO] [stderr] Downloaded amplify_derive v2.11.3 [INFO] [stderr] Downloaded amplify_num v0.4.1 [INFO] [stderr] Downloaded ac-library-rs v0.1.1 [INFO] [stderr] Downloaded wide v0.7.16 [INFO] [stderr] Downloaded amplify_syn v1.1.6 [INFO] [stderr] Downloaded stringly_conversions v0.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bccff499259017d28a65bfead048910311d617a531972a1ce480a6b401bd48e1 [INFO] running `Command { std: "docker" "start" "-a" "bccff499259017d28a65bfead048910311d617a531972a1ce480a6b401bd48e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bccff499259017d28a65bfead048910311d617a531972a1ce480a6b401bd48e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bccff499259017d28a65bfead048910311d617a531972a1ce480a6b401bd48e1", kill_on_drop: false }` [INFO] [stdout] bccff499259017d28a65bfead048910311d617a531972a1ce480a6b401bd48e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d10fc233e02cf40015c1eb2b7a8b65a4e5fd872c7860395e984a63852594988a [INFO] running `Command { std: "docker" "start" "-a" "d10fc233e02cf40015c1eb2b7a8b65a4e5fd872c7860395e984a63852594988a", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Compiling serde v1.0.185 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking arbitrary v1.3.2 [INFO] [stderr] Checking amplify_num v0.4.1 [INFO] [stderr] Checking bitset-fixed v0.1.0 [INFO] [stderr] Checking glidesort v0.1.2 [INFO] [stderr] Checking ac-library-rs v0.1.1 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking stringly_conversions v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking wide v0.7.16 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_hc v0.3.2 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking ordered-float v3.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling amplify_syn v1.1.6 [INFO] [stderr] Compiling proconio-derive v0.2.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Compiling amplify_derive v2.11.3 [INFO] [stderr] Checking proconio v0.4.5 [INFO] [stderr] Checking nalgebra v0.32.3 [INFO] [stderr] Checking amplify v3.14.2 [INFO] [stderr] Checking rco-contest-2017-qual v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Input` is never constructed [INFO] [stdout] --> src/bin/b.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct Input {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Input` is never constructed [INFO] [stdout] --> src/bin/b.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct Input {} [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 105 | fn get_callbacks() -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 105 | fn get_callbacks() -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/bin/a.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | (self.score + 9999) / 10000 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.score.div_ceil(10000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/bin/a.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | (self.score + 9999) / 10000 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.score.div_ceil(10000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `piece` [INFO] [stdout] --> src/bin/a.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | for i in 0..Input::K { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 233 - for i in 0..Input::K { [INFO] [stdout] 233 + for in piece.iter_mut().take(Input::K) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `piece` [INFO] [stdout] --> src/bin/a.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | for i in 0..Input::K { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 233 - for i in 0..Input::K { [INFO] [stdout] 233 + for in piece.iter_mut().take(Input::K) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/a.rs:368:20 [INFO] [stdout] | [INFO] [stdout] 368 | if !state.piece_map[next].is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.piece_map[next].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `piece` [INFO] [stdout] --> src/bin/a.rs:355:18 [INFO] [stdout] | [INFO] [stdout] 355 | for i in 0..Input::K { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 355 - for i in 0..Input::K { [INFO] [stdout] 355 + for in piece.iter_mut().take(Input::K) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/a.rs:368:20 [INFO] [stdout] | [INFO] [stdout] 368 | if !state.piece_map[next].is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.piece_map[next].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `piece` [INFO] [stdout] --> src/bin/a.rs:355:18 [INFO] [stdout] | [INFO] [stdout] 355 | for i in 0..Input::K { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 355 - for i in 0..Input::K { [INFO] [stdout] 355 + for in piece.iter_mut().take(Input::K) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:752:20 [INFO] [stdout] | [INFO] [stdout] 752 | callbacks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:761:24 [INFO] [stdout] | [INFO] [stdout] 761 | callbacks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:780:49 [INFO] [stdout] | [INFO] [stdout] 780 | let mut current_score = state.score(&env); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:752:20 [INFO] [stdout] | [INFO] [stdout] 752 | callbacks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/a.rs:761:24 [INFO] [stdout] | [INFO] [stdout] 761 | callbacks: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/a.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if diagnostics.all_iter % self.clock_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `diagnostics.all_iter.is_multiple_of(self.clock_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:780:49 [INFO] [stdout] | [INFO] [stdout] 780 | let mut current_score = state.score(&env); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:820:50 [INFO] [stdout] | [INFO] [stdout] 820 | debug_assert_eq!(state.score(&env), current_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/a.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if diagnostics.all_iter % self.clock_interval == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `diagnostics.all_iter.is_multiple_of(self.clock_interval)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:827:50 [INFO] [stdout] | [INFO] [stdout] 827 | debug_assert_eq!(state.score(&env), new_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:841:50 [INFO] [stdout] | [INFO] [stdout] 841 | debug_assert_eq!(state.score(&env), current_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:820:50 [INFO] [stdout] | [INFO] [stdout] 820 | debug_assert_eq!(state.score(&env), current_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:845:56 [INFO] [stdout] | [INFO] [stdout] 845 | diagnostics.final_score = best_state.score(&env).raw_score(); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:827:50 [INFO] [stdout] | [INFO] [stdout] 827 | debug_assert_eq!(state.score(&env), new_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:841:50 [INFO] [stdout] | [INFO] [stdout] 841 | debug_assert_eq!(state.score(&env), current_score); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/a.rs:845:56 [INFO] [stdout] | [INFO] [stdout] 845 | diagnostics.final_score = best_state.score(&env).raw_score(); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/bin/a.rs:1232:31 [INFO] [stdout] | [INFO] [stdout] 1232 | pub const fn to_index(&self, size: usize) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/bin/a.rs:1302:31 [INFO] [stdout] | [INFO] [stdout] 1302 | pub const fn to_coord(&self, n: usize) -> Coord { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/a.rs:1187:13 [INFO] [stdout] | [INFO] [stdout] 1187 | assert_eq!(array.get(0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1187 - assert_eq!(array.get(0), false); [INFO] [stdout] 1187 + assert!(!array.get(0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/a.rs:1190:13 [INFO] [stdout] | [INFO] [stdout] 1190 | assert_eq!(array.get(0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1190 - assert_eq!(array.get(0), true); [INFO] [stdout] 1190 + assert!(array.get(0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:225:30 [INFO] [stdout] | [INFO] [stdout] 225 | let queue = unsafe { &mut QUEUE_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 225 | let queue = unsafe { &raw mut QUEUE_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | let weights = unsafe { &mut WEIGHTS_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 226 | let weights = unsafe { &raw mut WEIGHTS_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:347:30 [INFO] [stdout] | [INFO] [stdout] 347 | let queue = unsafe { &mut QUEUE_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 347 | let queue = unsafe { &raw mut QUEUE_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:348:32 [INFO] [stdout] | [INFO] [stdout] 348 | let weights = unsafe { &mut WEIGHTS_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 348 | let weights = unsafe { &raw mut WEIGHTS_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/bin/a.rs:1101:21 [INFO] [stdout] | [INFO] [stdout] 1101 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1101 | pub fn iter(&self) -> Iter<'_, usize> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/a.rs:1191:13 [INFO] [stdout] | [INFO] [stdout] 1191 | assert_eq!(array.get(1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1191 - assert_eq!(array.get(1), false); [INFO] [stdout] 1191 + assert!(!array.get(1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/a.rs:1194:13 [INFO] [stdout] | [INFO] [stdout] 1194 | assert_eq!(array.get(0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1194 - assert_eq!(array.get(0), false); [INFO] [stdout] 1194 + assert!(!array.get(0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bin/a.rs:1197:13 [INFO] [stdout] | [INFO] [stdout] 1197 | assert_eq!(array.get(0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1197 - assert_eq!(array.get(0), true); [INFO] [stdout] 1197 + assert!(array.get(0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/bin/a.rs:1232:31 [INFO] [stdout] | [INFO] [stdout] 1232 | pub const fn to_index(&self, size: usize) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/bin/a.rs:1302:31 [INFO] [stdout] | [INFO] [stdout] 1302 | pub const fn to_coord(&self, n: usize) -> Coord { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:225:30 [INFO] [stdout] | [INFO] [stdout] 225 | let queue = unsafe { &mut QUEUE_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 225 | let queue = unsafe { &raw mut QUEUE_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:226:32 [INFO] [stdout] | [INFO] [stdout] 226 | let weights = unsafe { &mut WEIGHTS_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 226 | let weights = unsafe { &raw mut WEIGHTS_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:347:30 [INFO] [stdout] | [INFO] [stdout] 347 | let queue = unsafe { &mut QUEUE_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 347 | let queue = unsafe { &raw mut QUEUE_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static [INFO] [stdout] --> src/bin/a.rs:348:32 [INFO] [stdout] | [INFO] [stdout] 348 | let weights = unsafe { &mut WEIGHTS_BUF }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: use `&raw mut` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 348 | let weights = unsafe { &raw mut WEIGHTS_BUF }; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/bin/a.rs:1101:21 [INFO] [stdout] | [INFO] [stdout] 1101 | pub fn iter(&self) -> Iter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1101 | pub fn iter(&self) -> Iter<'_, usize> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.40s [INFO] running `Command { std: "docker" "inspect" "d10fc233e02cf40015c1eb2b7a8b65a4e5fd872c7860395e984a63852594988a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d10fc233e02cf40015c1eb2b7a8b65a4e5fd872c7860395e984a63852594988a", kill_on_drop: false }` [INFO] [stdout] d10fc233e02cf40015c1eb2b7a8b65a4e5fd872c7860395e984a63852594988a