[INFO] cloning repository https://github.com/teras/basil [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/teras/basil" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteras%2Fbasil", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteras%2Fbasil'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c3b539072aa2519a638169112e3f56801d87588 [INFO] linting teras/basil against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteras%2Fbasil" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/teras/basil [INFO] finished tweaking git repo https://github.com/teras/basil [INFO] tweaked toml for git repo https://github.com/teras/basil written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/teras/basil on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/teras/basil already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0c6ef2cf41ec466a77b6992c8ee55e820ce41258df47dbc58e16b8599f47fac [INFO] running `Command { std: "docker" "start" "-a" "e0c6ef2cf41ec466a77b6992c8ee55e820ce41258df47dbc58e16b8599f47fac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0c6ef2cf41ec466a77b6992c8ee55e820ce41258df47dbc58e16b8599f47fac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0c6ef2cf41ec466a77b6992c8ee55e820ce41258df47dbc58e16b8599f47fac", kill_on_drop: false }` [INFO] [stdout] e0c6ef2cf41ec466a77b6992c8ee55e820ce41258df47dbc58e16b8599f47fac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ded5e436ed30318508c7d84572b574eb0319cc9009271790c84c2230979bd37d [INFO] running `Command { std: "docker" "start" "-a" "ded5e436ed30318508c7d84572b574eb0319cc9009271790c84c2230979bd37d", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bollard-stubs v1.47.1-rc.27.3.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking bollard v0.18.1 [INFO] [stderr] Checking basil v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/docker.rs:185:10 [INFO] [stdout] | [INFO] [stdout] 185 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docker.rs:319:8 [INFO] [stdout] | [INFO] [stdout] 319 | if !config.get("mcpServers").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.get("mcpServers").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/docker.rs:695:13 [INFO] [stdout] | [INFO] [stdout] 695 | / c.names.as_ref().map_or(false, |names| { [INFO] [stdout] 696 | | names [INFO] [stdout] 697 | | .iter() [INFO] [stdout] 698 | | .any(|n| n.trim_start_matches('/') == container_name) [INFO] [stdout] 699 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 695 - c.names.as_ref().map_or(false, |names| { [INFO] [stdout] 695 + c.names.as_ref().is_some_and(|names| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/docker.rs:185:10 [INFO] [stdout] | [INFO] [stdout] 185 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/docker.rs:319:8 [INFO] [stdout] | [INFO] [stdout] 319 | if !config.get("mcpServers").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.get("mcpServers").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mcp.rs:878:71 [INFO] [stdout] | [INFO] [stdout] 878 | let continuation = build_continuation_message(&settings); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/docker.rs:695:13 [INFO] [stdout] | [INFO] [stdout] 695 | / c.names.as_ref().map_or(false, |names| { [INFO] [stdout] 696 | | names [INFO] [stdout] 697 | | .iter() [INFO] [stdout] 698 | | .any(|n| n.trim_start_matches('/') == container_name) [INFO] [stdout] 699 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 695 - c.names.as_ref().map_or(false, |names| { [INFO] [stdout] 695 + c.names.as_ref().is_some_and(|names| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/services/claude.rs:266:33 [INFO] [stdout] | [INFO] [stdout] 266 | / ... if data.get("subtype").and_then(|v| v.as_str()) == Some("init") { [INFO] [stdout] 267 | | ... if let Some(sid) = data.get("session_id").and_then(|v| v.as_str()) { [INFO] [stdout] 268 | | ... sessions.set_claude_session_id(&session_id, sid.to_string()).await; [INFO] [stdout] 269 | | ... } [INFO] [stdout] 270 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 265 ~ "system" [INFO] [stdout] 266 ~ if data.get("subtype").and_then(|v| v.as_str()) == Some("init") => { [INFO] [stdout] 267 | if let Some(sid) = data.get("session_id").and_then(|v| v.as_str()) { [INFO] [stdout] 268 | sessions.set_claude_session_id(&session_id, sid.to_string()).await; [INFO] [stdout] 269 | } [INFO] [stdout] 270 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:137:60 [INFO] [stdout] | [INFO] [stdout] 137 | async fn run_init(init_state: Arc, project_dir: &PathBuf, port: u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - async fn run_init(init_state: Arc, project_dir: &PathBuf, port: u16) { [INFO] [stdout] 137 + async fn run_init(init_state: Arc, project_dir: &Path, port: u16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:204:34 [INFO] [stdout] | [INFO] [stdout] 204 | async fn run_server(project_dir: &PathBuf, port: u16, serve_ui: bool, init_state: Arc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 ~ async fn run_server(project_dir: &Path, port: u16, serve_ui: bool, init_state: Arc) { [INFO] [stdout] 205 | let project_name = project_dir [INFO] [stdout] ... [INFO] [stdout] 217 | project_path: project_dir.to_string_lossy().to_string(), [INFO] [stdout] 218 ~ default_working_dir: project_dir.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mcp.rs:878:71 [INFO] [stdout] | [INFO] [stdout] 878 | let continuation = build_continuation_message(&settings); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `settings` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/services/claude.rs:266:33 [INFO] [stdout] | [INFO] [stdout] 266 | / ... if data.get("subtype").and_then(|v| v.as_str()) == Some("init") { [INFO] [stdout] 267 | | ... if let Some(sid) = data.get("session_id").and_then(|v| v.as_str()) { [INFO] [stdout] 268 | | ... sessions.set_claude_session_id(&session_id, sid.to_string()).await; [INFO] [stdout] 269 | | ... } [INFO] [stdout] 270 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 265 ~ "system" [INFO] [stdout] 266 ~ if data.get("subtype").and_then(|v| v.as_str()) == Some("init") => { [INFO] [stdout] 267 | if let Some(sid) = data.get("session_id").and_then(|v| v.as_str()) { [INFO] [stdout] 268 | sessions.set_claude_session_id(&session_id, sid.to_string()).await; [INFO] [stdout] 269 | } [INFO] [stdout] 270 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:137:60 [INFO] [stdout] | [INFO] [stdout] 137 | async fn run_init(init_state: Arc, project_dir: &PathBuf, port: u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - async fn run_init(init_state: Arc, project_dir: &PathBuf, port: u16) { [INFO] [stdout] 137 + async fn run_init(init_state: Arc, project_dir: &Path, port: u16) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:204:34 [INFO] [stdout] | [INFO] [stdout] 204 | async fn run_server(project_dir: &PathBuf, port: u16, serve_ui: bool, init_state: Arc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 ~ async fn run_server(project_dir: &Path, port: u16, serve_ui: bool, init_state: Arc) { [INFO] [stdout] 205 | let project_name = project_dir [INFO] [stdout] ... [INFO] [stdout] 217 | project_path: project_dir.to_string_lossy().to_string(), [INFO] [stdout] 218 ~ default_working_dir: project_dir.to_path_buf(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.19s [INFO] running `Command { std: "docker" "inspect" "ded5e436ed30318508c7d84572b574eb0319cc9009271790c84c2230979bd37d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ded5e436ed30318508c7d84572b574eb0319cc9009271790c84c2230979bd37d", kill_on_drop: false }` [INFO] [stdout] ded5e436ed30318508c7d84572b574eb0319cc9009271790c84c2230979bd37d