[INFO] cloning repository https://github.com/teikmeier/rustylight [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/teikmeier/rustylight" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteikmeier%2Frustylight", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteikmeier%2Frustylight'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 94056ed310dd024278dc8be51a62e2e29d2822fb [INFO] linting teikmeier/rustylight against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fteikmeier%2Frustylight" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/teikmeier/rustylight [INFO] finished tweaking git repo https://github.com/teikmeier/rustylight [INFO] tweaked toml for git repo https://github.com/teikmeier/rustylight written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/teikmeier/rustylight on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/teikmeier/rustylight already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded notify v5.2.0 [INFO] [stderr] Downloaded log4rs v1.3.0 [INFO] [stderr] Downloaded confy v0.5.1 [INFO] [stderr] Downloaded directories v4.0.1 [INFO] [stderr] Downloaded midir v0.7.0 [INFO] [stderr] Downloaded serialport v4.7.2 [INFO] [stderr] Downloaded coremidi v0.4.0 [INFO] [stderr] Downloaded coremidi-sys v2.0.2 [INFO] [stderr] Downloaded libudev v0.3.0 [INFO] [stderr] Downloaded unescaper v0.1.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 194c84d63c1bc1c71bb2234744aa7fabc166cbdaf48061dee2a3e1dfea575867 [INFO] running `Command { std: "docker" "start" "-a" "194c84d63c1bc1c71bb2234744aa7fabc166cbdaf48061dee2a3e1dfea575867", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "194c84d63c1bc1c71bb2234744aa7fabc166cbdaf48061dee2a3e1dfea575867", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "194c84d63c1bc1c71bb2234744aa7fabc166cbdaf48061dee2a3e1dfea575867", kill_on_drop: false }` [INFO] [stdout] 194c84d63c1bc1c71bb2234744aa7fabc166cbdaf48061dee2a3e1dfea575867 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3adee87720715ae98fdc4fc957394437bd2690edb5ea47a251d0f367695e2bd [INFO] running `Command { std: "docker" "start" "-a" "c3adee87720715ae98fdc4fc957394437bd2690edb5ea47a251d0f367695e2bd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking lock_api v0.4.13 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking memalloc v0.1.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking nix v0.15.0 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking unescaper v0.1.6 [INFO] [stderr] Checking serialport v4.7.2 [INFO] [stderr] Checking alsa v0.4.3 [INFO] [stderr] Checking midir v0.7.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking notify v5.2.0 [INFO] [stderr] Checking confy v0.5.1 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking rustylight v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/enttec_devices.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 122 | 0..=MIN_FRAME_SIZE => MIN_FRAME_SIZE, [INFO] [stdout] | ------------------ this range overlaps on `24_usize`... [INFO] [stdout] 123 | MIN_FRAME_SIZE..=MAX_FRAME_SIZE => input_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/enttec_devices.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 122 | 0..=MIN_FRAME_SIZE => MIN_FRAME_SIZE, [INFO] [stdout] | ------------------ this range overlaps on `24_usize`... [INFO] [stdout] 123 | MIN_FRAME_SIZE..=MAX_FRAME_SIZE => input_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config` after checking its variant with `is_err` [INFO] [stdout] --> src/configuration.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 45 | if config.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = config` [INFO] [stdout] ... [INFO] [stdout] 49 | let config_result = config.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config` after checking its variant with `is_err` [INFO] [stdout] --> src/configuration.rs:49:29 [INFO] [stdout] | [INFO] [stdout] 45 | if config.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = config` [INFO] [stdout] ... [INFO] [stdout] 49 | let config_result = config.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enttec_devices.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return Dmxis{ [INFO] [stdout] 61 | | port: None, [INFO] [stdout] 62 | | port_name: String::from(port_name_input), [INFO] [stdout] 63 | | break_time: 9, //DMX protocol defines a break to indicate the beginnging of a packet [INFO] [stdout] 64 | | mark_after_break_time: 1, //DMX protocol defines a mark after break to indicate the beginnging of a packet [INFO] [stdout] 65 | | output_rate: 40 //fps [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ Dmxis{ [INFO] [stdout] 61 + port: None, [INFO] [stdout] 62 + port_name: String::from(port_name_input), [INFO] [stdout] 63 + break_time: 9, //DMX protocol defines a break to indicate the beginnging of a packet [INFO] [stdout] 64 + mark_after_break_time: 1, //DMX protocol defines a mark after break to indicate the beginnging of a packet [INFO] [stdout] 65 + output_rate: 40 //fps [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/enttec_devices.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | 0..=MIN_FRAME_SIZE => MIN_FRAME_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/enttec_devices.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | MIN_FRAME_SIZE..=MAX_FRAME_SIZE => input_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enttec_devices.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | return Err("".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Err("".into()); [INFO] [stdout] 178 + Err("".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enttec_devices.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return Dmxis{ [INFO] [stdout] 61 | | port: None, [INFO] [stdout] 62 | | port_name: String::from(port_name_input), [INFO] [stdout] 63 | | break_time: 9, //DMX protocol defines a break to indicate the beginnging of a packet [INFO] [stdout] 64 | | mark_after_break_time: 1, //DMX protocol defines a mark after break to indicate the beginnging of a packet [INFO] [stdout] 65 | | output_rate: 40 //fps [INFO] [stdout] 66 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ Dmxis{ [INFO] [stdout] 61 + port: None, [INFO] [stdout] 62 + port_name: String::from(port_name_input), [INFO] [stdout] 63 + break_time: 9, //DMX protocol defines a break to indicate the beginnging of a packet [INFO] [stdout] 64 + mark_after_break_time: 1, //DMX protocol defines a mark after break to indicate the beginnging of a packet [INFO] [stdout] 65 + output_rate: 40 //fps [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/enttec_devices.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | 0..=MIN_FRAME_SIZE => MIN_FRAME_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/enttec_devices.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | MIN_FRAME_SIZE..=MAX_FRAME_SIZE => input_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/enttec_devices.rs:178:5 [INFO] [stdout] | [INFO] [stdout] 178 | return Err("".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 - return Err("".into()); [INFO] [stdout] 178 + Err("".into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/faders.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return Some(fader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Some(fader) [INFO] [stdout] 150 + Some(fader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/faders.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | return Some(fader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Some(fader) [INFO] [stdout] 150 + Some(fader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/faders.rs:275:67 [INFO] [stdout] | [INFO] [stdout] 275 | } else if current_position >= 0.5 && movement.reverse { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 276 | | new_value = curve_min; [INFO] [stdout] 277 | | } else if current_position < 0.5 && !movement.reverse { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/faders.rs:277:67 [INFO] [stdout] | [INFO] [stdout] 277 | } else if current_position < 0.5 && !movement.reverse { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 278 | | new_value = curve_min; [INFO] [stdout] 279 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | / if position > 1.0 { [INFO] [stdout] 305 | | position = 1.0; [INFO] [stdout] 306 | | } else if position < 0.0 { [INFO] [stdout] 307 | | position = 0.0; [INFO] [stdout] 308 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/faders.rs:312:6 [INFO] [stdout] | [INFO] [stdout] 312 | (-1.0 * reverse_operator * f64::cos( 2.0 * PI * position ) + 1.0) / 2.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-reverse_operator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/faders.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | return position; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return position; [INFO] [stdout] 324 + position [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / if position > 1.0 { [INFO] [stdout] 317 | | position = 1.0; [INFO] [stdout] 318 | | } else if position < 0.0 { [INFO] [stdout] 319 | | position = 0.0; [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | / if position > 1.0 { [INFO] [stdout] 329 | | position = 1.0; [INFO] [stdout] 330 | | } else if position < 0.0 { [INFO] [stdout] 331 | | position = 0.0; [INFO] [stdout] 332 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/midi_ports.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Ok(()); [INFO] [stdout] 65 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/midi_ports.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let port; [INFO] [stdout] | ^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 48 | port = port_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `port` here [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 | [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let port = port_result.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/midi_ports.rs:42:54 [INFO] [stdout] | [INFO] [stdout] 42 | error!(" - {}", midi_in.port_name(&p)?); [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/midi_ports.rs:53:42 [INFO] [stdout] | [INFO] [stdout] 53 | let connection = midi_in.connect(&port, "midir-read-input", move |_stamp, message, _| { [INFO] [stdout] | ^^^^^ help: change this to: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/faders.rs:275:67 [INFO] [stdout] | [INFO] [stdout] 275 | } else if current_position >= 0.5 && movement.reverse { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 276 | | new_value = curve_min; [INFO] [stdout] 277 | | } else if current_position < 0.5 && !movement.reverse { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/faders.rs:277:67 [INFO] [stdout] | [INFO] [stdout] 277 | } else if current_position < 0.5 && !movement.reverse { [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 278 | | new_value = curve_min; [INFO] [stdout] 279 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tempo1` after checking its variant with `is_some` [INFO] [stdout] --> src/midi_ports.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 101 | if tempo1.is_some() && tempo2.is_some() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 102 | update.tempo = Some(tempo1.unwrap() + tempo2.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tempo2` after checking its variant with `is_some` [INFO] [stdout] --> src/midi_ports.rs:102:55 [INFO] [stdout] | [INFO] [stdout] 101 | if tempo1.is_some() && tempo2.is_some() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 102 | update.tempo = Some(tempo1.unwrap() + tempo2.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/midi_ports.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / loop { [INFO] [stdout] 80 | | match receiver.try_recv() { [INFO] [stdout] 81 | | Ok(message) => { [INFO] [stdout] 82 | | if message.status == PROGRAMM_CHANGE + &self.midi_channel { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____________^ help: try: `while let Ok(message) = receiver.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | if message.status == PROGRAMM_CHANGE + &self.midi_channel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:84:53 [INFO] [stdout] | [INFO] [stdout] 84 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == SONG_SELECT && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:86:53 [INFO] [stdout] | [INFO] [stdout] 86 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == TEMPO_CONTROL_1 && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:88:53 [INFO] [stdout] | [INFO] [stdout] 88 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == TEMPO_CONTROL_2 && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == ALL_NOTES_OFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:92:53 [INFO] [stdout] | [INFO] [stdout] 92 | } else if message.status == NOTE_ON + &self.midi_channel && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:94:53 [INFO] [stdout] | [INFO] [stdout] 94 | } else if message.status == NOTE_OFF + &self.midi_channel { [INFO] [stdout] | ^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shows.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / if self.selected_song != next_song { [INFO] [stdout] 31 | | if self.songs.len() > next_song { [INFO] [stdout] 32 | | self.selected_song = next_song; [INFO] [stdout] 33 | | self.print_selected_song(); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if self.selected_song != next_song [INFO] [stdout] 31 ~ && self.songs.len() > next_song { [INFO] [stdout] 32 | self.selected_song = next_song; [INFO] [stdout] 33 | self.print_selected_song(); [INFO] [stdout] 34 | self.songs[self.selected_song].reset(); [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | / if position > 1.0 { [INFO] [stdout] 305 | | position = 1.0; [INFO] [stdout] 306 | | } else if position < 0.0 { [INFO] [stdout] 307 | | position = 0.0; [INFO] [stdout] 308 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/shows.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if let Some(_) = patch.off { [INFO] [stdout] | -------^^^^^^^------------ help: try: `if patch.off.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:55:64 [INFO] [stdout] | [INFO] [stdout] 55 | self.songs[self.selected_song].update_state(patch, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/faders.rs:312:6 [INFO] [stdout] | [INFO] [stdout] 312 | (-1.0 * reverse_operator * f64::cos( 2.0 * PI * position ) + 1.0) / 2.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-reverse_operator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/faders.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | return position; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - return position; [INFO] [stdout] 324 + position [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / if position > 1.0 { [INFO] [stdout] 317 | | position = 1.0; [INFO] [stdout] 318 | | } else if position < 0.0 { [INFO] [stdout] 319 | | position = 0.0; [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shows.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | / if self.selected_scene != next_scene { [INFO] [stdout] 100 | | if self.scenes.len() > next_scene { [INFO] [stdout] 101 | | self.selected_scene = next_scene; [INFO] [stdout] 102 | | self.scenes[self.selected_scene].reset(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if self.selected_scene != next_scene [INFO] [stdout] 100 ~ && self.scenes.len() > next_scene { [INFO] [stdout] 101 | self.selected_scene = next_scene; [INFO] [stdout] 102 | self.scenes[self.selected_scene].reset(); [INFO] [stdout] 103 | self.print_selected_scene(); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | self.scenes[self.selected_scene].update_state(patch, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/faders.rs:328:5 [INFO] [stdout] | [INFO] [stdout] 328 | / if position > 1.0 { [INFO] [stdout] 329 | | position = 1.0; [INFO] [stdout] 330 | | } else if position < 0.0 { [INFO] [stdout] 331 | | position = 0.0; [INFO] [stdout] 332 | | } [INFO] [stdout] | |_____^ help: replace with clamp: `position = position.clamp(0.0, 1.0);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/midi_ports.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Ok(()); [INFO] [stdout] 65 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:150:77 [INFO] [stdout] | [INFO] [stdout] 150 | fader.update_state(current_tempo, self.start_time, patch.notes, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shows.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return dmx_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return dmx_data; [INFO] [stdout] 159 + dmx_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/midi_ports.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let port; [INFO] [stdout] | ^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 48 | port = port_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `port` here [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 | [INFO] [stdout] ... [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let port = port_result.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/shows.rs:170:16 [INFO] [stdout] | [INFO] [stdout] 170 | if let Some(_) = note { [INFO] [stdout] | -------^^^^^^^------- help: try: `if note.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shows.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if song.scenes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!song.scenes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shows.rs:228:33 [INFO] [stdout] | [INFO] [stdout] 228 | let scene_file = File::open(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shows.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | return paths; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return paths; [INFO] [stdout] 259 + paths [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/midi_ports.rs:42:54 [INFO] [stdout] | [INFO] [stdout] 42 | error!(" - {}", midi_in.port_name(&p)?); [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/midi_ports.rs:53:42 [INFO] [stdout] | [INFO] [stdout] 53 | let connection = midi_in.connect(&port, "midir-read-input", move |_stamp, message, _| { [INFO] [stdout] | ^^^^^ help: change this to: `port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !show.is_some() || dmx_port.is_err() || !midi_port.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `show.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:48 [INFO] [stdout] | [INFO] [stdout] 34 | if !show.is_some() || dmx_port.is_err() || !midi_port.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `midi_port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Ok(()); [INFO] [stdout] 43 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tempo1` after checking its variant with `is_some` [INFO] [stdout] --> src/midi_ports.rs:102:37 [INFO] [stdout] | [INFO] [stdout] 101 | if tempo1.is_some() && tempo2.is_some() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 102 | update.tempo = Some(tempo1.unwrap() + tempo2.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tempo2` after checking its variant with `is_some` [INFO] [stdout] --> src/midi_ports.rs:102:55 [INFO] [stdout] | [INFO] [stdout] 101 | if tempo1.is_some() && tempo2.is_some() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 102 | update.tempo = Some(tempo1.unwrap() + tempo2.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | show.update_state(update, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/midi_ports.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / loop { [INFO] [stdout] 80 | | match receiver.try_recv() { [INFO] [stdout] 81 | | Ok(message) => { [INFO] [stdout] 82 | | if message.status == PROGRAMM_CHANGE + &self.midi_channel { [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____________^ help: try: `while let Ok(message) = receiver.try_recv() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:82:46 [INFO] [stdout] | [INFO] [stdout] 82 | if message.status == PROGRAMM_CHANGE + &self.midi_channel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:84:53 [INFO] [stdout] | [INFO] [stdout] 84 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == SONG_SELECT && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:86:53 [INFO] [stdout] | [INFO] [stdout] 86 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == TEMPO_CONTROL_1 && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:88:53 [INFO] [stdout] | [INFO] [stdout] 88 | ... } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == TEMPO_CONTROL_2 && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:90:53 [INFO] [stdout] | [INFO] [stdout] 90 | } else if message.status == CONTROL_CHANGE + &self.midi_channel && message.data1 == ALL_NOTES_OFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:92:53 [INFO] [stdout] | [INFO] [stdout] 92 | } else if message.status == NOTE_ON + &self.midi_channel && message.data2.is_some() { [INFO] [stdout] | ^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/midi_ports.rs:94:53 [INFO] [stdout] | [INFO] [stdout] 94 | } else if message.status == NOTE_OFF + &self.midi_channel { [INFO] [stdout] | ^^^^^^^^^^^------------------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.midi_channel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shows.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / if self.selected_song != next_song { [INFO] [stdout] 31 | | if self.songs.len() > next_song { [INFO] [stdout] 32 | | self.selected_song = next_song; [INFO] [stdout] 33 | | self.print_selected_song(); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if self.selected_song != next_song [INFO] [stdout] 31 ~ && self.songs.len() > next_song { [INFO] [stdout] 32 | self.selected_song = next_song; [INFO] [stdout] 33 | self.print_selected_song(); [INFO] [stdout] 34 | self.songs[self.selected_song].reset(); [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/shows.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if let Some(_) = patch.off { [INFO] [stdout] | -------^^^^^^^------------ help: try: `if patch.off.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:55:64 [INFO] [stdout] | [INFO] [stdout] 55 | self.songs[self.selected_song].update_state(patch, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shows.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | / if self.selected_scene != next_scene { [INFO] [stdout] 100 | | if self.scenes.len() > next_scene { [INFO] [stdout] 101 | | self.selected_scene = next_scene; [INFO] [stdout] 102 | | self.scenes[self.selected_scene].reset(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if self.selected_scene != next_scene [INFO] [stdout] 100 ~ && self.scenes.len() > next_scene { [INFO] [stdout] 101 | self.selected_scene = next_scene; [INFO] [stdout] 102 | self.scenes[self.selected_scene].reset(); [INFO] [stdout] 103 | self.print_selected_scene(); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | self.scenes[self.selected_scene].update_state(patch, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shows.rs:150:77 [INFO] [stdout] | [INFO] [stdout] 150 | fader.update_state(current_tempo, self.start_time, patch.notes, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shows.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | return dmx_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - return dmx_data; [INFO] [stdout] 159 + dmx_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/shows.rs:170:16 [INFO] [stdout] | [INFO] [stdout] 170 | if let Some(_) = note { [INFO] [stdout] | -------^^^^^^^------- help: try: `if note.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shows.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | if song.scenes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!song.scenes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shows.rs:228:33 [INFO] [stdout] | [INFO] [stdout] 228 | let scene_file = File::open(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shows.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | return paths; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return paths; [INFO] [stdout] 259 + paths [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !show.is_some() || dmx_port.is_err() || !midi_port.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `show.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:48 [INFO] [stdout] | [INFO] [stdout] 34 | if !show.is_some() || dmx_port.is_err() || !midi_port.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `midi_port.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Ok(()); [INFO] [stdout] 43 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:60:35 [INFO] [stdout] | [INFO] [stdout] 60 | show.update_state(update, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.81s [INFO] running `Command { std: "docker" "inspect" "c3adee87720715ae98fdc4fc957394437bd2690edb5ea47a251d0f367695e2bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3adee87720715ae98fdc4fc957394437bd2690edb5ea47a251d0f367695e2bd", kill_on_drop: false }` [INFO] [stdout] c3adee87720715ae98fdc4fc957394437bd2690edb5ea47a251d0f367695e2bd