[INFO] cloning repository https://github.com/tchandrakar/nakama-cli-suite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/tchandrakar/nakama-cli-suite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftchandrakar%2Fnakama-cli-suite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftchandrakar%2Fnakama-cli-suite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f812bae5a7a8918bd44e0f4456c5716ee57474a [INFO] linting tchandrakar/nakama-cli-suite against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftchandrakar%2Fnakama-cli-suite" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/tchandrakar/nakama-cli-suite [INFO] finished tweaking git repo https://github.com/tchandrakar/nakama-cli-suite [INFO] tweaked toml for git repo https://github.com/tchandrakar/nakama-cli-suite written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/tchandrakar/nakama-cli-suite on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/tchandrakar/nakama-cli-suite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded comfy-table v7.2.2 [INFO] [stderr] Downloaded keyring v3.6.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a1fc11139a38238f0adc8f2a2f1a565d48623547c10b42f9ec6d4a965f710b04 [INFO] running `Command { std: "docker" "start" "-a" "a1fc11139a38238f0adc8f2a2f1a565d48623547c10b42f9ec6d4a965f710b04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a1fc11139a38238f0adc8f2a2f1a565d48623547c10b42f9ec6d4a965f710b04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1fc11139a38238f0adc8f2a2f1a565d48623547c10b42f9ec6d4a965f710b04", kill_on_drop: false }` [INFO] [stdout] a1fc11139a38238f0adc8f2a2f1a565d48623547c10b42f9ec6d4a965f710b04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b22342a09e92f29ed2efb82bbba047271d6c4bff1e819d97c9d128c66d03aad [INFO] running `Command { std: "docker" "start" "-a" "8b22342a09e92f29ed2efb82bbba047271d6c4bff1e819d97c9d128c66d03aad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling owo-colors v4.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking supports-color v3.0.2 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Checking num-conv v0.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking time-core v0.1.8 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking keyring v3.6.3 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking comfy-table v7.2.2 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling openssl-src v300.5.5+3.5.5 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling libz-sys v1.1.24 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking clap_complete v4.5.66 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking secrecy v0.10.3 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking nakama-core v0.2.0 (/opt/rustwide/workdir/shared/nakama-core) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Default for Config { [INFO] [stdout] 196 | | fn default() -> Self { [INFO] [stdout] 197 | | Self { [INFO] [stdout] 198 | | ai: AiConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 208 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:210:1 [INFO] [stdout] | [INFO] [stdout] 210 | / impl Default for PlatformsConfig { [INFO] [stdout] 211 | | fn default() -> Self { [INFO] [stdout] 212 | | Self { [INFO] [stdout] 213 | | github: GitHubPlatformConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 218 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct PlatformsConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:268:1 [INFO] [stdout] | [INFO] [stdout] 268 | / impl Default for ByakuganPromptsConfig { [INFO] [stdout] 269 | | fn default() -> Self { [INFO] [stdout] 270 | | Self { [INFO] [stdout] 271 | | preamble: None, [INFO] [stdout] ... | [INFO] [stdout] 279 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 72 + #[derive(Default)] [INFO] [stdout] 73 | pub struct ByakuganPromptsConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:321:1 [INFO] [stdout] | [INFO] [stdout] 321 | / impl Default for ProviderModels { [INFO] [stdout] 322 | | fn default() -> Self { [INFO] [stdout] 323 | | Self { [INFO] [stdout] 324 | | model_fast: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 330 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Default)] [INFO] [stdout] 121 | pub struct ProviderModels { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> shared/nakama-core/src/diff.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | let suffix = &pattern[1..]; // e.g. ".lock", ".min.js" [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> shared/nakama-core/src/diff.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | if pattern.starts_with('*') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 167 ~ if let Some(suffix) = pattern.strip_prefix('*') { [INFO] [stdout] 168 | // *.ext or *.foo.* patterns [INFO] [stdout] 169 ~ // e.g. ".lock", ".min.js" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `keep` [INFO] [stdout] --> shared/nakama-core/src/diff.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | for i in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 225 - for i in start..end { [INFO] [stdout] 225 + for in keep.iter_mut().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:195:1 [INFO] [stdout] | [INFO] [stdout] 195 | / impl Default for Config { [INFO] [stdout] 196 | | fn default() -> Self { [INFO] [stdout] 197 | | Self { [INFO] [stdout] 198 | | ai: AiConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 208 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:210:1 [INFO] [stdout] | [INFO] [stdout] 210 | / impl Default for PlatformsConfig { [INFO] [stdout] 211 | | fn default() -> Self { [INFO] [stdout] 212 | | Self { [INFO] [stdout] 213 | | github: GitHubPlatformConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 218 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 26 + #[derive(Default)] [INFO] [stdout] 27 | pub struct PlatformsConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:268:1 [INFO] [stdout] | [INFO] [stdout] 268 | / impl Default for ByakuganPromptsConfig { [INFO] [stdout] 269 | | fn default() -> Self { [INFO] [stdout] 270 | | Self { [INFO] [stdout] 271 | | preamble: None, [INFO] [stdout] ... | [INFO] [stdout] 279 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 72 + #[derive(Default)] [INFO] [stdout] 73 | pub struct ByakuganPromptsConfig { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> shared/nakama-core/src/config.rs:321:1 [INFO] [stdout] | [INFO] [stdout] 321 | / impl Default for ProviderModels { [INFO] [stdout] 322 | | fn default() -> Self { [INFO] [stdout] 323 | | Self { [INFO] [stdout] 324 | | model_fast: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 330 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Default)] [INFO] [stdout] 121 | pub struct ProviderModels { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> shared/nakama-core/src/diff.rs:169:22 [INFO] [stdout] | [INFO] [stdout] 169 | let suffix = &pattern[1..]; // e.g. ".lock", ".min.js" [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> shared/nakama-core/src/diff.rs:167:5 [INFO] [stdout] | [INFO] [stdout] 167 | if pattern.starts_with('*') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 167 ~ if let Some(suffix) = pattern.strip_prefix('*') { [INFO] [stdout] 168 | // *.ext or *.foo.* patterns [INFO] [stdout] 169 ~ // e.g. ".lock", ".min.js" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `keep` [INFO] [stdout] --> shared/nakama-core/src/diff.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | for i in start..end { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 225 - for i in start..end { [INFO] [stdout] 225 + for in keep.iter_mut().take(end).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nakama-ui v0.2.0 (/opt/rustwide/workdir/shared/nakama-ui) [INFO] [stderr] Checking nakama-ai v0.2.0 (/opt/rustwide/workdir/shared/nakama-ai) [INFO] [stderr] Checking nakama-log v0.2.0 (/opt/rustwide/workdir/shared/nakama-log) [INFO] [stderr] Checking nakama-vault v0.2.0 (/opt/rustwide/workdir/shared/nakama-vault) [INFO] [stderr] Checking nakama-ipc v0.2.0 (/opt/rustwide/workdir/shared/nakama-ipc) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> shared/nakama-ui/src/theme.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// can be applied to any displayable value via the `.style()` method. [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | /// Primary color (purple/magenta) for headers, emphasis, and branding. [INFO] [stdout] 10 | pub fn primary() -> Style { [INFO] [stdout] | -------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 8 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> shared/nakama-ipc/src/pipe.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> shared/nakama-ui/src/theme.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// can be applied to any displayable value via the `.style()` method. [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | /// Primary color (purple/magenta) for headers, emphasis, and branding. [INFO] [stdout] 10 | pub fn primary() -> Style { [INFO] [stdout] | -------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 8 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> shared/nakama-ui/src/table.rs:58:51 [INFO] [stdout] | [INFO] [stdout] 58 | let cells: Vec = row.iter().map(|c| Cell::new(c)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Cell::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> shared/nakama-ui/src/panel.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new(title: &str, content: &str) -> String { [INFO] [stdout] 28 | | let content_lines: Vec<&str> = content.lines().collect(); [INFO] [stdout] ... | [INFO] [stdout] 101 | | lines.join("\n") [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking nakama-update v0.2.0 (/opt/rustwide/workdir/shared/nakama-update) [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> shared/nakama-ui/src/table.rs:58:51 [INFO] [stdout] | [INFO] [stdout] 58 | let cells: Vec = row.iter().map(|c| Cell::new(c)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Cell::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> shared/nakama-ui/src/panel.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new(title: &str, content: &str) -> String { [INFO] [stdout] 28 | | let content_lines: Vec<&str> = content.lines().collect(); [INFO] [stdout] ... | [INFO] [stdout] 101 | | lines.join("\n") [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/nakama-vault/src/encrypted_file.rs:250:8 [INFO] [stdout] | [INFO] [stdout] 250 | if hex.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!hex.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EnvBackend` [INFO] [stdout] --> shared/nakama-vault/src/env_fallback.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { _private: () } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for EnvBackend { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/nakama-vault/src/encrypted_file.rs:250:8 [INFO] [stdout] | [INFO] [stdout] 250 | if hex.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!hex.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EnvBackend` [INFO] [stdout] --> shared/nakama-vault/src/env_fallback.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new() -> Self { [INFO] [stdout] 20 | | Self { _private: () } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 17 + impl Default for EnvBackend { [INFO] [stdout] 18 + fn default() -> Self { [INFO] [stdout] 19 + Self::new() [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking nakama-audit v0.2.0 (/opt/rustwide/workdir/shared/nakama-audit) [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> shared/nakama-audit/src/entry.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | / pub fn new( [INFO] [stdout] 45 | | trace_id: &str, [INFO] [stdout] 46 | | tool: &str, [INFO] [stdout] 47 | | command: &str, [INFO] [stdout] ... | [INFO] [stdout] 52 | | duration_ms: u64, [INFO] [stdout] 53 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking senku v0.2.0 (/opt/rustwide/workdir/senku) [INFO] [stderr] Checking sharingan v0.2.0 (/opt/rustwide/workdir/sharingan) [INFO] [stderr] Checking mugen v0.2.0 (/opt/rustwide/workdir/mugen) [INFO] [stderr] Checking zangetsu v0.2.0 (/opt/rustwide/workdir/zangetsu) [INFO] [stderr] Checking itachi v0.2.0 (/opt/rustwide/workdir/itachi) [INFO] [stderr] Checking kami v0.2.0 (/opt/rustwide/workdir/kami) [INFO] [stderr] Checking gate v0.2.0 (/opt/rustwide/workdir/gate) [INFO] [stderr] Checking jogan v0.2.0 (/opt/rustwide/workdir/jogan) [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> shared/nakama-audit/src/entry.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | / pub fn new( [INFO] [stdout] 45 | | trace_id: &str, [INFO] [stdout] 46 | | tool: &str, [INFO] [stdout] 47 | | command: &str, [INFO] [stdout] ... | [INFO] [stdout] 52 | | duration_ms: u64, [INFO] [stdout] 53 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> gate/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> gate/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> mugen/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> mugen/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> mugen/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> mugen/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> senku/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> senku/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> jogan/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> jogan/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> senku/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> senku/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> jogan/src/health.rs:129:46 [INFO] [stdout] | [INFO] [stdout] 129 | if has_net_errors || mem_warning { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 130 | | Outcome::Success [INFO] [stdout] 131 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> jogan/src/health.rs:131:20 [INFO] [stdout] | [INFO] [stdout] 131 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 132 | | Outcome::Success [INFO] [stdout] 133 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> jogan/src/network.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / let mut checks = Vec::new(); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | // 1. Internet connectivity (ping) [INFO] [stdout] 55 | | checks.push(check_ping("8.8.8.8", "Internet (Google DNS)")); [INFO] [stdout] ... | [INFO] [stdout] 69 | | checks.push(check_dns_config()); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let checks = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> senku/src/deps.rs:144:36 [INFO] [stdout] | [INFO] [stdout] 144 | if let Some(end) = after_eq[1..].find('"') { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> senku/src/deps.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | if after_eq.starts_with('"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some() = after_eq.strip_prefix('"') { [INFO] [stdout] 144 ~ if let Some(end) = .find('"') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> senku/src/deps.rs:162:36 [INFO] [stdout] | [INFO] [stdout] 162 | if let Some(end) = after_eq[1..].find('"') { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> senku/src/deps.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | if after_eq.starts_with('"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 161 ~ if let Some() = after_eq.strip_prefix('"') { [INFO] [stdout] 162 ~ if let Some(end) = .find('"') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> senku/src/index_cmd.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | ext_stats.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 - ext_stats.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 41 + ext_stats.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> kami/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> kami/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> senku/src/deps.rs:144:36 [INFO] [stdout] | [INFO] [stdout] 144 | if let Some(end) = after_eq[1..].find('"') { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> senku/src/deps.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | if after_eq.starts_with('"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some() = after_eq.strip_prefix('"') { [INFO] [stdout] 144 ~ if let Some(end) = .find('"') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> senku/src/deps.rs:162:36 [INFO] [stdout] | [INFO] [stdout] 162 | if let Some(end) = after_eq[1..].find('"') { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> senku/src/deps.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | if after_eq.starts_with('"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 161 ~ if let Some() = after_eq.strip_prefix('"') { [INFO] [stdout] 162 ~ if let Some(end) = .find('"') { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> senku/src/index_cmd.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | ext_stats.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 - ext_stats.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 41 + ext_stats.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> sharingan/src/parser.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct LogLine { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | pub raw: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LogLine` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> kami/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> kami/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> sharingan/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> sharingan/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `color_label` is never used [INFO] [stdout] --> zangetsu/src/risk.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | impl RiskLevel { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 33 | /// Return a color hint for UI rendering. [INFO] [stdout] 34 | pub fn color_label(&self) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> zangetsu/src/risk.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct RiskAssessment { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 57 | /// The command that was assessed. [INFO] [stdout] 58 | pub command: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RiskAssessment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `color_label` is never used [INFO] [stdout] --> zangetsu/src/risk.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 32 | impl RiskLevel { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 33 | /// Return a color hint for UI rendering. [INFO] [stdout] 34 | pub fn color_label(&self) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `command` is never read [INFO] [stdout] --> zangetsu/src/risk.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 56 | pub struct RiskAssessment { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 57 | /// The command that was assessed. [INFO] [stdout] 58 | pub command: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RiskAssessment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> itachi/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> itachi/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> itachi/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> itachi/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> zangetsu/src/risk.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 240 | if !assessment.reasons.is_empty() [INFO] [stdout] | ________^ [INFO] [stdout] 241 | | && !(assessment.reasons.len() == 1 [INFO] [stdout] 242 | | && assessment.reasons[0] == "No dangerous patterns detected.") [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!(assessment.reasons.is_empty() || assessment.reasons.len() == 1 && assessment.reasons[0] == "No dangerous patterns detected.")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> jogan/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> jogan/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> gate/src/ai_helper.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> gate/src/ai_helper.rs:20:38 [INFO] [stdout] | [INFO] [stdout] 20 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> jogan/src/health.rs:129:46 [INFO] [stdout] | [INFO] [stdout] 129 | if has_net_errors || mem_warning { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 130 | | Outcome::Success [INFO] [stdout] 131 | | } else { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> jogan/src/health.rs:131:20 [INFO] [stdout] | [INFO] [stdout] 131 | } else { [INFO] [stdout] | ____________________^ [INFO] [stdout] 132 | | Outcome::Success [INFO] [stdout] 133 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> jogan/src/network.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / let mut checks = Vec::new(); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | // 1. Internet connectivity (ping) [INFO] [stdout] 55 | | checks.push(check_ping("8.8.8.8", "Internet (Google DNS)")); [INFO] [stdout] ... | [INFO] [stdout] 69 | | checks.push(check_dns_config()); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let checks = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> zangetsu/src/risk.rs:240:8 [INFO] [stdout] | [INFO] [stdout] 240 | if !assessment.reasons.is_empty() [INFO] [stdout] | ________^ [INFO] [stdout] 241 | | && !(assessment.reasons.len() == 1 [INFO] [stdout] 242 | | && assessment.reasons[0] == "No dangerous patterns detected.") [INFO] [stdout] | |__________________________________________________________________________^ help: try: `!(assessment.reasons.is_empty() || assessment.reasons.len() == 1 && assessment.reasons[0] == "No dangerous patterns detected.")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> sharingan/src/parser.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub struct LogLine { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | pub raw: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LogLine` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> sharingan/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> sharingan/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking tensai v0.2.0 (/opt/rustwide/workdir/tensai) [INFO] [stderr] Checking byakugan v0.2.0 (/opt/rustwide/workdir/byakugan) [INFO] [stderr] Checking shinigami v0.2.0 (/opt/rustwide/workdir/shinigami) [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> tensai/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> tensai/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tensai/src/git_info.rs:63:15 [INFO] [stdout] | [INFO] [stdout] 63 | .args(&["-rn", "--include=*.rs", "--include=*.py", "--include=*.js", [INFO] [stdout] | _______________^ [INFO] [stdout] 64 | | "--include=*.ts", "--include=*.go", "--include=*.java", [INFO] [stdout] 65 | | "-E", "TODO|FIXME|HACK|XXX", "."]) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 ~ .args(["-rn", "--include=*.rs", "--include=*.py", "--include=*.js", [INFO] [stdout] 64 + "--include=*.ts", "--include=*.go", "--include=*.java", [INFO] [stdout] 65 ~ "-E", "TODO|FIXME|HACK|XXX", "."]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> tensai/src/ai_helper.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let provider = config.ai.default_provider.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.ai.default_provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Provider` which implements the `Copy` trait [INFO] [stdout] --> tensai/src/ai_helper.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | let model = config.resolve_model(provider.clone(), tier); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `provider` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tensai/src/git_info.rs:63:15 [INFO] [stdout] | [INFO] [stdout] 63 | .args(&["-rn", "--include=*.rs", "--include=*.py", "--include=*.js", [INFO] [stdout] | _______________^ [INFO] [stdout] 64 | | "--include=*.ts", "--include=*.go", "--include=*.java", [INFO] [stdout] 65 | | "-E", "TODO|FIXME|HACK|XXX", "."]) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 ~ .args(["-rn", "--include=*.rs", "--include=*.py", "--include=*.js", [INFO] [stdout] 64 + "--include=*.ts", "--include=*.go", "--include=*.java", [INFO] [stdout] 65 ~ "-E", "TODO|FIXME|HACK|XXX", "."]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | log_audit(&config, &trace, "commit", &commit_msg, Outcome::Success, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | log_audit(&config, &trace, "commit", "aborted (empty edit)", Outcome::Skipped, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 116 | log_audit(&config, &trace, "commit", &edited, Outcome::Success, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 120 | log_audit(&config, &trace, "commit", "rejected by user", Outcome::Skipped, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> shinigami/src/git.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 255 | if best.as_ref().map_or(true, |(t, _)| time > *t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 255 - if best.as_ref().map_or(true, |(t, _)| time > *t) { [INFO] [stdout] 255 + if best.as_ref().is_none_or(|(t, _)| time > *t) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:59:44 [INFO] [stdout] | [INFO] [stdout] 59 | fn install_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn install_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 59 + fn install_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:85:43 [INFO] [stdout] | [INFO] [stdout] 85 | fn remove_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn remove_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 85 + fn remove_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:104:41 [INFO] [stdout] | [INFO] [stdout] 104 | fn list_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn list_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 104 + fn list_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | log_audit(&config, &trace, "commit", &commit_msg, Outcome::Success, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:111:27 [INFO] [stdout] | [INFO] [stdout] 111 | log_audit(&config, &trace, "commit", "aborted (empty edit)", Outcome::Skipped, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:116:23 [INFO] [stdout] | [INFO] [stdout] 116 | log_audit(&config, &trace, "commit", &edited, Outcome::Success, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> shinigami/src/commit.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 120 | log_audit(&config, &trace, "commit", "rejected by user", Outcome::Skipped, start.elapsed().as_millis() as u64); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> shinigami/src/git.rs:255:20 [INFO] [stdout] | [INFO] [stdout] 255 | if best.as_ref().map_or(true, |(t, _)| time > *t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 255 - if best.as_ref().map_or(true, |(t, _)| time > *t) { [INFO] [stdout] 255 + if best.as_ref().is_none_or(|(t, _)| time > *t) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:59:44 [INFO] [stdout] | [INFO] [stdout] 59 | fn install_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 59 - fn install_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 59 + fn install_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:85:43 [INFO] [stdout] | [INFO] [stdout] 85 | fn remove_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn remove_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 85 + fn remove_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> shinigami/src/hook.rs:104:41 [INFO] [stdout] | [INFO] [stdout] 104 | fn list_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 - fn list_hooks(ui: &NakamaUI, hooks_dir: &PathBuf) -> Result<()> { [INFO] [stdout] 104 + fn list_hooks(ui: &NakamaUI, hooks_dir: &Path) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `group_files_by_directory` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:238:8 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn group_files_by_directory(diff: &UnifiedDiff) -> Vec<(String, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `diff_stats` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn diff_stats(diff: &UnifiedDiff) -> (usize, usize, usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_context_lines` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn read_context_lines(file_path: &str, line: u32, context: u32) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `store_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn store_token(platform: &str, token: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `retrieve_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn retrieve_token(platform: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `has_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn has_token(platform: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `verify_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn verify_token(platform: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `auth_status` is never used [INFO] [stdout] --> byakugan/src/auth.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn auth_status() -> Vec<(String, bool)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_threshold` is never used [INFO] [stdout] --> byakugan/src/dedup.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn filter_by_threshold(findings: &[DedupFinding], threshold: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `emit_scan_message` is never used [INFO] [stdout] --> byakugan/src/ipc.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn emit_scan_message(findings: &[RuleFinding]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_enrichment_context` is never used [INFO] [stdout] --> byakugan/src/ipc.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn read_enrichment_context() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `format_dedup_summary` is never used [INFO] [stdout] --> byakugan/src/output.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn format_dedup_summary(findings: &[DedupFinding]) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `platform` is never used [INFO] [stdout] --> byakugan/src/platform/mod.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 159 | pub trait PlatformAdapter: Send + Sync { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 160 | /// Which platform this adapter targets. [INFO] [stdout] 161 | fn platform(&self) -> Platform; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_review_body` is never used [INFO] [stdout] --> byakugan/src/review.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn build_review_body(results: &[PassResult], model: &str, context_label: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> byakugan/src/analysis.rs:324:17 [INFO] [stdout] | [INFO] [stdout] 324 | assert!(chunks.len() >= 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!chunks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> byakugan/src/output.rs:141:18 [INFO] [stdout] | [INFO] [stdout] 141 | md.push_str(&format!("# Byakugan Review Report\n\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"# Byakugan Review Report\n\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `split_diff_by_files` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:196:8 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn split_diff_by_files(raw: &str, max_chars: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `group_files_by_directory` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:238:8 [INFO] [stdout] | [INFO] [stdout] 238 | pub fn group_files_by_directory(diff: &UnifiedDiff) -> Vec<(String, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `diff_stats` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn diff_stats(diff: &UnifiedDiff) -> (usize, usize, usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_context_lines` is never used [INFO] [stdout] --> byakugan/src/analysis.rs:263:8 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn read_context_lines(file_path: &str, line: u32, context: u32) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `store_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn store_token(platform: &str, token: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `retrieve_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn retrieve_token(platform: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `has_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn has_token(platform: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `verify_token` is never used [INFO] [stdout] --> byakugan/src/auth.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn verify_token(platform: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `auth_status` is never used [INFO] [stdout] --> byakugan/src/auth.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn auth_status() -> Vec<(String, bool)> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_by_threshold` is never used [INFO] [stdout] --> byakugan/src/dedup.rs:330:8 [INFO] [stdout] | [INFO] [stdout] 330 | pub fn filter_by_threshold(findings: &[DedupFinding], threshold: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `emit_scan_message` is never used [INFO] [stdout] --> byakugan/src/ipc.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn emit_scan_message(findings: &[RuleFinding]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_enrichment_context` is never used [INFO] [stdout] --> byakugan/src/ipc.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn read_enrichment_context() -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `format_dedup_summary` is never used [INFO] [stdout] --> byakugan/src/output.rs:197:8 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn format_dedup_summary(findings: &[DedupFinding]) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `platform` is never used [INFO] [stdout] --> byakugan/src/platform/mod.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 159 | pub trait PlatformAdapter: Send + Sync { [INFO] [stdout] | --------------- method in this trait [INFO] [stdout] 160 | /// Which platform this adapter targets. [INFO] [stdout] 161 | fn platform(&self) -> Platform; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_review_body` is never used [INFO] [stdout] --> byakugan/src/review.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn build_review_body(results: &[PassResult], model: &str, context_label: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip_while(

).next()` on an `Iterator` [INFO] [stdout] --> byakugan/src/passes.rs:307:20 [INFO] [stdout] | [INFO] [stdout] 307 | if stripped.chars().skip_while(|c| c.is_ascii_digit()).next() == Some('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: this is more succinctly expressed by calling `.find(!

)` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next [INFO] [stdout] = note: `#[warn(clippy::skip_while_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> byakugan/src/passes.rs:332:37 [INFO] [stdout] | [INFO] [stdout] 332 | } else if lower.contains("low") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 333 | | Severity::Low [INFO] [stdout] 334 | | } else if count > 0 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> byakugan/src/passes.rs:334:25 [INFO] [stdout] | [INFO] [stdout] 334 | } else if count > 0 { [INFO] [stdout] | _________________________^ [INFO] [stdout] 335 | | Severity::Low [INFO] [stdout] 336 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> byakugan/src/output.rs:141:18 [INFO] [stdout] | [INFO] [stdout] 141 | md.push_str(&format!("# Byakugan Review Report\n\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"# Byakugan Review Report\n\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip_while(

).next()` on an `Iterator` [INFO] [stdout] --> byakugan/src/passes.rs:307:20 [INFO] [stdout] | [INFO] [stdout] 307 | if stripped.chars().skip_while(|c| c.is_ascii_digit()).next() == Some('.') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: this is more succinctly expressed by calling `.find(!

)` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#skip_while_next [INFO] [stdout] = note: `#[warn(clippy::skip_while_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> byakugan/src/passes.rs:332:37 [INFO] [stdout] | [INFO] [stdout] 332 | } else if lower.contains("low") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 333 | | Severity::Low [INFO] [stdout] 334 | | } else if count > 0 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> byakugan/src/passes.rs:334:25 [INFO] [stdout] | [INFO] [stdout] 334 | } else if count > 0 { [INFO] [stdout] | _________________________^ [INFO] [stdout] 335 | | Severity::Low [INFO] [stdout] 336 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> byakugan/src/platform/mod.rs:430:52 [INFO] [stdout] | [INFO] [stdout] 430 | let skip = if parts[0].starts_with("www.") { 1 } else { 1 }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> byakugan/src/platform/mod.rs:430:63 [INFO] [stdout] | [INFO] [stdout] 430 | let skip = if parts[0].starts_with("www.") { 1 } else { 1 }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> byakugan/src/platform/mod.rs:445:5 [INFO] [stdout] | [INFO] [stdout] 445 | / if without_scheme.starts_with("github.com") { [INFO] [stdout] 446 | | if parts.len() >= 5 && parts[3] == "pull" { [INFO] [stdout] 447 | | let number = parts[4] [INFO] [stdout] 448 | | .parse::() [INFO] [stdout] ... | [INFO] [stdout] 457 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 445 ~ if without_scheme.starts_with("github.com") [INFO] [stdout] 446 ~ && parts.len() >= 5 && parts[3] == "pull" { [INFO] [stdout] 447 | let number = parts[4] [INFO] [stdout] ... [INFO] [stdout] 455 | }); [INFO] [stdout] 456 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> byakugan/src/platform/mod.rs:430:52 [INFO] [stdout] | [INFO] [stdout] 430 | let skip = if parts[0].starts_with("www.") { 1 } else { 1 }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> byakugan/src/platform/mod.rs:430:63 [INFO] [stdout] | [INFO] [stdout] 430 | let skip = if parts[0].starts_with("www.") { 1 } else { 1 }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> byakugan/src/platform/mod.rs:445:5 [INFO] [stdout] | [INFO] [stdout] 445 | / if without_scheme.starts_with("github.com") { [INFO] [stdout] 446 | | if parts.len() >= 5 && parts[3] == "pull" { [INFO] [stdout] 447 | | let number = parts[4] [INFO] [stdout] 448 | | .parse::() [INFO] [stdout] ... | [INFO] [stdout] 457 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 445 ~ if without_scheme.starts_with("github.com") [INFO] [stdout] 446 ~ && parts.len() >= 5 && parts[3] == "pull" { [INFO] [stdout] 447 | let number = parts[4] [INFO] [stdout] ... [INFO] [stdout] 455 | }); [INFO] [stdout] 456 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 34s [INFO] running `Command { std: "docker" "inspect" "8b22342a09e92f29ed2efb82bbba047271d6c4bff1e819d97c9d128c66d03aad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b22342a09e92f29ed2efb82bbba047271d6c4bff1e819d97c9d128c66d03aad", kill_on_drop: false }` [INFO] [stdout] 8b22342a09e92f29ed2efb82bbba047271d6c4bff1e819d97c9d128c66d03aad