[INFO] cloning repository https://github.com/taoli-ax/rust-demo-study [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/taoli-ax/rust-demo-study" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaoli-ax%2Frust-demo-study", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaoli-ax%2Frust-demo-study'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a97252d4f3ce2c429448f9c5356a8f75af3e8130 [INFO] linting taoli-ax/rust-demo-study against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftaoli-ax%2Frust-demo-study" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/taoli-ax/rust-demo-study [INFO] finished tweaking git repo https://github.com/taoli-ax/rust-demo-study [INFO] tweaked toml for git repo https://github.com/taoli-ax/rust-demo-study written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/taoli-ax/rust-demo-study on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/taoli-ax/rust-demo-study already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c25352bc812bcbceb845f1aaa5a9c5405d065fee4ac4dba6aa7c373fcd7e7c6 [INFO] running `Command { std: "docker" "start" "-a" "8c25352bc812bcbceb845f1aaa5a9c5405d065fee4ac4dba6aa7c373fcd7e7c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c25352bc812bcbceb845f1aaa5a9c5405d065fee4ac4dba6aa7c373fcd7e7c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c25352bc812bcbceb845f1aaa5a9c5405d065fee4ac4dba6aa7c373fcd7e7c6", kill_on_drop: false }` [INFO] [stdout] 8c25352bc812bcbceb845f1aaa5a9c5405d065fee4ac4dba6aa7c373fcd7e7c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a0976ea96201f5a4e998e2003074457513ee40c7c76d39fa073172f7538577ff [INFO] running `Command { std: "docker" "start" "-a" "a0976ea96201f5a4e998e2003074457513ee40c7c76d39fa073172f7538577ff", kill_on_drop: false }` [INFO] [stderr] Checking hello-world v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `primitives::tuple_2_2::Matrix` is more private than the item `primitives::tuple_2_2::transpose` [INFO] [stdout] --> src/primitives/tuple_2_2.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn transpose(matrix:Matrix) -> Matrix{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `primitives::tuple_2_2::transpose` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `primitives::tuple_2_2::Matrix` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/primitives/tuple_2_2.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | struct Matrix(f32, f32, f32, f32); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | print!("the reversed pair is {:?}\n", reverse(pair)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 41 - print!("the reversed pair is {:?}\n", reverse(pair)); [INFO] [stdout] 41 + println!("the reversed pair is {:?}", reverse(pair)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | print!("on element tuple:{:?}\n", (5u32,)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 43 - print!("on element tuple:{:?}\n", (5u32,)); [INFO] [stdout] 43 + println!("on element tuple:{:?}", (5u32,)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | print!("just an integer: {:?}\n",(5u32)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 44 - print!("just an integer: {:?}\n",(5u32)); [INFO] [stdout] 44 + println!("just an integer: {:?}",(5u32)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/slice_2_3.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | print!("array occupies {} bytes\n", mem::size_of_val(&xs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 14 - print!("array occupies {} bytes\n", mem::size_of_val(&xs)); [INFO] [stdout] 14 + println!("array occupies {} bytes", mem::size_of_val(&xs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:57:48 [INFO] [stdout] | [INFO] [stdout] 57 | println!("My name is {0}, {1} {0}","James","Bond"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - println!("My name is {0}, {1} {0}","James","Bond"); [INFO] [stdout] 57 + println!("My name is {0}, Bond {0}","James"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `primitives::tuple_2_2::Matrix` is more private than the item `primitives::tuple_2_2::transpose` [INFO] [stdout] --> src/primitives/tuple_2_2.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn transpose(matrix:Matrix) -> Matrix{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function `primitives::tuple_2_2::transpose` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `primitives::tuple_2_2::Matrix` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/primitives/tuple_2_2.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | struct Matrix(f32, f32, f32, f32); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | print!("the reversed pair is {:?}\n", reverse(pair)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 41 - print!("the reversed pair is {:?}\n", reverse(pair)); [INFO] [stdout] 41 + println!("the reversed pair is {:?}", reverse(pair)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | print!("on element tuple:{:?}\n", (5u32,)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 43 - print!("on element tuple:{:?}\n", (5u32,)); [INFO] [stdout] 43 + println!("on element tuple:{:?}", (5u32,)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/tuple_2_2.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | print!("just an integer: {:?}\n",(5u32)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 44 - print!("just an integer: {:?}\n",(5u32)); [INFO] [stdout] 44 + println!("just an integer: {:?}",(5u32)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/primitives/slice_2_3.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | print!("array occupies {} bytes\n", mem::size_of_val(&xs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 14 - print!("array occupies {} bytes\n", mem::size_of_val(&xs)); [INFO] [stdout] 14 + println!("array occupies {} bytes", mem::size_of_val(&xs)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives_2_0.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:57:48 [INFO] [stdout] | [INFO] [stdout] 57 | println!("My name is {0}, {1} {0}","James","Bond"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - println!("My name is {0}, {1} {0}","James","Bond"); [INFO] [stdout] 57 + println!("My name is {0}, Bond {0}","James"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "a0976ea96201f5a4e998e2003074457513ee40c7c76d39fa073172f7538577ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0976ea96201f5a4e998e2003074457513ee40c7c76d39fa073172f7538577ff", kill_on_drop: false }` [INFO] [stdout] a0976ea96201f5a4e998e2003074457513ee40c7c76d39fa073172f7538577ff