[INFO] cloning repository https://github.com/talwat/oh-my-crab [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/talwat/oh-my-crab" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Foh-my-crab", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Foh-my-crab'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dcab24f2e4202e92af04d22824199c85c89e89df [INFO] linting talwat/oh-my-crab/dcab24f2e4202e92af04d22824199c85c89e89df against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Foh-my-crab" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/talwat/oh-my-crab [INFO] finished tweaking git repo https://github.com/talwat/oh-my-crab [INFO] tweaked toml for git repo https://github.com/talwat/oh-my-crab written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/talwat/oh-my-crab on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/talwat/oh-my-crab already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07b8de0da27eb47ab58dc5c2929cb0593f467c3953a8ed8d97f11550babc9b66 [INFO] running `Command { std: "docker" "start" "-a" "07b8de0da27eb47ab58dc5c2929cb0593f467c3953a8ed8d97f11550babc9b66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07b8de0da27eb47ab58dc5c2929cb0593f467c3953a8ed8d97f11550babc9b66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07b8de0da27eb47ab58dc5c2929cb0593f467c3953a8ed8d97f11550babc9b66", kill_on_drop: false }` [INFO] [stdout] 07b8de0da27eb47ab58dc5c2929cb0593f467c3953a8ed8d97f11550babc9b66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eba51a32578ce058bdb6c90a074c6d6bfe9dca80cfefd18b6c660a52e95f2c46 [INFO] running `Command { std: "docker" "start" "-a" "eba51a32578ce058bdb6c90a074c6d6bfe9dca80cfefd18b6c660a52e95f2c46", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.23 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking clap v4.5.23 [INFO] [stderr] Checking oh-my-crab v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> src/main.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{arg, Parser, Subcommand}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arg` [INFO] [stdout] --> src/main.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{arg, Parser, Subcommand}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `URL` contains a capitalized acronym [INFO] [stdout] --> src/color.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | URL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/plugins.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return Some(Output { [INFO] [stdout] 44 | | value: (value.0(output)?, value.1), [INFO] [stdout] 45 | | label, [INFO] [stdout] 46 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ Some(Output { [INFO] [stdout] 44 + value: (value.0(output)?, value.1), [INFO] [stdout] 45 + label, [INFO] [stdout] 46 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `URL` contains a capitalized acronym [INFO] [stdout] --> src/color.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | URL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/plugins.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return Some(Output { [INFO] [stdout] 44 | | value: (value.0(output)?, value.1), [INFO] [stdout] 45 | | label, [INFO] [stdout] 46 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ Some(Output { [INFO] [stdout] 44 + value: (value.0(output)?, value.1), [INFO] [stdout] 45 + label, [INFO] [stdout] 46 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return Some(if pwd != home { [INFO] [stdout] 44 | | let path = Path::new(&pwd); [INFO] [stdout] 45 | | let name = path [INFO] [stdout] 46 | | .file_name() [INFO] [stdout] ... | [INFO] [stdout] 50 | | "~".to_string() [INFO] [stdout] 51 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ Some(if pwd != home { [INFO] [stdout] 44 + let path = Path::new(&pwd); [INFO] [stdout] 45 + let name = path [INFO] [stdout] 46 + .file_name() [INFO] [stdout] 47 + .unwrap_or_else(|| std::ffi::OsStr::new("/")); [INFO] [stdout] 48 + name.to_str()?.to_string() [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + "~".to_string() [INFO] [stdout] 51 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return output.status.success() && !output.stdout.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return output.status.success() && !output.stdout.is_empty(); [INFO] [stdout] 63 + output.status.success() && !output.stdout.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | / return Some(if pwd != home { [INFO] [stdout] 44 | | let path = Path::new(&pwd); [INFO] [stdout] 45 | | let name = path [INFO] [stdout] 46 | | .file_name() [INFO] [stdout] ... | [INFO] [stdout] 50 | | "~".to_string() [INFO] [stdout] 51 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 ~ Some(if pwd != home { [INFO] [stdout] 44 + let path = Path::new(&pwd); [INFO] [stdout] 45 + let name = path [INFO] [stdout] 46 + .file_name() [INFO] [stdout] 47 + .unwrap_or_else(|| std::ffi::OsStr::new("/")); [INFO] [stdout] 48 + name.to_str()?.to_string() [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + "~".to_string() [INFO] [stdout] 51 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return output.status.success() && !output.stdout.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return output.status.success() && !output.stdout.is_empty(); [INFO] [stdout] 63 + output.status.success() && !output.stdout.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.00s [INFO] running `Command { std: "docker" "inspect" "eba51a32578ce058bdb6c90a074c6d6bfe9dca80cfefd18b6c660a52e95f2c46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eba51a32578ce058bdb6c90a074c6d6bfe9dca80cfefd18b6c660a52e95f2c46", kill_on_drop: false }` [INFO] [stdout] eba51a32578ce058bdb6c90a074c6d6bfe9dca80cfefd18b6c660a52e95f2c46