[INFO] cloning repository https://github.com/talwat/geoterm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/talwat/geoterm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Fgeoterm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Fgeoterm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 29fba91169c107fe7b465093e893aa2b1360f1f6 [INFO] linting talwat/geoterm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftalwat%2Fgeoterm" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/talwat/geoterm [INFO] finished tweaking git repo https://github.com/talwat/geoterm [INFO] tweaked toml for git repo https://github.com/talwat/geoterm written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/talwat/geoterm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/talwat/geoterm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ctrlc v3.5.0 [INFO] [stderr] Downloaded geoutils v0.5.1 [INFO] [stderr] Downloaded mio-serial v5.0.6 [INFO] [stderr] Downloaded tokio-serial v5.4.5 [INFO] [stderr] Downloaded serialport v4.7.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 163cd4cb35b83be3d7de3168a8ae275f7b3e9fbef3eaa902f73e1c3eef6feff2 [INFO] running `Command { std: "docker" "start" "-a" "163cd4cb35b83be3d7de3168a8ae275f7b3e9fbef3eaa902f73e1c3eef6feff2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "163cd4cb35b83be3d7de3168a8ae275f7b3e9fbef3eaa902f73e1c3eef6feff2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "163cd4cb35b83be3d7de3168a8ae275f7b3e9fbef3eaa902f73e1c3eef6feff2", kill_on_drop: false }` [INFO] [stdout] 163cd4cb35b83be3d7de3168a8ae275f7b3e9fbef3eaa902f73e1c3eef6feff2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d2314925286b912448e0327c7434ad09ce2fe7148d54137352a127b83acf4fb9 [INFO] running `Command { std: "docker" "start" "-a" "d2314925286b912448e0327c7434ad09ce2fe7148d54137352a127b83acf4fb9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Compiling cc v1.2.41 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking pxfm v0.1.25 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking indenter v0.3.4 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking eyre v0.6.12 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Compiling color-spantrace v0.3.0 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking geoutils v0.5.1 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Compiling openssl-sys v0.9.110 [INFO] [stderr] Checking tracing-error v0.2.1 [INFO] [stderr] Compiling openssl v0.10.74 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking ctrlc v3.5.0 [INFO] [stderr] Checking moxcms v0.7.7 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking color-eyre v0.6.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking unescaper v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking serialport v4.7.3 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking mio-serial v5.0.6 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking clap v4.5.50 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-serial v5.4.5 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking shared v0.1.0 (/opt/rustwide/workdir/shared) [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> shared/src/deserializers.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | action: unsafe { std::mem::transmute(reader.read_u8().await?) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/src/image.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | assert!(width % WIDTH == 0, "width is incorrect!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `width.is_multiple_of(WIDTH)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/src/image.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | assert!(height % HEIGHT == 0, "height is incorrect!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `height.is_multiple_of(HEIGHT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Clients` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> shared/src/lobby.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> shared/src/serializers.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | writer.write_u32(self.points as u32).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> shared/src/serializers.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | writer.write_u32(self.delta as u32).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.delta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> shared/src/deserializers.rs:110:44 [INFO] [stdout] | [INFO] [stdout] 110 | action: unsafe { std::mem::transmute(reader.read_u8().await?) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/src/image.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | assert!(width % WIDTH == 0, "width is incorrect!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `width.is_multiple_of(WIDTH)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> shared/src/image.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | assert!(height % HEIGHT == 0, "height is incorrect!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `height.is_multiple_of(HEIGHT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Clients` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> shared/src/lobby.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> shared/src/serializers.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 69 | writer.write_u32(self.points as u32).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> shared/src/serializers.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | writer.write_u32(self.delta as u32).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.delta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio-transponder v0.1.0 (/opt/rustwide/workdir/transponders/tokio) [INFO] [stderr] Checking tui v0.1.0 (/opt/rustwide/workdir/clients/tui) [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> transponders/tokio/src/serial.rs:48:40 [INFO] [stdout] | [INFO] [stdout] 48 | let Ok((reader, writer)) = tokio_serial::new(path, 9600 * 4) [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 49 | | .open_native_async() [INFO] [stdout] 50 | | .and_then(|x| Ok(tokio::io::split(x))) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ let Ok((reader, writer)) = tokio_serial::new(path, 9600 * 4) [INFO] [stdout] 49 + .open_native_async().map(|x| tokio::io::split(x)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddrV4` which implements the `Copy` trait [INFO] [stdout] --> transponders/tokio/src/main.rs:32:39 [INFO] [stdout] | [INFO] [stdout] 32 | let (tcp, writer) = TCP::init(rx, address.clone()).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> clients/tui/src/logic.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 72 | Message::Packet(packet) => match packet { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 73 | | Packet::Round { number, image } => { [INFO] [stdout] 74 | | Result::ChangeState(State::Round(round::Round { [INFO] [stdout] 75 | | image_len: image.len(), [INFO] [stdout] ... | [INFO] [stdout] 83 | | _ => Result::Unhandled, [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> clients/tui/src/logic.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | Message::Packet(packet) => match packet { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 73 | Packet::Round { number, image } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> clients/tui/src/logic.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 72 | Message::Packet(packet) => match packet { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 73 | | Packet::Round { number, image } => { [INFO] [stdout] 74 | | Result::ChangeState(State::Round(round::Round { [INFO] [stdout] 75 | | image_len: image.len(), [INFO] [stdout] ... | [INFO] [stdout] 83 | | _ => Result::Unhandled, [INFO] [stdout] 84 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> clients/tui/src/logic.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | Message::Packet(packet) => match packet { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 73 | Packet::Round { number, image } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> transponders/tokio/src/serial.rs:48:40 [INFO] [stdout] | [INFO] [stdout] 48 | let Ok((reader, writer)) = tokio_serial::new(path, 9600 * 4) [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 49 | | .open_native_async() [INFO] [stdout] 50 | | .and_then(|x| Ok(tokio::io::split(x))) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ let Ok((reader, writer)) = tokio_serial::new(path, 9600 * 4) [INFO] [stdout] 49 + .open_native_async().map(|x| tokio::io::split(x)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddrV4` which implements the `Copy` trait [INFO] [stdout] --> transponders/tokio/src/main.rs:32:39 [INFO] [stdout] | [INFO] [stdout] 32 | let (tcp, writer) = TCP::init(rx, address.clone()).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `address` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking server v0.1.0 (/opt/rustwide/workdir/server) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> server/src/images.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | let bytes = shared::image::encode(resized).unwrap(); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 30 | [INFO] [stdout] 31 | bytes [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 29 ~ [INFO] [stdout] 30 | [INFO] [stdout] 31 ~ shared::image::encode(resized).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> server/src/round.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | let number = old.and_then(|x| Some(x.number + 1)).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old.map(|x| x.number + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> server/src/images.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 29 | let bytes = shared::image::encode(resized).unwrap(); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 30 | [INFO] [stdout] 31 | bytes [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 29 ~ [INFO] [stdout] 30 | [INFO] [stdout] 31 ~ shared::image::encode(resized).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> server/src/server.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | .expect(&format!("couldn't find client {index}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("couldn't find client {index}"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> server/src/server.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 49 | .expect(&format!("couldn't find client {index}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("couldn't find client {index}"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> server/src/round.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | let number = old.and_then(|x| Some(x.number + 1)).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `old.map(|x| x.number + 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> server/src/server.rs:38:14 [INFO] [stdout] | [INFO] [stdout] 38 | .expect(&format!("couldn't find client {index}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("couldn't find client {index}"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> server/src/server.rs:132:54 [INFO] [stdout] | [INFO] [stdout] 132 | .filter(|client| client.initialized() && !exclude.is_some_and(|x| client.id == x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `exclude.is_none_or(|x| client.id != x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> server/src/server.rs:49:14 [INFO] [stdout] | [INFO] [stdout] 49 | .expect(&format!("couldn't find client {index}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("couldn't find client {index}"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> server/src/server.rs:132:54 [INFO] [stdout] | [INFO] [stdout] 132 | .filter(|client| client.initialized() && !exclude.is_some_and(|x| client.id == x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `exclude.is_none_or(|x| client.id != x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.20s [INFO] running `Command { std: "docker" "inspect" "d2314925286b912448e0327c7434ad09ce2fe7148d54137352a127b83acf4fb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2314925286b912448e0327c7434ad09ce2fe7148d54137352a127b83acf4fb9", kill_on_drop: false }` [INFO] [stdout] d2314925286b912448e0327c7434ad09ce2fe7148d54137352a127b83acf4fb9