[INFO] cloning repository https://github.com/takuho0115/node_expr_test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/takuho0115/node_expr_test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftakuho0115%2Fnode_expr_test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftakuho0115%2Fnode_expr_test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 562ad939ec57da95d7bd8685d4d4d77633aad9e8 [INFO] linting takuho0115/node_expr_test against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ftakuho0115%2Fnode_expr_test" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/takuho0115/node_expr_test [INFO] finished tweaking git repo https://github.com/takuho0115/node_expr_test [INFO] tweaked toml for git repo https://github.com/takuho0115/node_expr_test written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/takuho0115/node_expr_test on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/takuho0115/node_expr_test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 237a9e523aadcef3431110852552879053053b66a5056c02f06b4893b920ee9b [INFO] running `Command { std: "docker" "start" "-a" "237a9e523aadcef3431110852552879053053b66a5056c02f06b4893b920ee9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "237a9e523aadcef3431110852552879053053b66a5056c02f06b4893b920ee9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "237a9e523aadcef3431110852552879053053b66a5056c02f06b4893b920ee9b", kill_on_drop: false }` [INFO] [stdout] 237a9e523aadcef3431110852552879053053b66a5056c02f06b4893b920ee9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17b186b5e932c502ad14270c82a35e6eff802992c5c693f220d265b1a94989f6 [INFO] running `Command { std: "docker" "start" "-a" "17b186b5e932c502ad14270c82a35e6eff802992c5c693f220d265b1a94989f6", kill_on_drop: false }` [INFO] [stderr] Checking node_expr_test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/./token.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Token { kind: kind, val: None, str: Some(str.to_string()), pos:Some(*pos) } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/node.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | Self { kind: kind, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), val: None } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `swap` is never used [INFO] [stdout] --> src/node.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 30 | impl Node{ [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn swap(&self)->Self{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `list` is never read [INFO] [stdout] --> src/./tokenlist.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TokenList{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 9 | pub original: String, [INFO] [stdout] 10 | pub list: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenList` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pos` is never read [INFO] [stdout] --> src/./token.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Token{ [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub pos: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `at_eof` is never used [INFO] [stdout] --> src/./token.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 16 | impl Token{ [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn at_eof(&self)->bool{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Tk` [INFO] [stdout] --> src/./token.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / pub enum TokenKind { [INFO] [stdout] 3 | | TkReserved, [INFO] [stdout] 4 | | TkNum, [INFO] [stdout] 5 | | TkEof, [INFO] [stdout] 6 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./tokenlist.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | return Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())); [INFO] [stdout] 71 + Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./tokenlist.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | let is_digit = |c: &char| !c.to_digit(10).is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Nd` [INFO] [stdout] --> src/node.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / pub enum NodeKind { [INFO] [stdout] 7 | | NdAdd, // + [INFO] [stdout] 8 | | NdSub, // - [INFO] [stdout] 9 | | NdMul, // * [INFO] [stdout] ... | [INFO] [stdout] 18 | | NdBnk, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/node.rs:134:3 [INFO] [stdout] | [INFO] [stdout] 134 | return self.primary(tok); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return self.primary(tok); [INFO] [stdout] 134 + self.primary(tok) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/./token.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Token { kind: kind, val: None, str: Some(str.to_string()), pos:Some(*pos) } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/node.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | Self { kind: kind, lhs: Some(Box::new(lhs)), rhs: Some(Box::new(rhs)), val: None } [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `swap` is never used [INFO] [stdout] --> src/node.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 30 | impl Node{ [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn swap(&self)->Self{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `list` is never read [INFO] [stdout] --> src/./tokenlist.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TokenList{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 9 | pub original: String, [INFO] [stdout] 10 | pub list: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenList` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pos` is never read [INFO] [stdout] --> src/./token.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Token{ [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub pos: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `at_eof` is never used [INFO] [stdout] --> src/./token.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 16 | impl Token{ [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn at_eof(&self)->bool{ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Tk` [INFO] [stdout] --> src/./token.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / pub enum TokenKind { [INFO] [stdout] 3 | | TkReserved, [INFO] [stdout] 4 | | TkNum, [INFO] [stdout] 5 | | TkEof, [INFO] [stdout] 6 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./tokenlist.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | return Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())); [INFO] [stdout] 71 + Some(Token::new(TokenKind::TkEof, &"\0", &chars.count())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./tokenlist.rs:46:29 [INFO] [stdout] | [INFO] [stdout] 46 | let is_digit = |c: &char| !c.to_digit(10).is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.to_digit(10).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Nd` [INFO] [stdout] --> src/node.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / pub enum NodeKind { [INFO] [stdout] 7 | | NdAdd, // + [INFO] [stdout] 8 | | NdSub, // - [INFO] [stdout] 9 | | NdMul, // * [INFO] [stdout] ... | [INFO] [stdout] 18 | | NdBnk, [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/node.rs:134:3 [INFO] [stdout] | [INFO] [stdout] 134 | return self.primary(tok); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return self.primary(tok); [INFO] [stdout] 134 + self.primary(tok) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "17b186b5e932c502ad14270c82a35e6eff802992c5c693f220d265b1a94989f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17b186b5e932c502ad14270c82a35e6eff802992c5c693f220d265b1a94989f6", kill_on_drop: false }` [INFO] [stdout] 17b186b5e932c502ad14270c82a35e6eff802992c5c693f220d265b1a94989f6