[INFO] cloning repository https://github.com/szabgab/pydigger.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/szabgab/pydigger.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fszabgab%2Fpydigger.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fszabgab%2Fpydigger.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c229b5169ef2dd4ff676dbd2467d7ccff65cb9d2 [INFO] linting szabgab/pydigger.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fszabgab%2Fpydigger.rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/szabgab/pydigger.rs [INFO] finished tweaking git repo https://github.com/szabgab/pydigger.rs [INFO] tweaked toml for git repo https://github.com/szabgab/pydigger.rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/szabgab/pydigger.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/szabgab/pydigger.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded atom_syndication v0.12.7 [INFO] [stderr] Downloaded env_filter v0.1.4 [INFO] [stderr] Downloaded never v0.1.0 [INFO] [stderr] Downloaded flate2 v1.1.8 [INFO] [stderr] Downloaded diligent-date-parser v0.1.5 [INFO] [stderr] Downloaded rss v2.0.12 [INFO] [stderr] Downloaded jiff-static v0.2.18 [INFO] [stderr] Downloaded ureq v3.1.4 [INFO] [stderr] Downloaded webpki-roots v1.0.5 [INFO] [stderr] Downloaded jiff v0.2.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acf409f160964eb16d40ae8c972bc80dee5f4d9e01b7f4843562ce524e3906fb [INFO] running `Command { std: "docker" "start" "-a" "acf409f160964eb16d40ae8c972bc80dee5f4d9e01b7f4843562ce524e3906fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acf409f160964eb16d40ae8c972bc80dee5f4d9e01b7f4843562ce524e3906fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acf409f160964eb16d40ae8c972bc80dee5f4d9e01b7f4843562ce524e3906fb", kill_on_drop: false }` [INFO] [stdout] acf409f160964eb16d40ae8c972bc80dee5f4d9e01b7f4843562ce524e3906fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a292740dc92ee5ee181795dd802b7cb8ef2df4ce5d90c02a03d4b8a2ec822d3f [INFO] running `Command { std: "docker" "start" "-a" "a292740dc92ee5ee181795dd802b7cb8ef2df4ce5d90c02a03d4b8a2ec822d3f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling zmij v1.0.14 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking jiff v0.2.18 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Checking never v0.1.0 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ureq v3.1.4 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking git-digger v0.2.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking diligent-date-parser v0.1.5 [INFO] [stderr] Checking atom_syndication v0.12.7 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking rss v2.0.12 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking pydigger v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if !self.home_page.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.home_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / match &project.info.project_urls { [INFO] [stdout] 124 | | Some(urls) => { [INFO] [stdout] 125 | | for (key, value) in urls.iter() { [INFO] [stdout] 126 | | if let Some(value_str) = value.as_str() { [INFO] [stdout] ... | [INFO] [stdout] 165 | | None => {} [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(urls) = &project.info.project_urls { [INFO] [stdout] 124 + for (key, value) in urls.iter() { [INFO] [stdout] 125 + if let Some(value_str) = value.as_str() { [INFO] [stdout] 126 + self.project_urls.insert(key.clone(), value_str.to_string()); [INFO] [stdout] 127 + let normalized_key = normalize_url(key); [INFO] [stdout] 128 + [INFO] [stdout] 129 + if normalized_key == "source" { [INFO] [stdout] 130 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 131 + self.repository_source = Some(String::from("project_urls.source")); [INFO] [stdout] 132 + } [INFO] [stdout] 133 + if normalized_key == "sourcecode" { [INFO] [stdout] 134 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 135 + self.repository_source = Some(String::from("project_urls.sourcecode")); [INFO] [stdout] 136 + } [INFO] [stdout] 137 + if normalized_key == "repository" { [INFO] [stdout] 138 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 139 + self.repository_source = Some(String::from("project_urls.repository")); [INFO] [stdout] 140 + } [INFO] [stdout] 141 + if normalized_key == "github" { [INFO] [stdout] 142 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 143 + self.repository_source = Some(String::from("project_urls.github")); [INFO] [stdout] 144 + } [INFO] [stdout] 145 + [INFO] [stdout] 146 + if normalized_key == "download" { [INFO] [stdout] 147 + self.download = Some(value_str.to_string()); [INFO] [stdout] 148 + self.download_source = Some(String::from("project_urls.download")); [INFO] [stdout] 149 + } [INFO] [stdout] 150 + [INFO] [stdout] 151 + if normalized_key == "homepage" { [INFO] [stdout] 152 + self.home_page = Some(value_str.to_string()); [INFO] [stdout] 153 + self.home_page_source = Some(String::from("project_urls.homepage")); [INFO] [stdout] 154 + [INFO] [stdout] 155 + if self.repository.is_none() { [INFO] [stdout] 156 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 157 + self.repository_source = [INFO] [stdout] 158 + Some(String::from("project_urls.homepage")); [INFO] [stdout] 159 + } [INFO] [stdout] 160 + } [INFO] [stdout] 161 + } [INFO] [stdout] 162 + } [INFO] [stdout] 163 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | / match &project.info.home_page { [INFO] [stdout] 170 | | Some(home_page) => { [INFO] [stdout] 171 | | self.home_page = Some(home_page.clone()); [INFO] [stdout] 172 | | self.home_page_source = Some(String::from("info.home_page")); [INFO] [stdout] 173 | | } [INFO] [stdout] 174 | | None => {} [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ if let Some(home_page) = &project.info.home_page { [INFO] [stdout] 170 + self.home_page = Some(home_page.clone()); [INFO] [stdout] 171 + self.home_page_source = Some(String::from("info.home_page")); [INFO] [stdout] 172 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | / match &project.info.download_url { [INFO] [stdout] 179 | | Some(download_url) => { [INFO] [stdout] 180 | | self.download = Some(download_url.clone()); [INFO] [stdout] 181 | | self.download_source = Some(String::from("info.download_url")); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | None => {} [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ if let Some(download_url) = &project.info.download_url { [INFO] [stdout] 179 + self.download = Some(download_url.clone()); [INFO] [stdout] 180 + self.download_source = Some(String::from("info.download_url")); [INFO] [stdout] 181 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if self.repository.is_none() { [INFO] [stdout] 188 | | if !self.home_page.is_none() { [INFO] [stdout] 189 | | self.repository = self.home_page.clone(); [INFO] [stdout] 190 | | self.repository_source = Some(String::from("info.home_page")); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if self.repository.is_none() [INFO] [stdout] 188 ~ && !self.home_page.is_none() { [INFO] [stdout] 189 | self.repository = self.home_page.clone(); [INFO] [stdout] 190 | self.repository_source = Some(String::from("info.home_page")); [INFO] [stdout] 191 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if !self.home_page.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.home_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / match &project.info.project_urls { [INFO] [stdout] 124 | | Some(urls) => { [INFO] [stdout] 125 | | for (key, value) in urls.iter() { [INFO] [stdout] 126 | | if let Some(value_str) = value.as_str() { [INFO] [stdout] ... | [INFO] [stdout] 165 | | None => {} [INFO] [stdout] 166 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(urls) = &project.info.project_urls { [INFO] [stdout] 124 + for (key, value) in urls.iter() { [INFO] [stdout] 125 + if let Some(value_str) = value.as_str() { [INFO] [stdout] 126 + self.project_urls.insert(key.clone(), value_str.to_string()); [INFO] [stdout] 127 + let normalized_key = normalize_url(key); [INFO] [stdout] 128 + [INFO] [stdout] 129 + if normalized_key == "source" { [INFO] [stdout] 130 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 131 + self.repository_source = Some(String::from("project_urls.source")); [INFO] [stdout] 132 + } [INFO] [stdout] 133 + if normalized_key == "sourcecode" { [INFO] [stdout] 134 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 135 + self.repository_source = Some(String::from("project_urls.sourcecode")); [INFO] [stdout] 136 + } [INFO] [stdout] 137 + if normalized_key == "repository" { [INFO] [stdout] 138 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 139 + self.repository_source = Some(String::from("project_urls.repository")); [INFO] [stdout] 140 + } [INFO] [stdout] 141 + if normalized_key == "github" { [INFO] [stdout] 142 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 143 + self.repository_source = Some(String::from("project_urls.github")); [INFO] [stdout] 144 + } [INFO] [stdout] 145 + [INFO] [stdout] 146 + if normalized_key == "download" { [INFO] [stdout] 147 + self.download = Some(value_str.to_string()); [INFO] [stdout] 148 + self.download_source = Some(String::from("project_urls.download")); [INFO] [stdout] 149 + } [INFO] [stdout] 150 + [INFO] [stdout] 151 + if normalized_key == "homepage" { [INFO] [stdout] 152 + self.home_page = Some(value_str.to_string()); [INFO] [stdout] 153 + self.home_page_source = Some(String::from("project_urls.homepage")); [INFO] [stdout] 154 + [INFO] [stdout] 155 + if self.repository.is_none() { [INFO] [stdout] 156 + self.repository = Some(value_str.to_string()); [INFO] [stdout] 157 + self.repository_source = [INFO] [stdout] 158 + Some(String::from("project_urls.homepage")); [INFO] [stdout] 159 + } [INFO] [stdout] 160 + } [INFO] [stdout] 161 + } [INFO] [stdout] 162 + } [INFO] [stdout] 163 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | / match &project.info.home_page { [INFO] [stdout] 170 | | Some(home_page) => { [INFO] [stdout] 171 | | self.home_page = Some(home_page.clone()); [INFO] [stdout] 172 | | self.home_page_source = Some(String::from("info.home_page")); [INFO] [stdout] 173 | | } [INFO] [stdout] 174 | | None => {} [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 169 ~ if let Some(home_page) = &project.info.home_page { [INFO] [stdout] 170 + self.home_page = Some(home_page.clone()); [INFO] [stdout] 171 + self.home_page_source = Some(String::from("info.home_page")); [INFO] [stdout] 172 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | / match &project.info.download_url { [INFO] [stdout] 179 | | Some(download_url) => { [INFO] [stdout] 180 | | self.download = Some(download_url.clone()); [INFO] [stdout] 181 | | self.download_source = Some(String::from("info.download_url")); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | None => {} [INFO] [stdout] 184 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ if let Some(download_url) = &project.info.download_url { [INFO] [stdout] 179 + self.download = Some(download_url.clone()); [INFO] [stdout] 180 + self.download_source = Some(String::from("info.download_url")); [INFO] [stdout] 181 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if self.repository.is_none() { [INFO] [stdout] 188 | | if !self.home_page.is_none() { [INFO] [stdout] 189 | | self.repository = self.home_page.clone(); [INFO] [stdout] 190 | | self.repository_source = Some(String::from("info.home_page")); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if self.repository.is_none() [INFO] [stdout] 188 ~ && !self.home_page.is_none() { [INFO] [stdout] 189 | self.repository = self.home_page.clone(); [INFO] [stdout] 190 | self.repository_source = Some(String::from("info.home_page")); [INFO] [stdout] 191 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | project_urls: project_urls, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_urls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | project_urls: project_urls, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_urls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/report.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | project_urls_count: project_urls_count, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_urls_count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/report.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | project_urls_count: project_urls_count, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `project_urls_count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(json); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(json); [INFO] [stdout] 42 + Ok(json) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(json); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(json); [INFO] [stdout] 42 + Ok(json) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download.rs:140:35 [INFO] [stdout] | [INFO] [stdout] 140 | process_items(&items, limit); [INFO] [stdout] | ^^^^^^ help: change this to: `items` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download.rs:140:35 [INFO] [stdout] | [INFO] [stdout] 140 | process_items(&items, limit); [INFO] [stdout] | ^^^^^^ help: change this to: `items` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Ok(saved_project) = load_mt_project_from_file(&name) { [INFO] [stdout] 216 | | if saved_project.pub_date >= pub_date { [INFO] [stdout] 217 | | info!("Project {} is up to date, skipping download.", name); [INFO] [stdout] 218 | | return Ok(Status::Skipping); [INFO] [stdout] 219 | | }; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Ok(saved_project) = load_mt_project_from_file(&name) [INFO] [stdout] 216 ~ && saved_project.pub_date >= pub_date { [INFO] [stdout] 217 | info!("Project {} is up to date, skipping download.", name); [INFO] [stdout] 218 | return Ok(Status::Skipping); [INFO] [stdout] 219 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/download.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | / if let Ok(saved_project) = load_mt_project_from_file(&name) { [INFO] [stdout] 216 | | if saved_project.pub_date >= pub_date { [INFO] [stdout] 217 | | info!("Project {} is up to date, skipping download.", name); [INFO] [stdout] 218 | | return Ok(Status::Skipping); [INFO] [stdout] 219 | | }; [INFO] [stdout] 220 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if let Ok(saved_project) = load_mt_project_from_file(&name) [INFO] [stdout] 216 ~ && saved_project.pub_date >= pub_date { [INFO] [stdout] 217 | info!("Project {} is up to date, skipping download.", name); [INFO] [stdout] 218 | return Ok(Status::Skipping); [INFO] [stdout] 219 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download.rs:245:55 [INFO] [stdout] | [INFO] [stdout] 245 | let project = serde_json::from_str::(&project_json_from_pypi).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `project_json_from_pypi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download.rs:245:55 [INFO] [stdout] | [INFO] [stdout] 245 | let project = serde_json::from_str::(&project_json_from_pypi).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `project_json_from_pypi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | / if let Some(has_setup_cfg) = project.has_setup_cfg { [INFO] [stdout] 199 | | if has_setup_cfg { [INFO] [stdout] 200 | | vr.has_setup_cfg_count += 1; [INFO] [stdout] 201 | | if vr.has_setup_cfg.len() < PAGE_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 198 ~ if let Some(has_setup_cfg) = project.has_setup_cfg [INFO] [stdout] 199 ~ && has_setup_cfg { [INFO] [stdout] 200 | vr.has_setup_cfg_count += 1; [INFO] [stdout] ... [INFO] [stdout] 203 | } [INFO] [stdout] 204 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | / if let Some(has_pyproject_toml) = project.has_pyproject_toml { [INFO] [stdout] 208 | | if !has_pyproject_toml { [INFO] [stdout] 209 | | vr.no_pyproject_toml_count += 1; [INFO] [stdout] 210 | | if vr.no_pyproject_toml.len() < PAGE_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 207 ~ if let Some(has_pyproject_toml) = project.has_pyproject_toml [INFO] [stdout] 208 ~ && !has_pyproject_toml { [INFO] [stdout] 209 | vr.no_pyproject_toml_count += 1; [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | / if let Some(has_setup_cfg) = project.has_setup_cfg { [INFO] [stdout] 199 | | if has_setup_cfg { [INFO] [stdout] 200 | | vr.has_setup_cfg_count += 1; [INFO] [stdout] 201 | | if vr.has_setup_cfg.len() < PAGE_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 205 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 198 ~ if let Some(has_setup_cfg) = project.has_setup_cfg [INFO] [stdout] 199 ~ && has_setup_cfg { [INFO] [stdout] 200 | vr.has_setup_cfg_count += 1; [INFO] [stdout] ... [INFO] [stdout] 203 | } [INFO] [stdout] 204 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | / if let Some(has_pyproject_toml) = project.has_pyproject_toml { [INFO] [stdout] 208 | | if !has_pyproject_toml { [INFO] [stdout] 209 | | vr.no_pyproject_toml_count += 1; [INFO] [stdout] 210 | | if vr.no_pyproject_toml.len() < PAGE_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 207 ~ if let Some(has_pyproject_toml) = project.has_pyproject_toml [INFO] [stdout] 208 ~ && !has_pyproject_toml { [INFO] [stdout] 209 | vr.no_pyproject_toml_count += 1; [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/report.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | projects.sort_by(|a, b| b.pub_date.cmp(&a.pub_date)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 400 - projects.sort_by(|a, b| b.pub_date.cmp(&a.pub_date)); [INFO] [stdout] 400 + projects.sort_by_key(|b| std::cmp::Reverse(b.pub_date)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.project` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 52 | if args.project.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &args.project` [INFO] [stdout] 53 | let name = args.project.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/report.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | projects.sort_by(|a, b| b.pub_date.cmp(&a.pub_date)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 400 - projects.sort_by(|a, b| b.pub_date.cmp(&a.pub_date)); [INFO] [stdout] 400 + projects.sort_by_key(|b| std::cmp::Reverse(b.pub_date)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.project` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 52 | if args.project.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &args.project` [INFO] [stdout] 53 | let name = args.project.as_ref().unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.99s [INFO] running `Command { std: "docker" "inspect" "a292740dc92ee5ee181795dd802b7cb8ef2df4ce5d90c02a03d4b8a2ec822d3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a292740dc92ee5ee181795dd802b7cb8ef2df4ce5d90c02a03d4b8a2ec822d3f", kill_on_drop: false }` [INFO] [stdout] a292740dc92ee5ee181795dd802b7cb8ef2df4ce5d90c02a03d4b8a2ec822d3f