[INFO] cloning repository https://github.com/swektr/tetris [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/swektr/tetris" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswektr%2Ftetris", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswektr%2Ftetris'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 611551a29a5e0778e36e84888428189ace6aa65a [INFO] linting swektr/tetris against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswektr%2Ftetris" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/swektr/tetris [INFO] finished tweaking git repo https://github.com/swektr/tetris [INFO] tweaked toml for git repo https://github.com/swektr/tetris written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/swektr/tetris on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/swektr/tetris already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55597728bf2aec366237d6a437733af8c960094e398c15d36319786a7cd6e48e [INFO] running `Command { std: "docker" "start" "-a" "55597728bf2aec366237d6a437733af8c960094e398c15d36319786a7cd6e48e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55597728bf2aec366237d6a437733af8c960094e398c15d36319786a7cd6e48e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55597728bf2aec366237d6a437733af8c960094e398c15d36319786a7cd6e48e", kill_on_drop: false }` [INFO] [stdout] 55597728bf2aec366237d6a437733af8c960094e398c15d36319786a7cd6e48e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 050e8d29e897d2a49cb9adba46afd897f6575064cfc1dd00204a1db2521cc451 [INFO] running `Command { std: "docker" "start" "-a" "050e8d29e897d2a49cb9adba46afd897f6575064cfc1dd00204a1db2521cc451", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking tetris v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Board` [INFO] [stdout] --> src/board.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Board { [INFO] [stdout] 12 | | Board { [INFO] [stdout] 13 | | data: [[0 as u8; BOARD_WIDTH]; BOARD_HEIGHT], [INFO] [stdout] 14 | | width: BOARD_WIDTH, [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Board { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/board.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | data: [[0 as u8; BOARD_WIDTH]; BOARD_HEIGHT], [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | .any(|(px,_)| !board.at(y+py as i32, x+px as i32) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 31 | | .is_some_and(|cell| cell == 0)) [INFO] [stdout] | |_________________________________________________________________^ help: try: `board.at(y+py as i32, x+px as i32).is_none_or(|cell| cell != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:7:44 [INFO] [stdout] | [INFO] [stdout] 7 | pub const NCURSES_GETCH_TIMOUT: i32 = 1000/TICKS_PER_SECOND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `TICKS_PER_SECOND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Board` [INFO] [stdout] --> src/board.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn new() -> Board { [INFO] [stdout] 12 | | Board { [INFO] [stdout] 13 | | data: [[0 as u8; BOARD_WIDTH]; BOARD_HEIGHT], [INFO] [stdout] 14 | | width: BOARD_WIDTH, [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 10 + impl Default for Board { [INFO] [stdout] 11 + fn default() -> Self { [INFO] [stdout] 12 + Self::new() [INFO] [stdout] 13 + } [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/board.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | data: [[0 as u8; BOARD_WIDTH]; BOARD_HEIGHT], [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 30 | .any(|(px,_)| !board.at(y+py as i32, x+px as i32) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 31 | | .is_some_and(|cell| cell == 0)) [INFO] [stdout] | |_________________________________________________________________^ help: try: `board.at(y+py as i32, x+px as i32).is_none_or(|cell| cell != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:7:44 [INFO] [stdout] | [INFO] [stdout] 7 | pub const NCURSES_GETCH_TIMOUT: i32 = 1000/TICKS_PER_SECOND as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `TICKS_PER_SECOND` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use gfx; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use gfx; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | x = x+dx; [INFO] [stdout] | ^^^^^^^^ help: replace it with: `x += dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | x = x+dx; [INFO] [stdout] | ^^^^^^^^ help: replace it with: `x += dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.63s [INFO] running `Command { std: "docker" "inspect" "050e8d29e897d2a49cb9adba46afd897f6575064cfc1dd00204a1db2521cc451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "050e8d29e897d2a49cb9adba46afd897f6575064cfc1dd00204a1db2521cc451", kill_on_drop: false }` [INFO] [stdout] 050e8d29e897d2a49cb9adba46afd897f6575064cfc1dd00204a1db2521cc451