[INFO] cloning repository https://github.com/swananan/feather-quic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/swananan/feather-quic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswananan%2Ffeather-quic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswananan%2Ffeather-quic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f5f1f6001ffa928bf52c4db4c31e401e89a6ae85 [INFO] linting swananan/feather-quic/f5f1f6001ffa928bf52c4db4c31e401e89a6ae85 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fswananan%2Ffeather-quic" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/swananan/feather-quic [INFO] finished tweaking git repo https://github.com/swananan/feather-quic [INFO] tweaked toml for git repo https://github.com/swananan/feather-quic written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/swananan/feather-quic on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/swananan/mio-timerfd.git` [INFO] [stderr] Locking 252 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding rcgen v0.11.3 (available: v0.14.7) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded once_cell v1.21.4 [INFO] [stderr] Downloaded test-log v0.2.19 [INFO] [stderr] Downloaded test-log-macros v0.2.19 [INFO] [stderr] Downloaded directories-next v2.0.0 [INFO] [stderr] Downloaded openssl-probe v0.2.1 [INFO] [stderr] Downloaded rustls-platform-verifier-android v0.1.1 [INFO] [stderr] Downloaded colorchoice v1.0.5 [INFO] [stderr] Downloaded clap-num v1.2.0 [INFO] [stderr] Downloaded libredox v0.1.14 [INFO] [stderr] Downloaded lru-slab v0.1.2 [INFO] [stderr] Downloaded anstyle-parse v1.0.0 [INFO] [stderr] Downloaded wasm-metadata v0.244.0 [INFO] [stderr] Downloaded iana-time-zone v0.1.65 [INFO] [stderr] Downloaded clap_derive v4.6.0 [INFO] [stderr] Downloaded clap v4.6.0 [INFO] [stderr] Downloaded quinn v0.11.9 [INFO] [stderr] Downloaded cc v1.2.57 [INFO] [stderr] Downloaded io-uring v0.7.11 [INFO] [stderr] Downloaded libm v0.2.16 [INFO] [stderr] Downloaded webpki-root-certs v1.0.6 [INFO] [stderr] Downloaded wit-parser v0.244.0 [INFO] [stderr] Downloaded clap_builder v4.6.0 [INFO] [stderr] Downloaded quinn-proto v0.11.14 [INFO] [stderr] Downloaded aws-lc-rs v1.16.1 [INFO] [stderr] Downloaded time v0.3.47 [INFO] [stderr] Downloaded chrono v0.4.44 [INFO] [stderr] Downloaded wasmparser v0.244.0 [INFO] [stderr] Downloaded wit-component v0.244.0 [INFO] [stderr] Downloaded tracing-subscriber v0.3.23 [INFO] [stderr] Downloaded wasip3 v0.4.0+wasi-0.3.0-rc-2026-01-06 [INFO] [stderr] Downloaded prettyplease v0.2.37 [INFO] [stderr] Downloaded security-framework v3.7.0 [INFO] [stderr] Downloaded rustls v0.23.37 [INFO] [stderr] Downloaded rustix v1.1.4 [INFO] [stderr] Downloaded rustls-webpki v0.103.9 [INFO] [stderr] Downloaded wasm-encoder v0.244.0 [INFO] [stderr] Downloaded rustls-platform-verifier v0.6.2 [INFO] [stderr] Downloaded rcgen v0.11.3 [INFO] [stderr] Downloaded r-efi v6.0.0 [INFO] [stderr] Downloaded wit-bindgen-rust v0.51.0 [INFO] [stderr] Downloaded getrandom v0.4.2 [INFO] [stderr] Downloaded futures-executor v0.3.32 [INFO] [stderr] Downloaded futures-channel v0.3.32 [INFO] [stderr] Downloaded futures v0.3.32 [INFO] [stderr] Downloaded tinyvec v1.11.0 [INFO] [stderr] Downloaded rustls-pki-types v1.14.0 [INFO] [stderr] Downloaded wit-bindgen-core v0.51.0 [INFO] [stderr] Downloaded anyhow v1.0.102 [INFO] [stderr] Downloaded tempfile v3.27.0 [INFO] [stderr] Downloaded anstyle v1.0.14 [INFO] [stderr] Downloaded pin-project v1.1.11 [INFO] [stderr] Downloaded anstream v1.0.0 [INFO] [stderr] Downloaded quinn-udp v0.5.14 [INFO] [stderr] Downloaded fastbloom v0.14.1 [INFO] [stderr] Downloaded rand_core v0.9.5 [INFO] [stderr] Downloaded tokio v1.50.0 [INFO] [stderr] Downloaded schannel v0.1.29 [INFO] [stderr] Downloaded rustls-native-certs v0.8.3 [INFO] [stderr] Downloaded cmake v0.1.57 [INFO] [stderr] Downloaded fs_extra v1.3.0 [INFO] [stderr] Downloaded env_logger v0.11.9 [INFO] [stderr] Downloaded env_filter v1.0.0 [INFO] [stderr] Downloaded tokio-stream v0.1.18 [INFO] [stderr] Downloaded clap_lex v1.1.0 [INFO] [stderr] Downloaded futures-io v0.3.32 [INFO] [stderr] Downloaded futures-sink v0.3.32 [INFO] [stderr] Downloaded security-framework-sys v2.17.0 [INFO] [stderr] Downloaded deranged v0.5.8 [INFO] [stderr] Downloaded leb128fmt v0.1.0 [INFO] [stderr] Downloaded id-arena v2.3.0 [INFO] [stderr] Downloaded wit-bindgen-rust-macro v0.51.0 [INFO] [stderr] Downloaded pin-project-internal v1.1.11 [INFO] [stderr] Downloaded tracing-attributes v0.1.31 [INFO] [stderr] Downloaded linux-raw-sys v0.12.1 [INFO] [stderr] Downloaded aws-lc-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35932d1a331a38af2b1756393c0b75f546e49ee8adcacfb23a8441736ce7ae1e [INFO] running `Command { std: "docker" "start" "-a" "35932d1a331a38af2b1756393c0b75f546e49ee8adcacfb23a8441736ce7ae1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35932d1a331a38af2b1756393c0b75f546e49ee8adcacfb23a8441736ce7ae1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35932d1a331a38af2b1756393c0b75f546e49ee8adcacfb23a8441736ce7ae1e", kill_on_drop: false }` [INFO] [stdout] 35932d1a331a38af2b1756393c0b75f546e49ee8adcacfb23a8441736ce7ae1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65dafd247a84da457d5833dd11bbab4899473da35e0f80a563440400eb99a8d8 [INFO] running `Command { std: "docker" "start" "-a" "65dafd247a84da457d5833dd11bbab4899473da35e0f80a563440400eb99a8d8", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking anstyle-parse v1.0.0 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking openssl-probe v0.2.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking anstream v1.0.0 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking clap_lex v1.1.0 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking clap_builder v4.6.0 [INFO] [stderr] Compiling quinn-udp v0.5.14 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking siphasher v1.0.2 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking tinyvec v1.11.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Compiling quinn v0.11.9 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling io-uring v0.7.11 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking lru-slab v0.1.2 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking mio-timerfd v0.3.0 (https://github.com/swananan/mio-timerfd.git#af3295e7) [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking clap-num v1.2.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling clap_derive v4.6.0 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling test-log-macros v0.2.19 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking test-log v0.2.19 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking fastbloom v0.14.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking tracing-subscriber v0.3.23 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking clap v4.6.0 [INFO] [stderr] Checking rcgen v0.11.3 [INFO] [stderr] Checking feather-quic-core v0.1.0 (/opt/rustwide/workdir/feather-quic-core) [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stdout] warning: called `unwrap` on `self.pto_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2767:32 [INFO] [stdout] | [INFO] [stdout] 2764 | if self.pto_threshold.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = self.pto_threshold` [INFO] [stdout] ... [INFO] [stdout] 2767 | format_instant(self.pto_threshold.unwrap(), self.current_ts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.detect_lost_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2777:32 [INFO] [stdout] | [INFO] [stdout] 2774 | if self.detect_lost_threshold.is_some() && self.pto_threshold.is_some() { [INFO] [stdout] | ------------------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 2777 | format_instant(self.detect_lost_threshold.unwrap(), self.current_ts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.pto_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2778:32 [INFO] [stdout] | [INFO] [stdout] 2774 | if self.detect_lost_threshold.is_some() && self.pto_threshold.is_some() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 2778 | format_instant(self.pto_threshold.unwrap(), self.current_ts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.pto_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2767:32 [INFO] [stdout] | [INFO] [stdout] 2764 | if self.pto_threshold.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = self.pto_threshold` [INFO] [stdout] ... [INFO] [stdout] 2767 | format_instant(self.pto_threshold.unwrap(), self.current_ts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.detect_lost_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2777:32 [INFO] [stdout] | [INFO] [stdout] 2774 | if self.detect_lost_threshold.is_some() && self.pto_threshold.is_some() { [INFO] [stdout] | ------------------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 2777 | format_instant(self.detect_lost_threshold.unwrap(), self.current_ts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.pto_threshold` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-core/src/connection.rs:2778:32 [INFO] [stdout] | [INFO] [stdout] 2774 | if self.detect_lost_threshold.is_some() && self.pto_threshold.is_some() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 2778 | format_instant(self.pto_threshold.unwrap(), self.current_ts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> feather-quic-core/src/utils.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Err(anyhow!("Length is so big more then 1<<62 {}", len)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Err(anyhow!("Length is so big more then 1<<62 {}", len)); [INFO] [stdout] 45 + Err(anyhow!("Length is so big more then 1<<62 {}", len)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking feather-quic-tools v0.1.0 (/opt/rustwide/workdir/feather-quic-tools) [INFO] [stderr] Checking quinn-proto v0.11.14 [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> feather-quic-tools/src/client_tool.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | if hex.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!hex.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> feather-quic-tools/src/client_tool.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 25 | if hex.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `!hex.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> feather-quic-core/src/utils.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return Err(anyhow!("Length is so big more then 1<<62 {}", len)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return Err(anyhow!("Length is so big more then 1<<62 {}", len)); [INFO] [stdout] 45 + Err(anyhow!("Length is so big more then 1<<62 {}", len)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking feather-quic-integration-tests v0.1.0 (/opt/rustwide/workdir/feather-quic-integration-tests) [INFO] [stdout] warning: called `unwrap` on `opt.log_file` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-integration-tests/src/bin/echo_server.rs:172:42 [INFO] [stdout] | [INFO] [stdout] 171 | if opt.log_file.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &opt.log_file` [INFO] [stdout] 172 | let file = std::fs::File::create(opt.log_file.as_ref().unwrap()).with_context(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt.log_file` after checking its variant with `is_some` [INFO] [stdout] --> feather-quic-integration-tests/src/bin/echo_server.rs:172:42 [INFO] [stdout] | [INFO] [stdout] 171 | if opt.log_file.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &opt.log_file` [INFO] [stdout] 172 | let file = std::fs::File::create(opt.log_file.as_ref().unwrap()).with_context(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `Command { std: "docker" "inspect" "65dafd247a84da457d5833dd11bbab4899473da35e0f80a563440400eb99a8d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65dafd247a84da457d5833dd11bbab4899473da35e0f80a563440400eb99a8d8", kill_on_drop: false }` [INFO] [stdout] 65dafd247a84da457d5833dd11bbab4899473da35e0f80a563440400eb99a8d8