[INFO] cloning repository https://github.com/superspeeder/osdevrust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/superspeeder/osdevrust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuperspeeder%2Fosdevrust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuperspeeder%2Fosdevrust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54c2e54a1ee292b456881f8086ed94a9bef0d166 [INFO] linting superspeeder/osdevrust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuperspeeder%2Fosdevrust" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-1-tc1/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-1-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/superspeeder/osdevrust [INFO] finished tweaking git repo https://github.com/superspeeder/osdevrust [INFO] tweaked toml for git repo https://github.com/superspeeder/osdevrust written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/superspeeder/osdevrust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/superspeeder/osdevrust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded volatile v0.4.6 [INFO] [stderr] Downloaded const_fn v0.4.11 [INFO] [stderr] Downloaded x86_64 v0.15.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11f897680457bee9ab26e7100e0aad54f0ae6742a68af1c1773a821796bf053b [INFO] running `Command { std: "docker" "start" "-a" "11f897680457bee9ab26e7100e0aad54f0ae6742a68af1c1773a821796bf053b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11f897680457bee9ab26e7100e0aad54f0ae6742a68af1c1773a821796bf053b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11f897680457bee9ab26e7100e0aad54f0ae6742a68af1c1773a821796bf053b", kill_on_drop: false }` [INFO] [stdout] 11f897680457bee9ab26e7100e0aad54f0ae6742a68af1c1773a821796bf053b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cd0cc6cdc072af17fc5d87e5e8b998bd820dfa9f215b47fe6a4c93f5a6bfc353 [INFO] running `Command { std: "docker" "start" "-a" "cd0cc6cdc072af17fc5d87e5e8b998bd820dfa9f215b47fe6a4c93f5a6bfc353", kill_on_drop: false }` [INFO] [stderr] Compiling const_fn v0.4.11 [INFO] [stderr] Checking volatile v0.4.6 [INFO] [stderr] Compiling kernel v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking x86_64 v0.15.4 [INFO] [stdout] warning: unused import: `x86_64::instructions::interrupts::software_interrupt` [INFO] [stdout] --> src/cpu/interrupts.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use x86_64::instructions::interrupts::software_interrupt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `MappedPageTable` [INFO] [stdout] --> src/cpu/paging.rs:1:34 [INFO] [stdout] | [INFO] [stdout] 1 | use x86_64::structures::paging::{MappedPageTable, PageTable}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:8:46 [INFO] [stdout] | [INFO] [stdout] 8 | extern "x86-interrupt" fn page_fault_handler(frame: InterruptStackFrame, error_code: PageFaultErrorCode) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_code` [INFO] [stdout] --> src/cpu/interrupts.rs:8:74 [INFO] [stdout] | [INFO] [stdout] 8 | extern "x86-interrupt" fn page_fault_handler(frame: InterruptStackFrame, error_code: PageFaultErrorCode) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_error_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | extern "x86-interrupt" fn gpf_handler(frame: InterruptStackFrame, error_code: u64) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_code` [INFO] [stdout] --> src/cpu/interrupts.rs:13:67 [INFO] [stdout] | [INFO] [stdout] 13 | extern "x86-interrupt" fn gpf_handler(frame: InterruptStackFrame, error_code: u64) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_error_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:17:53 [INFO] [stdout] | [INFO] [stdout] 17 | extern "x86-interrupt" fn generic_exception_handler(frame: InterruptStackFrame, error_code: u64) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_code` [INFO] [stdout] --> src/cpu/interrupts.rs:17:81 [INFO] [stdout] | [INFO] [stdout] 17 | extern "x86-interrupt" fn generic_exception_handler(frame: InterruptStackFrame, error_code: u64) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_error_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | extern "x86-interrupt" fn generic_isr_handler(frame: InterruptStackFrame) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:25:48 [INFO] [stdout] | [INFO] [stdout] 25 | extern "x86-interrupt" fn double_fault_handler(frame: InterruptStackFrame, error_code: u64) -> ! { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `error_code` [INFO] [stdout] --> src/cpu/interrupts.rs:25:76 [INFO] [stdout] | [INFO] [stdout] 25 | extern "x86-interrupt" fn double_fault_handler(frame: InterruptStackFrame, error_code: u64) -> ! { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_error_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame` [INFO] [stdout] --> src/cpu/interrupts.rs:31:49 [INFO] [stdout] | [INFO] [stdout] 31 | extern "x86-interrupt" fn machine_check_handler(frame: InterruptStackFrame) -> ! { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `HELLO` is never used [INFO] [stdout] --> src/main.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | static HELLO: &[u8] = b"Hello World!"; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_level_4_table` is never used [INFO] [stdout] --> src/cpu/paging.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn get_level_4_table() -> &'static mut PageTable { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_pml4t_addr` is never used [INFO] [stdout] --> src/cpu/paging.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn get_pml4t_addr() -> *mut PageTable; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/header.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 3 | / struct MultibootTagHeader { [INFO] [stdout] 4 | | type_: u16, [INFO] [stdout] 5 | | flags: u16, [INFO] [stdout] 6 | | size: u32, [INFO] [stdout] 7 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] = note: `#[warn(clippy::repr_packed_without_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: item uses `packed` representation without ABI-qualification [INFO] [stdout] --> src/header.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 21 | #[repr(packed)] [INFO] [stdout] | ------ `packed` representation set here [INFO] [stdout] 22 | / struct MultibootHeader { [INFO] [stdout] 23 | | magic: u32, [INFO] [stdout] 24 | | arch: u32, [INFO] [stdout] 25 | | header_length: u32, [INFO] [stdout] ... | [INFO] [stdout] 28 | | null_tag: MultibootTagHeader, [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: unqualified `#[repr(packed)]` defaults to `#[repr(Rust, packed)]`, which has no stable ABI [INFO] [stdout] = help: qualify the desired ABI explicitly via `#[repr(C, packed)]` or `#[repr(Rust, packed)]` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#repr_packed_without_abi [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/drivers/serial.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | !(self.read_io_port(2) & 0b1 == 0b1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.read_io_port(2) & 0b1 != 0b1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty `loop {}` wastes CPU cycles [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | loop {} [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stdout] = note: `#[warn(clippy::empty_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:50:33 [INFO] [stdout] | [INFO] [stdout] 50 | COM1.write_byte('\n' as u8); [INFO] [stdout] | ^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.13s [INFO] running `Command { std: "docker" "inspect" "cd0cc6cdc072af17fc5d87e5e8b998bd820dfa9f215b47fe6a4c93f5a6bfc353", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd0cc6cdc072af17fc5d87e5e8b998bd820dfa9f215b47fe6a4c93f5a6bfc353", kill_on_drop: false }` [INFO] [stdout] cd0cc6cdc072af17fc5d87e5e8b998bd820dfa9f215b47fe6a4c93f5a6bfc353