[INFO] cloning repository https://github.com/supersanta183/password_vault [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/supersanta183/password_vault" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsupersanta183%2Fpassword_vault", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsupersanta183%2Fpassword_vault'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e947ab3a1e4a8de423fa0e1373deb85e0bd73eb3 [INFO] linting supersanta183/password_vault against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsupersanta183%2Fpassword_vault" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/supersanta183/password_vault [INFO] finished tweaking git repo https://github.com/supersanta183/password_vault [INFO] tweaked toml for git repo https://github.com/supersanta183/password_vault written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/supersanta183/password_vault on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/supersanta183/password_vault already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rsa_keygen v1.0.9 [INFO] [stderr] Downloaded random-number-macro-impl v0.1.7 [INFO] [stderr] Downloaded random-pick v1.2.16 [INFO] [stderr] Downloaded random-number v0.1.8 [INFO] [stderr] Downloaded passwords v3.1.16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d689bf71eea089462308700c092798ada0fa723366bc56bf7762f6dd93151547 [INFO] running `Command { std: "docker" "start" "-a" "d689bf71eea089462308700c092798ada0fa723366bc56bf7762f6dd93151547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d689bf71eea089462308700c092798ada0fa723366bc56bf7762f6dd93151547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d689bf71eea089462308700c092798ada0fa723366bc56bf7762f6dd93151547", kill_on_drop: false }` [INFO] [stdout] d689bf71eea089462308700c092798ada0fa723366bc56bf7762f6dd93151547 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb4fd3cec41d7e5237f49f40a481c9bfc4d17fd7e1982d9f965c3ca9380a9f6c [INFO] running `Command { std: "docker" "start" "-a" "bb4fd3cec41d7e5237f49f40a481c9bfc4d17fd7e1982d9f965c3ca9380a9f6c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling random-number-macro-impl v0.1.7 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking random-number v0.1.8 [INFO] [stderr] Checking random-pick v1.2.16 [INFO] [stderr] Checking passwords v3.1.16 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking tiny-bip39 v1.0.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking rsa_keygen v1.0.9 [INFO] [stderr] Checking password_vault v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `write` [INFO] [stdout] --> src/vault/vault_errors.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{self, write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Zeroize` and `Zeroizing` [INFO] [stdout] --> src/vault/helper_functions.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use zeroize::{Zeroize, Zeroizing}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vault` [INFO] [stdout] --> src/vault/vault.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | use crate::vault; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `write` [INFO] [stdout] --> src/vault/vault_errors.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{self, write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Zeroize` and `Zeroizing` [INFO] [stdout] --> src/vault/helper_functions.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use zeroize::{Zeroize, Zeroizing}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/vault/vault.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha2::{Digest, Sha256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/vault/vault.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha2::{Digest, Sha256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `update_password` is never used [INFO] [stdout] --> src/vault/vault.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Vault { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 174 | fn update_password() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/vault/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod vault; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(vault); [INFO] [stdout] 48 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(vault); [INFO] [stdout] 69 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vault/vault.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | let res = self.login_with_seedphrase(&seedphrase); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 121 | [INFO] [stdout] 122 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 | [INFO] [stdout] 122 ~ self.login_with_seedphrase(&seedphrase) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `update_password` is never used [INFO] [stdout] --> src/vault/vault.rs:174:8 [INFO] [stdout] | [INFO] [stdout] 26 | impl Vault { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 174 | fn update_password() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/vault/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod vault; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(vault); [INFO] [stdout] 48 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(vault); [INFO] [stdout] 69 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vault/vault.rs:227:51 [INFO] [stdout] | [INFO] [stdout] 227 | .decrypt(oaep::Oaep::new::(), &pw) [INFO] [stdout] | ^^^ help: change this to: `pw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/vault/vault.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / match seedphrase_string { [INFO] [stdout] 240 | | Ok(seedphrase) => Some(seedphrase), [INFO] [stdout] 241 | | Err(_) => None, [INFO] [stdout] 242 | | } [INFO] [stdout] | |_________^ help: replace with: `seedphrase_string.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vault/vault.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | let res = self.login_with_seedphrase(&seedphrase); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 121 | [INFO] [stdout] 122 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 | [INFO] [stdout] 122 ~ self.login_with_seedphrase(&seedphrase) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vault/vault.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(vault.logged_in, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(vault.logged_in, true); [INFO] [stdout] 323 + assert!(vault.logged_in); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vault/vault.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | assert_eq!(vault.logged_in, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 327 - assert_eq!(vault.logged_in, false); [INFO] [stdout] 327 + assert!(!vault.logged_in); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:335:17 [INFO] [stdout] | [INFO] [stdout] 335 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:342:17 [INFO] [stdout] | [INFO] [stdout] 342 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:345:17 [INFO] [stdout] | [INFO] [stdout] 345 | assert!(!available_credentials.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `available_credentials.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:354:17 [INFO] [stdout] | [INFO] [stdout] 354 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:364:17 [INFO] [stdout] | [INFO] [stdout] 364 | assert!(!credentials.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `credentials.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vault/vault.rs:227:51 [INFO] [stdout] | [INFO] [stdout] 227 | .decrypt(oaep::Oaep::new::(), &pw) [INFO] [stdout] | ^^^ help: change this to: `pw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/vault/vault.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / match seedphrase_string { [INFO] [stdout] 240 | | Ok(seedphrase) => Some(seedphrase), [INFO] [stdout] 241 | | Err(_) => None, [INFO] [stdout] 242 | | } [INFO] [stdout] | |_________^ help: replace with: `seedphrase_string.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:379:17 [INFO] [stdout] | [INFO] [stdout] 379 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:404:17 [INFO] [stdout] | [INFO] [stdout] 404 | assert!(!decrypted_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decrypted_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/password_generator/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod password_generator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PasswordGenerator` [INFO] [stdout] --> src/password_generator/password_generator.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> PasswordGenerator { [INFO] [stdout] 9 | | PasswordGenerator { [INFO] [stdout] 10 | | generator: passwords::PasswordGenerator::new() [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for PasswordGenerator { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/password_generator/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod password_generator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PasswordGenerator` [INFO] [stdout] --> src/password_generator/password_generator.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> PasswordGenerator { [INFO] [stdout] 9 | | PasswordGenerator { [INFO] [stdout] 10 | | generator: passwords::PasswordGenerator::new() [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for PasswordGenerator { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vault` [INFO] [stdout] --> src/vault/vault.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | use crate::vault; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `write` [INFO] [stdout] --> src/vault/vault_errors.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{self, write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Zeroize` and `Zeroizing` [INFO] [stdout] --> src/vault/helper_functions.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use zeroize::{Zeroize, Zeroizing}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `password_generator::password_generator::PasswordGenerator` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use password_generator::password_generator::PasswordGenerator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `write` [INFO] [stdout] --> src/vault/vault_errors.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::{self, write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Zeroize` and `Zeroizing` [INFO] [stdout] --> src/vault/helper_functions.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use zeroize::{Zeroize, Zeroizing}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `password_generator::password_generator::PasswordGenerator` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use password_generator::password_generator::PasswordGenerator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/vault/vault.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha2::{Digest, Sha256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Digest` [INFO] [stdout] --> src/vault/vault.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha2::{Digest, Sha256}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `logout`, and `update_password` are never used [INFO] [stdout] --> src/vault/vault.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl Vault { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 27 | pub fn new() -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 125 | pub fn logout(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 174 | fn update_password() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PasswordGenerator` is never constructed [INFO] [stdout] --> src/password_generator/password_generator.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct PasswordGenerator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/password_generator/password_generator.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl PasswordGenerator{ [INFO] [stdout] | ---------------------- associated items in this implementation [INFO] [stdout] 8 | pub fn new() -> PasswordGenerator { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | pub fn generate_password(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn set_length(&mut self, length: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn toggle_numbers(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn toggle_symbols(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn toggle_uppercase(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn toggle_lowercase(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn toggle_spaces(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn toggle_similar(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn toggle_strict(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn print_settings(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/vault/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod vault; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(vault); [INFO] [stdout] 48 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(vault); [INFO] [stdout] 69 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vault/vault.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | let res = self.login_with_seedphrase(&seedphrase); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 121 | [INFO] [stdout] 122 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 | [INFO] [stdout] 122 ~ self.login_with_seedphrase(&seedphrase) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `update_password` are never used [INFO] [stdout] --> src/vault/vault.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | impl Vault { [INFO] [stdout] | ---------- associated functions in this implementation [INFO] [stdout] 27 | pub fn new() -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 174 | fn update_password() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vault/vault.rs:227:51 [INFO] [stdout] | [INFO] [stdout] 227 | .decrypt(oaep::Oaep::new::(), &pw) [INFO] [stdout] | ^^^ help: change this to: `pw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/vault/vault.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / match seedphrase_string { [INFO] [stdout] 240 | | Ok(seedphrase) => Some(seedphrase), [INFO] [stdout] 241 | | Err(_) => None, [INFO] [stdout] 242 | | } [INFO] [stdout] | |_________^ help: replace with: `seedphrase_string.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PasswordGenerator` is never constructed [INFO] [stdout] --> src/password_generator/password_generator.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct PasswordGenerator { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/password_generator/password_generator.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl PasswordGenerator{ [INFO] [stdout] | ---------------------- associated items in this implementation [INFO] [stdout] 8 | pub fn new() -> PasswordGenerator { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 14 | pub fn generate_password(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn set_length(&mut self, length: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | pub fn toggle_numbers(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn toggle_symbols(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn toggle_uppercase(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | pub fn toggle_lowercase(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn toggle_spaces(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn toggle_similar(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn toggle_strict(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn print_settings(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/vault/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod vault; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/vault/vault_errors.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | FailedToGenerateVaultError(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/vault/vault_errors.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum VaultError { [INFO] [stdout] 6 | | NotLoggedInError(String), [INFO] [stdout] 7 | | CredentialsMissingForServiceError(String), [INFO] [stdout] 8 | | FailedToLoginError(String), [INFO] [stdout] ... | [INFO] [stdout] 11 | | FailedToDecryptError(String), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(vault); [INFO] [stdout] 48 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vault/vault.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(vault); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(vault); [INFO] [stdout] 69 + Ok(vault) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vault/vault.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 120 | let res = self.login_with_seedphrase(&seedphrase); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 121 | [INFO] [stdout] 122 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 | [INFO] [stdout] 122 ~ self.login_with_seedphrase(&seedphrase) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/password_generator/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod password_generator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vault/vault.rs:227:51 [INFO] [stdout] | [INFO] [stdout] 227 | .decrypt(oaep::Oaep::new::(), &pw) [INFO] [stdout] | ^^^ help: change this to: `pw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/vault/vault.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / match seedphrase_string { [INFO] [stdout] 240 | | Ok(seedphrase) => Some(seedphrase), [INFO] [stdout] 241 | | Err(_) => None, [INFO] [stdout] 242 | | } [INFO] [stdout] | |_________^ help: replace with: `seedphrase_string.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:306:17 [INFO] [stdout] | [INFO] [stdout] 306 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:314:17 [INFO] [stdout] | [INFO] [stdout] 314 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vault/vault.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(vault.logged_in, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(vault.logged_in, true); [INFO] [stdout] 323 + assert!(vault.logged_in); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vault/vault.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | assert_eq!(vault.logged_in, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 327 - assert_eq!(vault.logged_in, false); [INFO] [stdout] 327 + assert!(!vault.logged_in); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:335:17 [INFO] [stdout] | [INFO] [stdout] 335 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:342:17 [INFO] [stdout] | [INFO] [stdout] 342 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:345:17 [INFO] [stdout] | [INFO] [stdout] 345 | assert!(!available_credentials.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `available_credentials.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:354:17 [INFO] [stdout] | [INFO] [stdout] 354 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:364:17 [INFO] [stdout] | [INFO] [stdout] 364 | assert!(!credentials.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `credentials.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | vault.get_available_credentials(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = vault.get_available_credentials(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 372 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:379:17 [INFO] [stdout] | [INFO] [stdout] 379 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:392:17 [INFO] [stdout] | [INFO] [stdout] 392 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:404:17 [INFO] [stdout] | [INFO] [stdout] 404 | assert!(!decrypted_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `decrypted_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | assert!(!res.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vault/vault.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | assert!(!add_password.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `add_password.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/vault/vault_errors.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | FailedToGenerateVaultError(String), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/vault/vault_errors.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum VaultError { [INFO] [stdout] 6 | | NotLoggedInError(String), [INFO] [stdout] 7 | | CredentialsMissingForServiceError(String), [INFO] [stdout] 8 | | FailedToLoginError(String), [INFO] [stdout] ... | [INFO] [stdout] 11 | | FailedToDecryptError(String), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/password_generator/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod password_generator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | vault.get_available_credentials(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = vault.get_available_credentials(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.56s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "bb4fd3cec41d7e5237f49f40a481c9bfc4d17fd7e1982d9f965c3ca9380a9f6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4fd3cec41d7e5237f49f40a481c9bfc4d17fd7e1982d9f965c3ca9380a9f6c", kill_on_drop: false }` [INFO] [stdout] bb4fd3cec41d7e5237f49f40a481c9bfc4d17fd7e1982d9f965c3ca9380a9f6c