[INFO] cloning repository https://github.com/suleman-mahmood/game-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/suleman-mahmood/game-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuleman-mahmood%2Fgame-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuleman-mahmood%2Fgame-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 189b48d5da8d2e837ac58ff0737dbfc92957ff9a [INFO] linting suleman-mahmood/game-engine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsuleman-mahmood%2Fgame-engine" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/suleman-mahmood/game-engine [INFO] finished tweaking git repo https://github.com/suleman-mahmood/game-engine [INFO] tweaked toml for git repo https://github.com/suleman-mahmood/game-engine written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/suleman-mahmood/game-engine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/suleman-mahmood/game-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cgmath v0.18.0 [INFO] [stderr] Downloaded wgpu-hal v26.0.4 [INFO] [stderr] Downloaded ordered-float v5.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29e1ee97609359630f489660c1d698d356428153dade3751fa49dcaee0beb5a6 [INFO] running `Command { std: "docker" "start" "-a" "29e1ee97609359630f489660c1d698d356428153dade3751fa49dcaee0beb5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29e1ee97609359630f489660c1d698d356428153dade3751fa49dcaee0beb5a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29e1ee97609359630f489660c1d698d356428153dade3751fa49dcaee0beb5a6", kill_on_drop: false }` [INFO] [stdout] 29e1ee97609359630f489660c1d698d356428153dade3751fa49dcaee0beb5a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1b7a4a557a33b148fb460cbd27351bcf60ceb442484ff114eca2088071cbaf0 [INFO] running `Command { std: "docker" "start" "-a" "d1b7a4a557a33b148fb460cbd27351bcf60ceb442484ff114eca2088071cbaf0", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.226 [INFO] [stderr] Compiling serde v1.0.226 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling naga v26.0.0 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling cc v1.2.38 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wgpu-hal v26.0.4 [INFO] [stderr] Checking unicode-ident v1.0.19 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking ordered-float v5.0.0 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Compiling wgpu-core v26.0.1 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling wgpu v26.0.1 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking tobj v4.0.3 [INFO] [stderr] Compiling engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> build.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / let mut paths_to_copy = Vec::new(); [INFO] [stdout] 12 | | paths_to_copy.push("res/"); [INFO] [stdout] | |_______________________________^ help: consider using the `vec![]` macro: `let paths_to_copy = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking wgpu-types v26.0.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v26.0.0 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texture.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / /// Rules: Minimum dependencies [INFO] [stdout] 39 | | [INFO] [stdout] | |_^ [INFO] [stdout] 40 | fn _game_loop() { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:533:54 [INFO] [stdout] | [INFO] [stdout] 533 | let position = cgmath::Vector3 { x: x, y: 0.0, z: z } - INSTANCE_DISPLACEMENT; [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:533:68 [INFO] [stdout] | [INFO] [stdout] 533 | let position = cgmath::Vector3 { x: x, y: 0.0, z: z } - INSTANCE_DISPLACEMENT; [INFO] [stdout] | ^^^^ help: replace it with: `z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:779:13 [INFO] [stdout] | [INFO] [stdout] 779 | format: format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `tobj::load_obj_buf_async`: load_obj_buf_async is not fully async. Use futures/tokio feature flags instead [INFO] [stdout] --> src/resources.rs:43:41 [INFO] [stdout] | [INFO] [stdout] 43 | let (models, obj_materials) = tobj::load_obj_buf_async( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texture.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / /// Rules: Minimum dependencies [INFO] [stdout] 39 | | [INFO] [stdout] | |_^ [INFO] [stdout] 40 | fn _game_loop() { [INFO] [stdout] | ------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:533:54 [INFO] [stdout] | [INFO] [stdout] 533 | let position = cgmath::Vector3 { x: x, y: 0.0, z: z } - INSTANCE_DISPLACEMENT; [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:533:68 [INFO] [stdout] | [INFO] [stdout] 533 | let position = cgmath::Vector3 { x: x, y: 0.0, z: z } - INSTANCE_DISPLACEMENT; [INFO] [stdout] | ^^^^ help: replace it with: `z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:779:13 [INFO] [stdout] | [INFO] [stdout] 779 | format: format, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `tobj::load_obj_buf_async`: load_obj_buf_async is not fully async. Use futures/tokio feature flags instead [INFO] [stdout] --> src/resources.rs:43:41 [INFO] [stdout] | [INFO] [stdout] 43 | let (models, obj_materials) = tobj::load_obj_buf_async( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `diffuse_texture`, and `normal_texture` are never read [INFO] [stdout] --> src/model.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 63 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 64 | pub diffuse_texture: texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub normal_texture: texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/model.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | pub struct Mesh { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 110 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `draw_mesh` and `draw_model` are never used [INFO] [stdout] --> src/model.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 117 | pub trait DrawModel<'a> { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] 118 | fn draw_mesh( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | fn draw_model( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_light_mesh` is never used [INFO] [stdout] --> src/model.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 208 | pub trait DrawLight<'a> { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 209 | fn draw_light_mesh( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture` is never read [INFO] [stdout] --> src/texture.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Texture { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 4 | pub texture: wgpu::Texture, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/hdr.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | view: &output, [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | texture::Texture::from_bytes(&device, &queue, &data, file_name, is_normal_map) [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:30:43 [INFO] [stdout] | [INFO] [stdout] 30 | texture::Texture::from_bytes(&device, &queue, &data, file_name, is_normal_map) [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | / if state.mouse_pressed { [INFO] [stdout] 161 | | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 159 ~ DeviceEvent::MouseMotion { delta } [INFO] [stdout] 160 ~ if state.mouse_pressed => { [INFO] [stdout] 161 | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 162 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / match event { [INFO] [stdout] 159 | | DeviceEvent::MouseMotion { delta } => { [INFO] [stdout] 160 | | if state.mouse_pressed { [INFO] [stdout] 161 | | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] ... | [INFO] [stdout] 164 | | _ => {} [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 ~ if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 159 + if state.mouse_pressed { [INFO] [stdout] 160 + state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 161 + } [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:738:1 [INFO] [stdout] | [INFO] [stdout] 738 | / fn create_render_pipeline( [INFO] [stdout] 739 | | label: &str, [INFO] [stdout] 740 | | device: &wgpu::Device, [INFO] [stdout] 741 | | layout: &wgpu::PipelineLayout, [INFO] [stdout] ... | [INFO] [stdout] 746 | | shader: wgpu::ShaderModuleDescriptor, [INFO] [stdout] 747 | | ) -> wgpu::RenderPipeline { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `diffuse_texture`, and `normal_texture` are never read [INFO] [stdout] --> src/model.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct Material { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 63 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 64 | pub diffuse_texture: texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub normal_texture: texture::Texture, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/model.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | pub struct Mesh { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 110 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `draw_mesh` and `draw_model` are never used [INFO] [stdout] --> src/model.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 117 | pub trait DrawModel<'a> { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] 118 | fn draw_mesh( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 134 | fn draw_model( [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_light_mesh` is never used [INFO] [stdout] --> src/model.rs:209:8 [INFO] [stdout] | [INFO] [stdout] 208 | pub trait DrawLight<'a> { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] 209 | fn draw_light_mesh( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture` is never read [INFO] [stdout] --> src/texture.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Texture { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 4 | pub texture: wgpu::Texture, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/hdr.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | view: &output, [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | texture::Texture::from_bytes(&device, &queue, &data, file_name, is_normal_map) [INFO] [stdout] | ^^^^^^^ help: change this to: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resources.rs:30:43 [INFO] [stdout] | [INFO] [stdout] 30 | texture::Texture::from_bytes(&device, &queue, &data, file_name, is_normal_map) [INFO] [stdout] | ^^^^^^ help: change this to: `queue` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:160:17 [INFO] [stdout] | [INFO] [stdout] 160 | / if state.mouse_pressed { [INFO] [stdout] 161 | | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 162 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 159 ~ DeviceEvent::MouseMotion { delta } [INFO] [stdout] 160 ~ if state.mouse_pressed => { [INFO] [stdout] 161 | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 162 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / match event { [INFO] [stdout] 159 | | DeviceEvent::MouseMotion { delta } => { [INFO] [stdout] 160 | | if state.mouse_pressed { [INFO] [stdout] 161 | | state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] ... | [INFO] [stdout] 164 | | _ => {} [INFO] [stdout] 165 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 ~ if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 159 + if state.mouse_pressed { [INFO] [stdout] 160 + state.camera_controller.handle_mouse(delta.0, delta.1) [INFO] [stdout] 161 + } [INFO] [stdout] 162 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:738:1 [INFO] [stdout] | [INFO] [stdout] 738 | / fn create_render_pipeline( [INFO] [stdout] 739 | | label: &str, [INFO] [stdout] 740 | | device: &wgpu::Device, [INFO] [stdout] 741 | | layout: &wgpu::PipelineLayout, [INFO] [stdout] ... | [INFO] [stdout] 746 | | shader: wgpu::ShaderModuleDescriptor, [INFO] [stdout] 747 | | ) -> wgpu::RenderPipeline { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `Command { std: "docker" "inspect" "d1b7a4a557a33b148fb460cbd27351bcf60ceb442484ff114eca2088071cbaf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1b7a4a557a33b148fb460cbd27351bcf60ceb442484ff114eca2088071cbaf0", kill_on_drop: false }` [INFO] [stdout] d1b7a4a557a33b148fb460cbd27351bcf60ceb442484ff114eca2088071cbaf0