[INFO] cloning repository https://github.com/subnomo/tumblr-likes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/subnomo/tumblr-likes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubnomo%2Ftumblr-likes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubnomo%2Ftumblr-likes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a7c778ccd9476e680087665d379eaf8bba9d521 [INFO] linting subnomo/tumblr-likes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubnomo%2Ftumblr-likes" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/subnomo/tumblr-likes [INFO] finished tweaking git repo https://github.com/subnomo/tumblr-likes [INFO] tweaked toml for git repo https://github.com/subnomo/tumblr-likes written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/subnomo/tumblr-likes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/subnomo/tumblr-likes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded once_cell v1.13.0 [INFO] [stderr] Downloaded tokio-macros v1.8.0 [INFO] [stderr] Downloaded unicode-ident v1.0.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.43 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.32 [INFO] [stderr] Downloaded smallvec v1.9.0 [INFO] [stderr] Downloaded itoa v1.0.3 [INFO] [stderr] Downloaded atty v0.2.11 [INFO] [stderr] Downloaded console v0.15.1 [INFO] [stderr] Downloaded slab v0.4.7 [INFO] [stderr] Downloaded redox_syscall v0.1.43 [INFO] [stderr] Downloaded indexmap v1.9.1 [INFO] [stderr] Downloaded tokio-util v0.7.3 [INFO] [stderr] Downloaded tracing v0.1.36 [INFO] [stderr] Downloaded openssl-sys v0.9.75 [INFO] [stderr] Downloaded unicode-normalization v0.1.21 [INFO] [stderr] Downloaded serde_json v1.0.83 [INFO] [stderr] Downloaded clap v3.2.17 [INFO] [stderr] Downloaded regex v1.6.0 [INFO] [stderr] Downloaded http v0.2.8 [INFO] [stderr] Downloaded reqwest v0.11.11 [INFO] [stderr] Downloaded wasm-bindgen v0.2.82 [INFO] [stderr] Downloaded syn v1.0.99 [INFO] [stderr] Downloaded js-sys v0.3.59 [INFO] [stderr] Downloaded openssl v0.10.41 [INFO] [stderr] Downloaded bumpalo v3.10.0 [INFO] [stderr] Downloaded serde v1.0.143 [INFO] [stderr] Downloaded tracing-core v0.1.29 [INFO] [stderr] Downloaded tokio v1.20.1 [INFO] [stderr] Downloaded libc v0.2.131 [INFO] [stderr] Downloaded cc v1.0.25 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.82 [INFO] [stderr] Downloaded serde_derive v1.0.143 [INFO] [stderr] Downloaded bytes v1.2.1 [INFO] [stderr] Downloaded mio v0.8.4 [INFO] [stderr] Downloaded os_str_bytes v6.2.0 [INFO] [stderr] Downloaded indicatif v0.17.0 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.82 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.82 [INFO] [stderr] Downloaded schannel v0.1.20 [INFO] [stderr] Downloaded ryu v1.0.11 [INFO] [stderr] Downloaded web-sys v0.3.59 [INFO] [stderr] Downloaded pkg-config v0.3.14 [INFO] [stderr] Downloaded hyper v0.14.20 [INFO] [stderr] Downloaded fastrand v1.8.0 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.82 [INFO] [stderr] Downloaded encoding_rs v0.8.13 [INFO] [stderr] Downloaded regex-syntax v0.6.27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f48d0041123f690e8df0e20bb5cec881a09bf9943c9f9a2f208dba17c0189af2 [INFO] running `Command { std: "docker" "start" "-a" "f48d0041123f690e8df0e20bb5cec881a09bf9943c9f9a2f208dba17c0189af2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f48d0041123f690e8df0e20bb5cec881a09bf9943c9f9a2f208dba17c0189af2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f48d0041123f690e8df0e20bb5cec881a09bf9943c9f9a2f208dba17c0189af2", kill_on_drop: false }` [INFO] [stdout] f48d0041123f690e8df0e20bb5cec881a09bf9943c9f9a2f208dba17c0189af2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22a93971e348366080e261a7d4c5edce100a4745f7c6a1a8fa837b4ddaa6f695 [INFO] running `Command { std: "docker" "start" "-a" "22a93971e348366080e261a7d4c5edce100a4745f7c6a1a8fa837b4ddaa6f695", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.131 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling encoding_rs v0.8.13 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking indicatif v0.17.0 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking clap v3.2.17 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.11 [INFO] [stderr] Checking tumblr-likes v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:306:24 [INFO] [stdout] | [INFO] [stdout] 306 | static HTML_TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:332:24 [INFO] [stdout] | [INFO] [stdout] 332 | static CARD_TEMPLATE: &'static str = "
[INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:306:24 [INFO] [stdout] | [INFO] [stdout] 306 | static HTML_TEMPLATE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:332:24 [INFO] [stdout] | [INFO] [stdout] 332 | static CARD_TEMPLATE: &'static str = "
[INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 84 | download_url(&client, url.clone(), file).await [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / return match raw { [INFO] [stdout] 115 | | Ok(p) => match p { [INFO] [stdout] 116 | | Some(path) => cb(path), [INFO] [stdout] 117 | | None => error_text.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 120 | | _ => error_text.to_string(), [INFO] [stdout] 121 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 ~ match raw { [INFO] [stdout] 115 + Ok(p) => match p { [INFO] [stdout] 116 + Some(path) => cb(path), [INFO] [stdout] 117 + None => error_text.to_string(), [INFO] [stdout] 118 + }, [INFO] [stdout] 119 + [INFO] [stdout] 120 + _ => error_text.to_string(), [INFO] [stdout] 121 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/util.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | Ok(p) => match p { [INFO] [stdout] | __________________^ [INFO] [stdout] 116 | | Some(path) => cb(path), [INFO] [stdout] 117 | | None => error_text.to_string(), [INFO] [stdout] 118 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/util.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | Ok(p) => match p { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 116 | Some(path) => cb(path), [INFO] [stdout] | ^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | if !env_key.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `env_key.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `env_key` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 89 | if !env_key.is_err() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 90 | env_key.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:8 [INFO] [stdout] | [INFO] [stdout] 122 | if !args.restore.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.restore.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if !args.dump.is_none() || !args.export.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.dump.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:187:40 [INFO] [stdout] | [INFO] [stdout] 187 | if !args.dump.is_none() || !args.export.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.export.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:42 [INFO] [stdout] | [INFO] [stdout] 252 | post_files.push(download(&client, &args, "videos", url).await?); [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:51 [INFO] [stdout] | [INFO] [stdout] 252 | post_files.push(download(&client, &args, "videos", url).await?); [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | / for file in post { [INFO] [stdout] 266 | | if let Some(file) = file { [INFO] [stdout] 267 | | let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 276 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | / if let Some(file) = file { [INFO] [stdout] 267 | | let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] 268 | | [INFO] [stdout] 269 | | let mut new_file = file.clone(); [INFO] [stdout] ... | [INFO] [stdout] 274 | | }); [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 ~ for file in post.iter().flatten() { [INFO] [stdout] 266 + let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] 267 + [INFO] [stdout] 268 + let mut new_file = file.clone(); [INFO] [stdout] 269 + new_file.set_file_name(format!("{} - {}", i + 1, filename)); [INFO] [stdout] 270 + [INFO] [stdout] 271 + fs::rename(&file, new_file).unwrap_or_else(|e| { [INFO] [stdout] 272 + panic!("Could not rename file! Error: {}", e); [INFO] [stdout] 273 + }); [INFO] [stdout] 274 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:272:28 [INFO] [stdout] | [INFO] [stdout] 272 | fs::rename(&file, new_file).unwrap_or_else(|e| { [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:284:39 [INFO] [stdout] | [INFO] [stdout] 284 | let mut file = match File::create(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 372 | if post.tags.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!post.tags.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:390:26 [INFO] [stdout] | [INFO] [stdout] 390 | let re = Regex::new(r#"src="([^"]+)"#).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:368:5 [INFO] [stdout] | [INFO] [stdout] 368 | for post in posts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:400:38 [INFO] [stdout] | [INFO] [stdout] 400 | download_url(&client, url.clone(), format!("export/{}", filename)).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:426:38 [INFO] [stdout] | [INFO] [stdout] 426 | download_url(&client, url.clone(), format!("export/{}", filename)).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:461:47 [INFO] [stdout] | [INFO] [stdout] 461 | let dl = download_url(&client, url.clone(), format!("export/{}", filename)) [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:496:39 [INFO] [stdout] | [INFO] [stdout] 496 | let mut file = match File::create(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 84 | download_url(&client, url.clone(), file).await [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / return match raw { [INFO] [stdout] 115 | | Ok(p) => match p { [INFO] [stdout] 116 | | Some(path) => cb(path), [INFO] [stdout] 117 | | None => error_text.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 120 | | _ => error_text.to_string(), [INFO] [stdout] 121 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 ~ match raw { [INFO] [stdout] 115 + Ok(p) => match p { [INFO] [stdout] 116 + Some(path) => cb(path), [INFO] [stdout] 117 + None => error_text.to_string(), [INFO] [stdout] 118 + }, [INFO] [stdout] 119 + [INFO] [stdout] 120 + _ => error_text.to_string(), [INFO] [stdout] 121 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/util.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | Ok(p) => match p { [INFO] [stdout] | __________________^ [INFO] [stdout] 116 | | Some(path) => cb(path), [INFO] [stdout] 117 | | None => error_text.to_string(), [INFO] [stdout] 118 | | }, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/util.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 115 | Ok(p) => match p { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 116 | Some(path) => cb(path), [INFO] [stdout] | ^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | if !env_key.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `env_key.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `env_key` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 89 | if !env_key.is_err() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 90 | env_key.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:122:8 [INFO] [stdout] | [INFO] [stdout] 122 | if !args.restore.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.restore.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if !args.dump.is_none() || !args.export.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `args.dump.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:187:40 [INFO] [stdout] | [INFO] [stdout] 187 | if !args.dump.is_none() || !args.export.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.export.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:42 [INFO] [stdout] | [INFO] [stdout] 252 | post_files.push(download(&client, &args, "videos", url).await?); [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:51 [INFO] [stdout] | [INFO] [stdout] 252 | post_files.push(download(&client, &args, "videos", url).await?); [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:265:9 [INFO] [stdout] | [INFO] [stdout] 265 | / for file in post { [INFO] [stdout] 266 | | if let Some(file) = file { [INFO] [stdout] 267 | | let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 276 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | / if let Some(file) = file { [INFO] [stdout] 267 | | let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] 268 | | [INFO] [stdout] 269 | | let mut new_file = file.clone(); [INFO] [stdout] ... | [INFO] [stdout] 274 | | }); [INFO] [stdout] 275 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 265 ~ for file in post.iter().flatten() { [INFO] [stdout] 266 + let filename = &file.file_name().unwrap().to_str().unwrap(); [INFO] [stdout] 267 + [INFO] [stdout] 268 + let mut new_file = file.clone(); [INFO] [stdout] 269 + new_file.set_file_name(format!("{} - {}", i + 1, filename)); [INFO] [stdout] 270 + [INFO] [stdout] 271 + fs::rename(&file, new_file).unwrap_or_else(|e| { [INFO] [stdout] 272 + panic!("Could not rename file! Error: {}", e); [INFO] [stdout] 273 + }); [INFO] [stdout] 274 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:272:28 [INFO] [stdout] | [INFO] [stdout] 272 | fs::rename(&file, new_file).unwrap_or_else(|e| { [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:284:39 [INFO] [stdout] | [INFO] [stdout] 284 | let mut file = match File::create(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 372 | if post.tags.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!post.tags.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:390:26 [INFO] [stdout] | [INFO] [stdout] 390 | let re = Regex::new(r#"src="([^"]+)"#).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:368:5 [INFO] [stdout] | [INFO] [stdout] 368 | for post in posts { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:400:38 [INFO] [stdout] | [INFO] [stdout] 400 | download_url(&client, url.clone(), format!("export/{}", filename)).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:426:38 [INFO] [stdout] | [INFO] [stdout] 426 | download_url(&client, url.clone(), format!("export/{}", filename)).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:461:47 [INFO] [stdout] | [INFO] [stdout] 461 | let dl = download_url(&client, url.clone(), format!("export/{}", filename)) [INFO] [stdout] | ^^^^^^^ help: change this to: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:496:39 [INFO] [stdout] | [INFO] [stdout] 496 | let mut file = match File::create(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.10s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "22a93971e348366080e261a7d4c5edce100a4745f7c6a1a8fa837b4ddaa6f695", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22a93971e348366080e261a7d4c5edce100a4745f7c6a1a8fa837b4ddaa6f695", kill_on_drop: false }` [INFO] [stdout] 22a93971e348366080e261a7d4c5edce100a4745f7c6a1a8fa837b4ddaa6f695