[INFO] cloning repository https://github.com/subhdotsol/strslice
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/subhdotsol/strslice" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubhdotsol%2Fstrslice", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubhdotsol%2Fstrslice'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] a2ef2fd81e48602b9f8514c934a301fd52739ef5
[INFO] linting subhdotsol/strslice against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsubhdotsol%2Fstrslice" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/subhdotsol/strslice
[INFO] finished tweaking git repo https://github.com/subhdotsol/strslice
[INFO] tweaked toml for git repo https://github.com/subhdotsol/strslice written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/subhdotsol/strslice on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/subhdotsol/strslice already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] fa46783a4f7f6e7e827494281fb34690bf640b9466c02d8e5b6af02485c42455
[INFO] running `Command { std: "docker" "start" "-a" "fa46783a4f7f6e7e827494281fb34690bf640b9466c02d8e5b6af02485c42455", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "fa46783a4f7f6e7e827494281fb34690bf640b9466c02d8e5b6af02485c42455", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "fa46783a4f7f6e7e827494281fb34690bf640b9466c02d8e5b6af02485c42455", kill_on_drop: false }`
[INFO] [stdout] fa46783a4f7f6e7e827494281fb34690bf640b9466c02d8e5b6af02485c42455
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] b7db9f17752dfaf6d0534b852889d002855fafb9459d880c9f56d67fb90b0141
[INFO] running `Command { std: "docker" "start" "-a" "b7db9f17752dfaf6d0534b852889d002855fafb9459d880c9f56d67fb90b0141", kill_on_drop: false }`
[INFO] [stderr]     Checking strslice v0.1.4 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/str_matches.rs:36:17
[INFO] [stdout]    |
[INFO] [stdout] 36 |                 return Some(&self.text[match_start..match_end]);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -                 return Some(&self.text[match_start..match_end]);
[INFO] [stdout] 36 +                 Some(&self.text[match_start..match_end])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/str_matches.rs:39:17
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 return None;
[INFO] [stdout]    |                 ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -                 return None;
[INFO] [stdout] 39 +                 None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 | |                     || (c == '!' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 -                     || (c == '!' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<' && c != '>' && c != '!')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 -                     || (c == '!' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '!' || c == '>' || c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<' && c != '>')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '>' || c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/str_tokenize.rs:126:13
[INFO] [stdout]     |
[INFO] [stdout] 126 | /             if let Some((j, ch)) = chars.next() {
[INFO] [stdout] 127 | |                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout] ...   |
[INFO] [stdout] 136 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 126 ~             if let Some((j, ch)) = chars.next()
[INFO] [stdout] 127 ~                 && ((c == '=' && ch == '=')
[INFO] [stdout] 128 |                     || (c == '<' && ch == '=')
[INFO] [stdout] ...
[INFO] [stdout] 131 |                     || (c == '&' && ch == '&')
[INFO] [stdout] 132 ~                     || (c == '|' && ch == '|'))
[INFO] [stdout] 133 |                 {
[INFO] [stdout] 134 |                     end = j + ch.len_utf8();
[INFO] [stdout] 135 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/str_matches.rs:36:17
[INFO] [stdout]    |
[INFO] [stdout] 36 |                 return Some(&self.text[match_start..match_end]);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 36 -                 return Some(&self.text[match_start..match_end]);
[INFO] [stdout] 36 +                 Some(&self.text[match_start..match_end])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/str_matches.rs:39:17
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 return None;
[INFO] [stdout]    |                 ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -                 return None;
[INFO] [stdout] 39 +                 None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 | |                     || (c == '!' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 -                     || (c == '!' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<' && c != '>' && c != '!')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 130 -                     || (c == '!' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '!' || c == '>' || c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<' && c != '>')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 -                     || (c == '>' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '>' || c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/str_tokenize.rs:127:20
[INFO] [stdout]     |
[INFO] [stdout] 127 |                   if (c == '=' && ch == '=')
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout]     | |______________________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 127 +                 if !(ch != '=' || c != '=' && c != '<')
[INFO] [stdout]     |
[INFO] [stdout] 127 -                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 -                     || (c == '<' && ch == '=')
[INFO] [stdout] 127 +                 if (c == '<' || c == '=') && ch == '='
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/str_tokenize.rs:126:13
[INFO] [stdout]     |
[INFO] [stdout] 126 | /             if let Some((j, ch)) = chars.next() {
[INFO] [stdout] 127 | |                 if (c == '=' && ch == '=')
[INFO] [stdout] 128 | |                     || (c == '<' && ch == '=')
[INFO] [stdout] 129 | |                     || (c == '>' && ch == '=')
[INFO] [stdout] ...   |
[INFO] [stdout] 136 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 126 ~             if let Some((j, ch)) = chars.next()
[INFO] [stdout] 127 ~                 && ((c == '=' && ch == '=')
[INFO] [stdout] 128 |                     || (c == '<' && ch == '=')
[INFO] [stdout] ...
[INFO] [stdout] 131 |                     || (c == '&' && ch == '&')
[INFO] [stdout] 132 ~                     || (c == '|' && ch == '|'))
[INFO] [stdout] 133 |                 {
[INFO] [stdout] 134 |                     end = j + ch.len_utf8();
[INFO] [stdout] 135 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s
[INFO] running `Command { std: "docker" "inspect" "b7db9f17752dfaf6d0534b852889d002855fafb9459d880c9f56d67fb90b0141", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b7db9f17752dfaf6d0534b852889d002855fafb9459d880c9f56d67fb90b0141", kill_on_drop: false }`
[INFO] [stdout] b7db9f17752dfaf6d0534b852889d002855fafb9459d880c9f56d67fb90b0141