[INFO] cloning repository https://github.com/storyfeet/cardito [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/storyfeet/cardito" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstoryfeet%2Fcardito", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstoryfeet%2Fcardito'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 729fed604d658ee85b66f6ded65f163722a404ef [INFO] linting storyfeet/cardito against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstoryfeet%2Fcardito" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/storyfeet/cardito [INFO] finished tweaking git repo https://github.com/storyfeet/cardito [INFO] tweaked toml for git repo https://github.com/storyfeet/cardito written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/storyfeet/cardito on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/storyfeet/cardito already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded iter_tools v0.24.0 [INFO] [stderr] Downloaded tokenate v0.1.0 [INFO] [stderr] Downloaded gobble v0.6.3 [INFO] [stderr] Downloaded textwrap v0.16.1 [INFO] [stderr] Downloaded bytemuck v1.20.0 [INFO] [stderr] Downloaded deflate v0.8.6 [INFO] [stderr] Downloaded pulldown-cmark v0.7.2 [INFO] [stderr] Downloaded png v0.16.8 [INFO] [stderr] Downloaded syn v2.0.89 [INFO] [stderr] Downloaded serde_derive v1.0.215 [INFO] [stderr] Downloaded miniz_oxide v0.3.7 [INFO] [stderr] Downloaded templito v0.4.9 [INFO] [stderr] Downloaded scoped_threadpool v0.1.9 [INFO] [stderr] Downloaded libc v0.2.165 [INFO] [stderr] Downloaded cc v1.2.1 [INFO] [stderr] Downloaded unicase v2.8.0 [INFO] [stderr] Downloaded serde v1.0.215 [INFO] [stderr] Downloaded card_format v0.2.1 [INFO] [stderr] Downloaded err_tools v0.1.1 [INFO] [stderr] Downloaded imagesize v0.8.8 [INFO] [stderr] Downloaded clone_dyn_types v0.26.0 [INFO] [stderr] Downloaded jpeg-decoder v0.1.22 [INFO] [stderr] Downloaded image v0.23.14 [INFO] [stderr] Downloaded gif v0.11.4 [INFO] [stderr] Downloaded tiff v0.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f11404d5bc2f04f93d58fc44fb45c685044b6b0c2130c3b65555d11280c05ca3 [INFO] running `Command { std: "docker" "start" "-a" "f11404d5bc2f04f93d58fc44fb45c685044b6b0c2130c3b65555d11280c05ca3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f11404d5bc2f04f93d58fc44fb45c685044b6b0c2130c3b65555d11280c05ca3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f11404d5bc2f04f93d58fc44fb45c685044b6b0c2130c3b65555d11280c05ca3", kill_on_drop: false }` [INFO] [stdout] f11404d5bc2f04f93d58fc44fb45c685044b6b0c2130c3b65555d11280c05ca3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de69c606fe98bf986096e906ac418b84217507a059bfef6bad52dd466da265e3 [INFO] running `Command { std: "docker" "start" "-a" "de69c606fe98bf986096e906ac418b84217507a059bfef6bad52dd466da265e3", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.165 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling pulldown-cmark v0.7.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking tokenate v0.1.0 [INFO] [stderr] Checking clone_dyn_types v0.26.0 [INFO] [stderr] Checking bytemuck v1.20.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking unicase v2.8.0 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking imagesize v0.8.8 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking iter_tools v0.24.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking err_tools v0.1.1 [INFO] [stderr] Checking gobble v0.6.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking card_format v0.2.1 [INFO] [stderr] Checking templito v0.4.9 [INFO] [stderr] Checking cardito v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/templates.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | pub const PAGE_TEMPLATE: &'static str = r##" [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/templates.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub const CARD_WRAP: &'static str = r##"{{let u = first .units "mm"}} [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/templates.rs:1:27 [INFO] [stdout] | [INFO] [stdout] 1 | pub const PAGE_TEMPLATE: &'static str = r##" [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/templates.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 14 | pub const CARD_WRAP: &'static str = r##"{{let u = first .units "mm"}} [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::result::Result` [INFO] [stdout] --> src/build_config.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | None => return e_str("for --vars keys must have values").into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `e_str("for --vars keys must have values")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/imports.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | return err_tools::e_str("Can only import string and lists of templates"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return err_tools::e_str("Can only import string and lists of templates"); [INFO] [stdout] 16 + err_tools::e_str("Can only import string and lists of templates") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/imports.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | / for x in dir { [INFO] [stdout] 59 | | if let Ok(f) = x { [INFO] [stdout] 60 | | self.stack.push(f.path()); [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/imports.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | / if let Ok(f) = x { [INFO] [stdout] 60 | | self.stack.push(f.path()); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ for f in dir.flatten() { [INFO] [stdout] 59 + self.stack.push(f.path()); [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cards.get(0)` [INFO] [stdout] --> src/spread.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let n = cards.get(0).map(|c| c.num).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cards.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/template_set.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let page = tman.get("page").map(|c| c.clone()).unwrap_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `tman.get("page").cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/template_set.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | let card_wrap = tman.get("card_wrap").map(|c| c.clone()).unwrap_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `tman.get("card_wrap").cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:106:67 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some(tset) = TemplateSet::try_new("front", &bc.config, &mut bc.tman)? { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 106 - if let Some(tset) = TemplateSet::try_new("front", &bc.config, &mut bc.tman)? { [INFO] [stdout] 106 + if let Some(tset) = TemplateSet::try_new("front", &bc.config, &bc.tman)? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(tset) = TemplateSet::try_new("back", &bc.config, &mut bc.tman)? { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 112 - if let Some(tset) = TemplateSet::try_new("back", &bc.config, &mut bc.tman)? { [INFO] [stdout] 112 + if let Some(tset) = TemplateSet::try_new("back", &bc.config, &bc.tman)? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:159:8 [INFO] [stdout] | [INFO] [stdout] 159 | if !std::fs::metadata(&card_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&card_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::result::Result` [INFO] [stdout] --> src/build_config.rs:64:36 [INFO] [stdout] | [INFO] [stdout] 64 | None => return e_str("for --vars keys must have values").into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `e_str("for --vars keys must have values")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/imports.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | return err_tools::e_str("Can only import string and lists of templates"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return err_tools::e_str("Can only import string and lists of templates"); [INFO] [stdout] 16 + err_tools::e_str("Can only import string and lists of templates") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/imports.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | / for x in dir { [INFO] [stdout] 59 | | if let Ok(f) = x { [INFO] [stdout] 60 | | self.stack.push(f.path()); [INFO] [stdout] 61 | | } [INFO] [stdout] 62 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/imports.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | / if let Ok(f) = x { [INFO] [stdout] 60 | | self.stack.push(f.path()); [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ for f in dir.flatten() { [INFO] [stdout] 59 + self.stack.push(f.path()); [INFO] [stdout] 60 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cards.get(0)` [INFO] [stdout] --> src/spread.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | let n = cards.get(0).map(|c| c.num).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `cards.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/template_set.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let page = tman.get("page").map(|c| c.clone()).unwrap_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `tman.get("page").cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/template_set.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | let card_wrap = tman.get("card_wrap").map(|c| c.clone()).unwrap_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `tman.get("card_wrap").cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:106:67 [INFO] [stdout] | [INFO] [stdout] 106 | if let Some(tset) = TemplateSet::try_new("front", &bc.config, &mut bc.tman)? { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 106 - if let Some(tset) = TemplateSet::try_new("front", &bc.config, &mut bc.tman)? { [INFO] [stdout] 106 + if let Some(tset) = TemplateSet::try_new("front", &bc.config, &bc.tman)? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:112:66 [INFO] [stdout] | [INFO] [stdout] 112 | if let Some(tset) = TemplateSet::try_new("back", &bc.config, &mut bc.tman)? { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 112 - if let Some(tset) = TemplateSet::try_new("back", &bc.config, &mut bc.tman)? { [INFO] [stdout] 112 + if let Some(tset) = TemplateSet::try_new("back", &bc.config, &bc.tman)? { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:159:8 [INFO] [stdout] | [INFO] [stdout] 159 | if !std::fs::metadata(&card_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&card_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.05s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: gobble v0.6.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "de69c606fe98bf986096e906ac418b84217507a059bfef6bad52dd466da265e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de69c606fe98bf986096e906ac418b84217507a059bfef6bad52dd466da265e3", kill_on_drop: false }` [INFO] [stdout] de69c606fe98bf986096e906ac418b84217507a059bfef6bad52dd466da265e3