[INFO] cloning repository https://github.com/stonarini/mustash [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stonarini/mustash" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstonarini%2Fmustash", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstonarini%2Fmustash'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 964fa96bc8d77451163fc7b41cac8794a5e1d956 [INFO] linting stonarini/mustash against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstonarini%2Fmustash" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/stonarini/mustash [INFO] finished tweaking git repo https://github.com/stonarini/mustash [INFO] tweaked toml for git repo https://github.com/stonarini/mustash written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/stonarini/mustash on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/stonarini/mustash already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4dcd1ba474ef3710443c771e85ea29e2415e5a8027e9b69a7878b740e46765af [INFO] running `Command { std: "docker" "start" "-a" "4dcd1ba474ef3710443c771e85ea29e2415e5a8027e9b69a7878b740e46765af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4dcd1ba474ef3710443c771e85ea29e2415e5a8027e9b69a7878b740e46765af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4dcd1ba474ef3710443c771e85ea29e2415e5a8027e9b69a7878b740e46765af", kill_on_drop: false }` [INFO] [stdout] 4dcd1ba474ef3710443c771e85ea29e2415e5a8027e9b69a7878b740e46765af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c87861985a825ee53ac6ca166c9ec6142c522a2f15d818d5a2ce3375aacc42b [INFO] running `Command { std: "docker" "start" "-a" "0c87861985a825ee53ac6ca166c9ec6142c522a2f15d818d5a2ce3375aacc42b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_builder v4.5.42 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking mustash_macros v0.1.0 (/opt/rustwide/workdir/mustash_macros) [INFO] [stderr] Checking cli_macros v0.1.0 (/opt/rustwide/workdir/cli_macros) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> cli_macros/src/lib.rs:35:37 [INFO] [stdout] | [INFO] [stdout] 35 | if clicommand_name.is_none() && !command_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> cli_macros/src/lib.rs:35:37 [INFO] [stdout] | [INFO] [stdout] 35 | if clicommand_name.is_none() && !command_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> cli_macros/src/lib.rs:35:37 [INFO] [stdout] | [INFO] [stdout] 35 | if clicommand_name.is_none() && !command_name.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_name.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking mustash_core v0.1.0 (/opt/rustwide/workdir/crates/mustash_core) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Dispatcher` [INFO] [stdout] --> crates/mustash_core/src/dispatcher.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Dispatcher [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for Dispatcher { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Dispatcher` [INFO] [stdout] --> crates/mustash_core/src/dispatcher.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Dispatcher [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for Dispatcher { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> crates/mustash_core/tests/integration.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use mustash_core; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v4.5.42 [INFO] [stderr] Checking cli v0.1.0 (/opt/rustwide/workdir/crates/cli) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> crates/cli/tests/integration.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | .args(&["test", "hello"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["test", "hello"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.34s [INFO] running `Command { std: "docker" "inspect" "0c87861985a825ee53ac6ca166c9ec6142c522a2f15d818d5a2ce3375aacc42b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c87861985a825ee53ac6ca166c9ec6142c522a2f15d818d5a2ce3375aacc42b", kill_on_drop: false }` [INFO] [stdout] 0c87861985a825ee53ac6ca166c9ec6142c522a2f15d818d5a2ce3375aacc42b