[INFO] cloning repository https://github.com/stinkymonkeyph/oxide-arbiter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stinkymonkeyph/oxide-arbiter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstinkymonkeyph%2Foxide-arbiter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstinkymonkeyph%2Foxide-arbiter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f3cfeb43e248d6a9a32e6b32d650bd9af51b61a [INFO] linting stinkymonkeyph/oxide-arbiter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstinkymonkeyph%2Foxide-arbiter" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/stinkymonkeyph/oxide-arbiter [INFO] finished tweaking git repo https://github.com/stinkymonkeyph/oxide-arbiter [INFO] tweaked toml for git repo https://github.com/stinkymonkeyph/oxide-arbiter written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/stinkymonkeyph/oxide-arbiter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/stinkymonkeyph/oxide-arbiter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 363e0ea53cab64bcff5c2ae9655f64a7666475cf8d1d74e8b731a98e3cfa553b [INFO] running `Command { std: "docker" "start" "-a" "363e0ea53cab64bcff5c2ae9655f64a7666475cf8d1d74e8b731a98e3cfa553b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "363e0ea53cab64bcff5c2ae9655f64a7666475cf8d1d74e8b731a98e3cfa553b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "363e0ea53cab64bcff5c2ae9655f64a7666475cf8d1d74e8b731a98e3cfa553b", kill_on_drop: false }` [INFO] [stdout] 363e0ea53cab64bcff5c2ae9655f64a7666475cf8d1d74e8b731a98e3cfa553b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 155337328bc38f79050d925472cda9e34221cd9cec348d62302b51a2dbc1b1ee [INFO] running `Command { std: "docker" "start" "-a" "155337328bc38f79050d925472cda9e34221cd9cec348d62302b51a2dbc1b1ee", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking oxide-arbiter v0.2.0-beta.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrderBookService` [INFO] [stdout] --> src/components/services.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | OrderBookService { [INFO] [stdout] 24 | | orders: Default::default(), [INFO] [stdout] 25 | | buy_orders: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for OrderBookService { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/services.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | if !resting_order.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resting_order.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/components/services.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 360 | if trades.len() > 0 && matches!(incoming_order.time_in_force, TimeInForce::IOC) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trades.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> examples/basic_usage.rs:25:34 [INFO] [stdout] | [INFO] [stdout] 25 | for (_, order_book_order) in order_book.get_orders() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 25 - for (_, order_book_order) in order_book.get_orders() { [INFO] [stdout] 25 + for order_book_order in order_book.get_orders().values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrderBookService` [INFO] [stdout] --> src/components/services.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | OrderBookService { [INFO] [stdout] 24 | | orders: Default::default(), [INFO] [stdout] 25 | | buy_orders: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 21 + impl Default for OrderBookService { [INFO] [stdout] 22 + fn default() -> Self { [INFO] [stdout] 23 + Self::new() [INFO] [stdout] 24 + } [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/services.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | if !resting_order.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resting_order.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/components/services.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 360 | if trades.len() > 0 && matches!(incoming_order.time_in_force, TimeInForce::IOC) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trades.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(matches!(order.order_side, OrderSide::Buy), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(matches!(order.order_side, OrderSide::Buy), true); [INFO] [stdout] 25 + assert!(matches!(order.order_side, OrderSide::Buy)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(matches!(order.status, OrderStatus::Open), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(matches!(order.status, OrderStatus::Open), true); [INFO] [stdout] 26 + assert!(matches!(order.status, OrderStatus::Open)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / assert_eq!( [INFO] [stdout] 63 | | matches!(updated_order.unwrap().status, OrderStatus::Closed), [INFO] [stdout] 64 | | true [INFO] [stdout] 65 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 62 ~ assert!( [INFO] [stdout] 63 ~ matches!(updated_order.unwrap().status, OrderStatus::Closed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | / assert_eq!( [INFO] [stdout] 150 | | matches!(fetched_buy_order.status, OrderStatus::PartiallyFilled), [INFO] [stdout] 151 | | true [INFO] [stdout] 152 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 149 ~ assert!( [INFO] [stdout] 150 ~ matches!(fetched_buy_order.status, OrderStatus::PartiallyFilled) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / assert_eq!( [INFO] [stdout] 154 | | matches!(fetched_sell_order.status, OrderStatus::Closed), [INFO] [stdout] 155 | | true [INFO] [stdout] 156 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 153 ~ assert!( [INFO] [stdout] 154 ~ matches!(fetched_sell_order.status, OrderStatus::Closed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | / assert_eq!( [INFO] [stdout] 198 | | matches!(fetched_buy_order.status, OrderStatus::Closed), [INFO] [stdout] 199 | | true [INFO] [stdout] 200 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 197 ~ assert!( [INFO] [stdout] 198 ~ matches!(fetched_buy_order.status, OrderStatus::Closed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | / assert_eq!( [INFO] [stdout] 202 | | matches!(fetched_sell_order.status, OrderStatus::Closed), [INFO] [stdout] 203 | | true [INFO] [stdout] 204 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 201 ~ assert!( [INFO] [stdout] 202 ~ matches!(fetched_sell_order.status, OrderStatus::Closed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | assert_eq!(matches!(fetched_buy_order.status, OrderStatus::Open), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 323 - assert_eq!(matches!(fetched_buy_order.status, OrderStatus::Open), true); [INFO] [stdout] 323 + assert!(matches!(fetched_buy_order.status, OrderStatus::Open)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | assert_eq!(matches!(fetched_sell_order.status, OrderStatus::Open), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 324 - assert_eq!(matches!(fetched_sell_order.status, OrderStatus::Open), true); [INFO] [stdout] 324 + assert!(matches!(fetched_sell_order.status, OrderStatus::Open)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/components/services_test.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | assert_eq!(matches!(buy_ioc_order.status, OrderStatus::Closed), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 415 - assert_eq!(matches!(buy_ioc_order.status, OrderStatus::Closed), true); [INFO] [stdout] 415 + assert!(matches!(buy_ioc_order.status, OrderStatus::Closed)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.81s [INFO] running `Command { std: "docker" "inspect" "155337328bc38f79050d925472cda9e34221cd9cec348d62302b51a2dbc1b1ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "155337328bc38f79050d925472cda9e34221cd9cec348d62302b51a2dbc1b1ee", kill_on_drop: false }` [INFO] [stdout] 155337328bc38f79050d925472cda9e34221cd9cec348d62302b51a2dbc1b1ee