[INFO] cloning repository https://github.com/sthoni/muell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sthoni/muell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsthoni%2Fmuell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsthoni%2Fmuell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1c36bdeeaffb53dca15fecbc68f04fc7af039808 [INFO] linting sthoni/muell against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsthoni%2Fmuell" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sthoni/muell [INFO] finished tweaking git repo https://github.com/sthoni/muell [INFO] tweaked toml for git repo https://github.com/sthoni/muell written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sthoni/muell on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sthoni/muell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quad-rand v0.2.1 [INFO] [stderr] Downloaded ogg v0.7.1 [INFO] [stderr] Downloaded quad-alsa-sys v0.3.2 [INFO] [stderr] Downloaded macroquad_macro v0.1.7 [INFO] [stderr] Downloaded audir-sles v0.1.0 [INFO] [stderr] Downloaded audrey v0.3.0 [INFO] [stderr] Downloaded lewton v0.9.4 [INFO] [stderr] Downloaded ttf-parser v0.12.3 [INFO] [stderr] Downloaded glam v0.14.0 [INFO] [stderr] Downloaded fontdue v0.5.2 [INFO] [stderr] Downloaded miniquad v0.3.7 [INFO] [stderr] Downloaded macroquad v0.3.19 [INFO] [stderr] Downloaded quad-snd v0.2.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf48998b60916deb55c5ab50e1c955efb602db130e7f7dbc4b08f55a468dabde [INFO] running `Command { std: "docker" "start" "-a" "bf48998b60916deb55c5ab50e1c955efb602db130e7f7dbc4b08f55a468dabde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf48998b60916deb55c5ab50e1c955efb602db130e7f7dbc4b08f55a468dabde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf48998b60916deb55c5ab50e1c955efb602db130e7f7dbc4b08f55a468dabde", kill_on_drop: false }` [INFO] [stdout] bf48998b60916deb55c5ab50e1c955efb602db130e7f7dbc4b08f55a468dabde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0c7b2cd18e347780be69506e5393c7ebf898ce89d3639ca1334a7aee9241322 [INFO] running `Command { std: "docker" "start" "-a" "b0c7b2cd18e347780be69506e5393c7ebf898ce89d3639ca1334a7aee9241322", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling quad-alsa-sys v0.3.2 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Compiling miniquad v0.3.7 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Compiling quad-snd v0.2.3 [INFO] [stderr] Checking bytemuck v1.9.1 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Checking ttf-parser v0.12.3 [INFO] [stderr] Checking glam v0.14.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling macroquad_macro v0.1.7 [INFO] [stderr] Checking bumpalo v3.10.0 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking quad-rand v0.2.1 [INFO] [stderr] Checking dasp_frame v0.11.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking fontdue v0.5.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking audrey v0.3.0 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking macroquad v0.3.19 [INFO] [stderr] Checking muell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:101:47 [INFO] [stdout] | [INFO] [stdout] 101 | if is_key_down(KeyCode::Right) && !(player.koord.0 + 2 > GRID_CELLS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.0 + 2 <= GRID_CELLS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | } else if is_key_down(KeyCode::Left) && !(player.koord.0 < 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.0 >= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:105:51 [INFO] [stdout] | [INFO] [stdout] 105 | } else if is_key_down(KeyCode::Up) && !(player.koord.1 < 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.1 >= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:107:53 [INFO] [stdout] | [INFO] [stdout] 107 | } else if is_key_down(KeyCode::Down) && !(player.koord.1 + 2 > GRID_CELLS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.1 + 2 <= GRID_CELLS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | fn is_on_muell(muells: &Vec, b: &Bewohner) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 - fn is_on_muell(muells: &Vec, b: &Bewohner) -> bool { [INFO] [stdout] 154 + fn is_on_muell(muells: &[Muell], b: &Bewohner) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / if collided_muells.len() > 0 { [INFO] [stdout] 157 | | true [INFO] [stdout] 158 | | } else { [INFO] [stdout] 159 | | false [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `collided_muells.len() > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 156 | if collided_muells.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!collided_muells.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:101:47 [INFO] [stdout] | [INFO] [stdout] 101 | if is_key_down(KeyCode::Right) && !(player.koord.0 + 2 > GRID_CELLS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.0 + 2 <= GRID_CELLS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:53 [INFO] [stdout] | [INFO] [stdout] 103 | } else if is_key_down(KeyCode::Left) && !(player.koord.0 < 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.0 >= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:105:51 [INFO] [stdout] | [INFO] [stdout] 105 | } else if is_key_down(KeyCode::Up) && !(player.koord.1 < 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.1 >= 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:107:53 [INFO] [stdout] | [INFO] [stdout] 107 | } else if is_key_down(KeyCode::Down) && !(player.koord.1 + 2 > GRID_CELLS) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(player.koord.1 + 2 <= GRID_CELLS)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:154:24 [INFO] [stdout] | [INFO] [stdout] 154 | fn is_on_muell(muells: &Vec, b: &Bewohner) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 - fn is_on_muell(muells: &Vec, b: &Bewohner) -> bool { [INFO] [stdout] 154 + fn is_on_muell(muells: &[Muell], b: &Bewohner) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / if collided_muells.len() > 0 { [INFO] [stdout] 157 | | true [INFO] [stdout] 158 | | } else { [INFO] [stdout] 159 | | false [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `collided_muells.len() > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 156 | if collided_muells.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!collided_muells.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.03s [INFO] running `Command { std: "docker" "inspect" "b0c7b2cd18e347780be69506e5393c7ebf898ce89d3639ca1334a7aee9241322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0c7b2cd18e347780be69506e5393c7ebf898ce89d3639ca1334a7aee9241322", kill_on_drop: false }` [INFO] [stdout] b0c7b2cd18e347780be69506e5393c7ebf898ce89d3639ca1334a7aee9241322