[INFO] cloning repository https://github.com/stevenweaver/hivcluster_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stevenweaver/hivcluster_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenweaver%2Fhivcluster_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenweaver%2Fhivcluster_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ba0fd25f5aaff63fcd93ac89127850017a3b46a [INFO] linting stevenweaver/hivcluster_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenweaver%2Fhivcluster_rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/stevenweaver/hivcluster_rs [INFO] finished tweaking git repo https://github.com/stevenweaver/hivcluster_rs [INFO] tweaked toml for git repo https://github.com/stevenweaver/hivcluster_rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/stevenweaver/hivcluster_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/stevenweaver/hivcluster_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded criterion v0.4.0 [INFO] [stderr] Downloaded linux-raw-sys v0.9.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c096aa8dd10c282c82eb7255ea8650ec9cd8317726f6b33455fcda57006b0c0 [INFO] running `Command { std: "docker" "start" "-a" "5c096aa8dd10c282c82eb7255ea8650ec9cd8317726f6b33455fcda57006b0c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c096aa8dd10c282c82eb7255ea8650ec9cd8317726f6b33455fcda57006b0c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c096aa8dd10c282c82eb7255ea8650ec9cd8317726f6b33455fcda57006b0c0", kill_on_drop: false }` [INFO] [stdout] 5c096aa8dd10c282c82eb7255ea8650ec9cd8317726f6b33455fcda57006b0c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb0fbdd52f894b1ae08eddc06a5cb6f6e4855b2f32e7d91a9310670054151dea [INFO] running `Command { std: "docker" "start" "-a" "fb0fbdd52f894b1ae08eddc06a5cb6f6e4855b2f32e7d91a9310670054151dea", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.100 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling bumpalo v3.17.0 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling rustversion v1.0.20 [INFO] [stderr] Compiling wasm-bindgen v0.2.100 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking linux-raw-sys v0.9.3 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.100 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.50 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.100 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.100 [INFO] [stderr] Checking js-sys v0.3.77 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.50 [INFO] [stderr] Checking wasm-bindgen-test v0.3.50 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking hivcluster_rs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Cluster` is never constructed [INFO] [stdout] --> src/network.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Cluster { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `date_difference_days` is never used [INFO] [stdout] --> src/utils.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn date_difference_days(date1: &DateTime, date2: &DateTime) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compare_dates` is never used [INFO] [stdout] --> src/utils.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn compare_dates(date1: &Option>, date2: &Option>) -> Ordering { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `format_float` is never used [INFO] [stdout] --> src/utils.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn format_float(value: f64, decimals: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TransmissionNetwork` [INFO] [stdout] --> src/network.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | / pub fn new() -> Self { [INFO] [stdout] 160 | | TransmissionNetwork { [INFO] [stdout] 161 | | nodes: HashMap::new(), [INFO] [stdout] 162 | | edges: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 157 + impl Default for TransmissionNetwork { [INFO] [stdout] 158 + fn default() -> Self { [INFO] [stdout] 159 + Self::new() [INFO] [stdout] 160 + } [INFO] [stdout] 161 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:290:14 [INFO] [stdout] | [INFO] [stdout] 290 | .or_insert_with(Vec::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:339:14 [INFO] [stdout] | [INFO] [stdout] 339 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:344:14 [INFO] [stdout] | [INFO] [stdout] 344 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 384 | .or_insert_with(Vec::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:399:18 [INFO] [stdout] | [INFO] [stdout] 399 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:402:39 [INFO] [stdout] | [INFO] [stdout] 402 | self.adjacency.entry(id2).or_insert_with(Vec::new).push(id1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:510:26 [INFO] [stdout] | [INFO] [stdout] 510 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/parser.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match parse_date(parts[1].trim()) { [INFO] [stdout] 48 | | Ok(date) => Some(date), [INFO] [stdout] 49 | | Err(_) => None, [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: replace with: `parse_date(parts[1].trim()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/annotate.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !network_data.get("Nodes").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `network_data.get("Nodes").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Edges` should have a snake case name [INFO] [stdout] --> src/network.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub Edges: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `edges` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Nodes` should have a snake case name [INFO] [stdout] --> src/network.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | pub Nodes: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Clusters` should have a snake case name [INFO] [stdout] --> src/network.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub Clusters: usize, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `clusters` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Singletons` should have a snake case name [INFO] [stdout] --> src/network.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub Singletons: usize, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `singletons` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Count` should have a snake case name [INFO] [stdout] --> src/network.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub Count: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Distribution` should have a snake case name [INFO] [stdout] --> src/network.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | pub Distribution: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `distribution` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Model` should have a snake case name [INFO] [stdout] --> src/network.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | pub Model: String, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `model` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `BIC` should have a snake case name [INFO] [stdout] --> src/network.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | pub BIC: f64, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `bic` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hivcluster_rs::AnnotationError` [INFO] [stdout] --> src/bin/hivannotate.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use hivcluster_rs::AnnotationError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/bin/hivcluster.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/bin/hivannotate.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/bin/hivcluster.rs:196:5 [INFO] [stdout] | [INFO] [stdout] 196 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/perf_test.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | assert!(clusters.len() > 0, "Should have created clusters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!clusters.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hivcluster_rs::AnnotationError` [INFO] [stdout] --> src/bin/hivannotate.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use hivcluster_rs::AnnotationError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/singleton_test.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | degree_distribution.len() > 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!degree_distribution.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/network_test.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | assert!(clusters.len() > 0, "Should identify clusters"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!clusters.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `eprintln!` [INFO] [stdout] --> src/bin/hivannotate.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | eprintln!(""); [INFO] [stdout] | ^^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cluster` is never constructed [INFO] [stdout] --> src/network.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct Cluster { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `date_difference_days` is never used [INFO] [stdout] --> src/utils.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn date_difference_days(date1: &DateTime, date2: &DateTime) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compare_dates` is never used [INFO] [stdout] --> src/utils.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn compare_dates(date1: &Option>, date2: &Option>) -> Ordering { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `format_float` is never used [INFO] [stdout] --> src/utils.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn format_float(value: f64, decimals: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TransmissionNetwork` [INFO] [stdout] --> src/network.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 159 | / pub fn new() -> Self { [INFO] [stdout] 160 | | TransmissionNetwork { [INFO] [stdout] 161 | | nodes: HashMap::new(), [INFO] [stdout] 162 | | edges: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 167 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 157 + impl Default for TransmissionNetwork { [INFO] [stdout] 158 + fn default() -> Self { [INFO] [stdout] 159 + Self::new() [INFO] [stdout] 160 + } [INFO] [stdout] 161 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:290:14 [INFO] [stdout] | [INFO] [stdout] 290 | .or_insert_with(Vec::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:339:14 [INFO] [stdout] | [INFO] [stdout] 339 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:344:14 [INFO] [stdout] | [INFO] [stdout] 344 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:384:18 [INFO] [stdout] | [INFO] [stdout] 384 | .or_insert_with(Vec::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:399:18 [INFO] [stdout] | [INFO] [stdout] 399 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:402:39 [INFO] [stdout] | [INFO] [stdout] 402 | self.adjacency.entry(id2).or_insert_with(Vec::new).push(id1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/network.rs:510:26 [INFO] [stdout] | [INFO] [stdout] 510 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/parser.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match parse_date(parts[1].trim()) { [INFO] [stdout] 48 | | Ok(date) => Some(date), [INFO] [stdout] 49 | | Err(_) => None, [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________^ help: replace with: `parse_date(parts[1].trim()).ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/annotate.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !network_data.get("Nodes").is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `network_data.get("Nodes").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Edges` should have a snake case name [INFO] [stdout] --> src/network.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | pub Edges: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `edges` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Nodes` should have a snake case name [INFO] [stdout] --> src/network.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | pub Nodes: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `nodes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Clusters` should have a snake case name [INFO] [stdout] --> src/network.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub Clusters: usize, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `clusters` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Singletons` should have a snake case name [INFO] [stdout] --> src/network.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub Singletons: usize, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `singletons` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Count` should have a snake case name [INFO] [stdout] --> src/network.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | pub Count: usize, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `count` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Distribution` should have a snake case name [INFO] [stdout] --> src/network.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | pub Distribution: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `distribution` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Model` should have a snake case name [INFO] [stdout] --> src/network.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | pub Model: String, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `model` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `BIC` should have a snake case name [INFO] [stdout] --> src/network.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | pub BIC: f64, [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `bic` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.63s [INFO] running `Command { std: "docker" "inspect" "fb0fbdd52f894b1ae08eddc06a5cb6f6e4855b2f32e7d91a9310670054151dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb0fbdd52f894b1ae08eddc06a5cb6f6e4855b2f32e7d91a9310670054151dea", kill_on_drop: false }` [INFO] [stdout] fb0fbdd52f894b1ae08eddc06a5cb6f6e4855b2f32e7d91a9310670054151dea