[INFO] cloning repository https://github.com/stevenleadbeater/influxdb-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stevenleadbeater/influxdb-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenleadbeater%2Finfluxdb-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenleadbeater%2Finfluxdb-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 84a60941c90fec1b01d002e1316b488ee3f5e473 [INFO] linting stevenleadbeater/influxdb-client against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstevenleadbeater%2Finfluxdb-client" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/stevenleadbeater/influxdb-client [INFO] finished tweaking git repo https://github.com/stevenleadbeater/influxdb-client [INFO] tweaked toml for git repo https://github.com/stevenleadbeater/influxdb-client written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/stevenleadbeater/influxdb-client on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/stevenleadbeater/influxdb-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/stevenleadbeater/logger.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hyper-rustls v0.27.2 [INFO] [stderr] Downloaded tokio-rustls v0.26.0 [INFO] [stderr] Downloaded native-tls v0.2.12 [INFO] [stderr] Downloaded env_filter v0.1.0 [INFO] [stderr] Downloaded actix-test v0.1.5 [INFO] [stderr] Downloaded actix-http-test v3.2.0 [INFO] [stderr] Downloaded dyn-clone v1.0.17 [INFO] [stderr] Downloaded rustls-pki-types v1.7.0 [INFO] [stderr] Downloaded security-framework-sys v2.11.1 [INFO] [stderr] Downloaded actix-cors v0.7.0 [INFO] [stderr] Downloaded env_logger v0.11.3 [INFO] [stderr] Downloaded actix-tls v3.4.0 [INFO] [stderr] Downloaded hyper-util v0.1.6 [INFO] [stderr] Downloaded awc v3.5.0 [INFO] [stderr] Downloaded rustls-webpki v0.102.5 [INFO] [stderr] Downloaded rustls v0.23.11 [INFO] [stderr] Downloaded tokio v1.38.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89f75b7f3cddbc6cd20b04443733a9dfc3924de493bd326707e6b079bb51fcc7 [INFO] running `Command { std: "docker" "start" "-a" "89f75b7f3cddbc6cd20b04443733a9dfc3924de493bd326707e6b079bb51fcc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89f75b7f3cddbc6cd20b04443733a9dfc3924de493bd326707e6b079bb51fcc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89f75b7f3cddbc6cd20b04443733a9dfc3924de493bd326707e6b079bb51fcc7", kill_on_drop: false }` [INFO] [stdout] 89f75b7f3cddbc6cd20b04443733a9dfc3924de493bd326707e6b079bb51fcc7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ecf1d60bf0941984d88e73ccf9dfaba121a03205c477cba0a12affd1336b16c [INFO] running `Command { std: "docker" "start" "-a" "4ecf1d60bf0941984d88e73ccf9dfaba121a03205c477cba0a12affd1336b16c", kill_on_drop: false }` [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling cc v1.1.5 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking impl-more v0.1.6 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking logger v0.1.0 (https://github.com/stevenleadbeater/logger.git#62c908e5) [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking actix-server v2.4.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking actix-tls v3.4.0 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling zstd-safe v7.2.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking actix-http v3.8.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking awc v3.5.0 [INFO] [stderr] Checking actix-web v4.8.0 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking actix-http-test v3.2.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking actix-test v0.1.5 [INFO] [stderr] Checking actix-cors v0.7.0 [INFO] [stderr] Checking influxdb-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper/response_mapper.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return match result { [INFO] [stdout] 7 | | Err(error) => { [INFO] [stdout] 8 | | error!("Error: {:#?}", error); [INFO] [stdout] 9 | | Err(InfluxDbError::Failed(Some(error), "request failed".to_string())) [INFO] [stdout] ... | [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ match result { [INFO] [stdout] 7 + Err(error) => { [INFO] [stdout] 8 + error!("Error: {:#?}", error); [INFO] [stdout] 9 + Err(InfluxDbError::Failed(Some(error), "request failed".to_string())) [INFO] [stdout] 10 + } [INFO] [stdout] 11 + Ok(result) => { [INFO] [stdout] 12 + let status = result.status().clone(); [INFO] [stdout] 13 + let body = result [INFO] [stdout] 14 + .text() [INFO] [stdout] 15 + .await; [INFO] [stdout] 16 + debug!("Result: {:#?}", body); [INFO] [stdout] 17 + if !status.is_success() { [INFO] [stdout] 18 + return Err(map_bad_response(body, status.to_string())); [INFO] [stdout] 19 + } [INFO] [stdout] 20 + if body.is_err() { [INFO] [stdout] 21 + return Err(InfluxDbError::Failed(body.err(), "".to_string())) [INFO] [stdout] 22 + } [INFO] [stdout] 23 + Ok(body.unwrap()) [INFO] [stdout] 24 + } [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `StatusCode` which implements the `Copy` trait [INFO] [stdout] --> src/mapper/response_mapper.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | let status = result.status().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result.status()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapper/response_mapper.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !body.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `body.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_ok` [INFO] [stdout] --> src/mapper/response_mapper.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 31 | if !body.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 34 | let body = body.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mapper/response_mapper.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper/influxdb_payload_mapper.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | return format!("{}:{}", self.mapper_field_1, payload.field_1) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return format!("{}:{}", self.mapper_field_1, payload.field_1) [INFO] [stdout] 32 + format!("{}:{}", self.mapper_field_1, payload.field_1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mapper/response_mapper.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / return match result { [INFO] [stdout] 7 | | Err(error) => { [INFO] [stdout] 8 | | error!("Error: {:#?}", error); [INFO] [stdout] 9 | | Err(InfluxDbError::Failed(Some(error), "request failed".to_string())) [INFO] [stdout] ... | [INFO] [stdout] 25 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 ~ match result { [INFO] [stdout] 7 + Err(error) => { [INFO] [stdout] 8 + error!("Error: {:#?}", error); [INFO] [stdout] 9 + Err(InfluxDbError::Failed(Some(error), "request failed".to_string())) [INFO] [stdout] 10 + } [INFO] [stdout] 11 + Ok(result) => { [INFO] [stdout] 12 + let status = result.status().clone(); [INFO] [stdout] 13 + let body = result [INFO] [stdout] 14 + .text() [INFO] [stdout] 15 + .await; [INFO] [stdout] 16 + debug!("Result: {:#?}", body); [INFO] [stdout] 17 + if !status.is_success() { [INFO] [stdout] 18 + return Err(map_bad_response(body, status.to_string())); [INFO] [stdout] 19 + } [INFO] [stdout] 20 + if body.is_err() { [INFO] [stdout] 21 + return Err(InfluxDbError::Failed(body.err(), "".to_string())) [INFO] [stdout] 22 + } [INFO] [stdout] 23 + Ok(body.unwrap()) [INFO] [stdout] 24 + } [INFO] [stdout] 25 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `StatusCode` which implements the `Copy` trait [INFO] [stdout] --> src/mapper/response_mapper.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | let status = result.status().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `result.status()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mapper/response_mapper.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !body.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `body.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_ok` [INFO] [stdout] --> src/mapper/response_mapper.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 31 | if !body.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 34 | let body = body.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mapper/response_mapper.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 35 | if body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/influxdb_config.rs:32:59 [INFO] [stdout] | [INFO] [stdout] 32 | let result: InfluxdbConfig = serde_json::from_str(&payload).expect("Cannot serialize"); [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `Command { std: "docker" "inspect" "4ecf1d60bf0941984d88e73ccf9dfaba121a03205c477cba0a12affd1336b16c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ecf1d60bf0941984d88e73ccf9dfaba121a03205c477cba0a12affd1336b16c", kill_on_drop: false }` [INFO] [stdout] 4ecf1d60bf0941984d88e73ccf9dfaba121a03205c477cba0a12affd1336b16c