[INFO] cloning repository https://github.com/steve-canham/dl_anz [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/steve-canham/dl_anz" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsteve-canham%2Fdl_anz", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsteve-canham%2Fdl_anz'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eee0fae95ad07d2cb804399c49342ec0ea04b966 [INFO] linting steve-canham/dl_anz against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsteve-canham%2Fdl_anz" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/steve-canham/dl_anz [INFO] finished tweaking git repo https://github.com/steve-canham/dl_anz [INFO] tweaked toml for git repo https://github.com/steve-canham/dl_anz written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/steve-canham/dl_anz on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/steve-canham/dl_anz already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5bc0c0325f3c6ad106fb16492bb2cf2927294245dfdc3a949bb8a5f38bc0159f [INFO] running `Command { std: "docker" "start" "-a" "5bc0c0325f3c6ad106fb16492bb2cf2927294245dfdc3a949bb8a5f38bc0159f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5bc0c0325f3c6ad106fb16492bb2cf2927294245dfdc3a949bb8a5f38bc0159f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bc0c0325f3c6ad106fb16492bb2cf2927294245dfdc3a949bb8a5f38bc0159f", kill_on_drop: false }` [INFO] [stdout] 5bc0c0325f3c6ad106fb16492bb2cf2927294245dfdc3a949bb8a5f38bc0159f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87da6b2afac65c55214ccdebad8ae8e20501f5bb8a7bcc3a5cf9eef352c95bb2 [INFO] running `Command { std: "docker" "start" "-a" "87da6b2afac65c55214ccdebad8ae8e20501f5bb8a7bcc3a5cf9eef352c95bb2", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling tracing-core v0.1.35 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling iana-time-zone v0.1.64 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Compiling tokio v1.48.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking thread-id v5.0.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking mock_instant v0.6.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling derive_more-impl v2.1.0 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling tracing v0.1.43 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Checking derive_more v2.1.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking log4rs v1.4.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking dl_anz v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | csv_data_path: csv_data_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `csv_data_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | json_data_path: json_data_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `json_data_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | log_folder_path: log_folder_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_folder_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | source_id: source_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | study_type: study_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | study_status: study_status, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | agemin: agemin, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `agemin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | agemin_units:agemin_units, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `agemin_units` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | agemax: agemax, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `agemax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | agemax_units: agemax_units, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `agemax_units` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | gender: gender, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `gender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | ipd_plan: ipd_plan, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ipd_plan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:341:9 [INFO] [stdout] | [INFO] [stdout] 341 | ipd_description:ipd_description, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ipd_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | study_features: study_features, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_features` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | source_id: source_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | sd_sid: sd_sid, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sd_sid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 490 | title: title, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | table_name: table_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | date_last_rev: date_last_rev, // assumed to be always present [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_last_rev` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:877:21 [INFO] [stdout] | [INFO] [stdout] 877 | sec_id_source: sec_id_source, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sec_id_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1041:25 [INFO] [stdout] | [INFO] [stdout] 1041 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1063:21 [INFO] [stdout] | [INFO] [stdout] 1063 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1084:29 [INFO] [stdout] | [INFO] [stdout] 1084 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1112:25 [INFO] [stdout] | [INFO] [stdout] 1112 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1125:33 [INFO] [stdout] | [INFO] [stdout] 1125 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1151:29 [INFO] [stdout] | [INFO] [stdout] 1151 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | csv_data_path: csv_data_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `csv_data_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | json_data_path: json_data_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `json_data_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/setup/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | log_folder_path: log_folder_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_folder_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/setup/mod.rs:196:1 [INFO] [stdout] | [INFO] [stdout] 196 | / #[cfg(test)] [INFO] [stdout] 197 | | [INFO] [stdout] | |_^ [INFO] [stdout] 198 | mod tests { [INFO] [stdout] | --------- the attribute applies to this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | source_id: source_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 310 | study_type: study_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:315:9 [INFO] [stdout] | [INFO] [stdout] 315 | study_status: study_status, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | agemin: agemin, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `agemin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | agemin_units:agemin_units, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `agemin_units` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | agemax: agemax, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `agemax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | agemax_units: agemax_units, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `agemax_units` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | gender: gender, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `gender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | ipd_plan: ipd_plan, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ipd_plan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:341:9 [INFO] [stdout] | [INFO] [stdout] 341 | ipd_description:ipd_description, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ipd_description` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | study_features: study_features, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `study_features` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:488:9 [INFO] [stdout] | [INFO] [stdout] 488 | source_id: source_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | sd_sid: sd_sid, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sd_sid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 490 | title: title, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:503:9 [INFO] [stdout] | [INFO] [stdout] 503 | table_name: table_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/processor.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | date_last_rev: date_last_rev, // assumed to be always present [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_last_rev` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:877:21 [INFO] [stdout] | [INFO] [stdout] 877 | sec_id_source: sec_id_source, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sec_id_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1041:25 [INFO] [stdout] | [INFO] [stdout] 1041 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1063:21 [INFO] [stdout] | [INFO] [stdout] 1063 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1084:29 [INFO] [stdout] | [INFO] [stdout] 1084 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1112:25 [INFO] [stdout] | [INFO] [stdout] 1112 | processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1125:33 [INFO] [stdout] | [INFO] [stdout] 1125 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/download/who_helper.rs:1151:29 [INFO] [stdout] | [INFO] [stdout] 1151 | ... processed_id: processed_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/setup/cli_reader.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if i_flag == false && t_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!i_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/setup/cli_reader.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | if i_flag == false && t_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!t_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/setup/cli_reader.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 34 | / let res = match config_path.try_exists() { [INFO] [stdout] 35 | | Ok(true) => true, [INFO] [stdout] 36 | | Ok(false) => false, [INFO] [stdout] 37 | | Err(_e) => false, [INFO] [stdout] 38 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 39 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 ~ match config_path.try_exists() { [INFO] [stdout] 36 + Ok(true) => true, [INFO] [stdout] 37 + Ok(false) => false, [INFO] [stdout] 38 + Err(_e) => false, [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/config_reader.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | let toml_config = toml::from_str::(&config_string) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `config_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/setup/config_reader.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | let db_port: usize = db_port_as_string.parse().unwrap_or_else(|_| 5432); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 114 - let db_port: usize = db_port_as_string.parse().unwrap_or_else(|_| 5432); [INFO] [stdout] 114 + let db_port: usize = db_port_as_string.parse().unwrap_or(5432); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/setup/config_reader.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / return Result::Err(AppError::ConfigurationError("Essential configuration value missing or misspelt.".to_string(), [INFO] [stdout] 140 | | format!("Cannot find a value for {} ({}).", value_name, config_name))) [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ Result::Err(AppError::ConfigurationError("Essential configuration value missing or misspelt.".to_string(), [INFO] [stdout] 140 + format!("Cannot find a value for {} ({}).", value_name, config_name))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 137 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:155:47 [INFO] [stdout] | [INFO] [stdout] 155 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/create_tables.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 32 | sqlx::raw_sql(&sql).execute(pool) [INFO] [stdout] | ^^^^ help: change this to: `sql` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/mod.rs:43:67 [INFO] [stdout] | [INFO] [stdout] 43 | let config_file: Config = config_reader::populate_config_vars(&config_string)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `config_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/setup/mod.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] 68 + fn folder_exists(folder_name: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/setup/mod.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 69 | / let res = match folder_name.try_exists() { [INFO] [stdout] 70 | | Ok(true) => true, [INFO] [stdout] 71 | | Ok(false) => false, [INFO] [stdout] 72 | | Err(_e) => false, [INFO] [stdout] 73 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 74 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ match folder_name.try_exists() { [INFO] [stdout] 71 + Ok(true) => true, [INFO] [stdout] 72 + Ok(false) => false, [INFO] [stdout] 73 + Err(_e) => false, [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/mod.rs:136:40 [INFO] [stdout] | [INFO] [stdout] 136 | log_helper::log_startup_params(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/setup/mod.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | / match LOG_RUNNING.get() { [INFO] [stdout] 143 | | Some(_) => true, [INFO] [stdout] 144 | | None => false, [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ help: try: `LOG_RUNNING.get().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/setup/mod.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | if path.extension().map_or(false, |ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 164 - if path.extension().map_or(false, |ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] 164 + if path.extension().is_some_and(|ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/setup/mod.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | .filter_map(|f| [INFO] [stdout] | ______________^ [INFO] [stdout] 182 | | if f > last_file_as_osstr { [INFO] [stdout] 183 | | Some(f) [INFO] [stdout] ... | [INFO] [stdout] 186 | | None [INFO] [stdout] 187 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/err.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn report_error(e: AppError) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/err.rs:95:47 [INFO] [stdout] | [INFO] [stdout] 95 | let hdr_line = get_header_line (star_num, &header); [INFO] [stdout] | ^^^^^^^ help: change this to: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/err.rs:103:47 [INFO] [stdout] | [INFO] [stdout] 103 | let hdr_line = get_header_line (star_num, &header); [INFO] [stdout] | ^^^^^^^ help: change this to: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/err.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if hdr_len % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!hdr_len.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/download/processor.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn process_line(w: WHOLine,source_id: i32, sid: &String, study_type: i32, study_status: i32, [INFO] [stdout] 14 | | remote_url:&Option, study_idents: Option>, countries: Option>) -> Option { [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `condition_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 24 | if condition_list.is_some() [INFO] [stdout] | --------------------------- help: try: `if let Some() = condition_list` [INFO] [stdout] ... [INFO] [stdout] 31 | (conditions, meddraconds) = get_conditions(&condition_list.unwrap(), source_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `design_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 48 | if design_list.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = design_list` [INFO] [stdout] 49 | let des_list = &design_list.unwrap().to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `phase_statement` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 71 | if phase_statement.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = phase_statement` [INFO] [stdout] 72 | let phase_statement = &phase_statement.unwrap().to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `f` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 191 | if f.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = f` [INFO] [stdout] 192 | let pos = f.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/processor.rs:13:53 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn process_line(w: WHOLine,source_id: i32, sid: &String, study_type: i32, study_status: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 ~ pub fn process_line(w: WHOLine,source_id: i32, sid: &str, study_type: i32, study_status: i32, [INFO] [stdout] 14 | remote_url:&Option, study_idents: Option>, countries: Option>) -> Option { [INFO] [stdout] ... [INFO] [stdout] 296 | record_date: w.last_updated.as_iso_date(), [INFO] [stdout] 297 ~ sd_sid: sid.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/processor.rs:109:33 [INFO] [stdout] | [INFO] [stdout] 109 | if min_units != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/processor.rs:129:33 [INFO] [stdout] | [INFO] [stdout] 129 | if max_units != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `sec_ids` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:398:75 [INFO] [stdout] | [INFO] [stdout] 396 | if sec_ids.is_some() [INFO] [stdout] | -------------------- help: try: `if let Some() = sec_ids` [INFO] [stdout] 397 | { [INFO] [stdout] 398 | let mut initial_ids = split_and_add_ids(&secondary_ids, &sd_sid, &sec_ids.unwrap(), "secondary ids"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bridging_flag` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:404:27 [INFO] [stdout] | [INFO] [stdout] 403 | if bridging_flag.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = bridging_flag` [INFO] [stdout] 404 | let mut br_flag = bridging_flag.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `childs` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:422:73 [INFO] [stdout] | [INFO] [stdout] 420 | if childs.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = childs` [INFO] [stdout] 421 | { [INFO] [stdout] 422 | let mut child_ids = split_and_add_ids(&secondary_ids, &sd_sid, &childs.unwrap(), "bridged child recs"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `country_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:481:59 [INFO] [stdout] | [INFO] [stdout] 479 | if country_list.is_some() [INFO] [stdout] | ------------------------- help: try: `if let Some() = country_list` [INFO] [stdout] 480 | { [INFO] [stdout] 481 | countries = split_and_dedup_countries(source_id, &country_list.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/processor.rs:360:8 [INFO] [stdout] | [INFO] [stdout] 360 | if sd_sid == "" || sd_sid == "null" || sd_sid == "NULL" { // Seems to happen, or has happened in the past, with one Dutc... [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sd_sid.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/processor.rs:384:5 [INFO] [stdout] | [INFO] [stdout] 384 | let status: i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `status` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 384 ~ [INFO] [stdout] 385 ~ let status: i32 = if w.results_yes_no.to_lowercase() == "yes" { [INFO] [stdout] 386 ~ 30 // completed [INFO] [stdout] 387 | } [INFO] [stdout] 388 | else { [INFO] [stdout] 389 | let study_status = w.recruitment_status.tidy(); [INFO] [stdout] 390 ~ get_status(&study_status) [INFO] [stdout] 391 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/download/processor.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | table_name = table_name + suffix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name += suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/download/processor.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | table_name = table_name + suffix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name += suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/processor.rs:478:5 [INFO] [stdout] | [INFO] [stdout] 478 | let countries: Option>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `countries` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 478 ~ [INFO] [stdout] 479 ~ let countries: Option> = if country_list.is_some() [INFO] [stdout] 480 | { [INFO] [stdout] 481 ~ split_and_dedup_countries(source_id, &country_list.unwrap()) [INFO] [stdout] 482 | } [INFO] [stdout] 483 | else { [INFO] [stdout] 484 ~ None [INFO] [stdout] 485 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:9:66 [INFO] [stdout] | [INFO] [stdout] 9 | record_date: &Option, full_path: &PathBuf, pool: &Pool) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - record_date: &Option, full_path: &PathBuf, pool: &Pool) -> Result { [INFO] [stdout] 9 + record_date: &Option, full_path: &Path, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:83:64 [INFO] [stdout] | [INFO] [stdout] 83 | pub async fn add_new_single_file_record(dl_id: i32, file_path: &PathBuf, file_res: &DownloadResult, pool: &Pool) -> Result... [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 83 - pub async fn add_new_single_file_record(dl_id: i32, file_path: &PathBuf, file_res: &DownloadResult, pool: &Pool) -> Result { [INFO] [stdout] 83 + pub async fn add_new_single_file_record(dl_id: i32, file_path: &Path, file_res: &DownloadResult, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:96:45 [INFO] [stdout] | [INFO] [stdout] 96 | pub async fn add_contents_record(file_path: &PathBuf, source_tots: &mut HashMap, pool: &Pool) -> Result, pool: &Pool) -> Result { [INFO] [stdout] 96 + pub async fn add_contents_record(file_path: &Path, source_tots: &mut HashMap, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/data_access.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | if sids.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 25 ~ [INFO] [stdout] 26 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 27 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 28 ~ self.trim_matches(complex_trim) [INFO] [stdout] 29 | } [INFO] [stdout] 30 | else { [INFO] [stdout] 31 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 32 ~ self.trim_matches(complex_trim) [INFO] [stdout] 33 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 53 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 54 ~ self.trim_matches(complex_trim) [INFO] [stdout] 55 | } [INFO] [stdout] 56 | else { [INFO] [stdout] 57 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 58 ~ self.trim_matches(complex_trim) [INFO] [stdout] 59 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 84 ~ [INFO] [stdout] 85 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 86 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 87 ~ self.trim_matches(complex_trim) [INFO] [stdout] 88 | } [INFO] [stdout] 89 | else { [INFO] [stdout] 90 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 91 ~ self.trim_matches(complex_trim) [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 93 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download/gen_helper.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | return units.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return units.to_string() [INFO] [stdout] 319 + units.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn get_source_id(sd_sid: &String) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - pub fn get_source_id(sd_sid: &String) -> i32 { [INFO] [stdout] 8 + pub fn get_source_id(sd_sid: &str) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:228:39 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn get_conditions(condition_list: &String, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - pub fn get_conditions(condition_list: &String, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] 228 + pub fn get_conditions(condition_list: &str, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/who_helper.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 242 | if s1 != "" && s1.len() >= 3 [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:252:26 [INFO] [stdout] | [INFO] [stdout] 252 | let re = Regex::new(r"MedDRA version: (?.+)Level").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:253:49 [INFO] [stdout] | [INFO] [stdout] 253 | let version = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:259:26 [INFO] [stdout] | [INFO] [stdout] 259 | let re = Regex::new(r"Level: (?.+)Classific").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:260:47 [INFO] [stdout] | [INFO] [stdout] 260 | let level = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:266:26 [INFO] [stdout] | [INFO] [stdout] 266 | let re = Regex::new(r"Classification code (?[0-9]+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:267:46 [INFO] [stdout] | [INFO] [stdout] 267 | let code = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 273 | let re = Regex::new(r"Term: (?.+)System").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:274:46 [INFO] [stdout] | [INFO] [stdout] 274 | let term = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:280:26 [INFO] [stdout] | [INFO] [stdout] 280 | let re = Regex::new(r"System Organ Class: (?[0-9]+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:281:50 [INFO] [stdout] | [INFO] [stdout] 281 | let soc_code = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:287:26 [INFO] [stdout] | [INFO] [stdout] 287 | let re = Regex::new(r"System Organ Class: (.+) - (?.+)$").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:288:50 [INFO] [stdout] | [INFO] [stdout] 288 | let soc_term = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download/who_helper.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 386 | return Some(out_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 386 - return Some(out_strings); [INFO] [stdout] 386 + Some(out_strings) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:320:64 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn split_and_dedup_countries(source_id: i32, country_list: &String) -> Option> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 320 - pub fn split_and_dedup_countries(source_id: i32, country_list: &String) -> Option> { [INFO] [stdout] 320 + pub fn split_and_dedup_countries(source_id: i32, country_list: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/who_helper.rs:392:8 [INFO] [stdout] | [INFO] [stdout] 392 | if out_strings.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out_strings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:411:39 [INFO] [stdout] | [INFO] [stdout] 411 | pub fn add_eu_design_features(design: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 411 - pub fn add_eu_design_features(design: &String) -> Vec { [INFO] [stdout] 411 + pub fn add_eu_design_features(design: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:448:44 [INFO] [stdout] | [INFO] [stdout] 448 | pub fn add_int_study_features(design_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 448 - pub fn add_int_study_features(design_list: &String) -> Vec [INFO] [stdout] 448 + pub fn add_int_study_features(design_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:500:39 [INFO] [stdout] | [INFO] [stdout] 500 | pub fn add_obs_study_features(design: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 500 - pub fn add_obs_study_features(design: &String) -> Vec [INFO] [stdout] 500 + pub fn add_obs_study_features(design: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:557:42 [INFO] [stdout] | [INFO] [stdout] 557 | pub fn add_masking_features(design_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 557 - pub fn add_masking_features(design_list: &String) -> Vec [INFO] [stdout] 557 + pub fn add_masking_features(design_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/setup/cli_reader.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if i_flag == false && t_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!i_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/setup/cli_reader.rs:21:27 [INFO] [stdout] | [INFO] [stdout] 21 | if i_flag == false && t_flag == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `!t_flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/setup/cli_reader.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 34 | / let res = match config_path.try_exists() { [INFO] [stdout] 35 | | Ok(true) => true, [INFO] [stdout] 36 | | Ok(false) => false, [INFO] [stdout] 37 | | Err(_e) => false, [INFO] [stdout] 38 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 39 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 34 ~ [INFO] [stdout] 35 ~ match config_path.try_exists() { [INFO] [stdout] 36 + Ok(true) => true, [INFO] [stdout] 37 + Ok(false) => false, [INFO] [stdout] 38 + Err(_e) => false, [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(res.importing, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(res.importing, true); [INFO] [stdout] 79 + assert!(res.importing); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(res.transforming, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(res.transforming, false); [INFO] [stdout] 80 + assert!(!res.transforming); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:636:42 [INFO] [stdout] | [INFO] [stdout] 636 | pub fn add_eu_phase_features(phase_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 636 - pub fn add_eu_phase_features(phase_list: &String) -> Vec [INFO] [stdout] 636 + pub fn add_eu_phase_features(phase_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | assert_eq!(res.importing, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 92 - assert_eq!(res.importing, false); [INFO] [stdout] 92 + assert!(!res.importing); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | assert_eq!(res.transforming, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 93 - assert_eq!(res.transforming, true); [INFO] [stdout] 93 + assert!(res.transforming); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | assert_eq!(res.importing, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 104 - assert_eq!(res.importing, true); [INFO] [stdout] 104 + assert!(res.importing); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/setup/cli_reader.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | assert_eq!(res.transforming, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 105 - assert_eq!(res.transforming, true); [INFO] [stdout] 105 + assert!(res.transforming); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, char>` [INFO] [stdout] --> src/download/who_helper.rs:647:25 [INFO] [stdout] | [INFO] [stdout] 647 | let ps: Vec<&str> = phase_list.split(':').into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `phase_list.split(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/download/who_helper.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 688 | if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] | ____________^ [INFO] [stdout] 689 | | || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 | | || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 688 - if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] 689 - || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 - || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] 688 + if !(phase != "phase 0" && phase != "phase-0" && phase != "phase0" && phase != "0" && phase != "0 (exploratory trials)" && phase != "phase 0 (exploratory trials)") [INFO] [stdout] | [INFO] [stdout] 688 - if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] 689 - || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 - || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] 688 + if phase == "phase 0" || phase == "phase-0" || phase == "phase0" || phase == "0" || phase == "0 (exploratory trials)" || phase == "phase 0 (exploratory trials)" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/config_reader.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | let toml_config = toml::from_str::(&config_string) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `config_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/setup/config_reader.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | let db_port: usize = db_port_as_string.parse().unwrap_or_else(|_| 5432); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 114 - let db_port: usize = db_port_as_string.parse().unwrap_or_else(|_| 5432); [INFO] [stdout] 114 + let db_port: usize = db_port_as_string.parse().unwrap_or(5432); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/setup/config_reader.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / return Result::Err(AppError::ConfigurationError("Essential configuration value missing or misspelt.".to_string(), [INFO] [stdout] 140 | | format!("Cannot find a value for {} ({}).", value_name, config_name))) [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 ~ Result::Err(AppError::ConfigurationError("Essential configuration value missing or misspelt.".to_string(), [INFO] [stdout] 140 + format!("Cannot find a value for {} ({}).", value_name, config_name))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:137:47 [INFO] [stdout] | [INFO] [stdout] 137 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"none"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/setup/config_reader.rs:155:47 [INFO] [stdout] | [INFO] [stdout] 155 | if s == "none".to_string() || s.trim() == "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/create_tables.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 32 | sqlx::raw_sql(&sql).execute(pool) [INFO] [stdout] | ^^^^ help: change this to: `sql` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/mod.rs:43:67 [INFO] [stdout] | [INFO] [stdout] 43 | let config_file: Config = config_reader::populate_config_vars(&config_string)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `config_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/setup/mod.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] 68 + fn folder_exists(folder_name: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/setup/mod.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 69 | / let res = match folder_name.try_exists() { [INFO] [stdout] 70 | | Ok(true) => true, [INFO] [stdout] 71 | | Ok(false) => false, [INFO] [stdout] 72 | | Err(_e) => false, [INFO] [stdout] 73 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 74 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ match folder_name.try_exists() { [INFO] [stdout] 71 + Ok(true) => true, [INFO] [stdout] 72 + Ok(false) => false, [INFO] [stdout] 73 + Err(_e) => false, [INFO] [stdout] 74 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/setup/mod.rs:136:40 [INFO] [stdout] | [INFO] [stdout] 136 | log_helper::log_startup_params(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/setup/mod.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | / match LOG_RUNNING.get() { [INFO] [stdout] 143 | | Some(_) => true, [INFO] [stdout] 144 | | None => false, [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ help: try: `LOG_RUNNING.get().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/setup/mod.rs:164:20 [INFO] [stdout] | [INFO] [stdout] 164 | if path.extension().map_or(false, |ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 164 - if path.extension().map_or(false, |ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] 164 + if path.extension().is_some_and(|ext| ext == "csv") { // filter_map filters on Some()) values as [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/setup/mod.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | .filter_map(|f| [INFO] [stdout] | ______________^ [INFO] [stdout] 182 | | if f > last_file_as_osstr { [INFO] [stdout] 183 | | Some(f) [INFO] [stdout] ... | [INFO] [stdout] 186 | | None [INFO] [stdout] 187 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/err.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn report_error(e: AppError) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/err.rs:95:47 [INFO] [stdout] | [INFO] [stdout] 95 | let hdr_line = get_header_line (star_num, &header); [INFO] [stdout] | ^^^^^^^ help: change this to: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/err.rs:103:47 [INFO] [stdout] | [INFO] [stdout] 103 | let hdr_line = get_header_line (star_num, &header); [INFO] [stdout] | ^^^^^^^ help: change this to: `header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/err.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | if hdr_len % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `!hdr_len.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:741:90 [INFO] [stdout] | [INFO] [stdout] 741 | pub fn split_and_add_ids(existing_ids: &Vec::, sd_sid: &String, in_string: &String, source_field: &str) -> Vec, sd_sid: &String, in_string: &String, source_field: &str) -> Vec [INFO] [stdout] 741 + pub fn split_and_add_ids(existing_ids: &Vec::, sd_sid: &String, in_string: &str, source_field: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/download/who_helper.rs:756:46 [INFO] [stdout] | [INFO] [stdout] 756 | if secid_low.chars().any(|c| c.is_digit(10)) // has to include at least 1 number [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/who_helper.rs:772:52 [INFO] [stdout] | [INFO] [stdout] 772 | if sec_id_base.processed_id == sd_sid.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*sd_sid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/who_helper.rs:775:29 [INFO] [stdout] | [INFO] [stdout] 775 | else if existing_ids.len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!existing_ids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/mod.rs:126:31 [INFO] [stdout] | [INFO] [stdout] 126 | fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 - fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] 126 + fn folder_exists(folder_name: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/download/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 127 | / let res = match folder_name.try_exists() { [INFO] [stdout] 128 | | Ok(true) => true, [INFO] [stdout] 129 | | Ok(false) => false, [INFO] [stdout] 130 | | Err(_e) => false, [INFO] [stdout] 131 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 132 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 ~ match folder_name.try_exists() { [INFO] [stdout] 129 + Ok(true) => true, [INFO] [stdout] 130 + Ok(false) => false, [INFO] [stdout] 131 + Err(_e) => false, [INFO] [stdout] 132 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DownloadResult` [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | DownloadResult { [INFO] [stdout] 23 | | num_checked: 0, [INFO] [stdout] 24 | | num_downloaded: 0, [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for DownloadResult { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | let cli_pars: cli_reader::CliPars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 41 | cli_pars = cli_reader::fetch_valid_arguments(args)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `cli_pars` here [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ let cli_pars: cli_reader::CliPars = cli_reader::fetch_valid_arguments(args)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/download/processor.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | / pub fn process_line(w: WHOLine,source_id: i32, sid: &String, study_type: i32, study_status: i32, [INFO] [stdout] 14 | | remote_url:&Option, study_idents: Option>, countries: Option>) -> Option { [INFO] [stdout] | |____________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `condition_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:31:53 [INFO] [stdout] | [INFO] [stdout] 24 | if condition_list.is_some() [INFO] [stdout] | --------------------------- help: try: `if let Some() = condition_list` [INFO] [stdout] ... [INFO] [stdout] 31 | (conditions, meddraconds) = get_conditions(&condition_list.unwrap(), source_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `design_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 48 | if design_list.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = design_list` [INFO] [stdout] 49 | let des_list = &design_list.unwrap().to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `phase_statement` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:72:32 [INFO] [stdout] | [INFO] [stdout] 71 | if phase_statement.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = phase_statement` [INFO] [stdout] 72 | let phase_statement = &phase_statement.unwrap().to_lowercase(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `f` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 191 | if f.is_some() { [INFO] [stdout] | -------------- help: try: `if let Some() = f` [INFO] [stdout] 192 | let pos = f.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/processor.rs:13:53 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn process_line(w: WHOLine,source_id: i32, sid: &String, study_type: i32, study_status: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 13 ~ pub fn process_line(w: WHOLine,source_id: i32, sid: &str, study_type: i32, study_status: i32, [INFO] [stdout] 14 | remote_url:&Option, study_idents: Option>, countries: Option>) -> Option { [INFO] [stdout] ... [INFO] [stdout] 296 | record_date: w.last_updated.as_iso_date(), [INFO] [stdout] 297 ~ sd_sid: sid.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/processor.rs:109:33 [INFO] [stdout] | [INFO] [stdout] 109 | if min_units != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/processor.rs:129:33 [INFO] [stdout] | [INFO] [stdout] 129 | if max_units != "".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `sec_ids` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:398:75 [INFO] [stdout] | [INFO] [stdout] 396 | if sec_ids.is_some() [INFO] [stdout] | -------------------- help: try: `if let Some() = sec_ids` [INFO] [stdout] 397 | { [INFO] [stdout] 398 | let mut initial_ids = split_and_add_ids(&secondary_ids, &sd_sid, &sec_ids.unwrap(), "secondary ids"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `bridging_flag` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:404:27 [INFO] [stdout] | [INFO] [stdout] 403 | if bridging_flag.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = bridging_flag` [INFO] [stdout] 404 | let mut br_flag = bridging_flag.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `childs` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:422:73 [INFO] [stdout] | [INFO] [stdout] 420 | if childs.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = childs` [INFO] [stdout] 421 | { [INFO] [stdout] 422 | let mut child_ids = split_and_add_ids(&secondary_ids, &sd_sid, &childs.unwrap(), "bridged child recs"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `country_list` after checking its variant with `is_some` [INFO] [stdout] --> src/download/processor.rs:481:59 [INFO] [stdout] | [INFO] [stdout] 479 | if country_list.is_some() [INFO] [stdout] | ------------------------- help: try: `if let Some() = country_list` [INFO] [stdout] 480 | { [INFO] [stdout] 481 | countries = split_and_dedup_countries(source_id, &country_list.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/processor.rs:360:8 [INFO] [stdout] | [INFO] [stdout] 360 | if sd_sid == "" || sd_sid == "null" || sd_sid == "NULL" { // Seems to happen, or has happened in the past, with one Dutc... [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sd_sid.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/processor.rs:384:5 [INFO] [stdout] | [INFO] [stdout] 384 | let status: i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `status` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 384 ~ [INFO] [stdout] 385 ~ let status: i32 = if w.results_yes_no.to_lowercase() == "yes" { [INFO] [stdout] 386 ~ 30 // completed [INFO] [stdout] 387 | } [INFO] [stdout] 388 | else { [INFO] [stdout] 389 | let study_status = w.recruitment_status.tidy(); [INFO] [stdout] 390 ~ get_status(&study_status) [INFO] [stdout] 391 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/download/processor.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | table_name = table_name + suffix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name += suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/download/processor.rs:473:9 [INFO] [stdout] | [INFO] [stdout] 473 | table_name = table_name + suffix; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name += suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/processor.rs:478:5 [INFO] [stdout] | [INFO] [stdout] 478 | let countries: Option>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `countries` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 478 ~ [INFO] [stdout] 479 ~ let countries: Option> = if country_list.is_some() [INFO] [stdout] 480 | { [INFO] [stdout] 481 ~ split_and_dedup_countries(source_id, &country_list.unwrap()) [INFO] [stdout] 482 | } [INFO] [stdout] 483 | else { [INFO] [stdout] 484 ~ None [INFO] [stdout] 485 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:9:66 [INFO] [stdout] | [INFO] [stdout] 9 | record_date: &Option, full_path: &PathBuf, pool: &Pool) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - record_date: &Option, full_path: &PathBuf, pool: &Pool) -> Result { [INFO] [stdout] 9 + record_date: &Option, full_path: &Path, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:83:64 [INFO] [stdout] | [INFO] [stdout] 83 | pub async fn add_new_single_file_record(dl_id: i32, file_path: &PathBuf, file_res: &DownloadResult, pool: &Pool) -> Result... [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 83 - pub async fn add_new_single_file_record(dl_id: i32, file_path: &PathBuf, file_res: &DownloadResult, pool: &Pool) -> Result { [INFO] [stdout] 83 + pub async fn add_new_single_file_record(dl_id: i32, file_path: &Path, file_res: &DownloadResult, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/data_access.rs:96:45 [INFO] [stdout] | [INFO] [stdout] 96 | pub async fn add_contents_record(file_path: &PathBuf, source_tots: &mut HashMap, pool: &Pool) -> Result, pool: &Pool) -> Result { [INFO] [stdout] 96 + pub async fn add_contents_record(file_path: &Path, source_tots: &mut HashMap, pool: &Pool) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/data_access.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | if sids.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 25 ~ [INFO] [stdout] 26 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 27 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 28 ~ self.trim_matches(complex_trim) [INFO] [stdout] 29 | } [INFO] [stdout] 30 | else { [INFO] [stdout] 31 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 32 ~ self.trim_matches(complex_trim) [INFO] [stdout] 33 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 53 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 54 ~ self.trim_matches(complex_trim) [INFO] [stdout] 55 | } [INFO] [stdout] 56 | else { [INFO] [stdout] 57 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 58 ~ self.trim_matches(complex_trim) [INFO] [stdout] 59 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/download/gen_helper.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let trimmed: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trimmed` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 84 ~ [INFO] [stdout] 85 ~ let trimmed: &str = if self.starts_with("\"") { [INFO] [stdout] 86 | let complex_trim = |c| c == ' ' || c == ';' || c == '"'; [INFO] [stdout] 87 ~ self.trim_matches(complex_trim) [INFO] [stdout] 88 | } [INFO] [stdout] 89 | else { [INFO] [stdout] 90 | let complex_trim = |c| c == ' ' || c == ';'; [INFO] [stdout] 91 ~ self.trim_matches(complex_trim) [INFO] [stdout] 92 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/gen_helper.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 93 | if trimmed == "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `trimmed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download/gen_helper.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | return units.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return units.to_string() [INFO] [stdout] 319 + units.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn get_source_id(sd_sid: &String) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 8 - pub fn get_source_id(sd_sid: &String) -> i32 { [INFO] [stdout] 8 + pub fn get_source_id(sd_sid: &str) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:228:39 [INFO] [stdout] | [INFO] [stdout] 228 | pub fn get_conditions(condition_list: &String, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - pub fn get_conditions(condition_list: &String, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] 228 + pub fn get_conditions(condition_list: &str, source_id: i32) -> (Vec, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/download/who_helper.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 242 | if s1 != "" && s1.len() >= 3 [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:252:26 [INFO] [stdout] | [INFO] [stdout] 252 | let re = Regex::new(r"MedDRA version: (?.+)Level").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:253:49 [INFO] [stdout] | [INFO] [stdout] 253 | let version = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:259:26 [INFO] [stdout] | [INFO] [stdout] 259 | let re = Regex::new(r"Level: (?.+)Classific").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:260:47 [INFO] [stdout] | [INFO] [stdout] 260 | let level = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:266:26 [INFO] [stdout] | [INFO] [stdout] 266 | let re = Regex::new(r"Classification code (?[0-9]+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:267:46 [INFO] [stdout] | [INFO] [stdout] 267 | let code = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 273 | let re = Regex::new(r"Term: (?.+)System").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:274:46 [INFO] [stdout] | [INFO] [stdout] 274 | let term = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:280:26 [INFO] [stdout] | [INFO] [stdout] 280 | let re = Regex::new(r"System Organ Class: (?[0-9]+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:281:50 [INFO] [stdout] | [INFO] [stdout] 281 | let soc_code = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/download/who_helper.rs:287:26 [INFO] [stdout] | [INFO] [stdout] 287 | let re = Regex::new(r"System Organ Class: (.+) - (?.+)$").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/download/who_helper.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | for s in sep_conds [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/download/who_helper.rs:288:50 [INFO] [stdout] | [INFO] [stdout] 288 | let soc_term = match re.captures(&s1) [INFO] [stdout] | ^^^ help: change this to: `s1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/download/who_helper.rs:386:5 [INFO] [stdout] | [INFO] [stdout] 386 | return Some(out_strings); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 386 - return Some(out_strings); [INFO] [stdout] 386 + Some(out_strings) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:320:64 [INFO] [stdout] | [INFO] [stdout] 320 | pub fn split_and_dedup_countries(source_id: i32, country_list: &String) -> Option> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 320 - pub fn split_and_dedup_countries(source_id: i32, country_list: &String) -> Option> { [INFO] [stdout] 320 + pub fn split_and_dedup_countries(source_id: i32, country_list: &str) -> Option> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/who_helper.rs:392:8 [INFO] [stdout] | [INFO] [stdout] 392 | if out_strings.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out_strings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:411:39 [INFO] [stdout] | [INFO] [stdout] 411 | pub fn add_eu_design_features(design: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 411 - pub fn add_eu_design_features(design: &String) -> Vec { [INFO] [stdout] 411 + pub fn add_eu_design_features(design: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:448:44 [INFO] [stdout] | [INFO] [stdout] 448 | pub fn add_int_study_features(design_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 448 - pub fn add_int_study_features(design_list: &String) -> Vec [INFO] [stdout] 448 + pub fn add_int_study_features(design_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:500:39 [INFO] [stdout] | [INFO] [stdout] 500 | pub fn add_obs_study_features(design: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 500 - pub fn add_obs_study_features(design: &String) -> Vec [INFO] [stdout] 500 + pub fn add_obs_study_features(design: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:557:42 [INFO] [stdout] | [INFO] [stdout] 557 | pub fn add_masking_features(design_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 557 - pub fn add_masking_features(design_list: &String) -> Vec [INFO] [stdout] 557 + pub fn add_masking_features(design_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:636:42 [INFO] [stdout] | [INFO] [stdout] 636 | pub fn add_eu_phase_features(phase_list: &String) -> Vec [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 636 - pub fn add_eu_phase_features(phase_list: &String) -> Vec [INFO] [stdout] 636 + pub fn add_eu_phase_features(phase_list: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, char>` [INFO] [stdout] --> src/download/who_helper.rs:647:25 [INFO] [stdout] | [INFO] [stdout] 647 | let ps: Vec<&str> = phase_list.split(':').into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `phase_list.split(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/download/who_helper.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 688 | if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] | ____________^ [INFO] [stdout] 689 | | || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 | | || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 688 - if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] 689 - || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 - || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] 688 + if !(phase != "phase 0" && phase != "phase-0" && phase != "phase0" && phase != "0" && phase != "0 (exploratory trials)" && phase != "phase 0 (exploratory trials)") [INFO] [stdout] | [INFO] [stdout] 688 - if phase == "phase 0" || phase == "phase-0" || phase == "phase0" [INFO] [stdout] 689 - || phase == "0" || phase == "0 (exploratory trials)" [INFO] [stdout] 690 - || phase == "phase 0 (exploratory trials)" || phase == "0 (exploratory trials)" [INFO] [stdout] 688 + if phase == "phase 0" || phase == "phase-0" || phase == "phase0" || phase == "0" || phase == "0 (exploratory trials)" || phase == "phase 0 (exploratory trials)" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/download/who_helper.rs:741:90 [INFO] [stdout] | [INFO] [stdout] 741 | pub fn split_and_add_ids(existing_ids: &Vec::, sd_sid: &String, in_string: &String, source_field: &str) -> Vec, sd_sid: &String, in_string: &String, source_field: &str) -> Vec [INFO] [stdout] 741 + pub fn split_and_add_ids(existing_ids: &Vec::, sd_sid: &String, in_string: &str, source_field: &str) -> Vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/download/who_helper.rs:756:46 [INFO] [stdout] | [INFO] [stdout] 756 | if secid_low.chars().any(|c| c.is_digit(10)) // has to include at least 1 number [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/download/who_helper.rs:772:52 [INFO] [stdout] | [INFO] [stdout] 772 | if sec_id_base.processed_id == sd_sid.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*sd_sid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/download/who_helper.rs:775:29 [INFO] [stdout] | [INFO] [stdout] 775 | else if existing_ids.len() > 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!existing_ids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/download/mod.rs:126:31 [INFO] [stdout] | [INFO] [stdout] 126 | fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 126 - fn folder_exists(folder_name: &PathBuf) -> bool { [INFO] [stdout] 126 + fn folder_exists(folder_name: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/download/mod.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 127 | / let res = match folder_name.try_exists() { [INFO] [stdout] 128 | | Ok(true) => true, [INFO] [stdout] 129 | | Ok(false) => false, [INFO] [stdout] 130 | | Err(_e) => false, [INFO] [stdout] 131 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 132 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 127 ~ [INFO] [stdout] 128 ~ match folder_name.try_exists() { [INFO] [stdout] 129 + Ok(true) => true, [INFO] [stdout] 130 + Ok(false) => false, [INFO] [stdout] 131 + Err(_e) => false, [INFO] [stdout] 132 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DownloadResult` [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | DownloadResult { [INFO] [stdout] 23 | | num_checked: 0, [INFO] [stdout] 24 | | num_downloaded: 0, [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for DownloadResult { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | let cli_pars: cli_reader::CliPars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 41 | cli_pars = cli_reader::fetch_valid_arguments(args)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `cli_pars` here [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ let cli_pars: cli_reader::CliPars = cli_reader::fetch_valid_arguments(args)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `Command { std: "docker" "inspect" "87da6b2afac65c55214ccdebad8ae8e20501f5bb8a7bcc3a5cf9eef352c95bb2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87da6b2afac65c55214ccdebad8ae8e20501f5bb8a7bcc3a5cf9eef352c95bb2", kill_on_drop: false }` [INFO] [stdout] 87da6b2afac65c55214ccdebad8ae8e20501f5bb8a7bcc3a5cf9eef352c95bb2