[INFO] cloning repository https://github.com/stefanhofman/advent-of-code
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stefanhofman/advent-of-code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstefanhofman%2Fadvent-of-code", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstefanhofman%2Fadvent-of-code'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] c1828010a027be636a3fad74ad882a408562c374
[INFO] linting stefanhofman/advent-of-code against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstefanhofman%2Fadvent-of-code" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/stefanhofman/advent-of-code
[INFO] finished tweaking git repo https://github.com/stefanhofman/advent-of-code
[INFO] tweaked toml for git repo https://github.com/stefanhofman/advent-of-code written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/stefanhofman/advent-of-code on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/stefanhofman/advent-of-code already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d303841573f8bf6a83286c4f0e036cc99500a767a0c6dc0ce735ee666722f805
[INFO] running `Command { std: "docker" "start" "-a" "d303841573f8bf6a83286c4f0e036cc99500a767a0c6dc0ce735ee666722f805", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d303841573f8bf6a83286c4f0e036cc99500a767a0c6dc0ce735ee666722f805", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d303841573f8bf6a83286c4f0e036cc99500a767a0c6dc0ce735ee666722f805", kill_on_drop: false }`
[INFO] [stdout] d303841573f8bf6a83286c4f0e036cc99500a767a0c6dc0ce735ee666722f805
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5e709af76c8dc7fb8e3dc653c857c836cdece6ea052476b4b6cd94fb2856df4f
[INFO] running `Command { std: "docker" "start" "-a" "5e709af76c8dc7fb8e3dc653c857c836cdece6ea052476b4b6cd94fb2856df4f", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.92
[INFO] [stderr]    Compiling unicode-ident v1.0.14
[INFO] [stderr]    Compiling paste v1.0.15
[INFO] [stderr]     Checking strsim v0.11.1
[INFO] [stderr]     Checking clap_lex v0.7.4
[INFO] [stderr]     Checking anstream v0.6.18
[INFO] [stderr]    Compiling heck v0.5.0
[INFO] [stderr]     Checking regex-automata v0.4.9
[INFO] [stderr]     Checking clap_builder v4.5.23
[INFO] [stderr]    Compiling quote v1.0.37
[INFO] [stderr]    Compiling syn v2.0.90
[INFO] [stderr]     Checking regex v1.11.1
[INFO] [stderr]    Compiling clap_derive v4.5.18
[INFO] [stderr]     Checking clap v4.5.23
[INFO] [stderr]     Checking year_2024 v0.1.0 (/opt/rustwide/workdir/advent_of_code_2024)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> advent_of_code_2024/src/day_03/part_2.rs:20:54
[INFO] [stdout]    |
[INFO] [stdout] 20 |     for cap in reg.captures_iter(&text).filter(|cap| !cap.get(1).is_none()) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `cap.get(1).is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_04/part_2.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return col.contains("MAS") || col.contains("SAM");
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return col.contains("MAS") || col.contains("SAM");
[INFO] [stdout] 33 +     col.contains("MAS") || col.contains("SAM")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_1.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if line == "" {
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_2.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if line == "" {
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> advent_of_code_2024/src/day_05/part_2.rs:100:5
[INFO] [stdout]     |
[INFO] [stdout] 100 |     return re_order_and_validate(&string_line, dependencies);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -     return re_order_and_validate(&string_line, dependencies);
[INFO] [stdout] 100 +     re_order_and_validate(&string_line, dependencies)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_2.rs:77:16
[INFO] [stdout]    |
[INFO] [stdout] 77 |             if deps.len() > 0 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!deps.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_1.rs:26:32
[INFO] [stdout]    |
[INFO] [stdout] 26 |     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 26 -     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout] 26 +     fn move_pos(&self, matrix: &[Vec<char>]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_1.rs:59:35
[INFO] [stdout]    |
[INFO] [stdout] 59 |     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 59 -     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout] 59 +     fn can_go_next(&self, matrix: &[Vec<char>]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_2.rs:36:32
[INFO] [stdout]    |
[INFO] [stdout] 36 |     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 36 -     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout] 36 +     fn move_pos(&self, matrix: &[Vec<char>]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_2.rs:69:35
[INFO] [stdout]    |
[INFO] [stdout] 69 |     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 69 -     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout] 69 +     fn can_go_next(&self, matrix: &[Vec<char>]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> advent_of_code_2024/src/day_06/part_2.rs:138:20
[INFO] [stdout]     |
[INFO] [stdout] 138 |             if let Some(_) = explored.get(&position) {
[INFO] [stdout]     |             -------^^^^^^^-------------------------- help: try: `if explored.get(&position).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_1.rs:30:32
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 nodes.entry(c).or_insert_with(Vec::new).push(Point {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_1.rs:41:35
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let pairs = get_all_pairs(&node.1);
[INFO] [stdout]    |                                   ^^^^^^^ help: change this to: `node.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_2.rs:30:32
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 nodes.entry(c).or_insert_with(Vec::new).push(Point {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_2.rs:41:35
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let pairs = get_all_pairs(&node.1);
[INFO] [stdout]    |                                   ^^^^^^^ help: change this to: `node.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_1.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             return c * i as i64;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -             return c * i as i64;
[INFO] [stdout] 43 +             c * i as i64
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:42:46
[INFO] [stdout]    |
[INFO] [stdout] 42 |     let mut final_mem: Vec<Mem> = current_mem.iter().copied().collect();
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stdout]    = note: `#[warn(clippy::iter_cloned_collect)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Mem` which implements the `Copy` trait
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:50:26
[INFO] [stdout]    |
[INFO] [stdout] 50 |                 let fs = final_mem[spot].clone();
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `final_mem[spot]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `repeat().take()` can be written more concisely
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:80:23
[INFO] [stdout]    |
[INFO] [stdout] 80 |         .flat_map(|f| std::iter::repeat(f).take(f.size))
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(f, f.size)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
[INFO] [stdout]    = note: `#[warn(clippy::manual_repeat_n)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:86:13
[INFO] [stdout]    |
[INFO] [stdout] 86 |             return 0;
[INFO] [stdout]    |             ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             return 0;
[INFO] [stdout] 86 +             0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 |         line.chars().into_iter().enumerate().for_each(|(x, n)| {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:67:5
[INFO] [stdout]    |
[INFO] [stdout] 67 |     return count;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 -     return count;
[INFO] [stdout] 67 +     count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:70:30
[INFO] [stdout]    |
[INFO] [stdout] 70 | fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 - fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout] 70 + fn check_neighbours(numbers: &mut [Node], x: usize, y: usize, length: usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:22:9
[INFO] [stdout]    |
[INFO] [stdout] 22 |         line.chars().into_iter().enumerate().for_each(|(x, n)| {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:56:5
[INFO] [stdout]    |
[INFO] [stdout] 56 |     return count;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -     return count;
[INFO] [stdout] 56 +     count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:59:30
[INFO] [stdout]    |
[INFO] [stdout] 59 | fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 59 - fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout] 59 + fn check_neighbours(numbers: &mut [Node], x: usize, y: usize, length: usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> advent_of_code_2024/src/day_03/part_2.rs:20:54
[INFO] [stdout]    |
[INFO] [stdout] 20 |     for cap in reg.captures_iter(&text).filter(|cap| !cap.get(1).is_none()) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `cap.get(1).is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_04/part_2.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return col.contains("MAS") || col.contains("SAM");
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return col.contains("MAS") || col.contains("SAM");
[INFO] [stdout] 33 +     col.contains("MAS") || col.contains("SAM")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_1.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if line == "" {
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_2.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if line == "" {
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> advent_of_code_2024/src/day_05/part_2.rs:100:5
[INFO] [stdout]     |
[INFO] [stdout] 100 |     return re_order_and_validate(&string_line, dependencies);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 -     return re_order_and_validate(&string_line, dependencies);
[INFO] [stdout] 100 +     re_order_and_validate(&string_line, dependencies)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> advent_of_code_2024/src/day_05/part_2.rs:77:16
[INFO] [stdout]    |
[INFO] [stdout] 77 |             if deps.len() > 0 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!deps.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_1.rs:26:32
[INFO] [stdout]    |
[INFO] [stdout] 26 |     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 26 -     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout] 26 +     fn move_pos(&self, matrix: &[Vec<char>]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_1.rs:59:35
[INFO] [stdout]    |
[INFO] [stdout] 59 |     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 59 -     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout] 59 +     fn can_go_next(&self, matrix: &[Vec<char>]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_2.rs:36:32
[INFO] [stdout]    |
[INFO] [stdout] 36 |     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 36 -     fn move_pos(&self, matrix: &Vec<Vec<char>>) -> Self {
[INFO] [stdout] 36 +     fn move_pos(&self, matrix: &[Vec<char>]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_06/part_2.rs:69:35
[INFO] [stdout]    |
[INFO] [stdout] 69 |     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 69 -     fn can_go_next(&self, matrix: &Vec<Vec<char>>) -> bool {
[INFO] [stdout] 69 +     fn can_go_next(&self, matrix: &[Vec<char>]) -> bool {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> advent_of_code_2024/src/day_06/part_2.rs:138:20
[INFO] [stdout]     |
[INFO] [stdout] 138 |             if let Some(_) = explored.get(&position) {
[INFO] [stdout]     |             -------^^^^^^^-------------------------- help: try: `if explored.get(&position).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_1.rs:30:32
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 nodes.entry(c).or_insert_with(Vec::new).push(Point {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]    = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_1.rs:41:35
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let pairs = get_all_pairs(&node.1);
[INFO] [stdout]    |                                   ^^^^^^^ help: change this to: `node.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `or_insert_with` to construct default value
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_2.rs:30:32
[INFO] [stdout]    |
[INFO] [stdout] 30 |                 nodes.entry(c).or_insert_with(Vec::new).push(Point {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> advent_of_code_2024/src/day_08/part_2.rs:41:35
[INFO] [stdout]    |
[INFO] [stdout] 41 |         let pairs = get_all_pairs(&node.1);
[INFO] [stdout]    |                                   ^^^^^^^ help: change this to: `node.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_1.rs:43:13
[INFO] [stdout]    |
[INFO] [stdout] 43 |             return c * i as i64;
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -             return c * i as i64;
[INFO] [stdout] 43 +             c * i as i64
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `iter().copied().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:42:46
[INFO] [stdout]    |
[INFO] [stdout] 42 |     let mut final_mem: Vec<Mem> = current_mem.iter().copied().collect();
[INFO] [stdout]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
[INFO] [stdout]    = note: `#[warn(clippy::iter_cloned_collect)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Mem` which implements the `Copy` trait
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:50:26
[INFO] [stdout]    |
[INFO] [stdout] 50 |                 let fs = final_mem[spot].clone();
[INFO] [stdout]    |                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `final_mem[spot]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]    = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `repeat().take()` can be written more concisely
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:80:23
[INFO] [stdout]    |
[INFO] [stdout] 80 |         .flat_map(|f| std::iter::repeat(f).take(f.size))
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(f, f.size)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
[INFO] [stdout]    = note: `#[warn(clippy::manual_repeat_n)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_09/part_2.rs:86:13
[INFO] [stdout]    |
[INFO] [stdout] 86 |             return 0;
[INFO] [stdout]    |             ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             return 0;
[INFO] [stdout] 86 +             0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:23:9
[INFO] [stdout]    |
[INFO] [stdout] 23 |         line.chars().into_iter().enumerate().for_each(|(x, n)| {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:67:5
[INFO] [stdout]    |
[INFO] [stdout] 67 |     return count;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 67 -     return count;
[INFO] [stdout] 67 +     count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_1.rs:70:30
[INFO] [stdout]    |
[INFO] [stdout] 70 | fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 - fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout] 70 + fn check_neighbours(numbers: &mut [Node], x: usize, y: usize, length: usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>`
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:22:9
[INFO] [stdout]    |
[INFO] [stdout] 22 |         line.chars().into_iter().enumerate().for_each(|(x, n)| {
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.chars()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:56:5
[INFO] [stdout]    |
[INFO] [stdout] 56 |     return count;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -     return count;
[INFO] [stdout] 56 +     count
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> advent_of_code_2024/src/day_10/part_2.rs:59:30
[INFO] [stdout]    |
[INFO] [stdout] 59 | fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout]    |                              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 59 - fn check_neighbours(numbers: &mut Vec<Node>, x: usize, y: usize, length: usize) {
[INFO] [stdout] 59 + fn check_neighbours(numbers: &mut [Node], x: usize, y: usize, length: usize) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.44s
[INFO] running `Command { std: "docker" "inspect" "5e709af76c8dc7fb8e3dc653c857c836cdece6ea052476b4b6cd94fb2856df4f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5e709af76c8dc7fb8e3dc653c857c836cdece6ea052476b4b6cd94fb2856df4f", kill_on_drop: false }`
[INFO] [stdout] 5e709af76c8dc7fb8e3dc653c857c836cdece6ea052476b4b6cd94fb2856df4f