[INFO] cloning repository https://github.com/stangassinger/sudoku_rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/stangassinger/sudoku_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstangassinger%2Fsudoku_rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstangassinger%2Fsudoku_rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 77aef4e8621f84657a6b362840df13e5526791a2
[INFO] linting stangassinger/sudoku_rust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fstangassinger%2Fsudoku_rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/stangassinger/sudoku_rust
[INFO] finished tweaking git repo https://github.com/stangassinger/sudoku_rust
[INFO] tweaked toml for git repo https://github.com/stangassinger/sudoku_rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/stangassinger/sudoku_rust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/stangassinger/sudoku_rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 2e5e8b4763880e11c1394f1c606b586178fd4d10796cf8268c3429c378eea66d
[INFO] running `Command { std: "docker" "start" "-a" "2e5e8b4763880e11c1394f1c606b586178fd4d10796cf8268c3429c378eea66d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "2e5e8b4763880e11c1394f1c606b586178fd4d10796cf8268c3429c378eea66d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2e5e8b4763880e11c1394f1c606b586178fd4d10796cf8268c3429c378eea66d", kill_on_drop: false }`
[INFO] [stdout] 2e5e8b4763880e11c1394f1c606b586178fd4d10796cf8268c3429c378eea66d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 653a010c4d37c28e3b488feba78ab937b7c444e8ed4dd5acf40c127987dedb51
[INFO] running `Command { std: "docker" "start" "-a" "653a010c4d37c28e3b488feba78ab937b7c444e8ed4dd5acf40c127987dedb51", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking sudoku v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]   --> src/main.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 | /         if ret == true {
[INFO] [stdout] 31 | |             return true;
[INFO] [stdout] 32 | |         } else {
[INFO] [stdout] 33 | |             return false;
[INFO] [stdout] 34 | |         }
[INFO] [stdout]    | |_________^ help: you can reduce it to: `return ret == true`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]    = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:30:12
[INFO] [stdout]    |
[INFO] [stdout] 30 |         if ret == true {
[INFO] [stdout]    |            ^^^^^^^^^^^ help: try: `ret`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:37:12
[INFO] [stdout]    |
[INFO] [stdout] 37 |         if check_validity(n, pos % 9, pos / 9, sudoku_ar) == true {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_validity(n, pos % 9, pos / 9, sudoku_ar)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:40:16
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if ret == true {
[INFO] [stdout]    |                ^^^^^^^^^^^ help: try: `ret`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:54:32
[INFO] [stdout]    |
[INFO] [stdout] 54 |         if (i + 1) % 3 == 0 && !((i + 1) % 9 == 0) {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^ help: try: `((i + 1) % 9 != 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `sudoku_ar`
[INFO] [stdout]   --> src/main.rs:52:14
[INFO] [stdout]    |
[INFO] [stdout] 52 |     for i in 0..sudoku_ar.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 52 -     for i in 0..sudoku_ar.len() {
[INFO] [stdout] 52 +     for (i, <item>) in sudoku_ar.iter().enumerate() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]   --> src/main.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if solve(&mut sudoku_ar) == false {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!solve(&mut sudoku_ar)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]   --> src/main.rs:30:9
[INFO] [stdout]    |
[INFO] [stdout] 30 | /         if ret == true {
[INFO] [stdout] 31 | |             return true;
[INFO] [stdout] 32 | |         } else {
[INFO] [stdout] 33 | |             return false;
[INFO] [stdout] 34 | |         }
[INFO] [stdout]    | |_________^ help: you can reduce it to: `return ret == true`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]    = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:30:12
[INFO] [stdout]    |
[INFO] [stdout] 30 |         if ret == true {
[INFO] [stdout]    |            ^^^^^^^^^^^ help: try: `ret`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:37:12
[INFO] [stdout]    |
[INFO] [stdout] 37 |         if check_validity(n, pos % 9, pos / 9, sudoku_ar) == true {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_validity(n, pos % 9, pos / 9, sudoku_ar)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:40:16
[INFO] [stdout]    |
[INFO] [stdout] 40 |             if ret == true {
[INFO] [stdout]    |                ^^^^^^^^^^^ help: try: `ret`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:54:32
[INFO] [stdout]    |
[INFO] [stdout] 54 |         if (i + 1) % 3 == 0 && !((i + 1) % 9 == 0) {
[INFO] [stdout]    |                                ^^^^^^^^^^^^^^^^^^^ help: try: `((i + 1) % 9 != 0)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `sudoku_ar`
[INFO] [stdout]   --> src/main.rs:52:14
[INFO] [stdout]    |
[INFO] [stdout] 52 |     for i in 0..sudoku_ar.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 52 -     for i in 0..sudoku_ar.len() {
[INFO] [stdout] 52 +     for (i, <item>) in sudoku_ar.iter().enumerate() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]   --> src/main.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if solve(&mut sudoku_ar) == false {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!solve(&mut sudoku_ar)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.14s
[INFO] running `Command { std: "docker" "inspect" "653a010c4d37c28e3b488feba78ab937b7c444e8ed4dd5acf40c127987dedb51", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "653a010c4d37c28e3b488feba78ab937b7c444e8ed4dd5acf40c127987dedb51", kill_on_drop: false }`
[INFO] [stdout] 653a010c4d37c28e3b488feba78ab937b7c444e8ed4dd5acf40c127987dedb51