[INFO] cloning repository https://github.com/squidarth/optimal-line-length
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/squidarth/optimal-line-length" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsquidarth%2Foptimal-line-length", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsquidarth%2Foptimal-line-length'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8daab2974035469ebe2c850347dcff48bb49dd3a
[INFO] linting squidarth/optimal-line-length against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsquidarth%2Foptimal-line-length" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/squidarth/optimal-line-length
[INFO] finished tweaking git repo https://github.com/squidarth/optimal-line-length
[INFO] tweaked toml for git repo https://github.com/squidarth/optimal-line-length written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/squidarth/optimal-line-length on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/squidarth/optimal-line-length already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] ed8d5ee90c6051c6b13f6ece4f248fef955cde52939934668e6dfb4ff7dd1dc2
[INFO] running `Command { std: "docker" "start" "-a" "ed8d5ee90c6051c6b13f6ece4f248fef955cde52939934668e6dfb4ff7dd1dc2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "ed8d5ee90c6051c6b13f6ece4f248fef955cde52939934668e6dfb4ff7dd1dc2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ed8d5ee90c6051c6b13f6ece4f248fef955cde52939934668e6dfb4ff7dd1dc2", kill_on_drop: false }`
[INFO] [stdout] ed8d5ee90c6051c6b13f6ece4f248fef955cde52939934668e6dfb4ff7dd1dc2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 821a34d9ef08b9ee1cf43f272739af26344fc13b437de448bcea4a71c5515c86
[INFO] running `Command { std: "docker" "start" "-a" "821a34d9ef08b9ee1cf43f272739af26344fc13b437de448bcea4a71c5515c86", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking line_breaks v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/main.rs:50:19
[INFO] [stdout]    |
[INFO] [stdout] 50 |               let mut previous_cost: i32;
[INFO] [stdout]    |                   ----^^^^^^^^^^^^^
[INFO] [stdout]    |                   |
[INFO] [stdout]    |                   help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 |     return final_string
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 20 -     return final_string
[INFO] [stdout] 20 +     final_string
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/main.rs:5:60
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_final_string(words: Vec<&str>, final_break_indexes: &mut Vec<usize>) -> String {
[INFO] [stdout]   |                                                            ^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_final_string(words: Vec<&str>, final_break_indexes: &mut Vec<usize>) -> String {
[INFO] [stdout] 5 + fn get_final_string(words: Vec<&str>, final_break_indexes: &mut [usize]) -> String {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable does not need to be mutable
[INFO] [stdout]   --> src/main.rs:50:19
[INFO] [stdout]    |
[INFO] [stdout] 50 |               let mut previous_cost: i32;
[INFO] [stdout]    |                   ----^^^^^^^^^^^^^
[INFO] [stdout]    |                   |
[INFO] [stdout]    |                   help: remove this `mut`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `words`
[INFO] [stdout]   --> src/main.rs:10:14
[INFO] [stdout]    |
[INFO] [stdout] 10 |     for i in 0..words.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 10 -     for i in 0..words.len() {
[INFO] [stdout] 10 +     for (i, <item>) in words.iter().enumerate() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return final_break_indexes;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return final_break_indexes;
[INFO] [stdout] 26 +     final_break_indexes
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:31:7
[INFO] [stdout]    |
[INFO] [stdout] 31 |       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout] 31 +       get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/main.rs:31:58
[INFO] [stdout]    |
[INFO] [stdout] 31 |       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `last_break_index`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:48:16
[INFO] [stdout]    |
[INFO] [stdout] 48 |             if !(line_length > max_line_length) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(line_length <= max_line_length)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 |     return final_string
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 20 -     return final_string
[INFO] [stdout] 20 +     final_string
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     let max_line_length: i32;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `max_line_length` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 78 ~     
[INFO] [stdout] 79 ~     let max_line_length: i32 = match max_line_length_argv {
[INFO] [stdout] 80 ~         Some(x) => x.parse().unwrap(),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]  --> src/main.rs:5:60
[INFO] [stdout]   |
[INFO] [stdout] 5 | fn get_final_string(words: Vec<&str>, final_break_indexes: &mut Vec<usize>) -> String {
[INFO] [stdout]   |                                                            ^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]   = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]   |
[INFO] [stdout] 5 - fn get_final_string(words: Vec<&str>, final_break_indexes: &mut Vec<usize>) -> String {
[INFO] [stdout] 5 + fn get_final_string(words: Vec<&str>, final_break_indexes: &mut [usize]) -> String {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `words`
[INFO] [stdout]   --> src/main.rs:10:14
[INFO] [stdout]    |
[INFO] [stdout] 10 |     for i in 0..words.len() {
[INFO] [stdout]    |              ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]    = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]    |
[INFO] [stdout] 10 -     for i in 0..words.len() {
[INFO] [stdout] 10 +     for (i, <item>) in words.iter().enumerate() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:26:5
[INFO] [stdout]    |
[INFO] [stdout] 26 |     return final_break_indexes;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 26 -     return final_break_indexes;
[INFO] [stdout] 26 +     final_break_indexes
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:31:7
[INFO] [stdout]    |
[INFO] [stdout] 31 |       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout] 31 +       get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:88:5
[INFO] [stdout]    |
[INFO] [stdout] 88 |     let filename: String;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `filename` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 88 ~     
[INFO] [stdout] 89 ~     let filename: String = match filename_argv {
[INFO] [stdout] 90 ~         Some(x) => x.to_string(),
[INFO] [stdout] 91 |         None => {
[INFO] [stdout] ...
[INFO] [stdout] 94 |         }
[INFO] [stdout] 95 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/main.rs:31:58
[INFO] [stdout]    |
[INFO] [stdout] 31 |       return get_break_indexes(previous_break_indexes[0..(last_break_index as usize)].to_vec(), final_break_indexes)
[INFO] [stdout]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `last_break_index`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:48:16
[INFO] [stdout]    |
[INFO] [stdout] 48 |             if !(line_length > max_line_length) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(line_length <= max_line_length)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:78:5
[INFO] [stdout]    |
[INFO] [stdout] 78 |     let max_line_length: i32;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]    = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `max_line_length` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 78 ~     
[INFO] [stdout] 79 ~     let max_line_length: i32 = match max_line_length_argv {
[INFO] [stdout] 80 ~         Some(x) => x.parse().unwrap(),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]   --> src/main.rs:88:5
[INFO] [stdout]    |
[INFO] [stdout] 88 |     let filename: String;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `filename` here and remove the assignments from the `match` arms
[INFO] [stdout]    |
[INFO] [stdout] 88 ~     
[INFO] [stdout] 89 ~     let filename: String = match filename_argv {
[INFO] [stdout] 90 ~         Some(x) => x.to_string(),
[INFO] [stdout] 91 |         None => {
[INFO] [stdout] ...
[INFO] [stdout] 94 |         }
[INFO] [stdout] 95 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s
[INFO] running `Command { std: "docker" "inspect" "821a34d9ef08b9ee1cf43f272739af26344fc13b437de448bcea4a71c5515c86", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "821a34d9ef08b9ee1cf43f272739af26344fc13b437de448bcea4a71c5515c86", kill_on_drop: false }`
[INFO] [stdout] 821a34d9ef08b9ee1cf43f272739af26344fc13b437de448bcea4a71c5515c86