[INFO] cloning repository https://github.com/spritefullake/pomodoro
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/spritefullake/pomodoro" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspritefullake%2Fpomodoro", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspritefullake%2Fpomodoro'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] ab34445292a458bda66d196044f145d8ee17206a
[INFO] linting spritefullake/pomodoro against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspritefullake%2Fpomodoro" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/spritefullake/pomodoro
[INFO] finished tweaking git repo https://github.com/spritefullake/pomodoro
[INFO] tweaked toml for git repo https://github.com/spritefullake/pomodoro written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/spritefullake/pomodoro on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/spritefullake/pomodoro already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] da768be558c47d852330af46fffe7249e78d3cf42e44b31e0130ea3f4b52cee0
[INFO] running `Command { std: "docker" "start" "-a" "da768be558c47d852330af46fffe7249e78d3cf42e44b31e0130ea3f4b52cee0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "da768be558c47d852330af46fffe7249e78d3cf42e44b31e0130ea3f4b52cee0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "da768be558c47d852330af46fffe7249e78d3cf42e44b31e0130ea3f4b52cee0", kill_on_drop: false }`
[INFO] [stdout] da768be558c47d852330af46fffe7249e78d3cf42e44b31e0130ea3f4b52cee0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 65a098c6d80144b08263981e643e42aa39dd2fbb62d4612835232937a9e24e55
[INFO] running `Command { std: "docker" "start" "-a" "65a098c6d80144b08263981e643e42aa39dd2fbb62d4612835232937a9e24e55", kill_on_drop: false }`
[INFO] [stderr]     Checking pomodoro-timer v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `sync::mpsc::channel`, `thread`, and `time`
[INFO] [stdout]  --> src/main.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 |     sync::mpsc::channel,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 3 |     time,
[INFO] [stdout]   |     ^^^^
[INFO] [stdout] 4 |     thread,
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `ErrorKind`, `Write`, `error::Error`, `process`, `self`, and `thread`
[INFO] [stdout]   --> src/cli.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     error::Error,
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout] 14 |     fs,
[INFO] [stdout] 15 |     io::{self, ErrorKind, Write},
[INFO] [stdout]    |                ^^^^^^^^^  ^^^^^
[INFO] [stdout] 16 |     process,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout] 17 |     time::{self, Duration},
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] 18 |     thread,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `Trigger` and `task::Task`
[INFO] [stdout]  --> src/input.rs:8:21
[INFO] [stdout]   |
[INFO] [stdout] 8 |     fsm::{Stateful, Trigger},
[INFO] [stdout]   |                     ^^^^^^^
[INFO] [stdout] 9 |     task::Task,
[INFO] [stdout]   |     ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `time::Duration`
[INFO] [stdout]   --> src/input.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     time::Duration,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused label
[INFO] [stdout]   --> src/input.rs:79:13
[INFO] [stdout]    |
[INFO] [stdout] 79 |             'event_response: loop{
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `sync::mpsc::channel`, `thread`, and `time`
[INFO] [stdout]  --> src/main.rs:2:5
[INFO] [stdout]   |
[INFO] [stdout] 2 |     sync::mpsc::channel,
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 3 |     time,
[INFO] [stdout]   |     ^^^^
[INFO] [stdout] 4 |     thread,
[INFO] [stdout]   |     ^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `ErrorKind`, `Write`, `error::Error`, `process`, `self`, and `thread`
[INFO] [stdout]   --> src/cli.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     error::Error,
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout] 14 |     fs,
[INFO] [stdout] 15 |     io::{self, ErrorKind, Write},
[INFO] [stdout]    |                ^^^^^^^^^  ^^^^^
[INFO] [stdout] 16 |     process,
[INFO] [stdout]    |     ^^^^^^^
[INFO] [stdout] 17 |     time::{self, Duration},
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] 18 |     thread,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `super::*`
[INFO] [stdout]   --> src/mailbox.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |     use super::*;
[INFO] [stdout]    |         ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Trigger`
[INFO] [stdout]  --> src/input.rs:8:21
[INFO] [stdout]   |
[INFO] [stdout] 8 |     fsm::{Stateful, Trigger},
[INFO] [stdout]   |                     ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused label
[INFO] [stdout]   --> src/input.rs:79:13
[INFO] [stdout]    |
[INFO] [stdout] 79 |             'event_response: loop{
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_labels)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `c`
[INFO] [stdout]   --> src/cli.rs:77:21
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |                     ^ help: if this is intentional, prefix it with an underscore: `_c`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `p`
[INFO] [stdout]   --> src/cli.rs:77:47
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |                                               ^ help: if this is intentional, prefix it with an underscore: `_p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `command_loop` is never used
[INFO] [stdout]   --> src/cli.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |        ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `is_done` is never used
[INFO] [stdout]   --> src/pomodoro.rs:28:12
[INFO] [stdout]    |
[INFO] [stdout] 12 | impl Pomodoro{
[INFO] [stdout]    | ------------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 28 |     pub fn is_done(&self) -> bool {
[INFO] [stdout]    |            ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `Stop` is never constructed
[INFO] [stdout]   --> src/timer_state/event.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | pub enum Event{
[INFO] [stdout]    |          ----- variant in this enum
[INFO] [stdout] 13 |     Start,
[INFO] [stdout] 14 |     Stop,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Event` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `decrement_seconds` and `set` are never used
[INFO] [stdout]   --> src/timer.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 11 | impl Timer {
[INFO] [stdout]    | ---------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 18 |     pub fn decrement_seconds(&mut self, amount: u64) -> &mut Self {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 23 |     pub fn set(&mut self, duration: time::Duration){
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `c`
[INFO] [stdout]   --> src/cli.rs:77:21
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |                     ^ help: if this is intentional, prefix it with an underscore: `_c`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `p`
[INFO] [stdout]   --> src/cli.rs:77:47
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |                                               ^ help: if this is intentional, prefix it with an underscore: `_p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `begin` is never used
[INFO] [stdout]   --> src/input.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | pub fn begin(t: Timer, p: &mut Pomodoro) -> Result<mailbox::Mailbox<Event, State>,Box<dyn Error>>{
[INFO] [stdout]    |        ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type alias `TimerEvent` is never used
[INFO] [stdout]   --> src/input.rs:46:6
[INFO] [stdout]    |
[INFO] [stdout] 46 | type TimerEvent = Result<Event, Box<dyn Error>>;
[INFO] [stdout]    |      ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `stop` and `tick` are never used
[INFO] [stdout]   --> src/input.rs:54:12
[INFO] [stdout]    |
[INFO] [stdout] 48 | impl mailbox::Mailbox<Event, State> {
[INFO] [stdout]    | ----------------------------------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 54 |     pub fn stop(&self) -> TimerState {
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] ...
[INFO] [stdout] 57 |     pub fn tick(&self) -> TimerState {
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/cli.rs:33:28
[INFO] [stdout]    |
[INFO] [stdout] 33 | pub fn run(args: env::Args) -> () {
[INFO] [stdout]    |                            ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/pomodoro.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 | |             None => true,
[INFO] [stdout] 31 | |             _    => false,
[INFO] [stdout] 32 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 29 -         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 -             None => true,
[INFO] [stdout] 31 -             _    => false,
[INFO] [stdout] 32 -         }
[INFO] [stdout] 29 +         matches!(self.tasks.iter().filter(|task| !task.is_complete()).next(), None)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]   --> src/pomodoro.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 | |             None => true,
[INFO] [stdout] 31 | |             _    => false,
[INFO] [stdout] 32 | |         }
[INFO] [stdout]    | |_________^ help: try: `self.tasks.iter().filter(|task| !task.is_complete()).next().is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
[INFO] [stdout]   --> src/pomodoro.rs:29:15
[INFO] [stdout]    |
[INFO] [stdout] 29 |         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tasks.iter().find(|task| !task.is_complete())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stdout]    = note: `#[warn(clippy::filter_next)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/task.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         self.completed == true
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.completed`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `p`
[INFO] [stdout]    --> src/input.rs:119:13
[INFO] [stdout]     |
[INFO] [stdout] 119 |         let p = Pomodoro::new(tasks);
[INFO] [stdout]     |             ^ help: if this is intentional, prefix it with an underscore: `_p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/input.rs:87:17
[INFO] [stdout]    |
[INFO] [stdout] 87 | /                 match event {
[INFO] [stdout] 88 | |                     Event::Stop => thread::park(),
[INFO] [stdout] 89 | |                     _ => (),
[INFO] [stdout] 90 | |                 }
[INFO] [stdout]    | |_________________^ help: try: `if let Event::Stop = event { thread::park() }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `command_loop` is never used
[INFO] [stdout]   --> src/cli.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn command_loop(c: Mailbox<Event, State>, p: &mut Pomodoro) -> io::Result<()> {
[INFO] [stdout]    |        ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `decrement_seconds` and `set` are never used
[INFO] [stdout]   --> src/timer.rs:18:12
[INFO] [stdout]    |
[INFO] [stdout] 11 | impl Timer {
[INFO] [stdout]    | ---------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 18 |     pub fn decrement_seconds(&mut self, amount: u64) -> &mut Self {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 23 |     pub fn set(&mut self, duration: time::Duration){
[INFO] [stdout]    |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function `begin` is never used
[INFO] [stdout]   --> src/input.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | pub fn begin(t: Timer, p: &mut Pomodoro) -> Result<mailbox::Mailbox<Event, State>,Box<dyn Error>>{
[INFO] [stdout]    |        ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type alias `TimerEvent` is never used
[INFO] [stdout]   --> src/input.rs:46:6
[INFO] [stdout]    |
[INFO] [stdout] 46 | type TimerEvent = Result<Event, Box<dyn Error>>;
[INFO] [stdout]    |      ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: methods `stop` and `tick` are never used
[INFO] [stdout]   --> src/input.rs:54:12
[INFO] [stdout]    |
[INFO] [stdout] 48 | impl mailbox::Mailbox<Event, State> {
[INFO] [stdout]    | ----------------------------------- methods in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 54 |     pub fn stop(&self) -> TimerState {
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] ...
[INFO] [stdout] 57 |     pub fn tick(&self) -> TimerState {
[INFO] [stdout]    |            ^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/cli.rs:33:28
[INFO] [stdout]    |
[INFO] [stdout] 33 | pub fn run(args: env::Args) -> () {
[INFO] [stdout]    |                            ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers
[INFO] [stdout]   --> src/format.rs:56:20
[INFO] [stdout]    |
[INFO] [stdout] 56 |                 if current as *const _ == task as *const _ {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(current, task)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
[INFO] [stdout]    = note: `#[warn(clippy::ptr_eq)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]   --> src/pomodoro.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 | |             None => true,
[INFO] [stdout] 31 | |             _    => false,
[INFO] [stdout] 32 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]    = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]    |
[INFO] [stdout] 29 -         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 -             None => true,
[INFO] [stdout] 31 -             _    => false,
[INFO] [stdout] 32 -         }
[INFO] [stdout] 29 +         matches!(self.tasks.iter().filter(|task| !task.is_complete()).next(), None)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]   --> src/pomodoro.rs:29:9
[INFO] [stdout]    |
[INFO] [stdout] 29 | /         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout] 30 | |             None => true,
[INFO] [stdout] 31 | |             _    => false,
[INFO] [stdout] 32 | |         }
[INFO] [stdout]    | |_________^ help: try: `self.tasks.iter().filter(|task| !task.is_complete()).next().is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
[INFO] [stdout]   --> src/pomodoro.rs:29:15
[INFO] [stdout]    |
[INFO] [stdout] 29 |         match self.tasks.iter().filter(|task| !task.is_complete()).next() {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tasks.iter().find(|task| !task.is_complete())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stdout]    = note: `#[warn(clippy::filter_next)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_ne!` with a literal bool
[INFO] [stdout]   --> src/pomodoro.rs:71:9
[INFO] [stdout]    |
[INFO] [stdout] 71 |         assert_ne!(true, p.is_done());
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 71 -         assert_ne!(true, p.is_done());
[INFO] [stdout] 71 +         assert!(!p.is_done());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/task.rs:21:9
[INFO] [stdout]    |
[INFO] [stdout] 21 |         self.completed == true
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.completed`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/input.rs:87:17
[INFO] [stdout]    |
[INFO] [stdout] 87 | /                 match event {
[INFO] [stdout] 88 | |                     Event::Stop => thread::park(),
[INFO] [stdout] 89 | |                     _ => (),
[INFO] [stdout] 90 | |                 }
[INFO] [stdout]    | |_________________^ help: try: `if let Event::Stop = event { thread::park() }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/input.rs:123:20
[INFO] [stdout]     |
[INFO] [stdout] 123 |                 if !(t.duration.as_secs() == 0) {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(t.duration.as_secs() != 0)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers
[INFO] [stdout]   --> src/format.rs:56:20
[INFO] [stdout]    |
[INFO] [stdout] 56 |                 if current as *const _ == task as *const _ {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::ptr::eq(current, task)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq
[INFO] [stdout]    = note: `#[warn(clippy::ptr_eq)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s
[INFO] running `Command { std: "docker" "inspect" "65a098c6d80144b08263981e643e42aa39dd2fbb62d4612835232937a9e24e55", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "65a098c6d80144b08263981e643e42aa39dd2fbb62d4612835232937a9e24e55", kill_on_drop: false }`
[INFO] [stdout] 65a098c6d80144b08263981e643e42aa39dd2fbb62d4612835232937a9e24e55