[INFO] cloning repository https://github.com/spotlesscoder/mixxx-libhelper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/spotlesscoder/mixxx-libhelper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspotlesscoder%2Fmixxx-libhelper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspotlesscoder%2Fmixxx-libhelper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 600c6059972d1e8ec96db1dd9efc401eb0c593d4 [INFO] linting spotlesscoder/mixxx-libhelper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fspotlesscoder%2Fmixxx-libhelper" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/spotlesscoder/mixxx-libhelper [INFO] finished tweaking git repo https://github.com/spotlesscoder/mixxx-libhelper [INFO] tweaked toml for git repo https://github.com/spotlesscoder/mixxx-libhelper written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/spotlesscoder/mixxx-libhelper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/spotlesscoder/mixxx-libhelper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded muldiv v1.0.1 [INFO] [stderr] Downloaded flate2 v1.0.30 [INFO] [stderr] Downloaded serde_spanned v0.6.6 [INFO] [stderr] Downloaded toml_datetime v0.6.6 [INFO] [stderr] Downloaded gobject-sys v0.20.0 [INFO] [stderr] Downloaded target-lexicon v0.12.15 [INFO] [stderr] Downloaded serde_derive v1.0.204 [INFO] [stderr] Downloaded glib-sys v0.20.0 [INFO] [stderr] Downloaded id3 v1.14.0 [INFO] [stderr] Downloaded toml v0.8.15 [INFO] [stderr] Downloaded gio-sys v0.20.0 [INFO] [stderr] Downloaded toml_edit v0.22.16 [INFO] [stderr] Downloaded syn v2.0.70 [INFO] [stderr] Downloaded glib-macros v0.20.0 [INFO] [stderr] Downloaded serde v1.0.204 [INFO] [stderr] Downloaded winnow v0.6.14 [INFO] [stderr] Downloaded gstreamer-sys v0.23.0 [INFO] [stderr] Downloaded system-deps v7.0.1 [INFO] [stderr] Downloaded gstreamer v0.23.3 [INFO] [stderr] Downloaded option-operations v0.5.0 [INFO] [stderr] Downloaded glib v0.20.0 [INFO] [stderr] Downloaded regex-automata v0.4.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 01fd960c712af81f220118c9092a5a4033d455090750aad0375260ae97cecf9b [INFO] running `Command { std: "docker" "start" "-a" "01fd960c712af81f220118c9092a5a4033d455090750aad0375260ae97cecf9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "01fd960c712af81f220118c9092a5a4033d455090750aad0375260ae97cecf9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01fd960c712af81f220118c9092a5a4033d455090750aad0375260ae97cecf9b", kill_on_drop: false }` [INFO] [stdout] 01fd960c712af81f220118c9092a5a4033d455090750aad0375260ae97cecf9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7ea39012d59509fdf5e9af2ec0a520ed2662d7137cdec8ff8412386f8f17c7a [INFO] running `Command { std: "docker" "start" "-a" "b7ea39012d59509fdf5e9af2ec0a520ed2662d7137cdec8ff8412386f8f17c7a", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling target-lexicon v0.12.15 [INFO] [stderr] Compiling winnow v0.6.14 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking option-operations v0.5.0 [INFO] [stderr] Checking muldiv v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking id3 v1.14.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Compiling serde_spanned v0.6.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling toml_edit v0.22.16 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling toml v0.8.15 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling system-deps v7.0.1 [INFO] [stderr] Compiling glib-macros v0.20.0 [INFO] [stderr] Compiling glib-sys v0.20.0 [INFO] [stderr] Compiling gobject-sys v0.20.0 [INFO] [stderr] Compiling gio-sys v0.20.0 [INFO] [stderr] Compiling gstreamer-sys v0.23.0 [INFO] [stderr] Checking glib v0.20.0 [INFO] [stderr] Checking gstreamer v0.23.3 [INFO] [stderr] Checking mixxx_libhelper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `fingerprint` and `fingerprint_algorithm` are never read [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Fingerprint { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 11 | pub fingerprint: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 12 | pub fingerprint_algorithm: FingerprintAlgorithm, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_folder` is never used [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn move_folder( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/logfile_anonymize.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod logfile_anonymize { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use std::collections::HashMap; [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let device_serial_regex = Regex::new(®ex_str).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `regex_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | .replace_all(&line, device_serial_replacement) [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | .replace_all(&line, |caps: ®ex::Captures| { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | result.push_str(&device_serial_replacement); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `device_serial_replacement` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod track; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track/track.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod track { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use id3::Tag; [INFO] [stdout] ... | [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_categorization/genre.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod genre { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | fn is_trance(genre_string: &str) -> bool { [INFO] [stdout] 4 | | return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] 4 + genre_string.to_lowercase().contains("trance") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return genre_string.to_lowercase().contains("dance"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return genre_string.to_lowercase().contains("dance"); [INFO] [stdout] 8 + genre_string.to_lowercase().contains("dance") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] 12 + is_dance(&genre_string) || is_trance(&genre_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `genre_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:53 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `genre_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_fingerprinting.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod track_fingerprinting; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod track_fingerprinting { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use sha2::{Digest, Sha256}; [INFO] [stdout] ... | [INFO] [stdout] 53 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 22 | let file_bytes = std::fs::read(&file_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | if !file.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `file.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_err` [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 18 | if !file.is_err() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 19 | files.push(file.unwrap().path()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | let read_dir = fs::read_dir(&source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | let connection = get_connection(&mixxx_db_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:72:63 [INFO] [stdout] | [INFO] [stdout] 72 | let edm_tracks_low_bpm = find_edm_tracks_with_low_bpm(&mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:90:58 [INFO] [stdout] | [INFO] [stdout] 90 | multiply_bpm(&edm_tracks_low_bpm, 3.0 / 2.0, &mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:101:41 [INFO] [stdout] | [INFO] [stdout] 101 | let connection = get_connection(&db_path); [INFO] [stdout] | ^^^^^^^^ help: change this to: `db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/lib/lib.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | let new_bpm = track.bpm as f64 * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `track.bpm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:121:73 [INFO] [stdout] | [INFO] [stdout] 121 | let tracks_with_bpm_below_100 = find_tracks_with_bpm_below(100, &mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return Ok(result); [INFO] [stdout] 139 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return false; [INFO] [stdout] 156 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / return tracks [INFO] [stdout] 161 | | .iter() [INFO] [stdout] 162 | | .cloned() [INFO] [stdout] 163 | | .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] 164 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 ~ tracks [INFO] [stdout] 161 + .iter() [INFO] [stdout] 162 + .cloned() [INFO] [stdout] 163 + .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] 164 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 159 | fn filter_to_id3_supported_formats(tracks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - fn filter_to_id3_supported_formats(tracks: &Vec) -> Vec { [INFO] [stdout] 159 + fn filter_to_id3_supported_formats(tracks: &[Track]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | return tracks [INFO] [stdout] | _________________^ [INFO] [stdout] 161 | | .iter() [INFO] [stdout] | | ____________________- [INFO] [stdout] 162 | || .cloned() [INFO] [stdout] 163 | || .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] | ||_________________________________________________________________________________^ [INFO] [stdout] | |_________________________________________________________________________________| [INFO] [stdout] | help: try: `.filter(|&track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:167:37 [INFO] [stdout] | [INFO] [stdout] 167 | fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] 167 + fn filter_to_edm_tracks(tracks: &[Track], tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:167:67 [INFO] [stdout] | [INFO] [stdout] 167 | fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] 167 + fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &[Track]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:168:53 [INFO] [stdout] | [INFO] [stdout] 168 | let tracks_identified_from_db: Vec = tracks [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 169 | | .iter() [INFO] [stdout] | | ____________________- [INFO] [stdout] 170 | || .cloned() [INFO] [stdout] 171 | || .filter(|track| is_edm(&track.genre)) [INFO] [stdout] | ||_________________________________________________^ [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | help: try: `.filter(|&track| is_edm(&track.genre)).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:176:54 [INFO] [stdout] | [INFO] [stdout] 176 | let tracks_identified_from_id3: Vec = tracks_with_id3 [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 177 | | .iter() [INFO] [stdout] 178 | | .cloned() [INFO] [stdout] 179 | | .filter(|track| { [INFO] [stdout] ... | [INFO] [stdout] 182 | | && is_edm(track.id3.as_ref().unwrap().genre().as_ref().unwrap()) [INFO] [stdout] 183 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ .iter().filter(|&track| { [INFO] [stdout] 178 + track.id3.is_some() [INFO] [stdout] 179 + && track.id3.as_ref().unwrap().genre().is_some() [INFO] [stdout] 180 + && is_edm(track.id3.as_ref().unwrap().genre().as_ref().unwrap()) [INFO] [stdout] 181 + }).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:187:56 [INFO] [stdout] | [INFO] [stdout] 187 | let tracks_found_by_location: Vec = result [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 188 | | .iter() [INFO] [stdout] | | ________________________- [INFO] [stdout] 189 | || .cloned() [INFO] [stdout] 190 | || .filter(|existing| existing.location.eq(&track.location)) [INFO] [stdout] | ||_________________________________________________________________________^ [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | help: try: `.filter(|&existing| existing.location.eq(&track.location)).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/lib.rs:192:16 [INFO] [stdout] | [INFO] [stdout] 192 | if tracks_found_by_location.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tracks_found_by_location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | let connection = get_connection(&mixxx_db_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `move_folder` is never used [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn move_folder( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `full_integration_test` is never used [INFO] [stdout] --> src/lib/lib.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | fn full_integration_test() -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_test_db` is never used [INFO] [stdout] --> src/lib/lib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | fn setup_test_db(connection: &Connection) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return rusqlite::Connection::open(db_path).expect("Could not open db path"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return rusqlite::Connection::open(db_path).expect("Could not open db path"); [INFO] [stdout] 233 + rusqlite::Connection::open(db_path).expect("Could not open db path") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:30:54 [INFO] [stdout] | [INFO] [stdout] 30 | let mut target = String::from(target_path.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/logfile_anonymize.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod logfile_anonymize { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use std::collections::HashMap; [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | let device_serial_regex = Regex::new(®ex_str).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `regex_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | .replace_all(&line, device_serial_replacement) [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | .replace_all(&line, |caps: ®ex::Captures| { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/logfile_anonymize.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | result.push_str(&device_serial_replacement); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `device_serial_replacement` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod track; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track/track.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod track { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use id3::Tag; [INFO] [stdout] ... | [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_categorization/genre.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod genre { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | fn is_trance(genre_string: &str) -> bool { [INFO] [stdout] 4 | | return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return genre_string.to_lowercase().contains("trance"); [INFO] [stdout] 4 + genre_string.to_lowercase().contains("trance") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return genre_string.to_lowercase().contains("dance"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return genre_string.to_lowercase().contains("dance"); [INFO] [stdout] 8 + genre_string.to_lowercase().contains("dance") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] 12 + is_dance(&genre_string) || is_trance(&genre_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `genre_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/track_categorization/genre.rs:12:53 [INFO] [stdout] | [INFO] [stdout] 12 | return is_dance(&genre_string) || is_trance(&genre_string); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `genre_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib/track_categorization/genre.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | assert_eq!(is_edm("Trance (Main Floor)"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 21 - assert_eq!(is_edm("Trance (Main Floor)"), true); [INFO] [stdout] 21 + assert!(is_edm("Trance (Main Floor)")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib/track_categorization/genre.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | assert_eq!(is_trance("Trance (Main Floor"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 26 - assert_eq!(is_trance("Trance (Main Floor"), true); [INFO] [stdout] 26 + assert!(is_trance("Trance (Main Floor")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib/track_categorization/genre.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(is_trance("Trance"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 27 - assert_eq!(is_trance("Trance"), true); [INFO] [stdout] 27 + assert!(is_trance("Trance")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib/track_categorization/genre.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(is_dance("Dance"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(is_dance("Dance"), true); [INFO] [stdout] 32 + assert!(is_dance("Dance")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib/track_categorization/genre.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | assert_eq!(is_dance("Hard dance"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 33 - assert_eq!(is_dance("Hard dance"), true); [INFO] [stdout] 33 + assert!(is_dance("Hard dance")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_fingerprinting.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod track_fingerprinting; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod track_fingerprinting { [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use sha2::{Digest, Sha256}; [INFO] [stdout] ... | [INFO] [stdout] 53 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:22:40 [INFO] [stdout] | [INFO] [stdout] 22 | let file_bytes = std::fs::read(&file_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/track_fingerprinting/track_fingerprinting.rs:42:58 [INFO] [stdout] | [INFO] [stdout] 42 | let result = get_track_fingerprints_for_file(&"test-data/sample.dat").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"test-data/sample.dat"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | if !file.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `file.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `file` after checking its variant with `is_err` [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 18 | if !file.is_err() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 19 | files.push(file.unwrap().path()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | let read_dir = fs::read_dir(&source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | let connection = get_connection(&mixxx_db_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:72:63 [INFO] [stdout] | [INFO] [stdout] 72 | let edm_tracks_low_bpm = find_edm_tracks_with_low_bpm(&mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:90:58 [INFO] [stdout] | [INFO] [stdout] 90 | multiply_bpm(&edm_tracks_low_bpm, 3.0 / 2.0, &mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:101:41 [INFO] [stdout] | [INFO] [stdout] 101 | let connection = get_connection(&db_path); [INFO] [stdout] | ^^^^^^^^ help: change this to: `db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`) [INFO] [stdout] --> src/lib/lib.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | let new_bpm = track.bpm as f64 * multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `track.bpm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:121:73 [INFO] [stdout] | [INFO] [stdout] 121 | let tracks_with_bpm_below_100 = find_tracks_with_bpm_below(100, &mixxx_db_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return Ok(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return Ok(result); [INFO] [stdout] 139 + Ok(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return false; [INFO] [stdout] 156 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | / return tracks [INFO] [stdout] 161 | | .iter() [INFO] [stdout] 162 | | .cloned() [INFO] [stdout] 163 | | .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] 164 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 ~ tracks [INFO] [stdout] 161 + .iter() [INFO] [stdout] 162 + .cloned() [INFO] [stdout] 163 + .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] 164 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 159 | fn filter_to_id3_supported_formats(tracks: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - fn filter_to_id3_supported_formats(tracks: &Vec) -> Vec { [INFO] [stdout] 159 + fn filter_to_id3_supported_formats(tracks: &[Track]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | return tracks [INFO] [stdout] | _________________^ [INFO] [stdout] 161 | | .iter() [INFO] [stdout] | | ____________________- [INFO] [stdout] 162 | || .cloned() [INFO] [stdout] 163 | || .filter(|track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])) [INFO] [stdout] | ||_________________________________________________________________________________^ [INFO] [stdout] | |_________________________________________________________________________________| [INFO] [stdout] | help: try: `.filter(|&track| is_format(track, &vec!["mp3", "mp4", "wav", "aiff"])).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:167:37 [INFO] [stdout] | [INFO] [stdout] 167 | fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] 167 + fn filter_to_edm_tracks(tracks: &[Track], tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib/lib.rs:167:67 [INFO] [stdout] | [INFO] [stdout] 167 | fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 167 - fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &Vec) -> Vec { [INFO] [stdout] 167 + fn filter_to_edm_tracks(tracks: &Vec, tracks_with_id3: &[Track]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:168:53 [INFO] [stdout] | [INFO] [stdout] 168 | let tracks_identified_from_db: Vec = tracks [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 169 | | .iter() [INFO] [stdout] | | ____________________- [INFO] [stdout] 170 | || .cloned() [INFO] [stdout] 171 | || .filter(|track| is_edm(&track.genre)) [INFO] [stdout] | ||_________________________________________________^ [INFO] [stdout] | |_________________________________________________| [INFO] [stdout] | help: try: `.filter(|&track| is_edm(&track.genre)).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:176:54 [INFO] [stdout] | [INFO] [stdout] 176 | let tracks_identified_from_id3: Vec = tracks_with_id3 [INFO] [stdout] | ______________________________________________________^ [INFO] [stdout] 177 | | .iter() [INFO] [stdout] 178 | | .cloned() [INFO] [stdout] 179 | | .filter(|track| { [INFO] [stdout] ... | [INFO] [stdout] 182 | | && is_edm(track.id3.as_ref().unwrap().genre().as_ref().unwrap()) [INFO] [stdout] 183 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 ~ .iter().filter(|&track| { [INFO] [stdout] 178 + track.id3.is_some() [INFO] [stdout] 179 + && track.id3.as_ref().unwrap().genre().is_some() [INFO] [stdout] 180 + && is_edm(track.id3.as_ref().unwrap().genre().as_ref().unwrap()) [INFO] [stdout] 181 + }).cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:187:56 [INFO] [stdout] | [INFO] [stdout] 187 | let tracks_found_by_location: Vec = result [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 188 | | .iter() [INFO] [stdout] | | ________________________- [INFO] [stdout] 189 | || .cloned() [INFO] [stdout] 190 | || .filter(|existing| existing.location.eq(&track.location)) [INFO] [stdout] | ||_________________________________________________________________________^ [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | help: try: `.filter(|&existing| existing.location.eq(&track.location)).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/lib.rs:192:16 [INFO] [stdout] | [INFO] [stdout] 192 | if tracks_found_by_location.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tracks_found_by_location.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | let connection = get_connection(&mixxx_db_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `mixxx_db_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return rusqlite::Connection::open(db_path).expect("Could not open db path"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return rusqlite::Connection::open(db_path).expect("Could not open db path"); [INFO] [stdout] 233 + rusqlite::Connection::open(db_path).expect("Could not open db path") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib/lib.rs:253:57 [INFO] [stdout] | [INFO] [stdout] 253 | let connection = rusqlite::Connection::open(&db_name)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `db_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:257:25 [INFO] [stdout] | [INFO] [stdout] 257 | fix_edm_bpm(&db_name)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `db_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:283:29 [INFO] [stdout] | [INFO] [stdout] 283 | let edm_track = tracks.iter().cloned().find(|track| track.id == 1).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.find(|&track| track.id == 1).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/lib/lib.rs:286:39 [INFO] [stdout] | [INFO] [stdout] 286 | let unknown_genre_track = tracks.iter().cloned().find(|track| track.id == 2).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.find(|&track| track.id == 2).cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:374:32 [INFO] [stdout] | [INFO] [stdout] 374 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:384:32 [INFO] [stdout] | [INFO] [stdout] 384 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:396:32 [INFO] [stdout] | [INFO] [stdout] 396 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:408:32 [INFO] [stdout] | [INFO] [stdout] 408 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:424:32 [INFO] [stdout] | [INFO] [stdout] 424 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/lib.rs:441:32 [INFO] [stdout] | [INFO] [stdout] 441 | connection.execute(&stmt, ())?; [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib/track_movement/move_fns.rs:30:54 [INFO] [stdout] | [INFO] [stdout] 30 | let mut target = String::from(target_path.clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | let logfile_anonymized = mixxx_logfile::anonymize_logfile(&logfile_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `logfile_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | let target_filename = String::from(format!("{}.anonymized", logfile_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}.anonymized", logfile_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:39:33 [INFO] [stdout] | [INFO] [stdout] 39 | if !valid_commands.contains(&command) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return &args[1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return &args[1]; [INFO] [stdout] 57 + &args[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return &args[1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return &args[1]; [INFO] [stdout] 65 + &args[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | let logfile_anonymized = mixxx_logfile::anonymize_logfile(&logfile_path); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `logfile_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:23:31 [INFO] [stdout] | [INFO] [stdout] 23 | let target_filename = String::from(format!("{}.anonymized", logfile_path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}.anonymized", logfile_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:39:33 [INFO] [stdout] | [INFO] [stdout] 39 | if !valid_commands.contains(&command) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return &args[1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return &args[1]; [INFO] [stdout] 57 + &args[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return &args[1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return &args[1]; [INFO] [stdout] 65 + &args[1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.31s [INFO] running `Command { std: "docker" "inspect" "b7ea39012d59509fdf5e9af2ec0a520ed2662d7137cdec8ff8412386f8f17c7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7ea39012d59509fdf5e9af2ec0a520ed2662d7137cdec8ff8412386f8f17c7a", kill_on_drop: false }` [INFO] [stdout] b7ea39012d59509fdf5e9af2ec0a520ed2662d7137cdec8ff8412386f8f17c7a