[INFO] cloning repository https://github.com/soulslike-routing/proc_mem_platform_independent
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/soulslike-routing/proc_mem_platform_independent" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsoulslike-routing%2Fproc_mem_platform_independent", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsoulslike-routing%2Fproc_mem_platform_independent'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f39519a42d5ced685935e99385c1c527803d2790
[INFO] linting soulslike-routing/proc_mem_platform_independent against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsoulslike-routing%2Fproc_mem_platform_independent" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/soulslike-routing/proc_mem_platform_independent
[INFO] finished tweaking git repo https://github.com/soulslike-routing/proc_mem_platform_independent
[INFO] tweaked toml for git repo https://github.com/soulslike-routing/proc_mem_platform_independent written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/soulslike-routing/proc_mem_platform_independent on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/soulslike-routing/proc_mem_platform_independent already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded mach v0.3.2
[INFO] [stderr]   Downloaded crossbeam-epoch v0.9.18
[INFO] [stderr]   Downloaded process-memory v0.5.0
[INFO] [stderr]   Downloaded patternscan v1.2.0
[INFO] [stderr]   Downloaded either v1.12.0
[INFO] [stderr]   Downloaded crossbeam-deque v0.8.5
[INFO] [stderr]   Downloaded rayon-core v1.12.1
[INFO] [stderr]   Downloaded rayon v1.10.0
[INFO] [stderr]   Downloaded sysinfo v0.30.12
[INFO] [stderr]   Downloaded libc v0.2.155
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7be47362f402721f1a81468652c0b3c43168dcea2ea55b57fcef96b4c0ccffc2
[INFO] running `Command { std: "docker" "start" "-a" "7be47362f402721f1a81468652c0b3c43168dcea2ea55b57fcef96b4c0ccffc2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7be47362f402721f1a81468652c0b3c43168dcea2ea55b57fcef96b4c0ccffc2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7be47362f402721f1a81468652c0b3c43168dcea2ea55b57fcef96b4c0ccffc2", kill_on_drop: false }`
[INFO] [stdout] 7be47362f402721f1a81468652c0b3c43168dcea2ea55b57fcef96b4c0ccffc2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 28b4ebd95f811297f7b6b899827909391498e93a0c96f4d3e7e329681e811c5e
[INFO] running `Command { std: "docker" "start" "-a" "28b4ebd95f811297f7b6b899827909391498e93a0c96f4d3e7e329681e811c5e", kill_on_drop: false }`
[INFO] [stderr]    Compiling crossbeam-utils v0.8.20
[INFO] [stderr]    Compiling rayon-core v1.12.1
[INFO] [stderr]    Compiling libc v0.2.155
[INFO] [stderr]     Checking either v1.12.0
[INFO] [stderr]     Checking once_cell v1.19.0
[INFO] [stderr]     Checking patternscan v1.2.0
[INFO] [stderr]     Checking crossbeam-epoch v0.9.18
[INFO] [stderr]     Checking process-memory v0.5.0
[INFO] [stderr]     Checking crossbeam-deque v0.8.5
[INFO] [stderr]     Checking rayon v1.10.0
[INFO] [stderr]     Checking sysinfo v0.30.12
[INFO] [stderr]     Checking proc_mem_platform_independent v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/main.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | use std::usize;
[INFO] [stdout]   |     ^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `usize::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/main.rs:74:12
[INFO] [stdout]    |
[INFO] [stdout] 74 |         if base_address == None {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `base_address.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:88:66
[INFO] [stdout]    |
[INFO] [stdout] 88 |         let locs = match scan(Cursor::new(entire_memory_region), &player_pos_pattern) {
[INFO] [stdout]    |                                                                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_pos_pattern`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/main.rs:96:12
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if locs.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `locs.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:145:5
[INFO] [stdout]     |
[INFO] [stdout] 145 |     return ptr;
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 145 -     return ptr;
[INFO] [stdout] 145 +     ptr
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:129:19
[INFO] [stdout]     |
[INFO] [stdout] 129 |     let mut ptr = start.clone();
[INFO] [stdout]     |                   ^^^^^^^^^^^^^ help: try removing the `clone` call: `start`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:157:5
[INFO] [stdout]     |
[INFO] [stdout] 157 |     return ds_proc.pid().as_u32() as i32;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 157 -     return ds_proc.pid().as_u32() as i32;
[INFO] [stdout] 157 +     ds_proc.pid().as_u32() as i32
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
[INFO] [stdout]    --> src/main.rs:154:19
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sys.processes_by_name("DarkSouls").into_iter().find(|proc| proc.thread_kind() == None)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stdout]     = note: `#[warn(clippy::filter_next)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator<Item = &sysinfo::Process> + '_`
[INFO] [stdout]    --> src/main.rs:154:19
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `sys.processes_by_name("DarkSouls")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/main.rs:154:80
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `proc.thread_kind().is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:161:5
[INFO] [stdout]     |
[INFO] [stdout] 161 |     return pid.try_into_process_handle().unwrap();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 161 -     return pid.try_into_process_handle().unwrap();
[INFO] [stdout] 161 +     pid.try_into_process_handle().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:170:12
[INFO] [stdout]     |
[INFO] [stdout] 170 | ...if !address_space.contains("DarkSoulsRemastered.exe") && !(keep_going && (!address_space.contains("/") && !address_space.contains("["))) {
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(address_space.contains("DarkSoulsRemastered.exe") || keep_going && !address_space.contains("/") && !address_space.contains("["))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:177:5
[INFO] [stdout]     |
[INFO] [stdout] 177 |     return valid_adr_spc;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 177 -     return valid_adr_spc;
[INFO] [stdout] 177 +     valid_adr_spc
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:164:45
[INFO] [stdout]     |
[INFO] [stdout] 164 | fn get_available_address_spaces(all_spaces: &String) -> Vec<&str>{
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 164 - fn get_available_address_spaces(all_spaces: &String) -> Vec<&str>{
[INFO] [stdout] 164 + fn get_available_address_spaces(all_spaces: &str) -> Vec<&str>{
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/main.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | use std::usize;
[INFO] [stdout]   |     ^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `usize::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/main.rs:74:12
[INFO] [stdout]    |
[INFO] [stdout] 74 |         if base_address == None {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `base_address.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]    = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:88:66
[INFO] [stdout]    |
[INFO] [stdout] 88 |         let locs = match scan(Cursor::new(entire_memory_region), &player_pos_pattern) {
[INFO] [stdout]    |                                                                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `player_pos_pattern`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/main.rs:96:12
[INFO] [stdout]    |
[INFO] [stdout] 96 |         if locs.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `locs.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:145:5
[INFO] [stdout]     |
[INFO] [stdout] 145 |     return ptr;
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 145 -     return ptr;
[INFO] [stdout] 145 +     ptr
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/main.rs:129:19
[INFO] [stdout]     |
[INFO] [stdout] 129 |     let mut ptr = start.clone();
[INFO] [stdout]     |                   ^^^^^^^^^^^^^ help: try removing the `clone` call: `start`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:157:5
[INFO] [stdout]     |
[INFO] [stdout] 157 |     return ds_proc.pid().as_u32() as i32;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 157 -     return ds_proc.pid().as_u32() as i32;
[INFO] [stdout] 157 +     ds_proc.pid().as_u32() as i32
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.18s
[INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
[INFO] [stdout]    --> src/main.rs:154:19
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sys.processes_by_name("DarkSouls").into_iter().find(|proc| proc.thread_kind() == None)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stdout]     = note: `#[warn(clippy::filter_next)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator<Item = &sysinfo::Process> + '_`
[INFO] [stdout]    --> src/main.rs:154:19
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `sys.processes_by_name("DarkSouls")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/main.rs:154:80
[INFO] [stdout]     |
[INFO] [stdout] 154 |     let ds_proc = sys.processes_by_name("DarkSouls").into_iter().filter(|proc| proc.thread_kind() == None).next()
[INFO] [stdout]     |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `proc.thread_kind().is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:161:5
[INFO] [stdout]     |
[INFO] [stdout] 161 |     return pid.try_into_process_handle().unwrap();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 161 -     return pid.try_into_process_handle().unwrap();
[INFO] [stdout] 161 +     pid.try_into_process_handle().unwrap()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:170:12
[INFO] [stdout]     |
[INFO] [stdout] 170 | ...if !address_space.contains("DarkSoulsRemastered.exe") && !(keep_going && (!address_space.contains("/") && !address_space.contains("["))) {
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(address_space.contains("DarkSoulsRemastered.exe") || keep_going && !address_space.contains("/") && !address_space.contains("["))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:177:5
[INFO] [stdout]     |
[INFO] [stdout] 177 |     return valid_adr_spc;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 177 -     return valid_adr_spc;
[INFO] [stdout] 177 +     valid_adr_spc
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:164:45
[INFO] [stdout]     |
[INFO] [stdout] 164 | fn get_available_address_spaces(all_spaces: &String) -> Vec<&str>{
[INFO] [stdout]     |                                             ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 164 - fn get_available_address_spaces(all_spaces: &String) -> Vec<&str>{
[INFO] [stdout] 164 + fn get_available_address_spaces(all_spaces: &str) -> Vec<&str>{
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "28b4ebd95f811297f7b6b899827909391498e93a0c96f4d3e7e329681e811c5e", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "28b4ebd95f811297f7b6b899827909391498e93a0c96f4d3e7e329681e811c5e", kill_on_drop: false }`
[INFO] [stdout] 28b4ebd95f811297f7b6b899827909391498e93a0c96f4d3e7e329681e811c5e