[INFO] cloning repository https://github.com/smiz/pgmud [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/smiz/pgmud" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmiz%2Fpgmud", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmiz%2Fpgmud'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 375596aafb968d31be7f4a6f06514a8de68f210e [INFO] linting smiz/pgmud against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsmiz%2Fpgmud" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/smiz/pgmud [INFO] finished tweaking git repo https://github.com/smiz/pgmud [INFO] tweaked toml for git repo https://github.com/smiz/pgmud written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/smiz/pgmud on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/smiz/pgmud already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 542219e558bdb905fde8001d78b6024738cfb256c75d26b3101afef9b5ac21d3 [INFO] running `Command { std: "docker" "start" "-a" "542219e558bdb905fde8001d78b6024738cfb256c75d26b3101afef9b5ac21d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "542219e558bdb905fde8001d78b6024738cfb256c75d26b3101afef9b5ac21d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "542219e558bdb905fde8001d78b6024738cfb256c75d26b3101afef9b5ac21d3", kill_on_drop: false }` [INFO] [stdout] 542219e558bdb905fde8001d78b6024738cfb256c75d26b3101afef9b5ac21d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 75adc1bb2ff4e6eb000a7b2dffbd3f1b0f25ab3e2dc1bc002fe01a9bbd2aa49e [INFO] running `Command { std: "docker" "start" "-a" "75adc1bb2ff4e6eb000a7b2dffbd3f1b0f25ab3e2dc1bc002fe01a9bbd2aa49e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking pgmud v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/items.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | type_code: type_code, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mobile::*` [INFO] [stdout] --> src/items.rs:448:6 [INFO] [stdout] | [INFO] [stdout] 448 | use crate::mobile::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/location.rs:92:4 [INFO] [stdout] | [INFO] [stdout] 92 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/location.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::items::*` [INFO] [stdout] --> src/location.rs:242:6 [INFO] [stdout] | [INFO] [stdout] 242 | use crate::items::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mobile::*` [INFO] [stdout] --> src/location.rs:243:6 [INFO] [stdout] | [INFO] [stdout] 243 | use crate::mobile::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/mobile.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | ... _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::items::*` [INFO] [stdout] --> src/mobile.rs:839:6 [INFO] [stdout] | [INFO] [stdout] 839 | use crate::items::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:654:12 [INFO] [stdout] | [INFO] [stdout] 654 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:715:12 [INFO] [stdout] | [INFO] [stdout] 715 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::world::*` [INFO] [stdout] --> src/events.rs:799:6 [INFO] [stdout] | [INFO] [stdout] 799 | use crate::world::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::mobile::*` [INFO] [stdout] --> src/events.rs:800:6 [INFO] [stdout] | [INFO] [stdout] 800 | use crate::mobile::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::items::*` [INFO] [stdout] --> src/events.rs:801:6 [INFO] [stdout] | [INFO] [stdout] 801 | use crate::items::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/events.rs:825:46 [INFO] [stdout] | [INFO] [stdout] 825 | let mut event = MakeItemEvent { maker: id, item: item }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:60:4 [INFO] [stdout] | [INFO] [stdout] 60 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:61:4 [INFO] [stdout] | [INFO] [stdout] 61 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/items.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | type_code: type_code, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:222:77 [INFO] [stdout] | [INFO] [stdout] 222 | Some(defender) => { event_q.insert(Box::new(CombatEvent { attacker: uuid, defender: defender, first_round: true })); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `defender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:233:69 [INFO] [stdout] | [INFO] [stdout] 233 | Some(mark) => { event_q.insert(Box::new(StealEvent { thief: uuid, mark: mark })); }, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:242:4 [INFO] [stdout] | [INFO] [stdout] 242 | uuid: uuid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:243:4 [INFO] [stdout] | [INFO] [stdout] 243 | dx: dx, [INFO] [stdout] | ^^^^^^ help: replace it with: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:244:4 [INFO] [stdout] | [INFO] [stdout] 244 | dy: dy [INFO] [stdout] | ^^^^^^ help: replace it with: `dy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:549:11 [INFO] [stdout] | [INFO] [stdout] 549 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/location.rs:92:4 [INFO] [stdout] | [INFO] [stdout] 92 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/location.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/mobile.rs:148:18 [INFO] [stdout] | [INFO] [stdout] 148 | ... _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:654:12 [INFO] [stdout] | [INFO] [stdout] 654 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/events.rs:715:12 [INFO] [stdout] | [INFO] [stdout] 715 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:60:4 [INFO] [stdout] | [INFO] [stdout] 60 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:61:4 [INFO] [stdout] | [INFO] [stdout] 61 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/message.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:222:77 [INFO] [stdout] | [INFO] [stdout] 222 | Some(defender) => { event_q.insert(Box::new(CombatEvent { attacker: uuid, defender: defender, first_round: true })); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `defender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:233:69 [INFO] [stdout] | [INFO] [stdout] 233 | Some(mark) => { event_q.insert(Box::new(StealEvent { thief: uuid, mark: mark })); }, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `mark` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:242:4 [INFO] [stdout] | [INFO] [stdout] 242 | uuid: uuid, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:243:4 [INFO] [stdout] | [INFO] [stdout] 243 | dx: dx, [INFO] [stdout] | ^^^^^^ help: replace it with: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:244:4 [INFO] [stdout] | [INFO] [stdout] 244 | dy: dy [INFO] [stdout] | ^^^^^^ help: replace it with: `dy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:549:11 [INFO] [stdout] | [INFO] [stdout] 549 | _ => { () } [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `which` is never read [INFO] [stdout] --> src/location.rs:191:19 [INFO] [stdout] | [INFO] [stdout] 191 | let mut which = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `which` is never read [INFO] [stdout] --> src/location.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | let mut which = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/location.rs:249:7 [INFO] [stdout] | [INFO] [stdout] 249 | let mut rabbit1 = Mobile::rabbit(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/location.rs:250:7 [INFO] [stdout] | [INFO] [stdout] 250 | let mut rabbit2 = Mobile::rabbit(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/location.rs:251:7 [INFO] [stdout] | [INFO] [stdout] 251 | let mut rabbit3 = Mobile::rabbit(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `which` is never read [INFO] [stdout] --> src/location.rs:191:19 [INFO] [stdout] | [INFO] [stdout] 191 | let mut which = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `which` is never read [INFO] [stdout] --> src/location.rs:214:19 [INFO] [stdout] | [INFO] [stdout] 214 | let mut which = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/mobile.rs:847:7 [INFO] [stdout] | [INFO] [stdout] 847 | for i in 1..100 [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/mobile.rs:853:7 [INFO] [stdout] | [INFO] [stdout] 853 | for i in 1..100 [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/events.rs:811:7 [INFO] [stdout] | [INFO] [stdout] 811 | let mut event = MakeItemEvent { maker: id, item: ItemTypeCode::Sword }; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/events.rs:825:7 [INFO] [stdout] | [INFO] [stdout] 825 | let mut event = MakeItemEvent { maker: id, item: item }; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/dice.rs:35:7 [INFO] [stdout] | [INFO] [stdout] 35 | for i in 1..100 [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `has_input` is never read [INFO] [stdout] --> src/main.rs:560:5 [INFO] [stdout] | [INFO] [stdout] 560 | has_input = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 69 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return result; [INFO] [stdout] 69 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:71:11 [INFO] [stdout] | [INFO] [stdout] 71 | _ => { return result; } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - _ => { return result; } [INFO] [stdout] 71 + _ => { result} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:77:3 [INFO] [stdout] | [INFO] [stdout] 77 | return self.description.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.description.clone(); [INFO] [stdout] 77 + self.description.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:82:3 [INFO] [stdout] | [INFO] [stdout] 82 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.name.clone(); [INFO] [stdout] 82 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:93:63 [INFO] [stdout] | [INFO] [stdout] 93 | ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; return true; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; return true; } [INFO] [stdout] 93 + ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:98:6 [INFO] [stdout] | [INFO] [stdout] 98 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return true; [INFO] [stdout] 98 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:100:11 [INFO] [stdout] | [INFO] [stdout] 100 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - _ => { return false; } [INFO] [stdout] 100 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - _ => { return; } [INFO] [stdout] 122 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:134:11 [INFO] [stdout] | [INFO] [stdout] 134 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - _ => { return; } [INFO] [stdout] 134 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:145:3 [INFO] [stdout] | [INFO] [stdout] 145 | / return Box::new( [INFO] [stdout] 146 | | Item [INFO] [stdout] 147 | | { [INFO] [stdout] 148 | | description: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 157 | | xp_in_town_only: false, [INFO] [stdout] 158 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 ~ Box::new( [INFO] [stdout] 146 ~ Item [INFO] [stdout] 147 ~ { [INFO] [stdout] 148 ~ description: "".to_string(), [INFO] [stdout] 149 ~ name: "".to_string(), [INFO] [stdout] 150 ~ effect: "".to_string(), [INFO] [stdout] 151 ~ frequency: Mobile::easy_task(), [INFO] [stdout] 152 ~ type_code: type_code, [INFO] [stdout] 153 ~ category_code: cat_code, [INFO] [stdout] 154 ~ xp_value: 0, [INFO] [stdout] 155 ~ lifetime: 100, [INFO] [stdout] 156 ~ armor_value: 0, [INFO] [stdout] 157 ~ xp_in_town_only: false, [INFO] [stdout] 158 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return item; [INFO] [stdout] 169 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return item; [INFO] [stdout] 179 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/items.rs:175:53 [INFO] [stdout] | [INFO] [stdout] 175 | item.description = "A dead ".to_string()+&in_life+&" is here.".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" is here."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/items.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | item.name = in_life+&" corpse".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `" corpse"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `has_input` is never read [INFO] [stdout] --> src/main.rs:560:5 [INFO] [stdout] | [INFO] [stdout] 560 | has_input = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:189:3 [INFO] [stdout] | [INFO] [stdout] 189 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return item; [INFO] [stdout] 189 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:198:3 [INFO] [stdout] | [INFO] [stdout] 198 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return item; [INFO] [stdout] 198 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:210:3 [INFO] [stdout] | [INFO] [stdout] 210 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return item; [INFO] [stdout] 210 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:221:3 [INFO] [stdout] | [INFO] [stdout] 221 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 - return item; [INFO] [stdout] 221 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:233:3 [INFO] [stdout] | [INFO] [stdout] 233 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return item; [INFO] [stdout] 233 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:244:3 [INFO] [stdout] | [INFO] [stdout] 244 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return item; [INFO] [stdout] 244 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:255:3 [INFO] [stdout] | [INFO] [stdout] 255 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return item; [INFO] [stdout] 255 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_map` is never used [INFO] [stdout] --> src/map.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 18 | impl Map [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 143 | pub fn draw_map(&self) -> String [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:265:3 [INFO] [stdout] | [INFO] [stdout] 265 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return item; [INFO] [stdout] 265 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:276:3 [INFO] [stdout] | [INFO] [stdout] 276 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - return item; [INFO] [stdout] 276 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:287:3 [INFO] [stdout] | [INFO] [stdout] 287 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - return item; [INFO] [stdout] 287 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return item; [INFO] [stdout] 298 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:310:3 [INFO] [stdout] | [INFO] [stdout] 310 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 - return item; [INFO] [stdout] 310 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:321:3 [INFO] [stdout] | [INFO] [stdout] 321 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return item; [INFO] [stdout] 321 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:331:3 [INFO] [stdout] | [INFO] [stdout] 331 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return item; [INFO] [stdout] 331 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/items.rs:330:19 [INFO] [stdout] | [INFO] [stdout] 330 | item.lifetime = std::u32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 330 - item.lifetime = std::u32::MAX; [INFO] [stdout] 330 + item.lifetime = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:344:3 [INFO] [stdout] | [INFO] [stdout] 344 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return item; [INFO] [stdout] 344 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:357:3 [INFO] [stdout] | [INFO] [stdout] 357 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return item; [INFO] [stdout] 357 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:69:6 [INFO] [stdout] | [INFO] [stdout] 69 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return result; [INFO] [stdout] 69 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:71:11 [INFO] [stdout] | [INFO] [stdout] 71 | _ => { return result; } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - _ => { return result; } [INFO] [stdout] 71 + _ => { result} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:369:3 [INFO] [stdout] | [INFO] [stdout] 369 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return item; [INFO] [stdout] 369 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:77:3 [INFO] [stdout] | [INFO] [stdout] 77 | return self.description.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.description.clone(); [INFO] [stdout] 77 + self.description.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:82:3 [INFO] [stdout] | [INFO] [stdout] 82 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.name.clone(); [INFO] [stdout] 82 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:381:3 [INFO] [stdout] | [INFO] [stdout] 381 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return item; [INFO] [stdout] 381 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:93:63 [INFO] [stdout] | [INFO] [stdout] 93 | ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; return true; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; return true; } [INFO] [stdout] 93 + ItemTypeCode::HealthyNutsAndSeeds => { mobile.damage -= 1; true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:98:6 [INFO] [stdout] | [INFO] [stdout] 98 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return true; [INFO] [stdout] 98 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:394:3 [INFO] [stdout] | [INFO] [stdout] 394 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return item; [INFO] [stdout] 394 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:100:11 [INFO] [stdout] | [INFO] [stdout] 100 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - _ => { return false; } [INFO] [stdout] 100 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:406:3 [INFO] [stdout] | [INFO] [stdout] 406 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return item; [INFO] [stdout] 406 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:122:11 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - _ => { return; } [INFO] [stdout] 122 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:415:11 [INFO] [stdout] | [INFO] [stdout] 415 | 1 => { return Some(Self::rabbit_foot()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - 1 => { return Some(Self::rabbit_foot()); }, [INFO] [stdout] 415 + 1 => { Some(Self::rabbit_foot())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:416:11 [INFO] [stdout] | [INFO] [stdout] 416 | 2 => { return Some(Self::healthy_nuts_and_seeds()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 416 - 2 => { return Some(Self::healthy_nuts_and_seeds()); }, [INFO] [stdout] 416 + 2 => { Some(Self::healthy_nuts_and_seeds())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:417:11 [INFO] [stdout] | [INFO] [stdout] 417 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 417 - _ => { return None; } [INFO] [stdout] 417 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:134:11 [INFO] [stdout] | [INFO] [stdout] 134 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - _ => { return; } [INFO] [stdout] 134 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:427:11 [INFO] [stdout] | [INFO] [stdout] 427 | 1 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - 1 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] 427 + 1 => { Some(Self::gold_bauble())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:428:11 [INFO] [stdout] | [INFO] [stdout] 428 | 2 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - 2 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] 428 + 2 => { Some(Self::gold_bauble())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:429:11 [INFO] [stdout] | [INFO] [stdout] 429 | 3 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - 3 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 429 + 3 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:430:11 [INFO] [stdout] | [INFO] [stdout] 430 | 4 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 430 - 4 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 430 + 4 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:145:3 [INFO] [stdout] | [INFO] [stdout] 145 | / return Box::new( [INFO] [stdout] 146 | | Item [INFO] [stdout] 147 | | { [INFO] [stdout] 148 | | description: "".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 157 | | xp_in_town_only: false, [INFO] [stdout] 158 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 ~ Box::new( [INFO] [stdout] 146 ~ Item [INFO] [stdout] 147 ~ { [INFO] [stdout] 148 ~ description: "".to_string(), [INFO] [stdout] 149 ~ name: "".to_string(), [INFO] [stdout] 150 ~ effect: "".to_string(), [INFO] [stdout] 151 ~ frequency: Mobile::easy_task(), [INFO] [stdout] 152 ~ type_code: type_code, [INFO] [stdout] 153 ~ category_code: cat_code, [INFO] [stdout] 154 ~ xp_value: 0, [INFO] [stdout] 155 ~ lifetime: 100, [INFO] [stdout] 156 ~ armor_value: 0, [INFO] [stdout] 157 ~ xp_in_town_only: false, [INFO] [stdout] 158 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return item; [INFO] [stdout] 169 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:431:11 [INFO] [stdout] | [INFO] [stdout] 431 | 5 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 431 - 5 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 431 + 5 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:432:11 [INFO] [stdout] | [INFO] [stdout] 432 | 6 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 432 - 6 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] 432 + 6 => { Some(Self::shrunken_head())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:433:11 [INFO] [stdout] | [INFO] [stdout] 433 | 7 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - 7 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] 433 + 7 => { Some(Self::shrunken_head())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return item; [INFO] [stdout] 179 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:434:11 [INFO] [stdout] | [INFO] [stdout] 434 | 8 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 - 8 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] 434 + 8 => { Some(Self::dwarf_beard())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:435:11 [INFO] [stdout] | [INFO] [stdout] 435 | 9 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - 9 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] 435 + 9 => { Some(Self::dwarf_beard())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 436 | 10 => { return Some(Self::uncut_precious_stone()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - 10 => { return Some(Self::uncut_precious_stone()); }, [INFO] [stdout] 436 + 10 => { Some(Self::uncut_precious_stone())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:437:12 [INFO] [stdout] | [INFO] [stdout] 437 | 11 => { return Some(Self::useless_rock()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - 11 => { return Some(Self::useless_rock()); }, [INFO] [stdout] 437 + 11 => { Some(Self::useless_rock())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | 12 => { return Some(Self::healing_potion()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - 12 => { return Some(Self::healing_potion()); }, [INFO] [stdout] 438 + 12 => { Some(Self::healing_potion())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:439:11 [INFO] [stdout] | [INFO] [stdout] 439 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - _ => { return None; } [INFO] [stdout] 439 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/items.rs:175:53 [INFO] [stdout] | [INFO] [stdout] 175 | item.description = "A dead ".to_string()+&in_life+&" is here.".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" is here."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/items.rs:176:23 [INFO] [stdout] | [INFO] [stdout] 176 | item.name = in_life+&" corpse".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `" corpse"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:189:3 [INFO] [stdout] | [INFO] [stdout] 189 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return item; [INFO] [stdout] 189 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:198:3 [INFO] [stdout] | [INFO] [stdout] 198 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return item; [INFO] [stdout] 198 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:210:3 [INFO] [stdout] | [INFO] [stdout] 210 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return item; [INFO] [stdout] 210 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:221:3 [INFO] [stdout] | [INFO] [stdout] 221 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 - return item; [INFO] [stdout] 221 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:233:3 [INFO] [stdout] | [INFO] [stdout] 233 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return item; [INFO] [stdout] 233 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | / return WorldState [INFO] [stdout] 21 | | { [INFO] [stdout] 22 | | stash: BTreeMap::new(), [INFO] [stdout] 23 | | map: Map::new(), [INFO] [stdout] 24 | | message_list: MessageList::new(), [INFO] [stdout] 25 | | mobile_uuid_to_location: BTreeMap::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ WorldState [INFO] [stdout] 21 ~ { [INFO] [stdout] 22 ~ stash: BTreeMap::new(), [INFO] [stdout] 23 ~ map: Map::new(), [INFO] [stdout] 24 ~ message_list: MessageList::new(), [INFO] [stdout] 25 ~ mobile_uuid_to_location: BTreeMap::new(), [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:244:3 [INFO] [stdout] | [INFO] [stdout] 244 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return item; [INFO] [stdout] 244 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return population as f32 / area as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return population as f32 / area as f32; [INFO] [stdout] 33 + population as f32 / area as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:255:3 [INFO] [stdout] | [INFO] [stdout] 255 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return item; [INFO] [stdout] 255 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:265:3 [INFO] [stdout] | [INFO] [stdout] 265 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return item; [INFO] [stdout] 265 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:47:3 [INFO] [stdout] | [INFO] [stdout] 47 | return self.mobile_uuid_to_location.get(&uuid).copied(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self.mobile_uuid_to_location.get(&uuid).copied(); [INFO] [stdout] 47 + self.mobile_uuid_to_location.get(&uuid).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:52:3 [INFO] [stdout] | [INFO] [stdout] 52 | return self.mobile_uuid_to_location.contains_key(&uuid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.mobile_uuid_to_location.contains_key(&uuid); [INFO] [stdout] 52 + self.mobile_uuid_to_location.contains_key(&uuid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:276:3 [INFO] [stdout] | [INFO] [stdout] 276 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 276 - return item; [INFO] [stdout] 276 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:57:3 [INFO] [stdout] | [INFO] [stdout] 57 | return self.map.is_mobile_at_location(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return self.map.is_mobile_at_location(x,y); [INFO] [stdout] 57 + self.map.is_mobile_at_location(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:69:57 [INFO] [stdout] | [INFO] [stdout] 69 | Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); return true; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); return true; } [INFO] [stdout] 69 + Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:287:3 [INFO] [stdout] | [INFO] [stdout] 287 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - return item; [INFO] [stdout] 287 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return item; [INFO] [stdout] 298 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:310:3 [INFO] [stdout] | [INFO] [stdout] 310 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 310 - return item; [INFO] [stdout] 310 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:321:3 [INFO] [stdout] | [INFO] [stdout] 321 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 321 - return item; [INFO] [stdout] 321 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:331:3 [INFO] [stdout] | [INFO] [stdout] 331 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return item; [INFO] [stdout] 331 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 70 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - _ => { return false; } [INFO] [stdout] 70 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:79:3 [INFO] [stdout] | [INFO] [stdout] 79 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return mobile; [INFO] [stdout] 79 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 94 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return mobile; [INFO] [stdout] 94 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 96 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - _ => { return None; } [INFO] [stdout] 96 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:105:3 [INFO] [stdout] | [INFO] [stdout] 105 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return mobile; [INFO] [stdout] 105 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 121 | return Some(uuid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Some(uuid); [INFO] [stdout] 121 + Some(uuid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/items.rs:330:19 [INFO] [stdout] | [INFO] [stdout] 330 | item.lifetime = std::u32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 330 - item.lifetime = std::u32::MAX; [INFO] [stdout] 330 + item.lifetime = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:125:6 [INFO] [stdout] | [INFO] [stdout] 125 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return None; [INFO] [stdout] 125 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:344:3 [INFO] [stdout] | [INFO] [stdout] 344 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return item; [INFO] [stdout] 344 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:142:3 [INFO] [stdout] | [INFO] [stdout] 142 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return item; [INFO] [stdout] 142 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:357:3 [INFO] [stdout] | [INFO] [stdout] 357 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 357 - return item; [INFO] [stdout] 357 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:150:3 [INFO] [stdout] | [INFO] [stdout] 150 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return item; [INFO] [stdout] 150 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:369:3 [INFO] [stdout] | [INFO] [stdout] 369 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return item; [INFO] [stdout] 369 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:155:3 [INFO] [stdout] | [INFO] [stdout] 155 | return self.map.get_location_description(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return self.map.get_location_description(x,y); [INFO] [stdout] 155 + self.map.get_location_description(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 160 | return self.map.get_location_type(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return self.map.get_location_type(x,y); [INFO] [stdout] 160 + self.map.get_location_type(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:381:3 [INFO] [stdout] | [INFO] [stdout] 381 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return item; [INFO] [stdout] 381 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:394:3 [INFO] [stdout] | [INFO] [stdout] 394 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return item; [INFO] [stdout] 394 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:406:3 [INFO] [stdout] | [INFO] [stdout] 406 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return item; [INFO] [stdout] 406 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/location.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | items: Vec > [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return self.description(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.description(); [INFO] [stdout] 33 + self.description() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:415:11 [INFO] [stdout] | [INFO] [stdout] 415 | 1 => { return Some(Self::rabbit_foot()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - 1 => { return Some(Self::rabbit_foot()); }, [INFO] [stdout] 415 + 1 => { Some(Self::rabbit_foot())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:51:3 [INFO] [stdout] | [INFO] [stdout] 51 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result; [INFO] [stdout] 51 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:416:11 [INFO] [stdout] | [INFO] [stdout] 416 | 2 => { return Some(Self::healthy_nuts_and_seeds()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 416 - 2 => { return Some(Self::healthy_nuts_and_seeds()); }, [INFO] [stdout] 416 + 2 => { Some(Self::healthy_nuts_and_seeds())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:417:11 [INFO] [stdout] | [INFO] [stdout] 417 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 417 - _ => { return None; } [INFO] [stdout] 417 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:427:11 [INFO] [stdout] | [INFO] [stdout] 427 | 1 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - 1 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] 427 + 1 => { Some(Self::gold_bauble())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:428:11 [INFO] [stdout] | [INFO] [stdout] 428 | 2 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - 2 => { return Some(Self::gold_bauble()); }, [INFO] [stdout] 428 + 2 => { Some(Self::gold_bauble())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 54 | fn get_name(&self) -> String { return self.description.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - fn get_name(&self) -> String { return self.description.clone(); } [INFO] [stdout] 54 + fn get_name(&self) -> String { self.description.clone()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:429:11 [INFO] [stdout] | [INFO] [stdout] 429 | 3 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - 3 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 429 + 3 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:62:3 [INFO] [stdout] | [INFO] [stdout] 62 | return !self.mobiles.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return !self.mobiles.is_empty(); [INFO] [stdout] 62 + !self.mobiles.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:430:11 [INFO] [stdout] | [INFO] [stdout] 430 | 4 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 430 - 4 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 430 + 4 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:431:11 [INFO] [stdout] | [INFO] [stdout] 431 | 5 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 431 - 5 => { return Some(Self::bone_jewelry()); }, [INFO] [stdout] 431 + 5 => { Some(Self::bone_jewelry())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | return Some(self.items.remove(index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Some(self.items.remove(index)); [INFO] [stdout] 72 + Some(self.items.remove(index)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:432:11 [INFO] [stdout] | [INFO] [stdout] 432 | 6 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 432 - 6 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] 432 + 6 => { Some(Self::shrunken_head())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/location.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | if self.items.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:433:11 [INFO] [stdout] | [INFO] [stdout] 433 | 7 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - 7 => { return Some(Self::shrunken_head()); }, [INFO] [stdout] 433 + 7 => { Some(Self::shrunken_head())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:84:3 [INFO] [stdout] | [INFO] [stdout] 84 | return self.fetch_mobile_by_guid(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self.fetch_mobile_by_guid(key); [INFO] [stdout] 84 + self.fetch_mobile_by_guid(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:434:11 [INFO] [stdout] | [INFO] [stdout] 434 | 8 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 - 8 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] 434 + 8 => { Some(Self::dwarf_beard())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/location.rs:78:6 [INFO] [stdout] | [INFO] [stdout] 78 | if keys.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:435:11 [INFO] [stdout] | [INFO] [stdout] 435 | 9 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - 9 => { return Some(Self::dwarf_beard()); }, [INFO] [stdout] 435 + 9 => { Some(Self::dwarf_beard())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return result; [INFO] [stdout] 104 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 436 | 10 => { return Some(Self::uncut_precious_stone()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - 10 => { return Some(Self::uncut_precious_stone()); }, [INFO] [stdout] 436 + 10 => { Some(Self::uncut_precious_stone())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 106 | _ => { return result; } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - _ => { return result; } [INFO] [stdout] 106 + _ => { result} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:437:12 [INFO] [stdout] | [INFO] [stdout] 437 | 11 => { return Some(Self::useless_rock()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - 11 => { return Some(Self::useless_rock()); }, [INFO] [stdout] 437 + 11 => { Some(Self::useless_rock())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LocationTypeCode` which implements the `Copy` trait [INFO] [stdout] --> src/location.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | location_type: code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:438:12 [INFO] [stdout] | [INFO] [stdout] 438 | 12 => { return Some(Self::healing_potion()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - 12 => { return Some(Self::healing_potion()); }, [INFO] [stdout] 438 + 12 => { Some(Self::healing_potion())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/location.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 121 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 122 | { [INFO] [stdout] 123 | self.add_item(item.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/items.rs:439:11 [INFO] [stdout] | [INFO] [stdout] 439 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - _ => { return None; } [INFO] [stdout] 439 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:139:3 [INFO] [stdout] | [INFO] [stdout] 139 | return self.mobiles.remove(&key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self.mobiles.remove(&key); [INFO] [stdout] 139 + self.mobiles.remove(&key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:20:3 [INFO] [stdout] | [INFO] [stdout] 20 | / return WorldState [INFO] [stdout] 21 | | { [INFO] [stdout] 22 | | stash: BTreeMap::new(), [INFO] [stdout] 23 | | map: Map::new(), [INFO] [stdout] 24 | | message_list: MessageList::new(), [INFO] [stdout] 25 | | mobile_uuid_to_location: BTreeMap::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 ~ WorldState [INFO] [stdout] 21 ~ { [INFO] [stdout] 22 ~ stash: BTreeMap::new(), [INFO] [stdout] 23 ~ map: Map::new(), [INFO] [stdout] 24 ~ message_list: MessageList::new(), [INFO] [stdout] 25 ~ mobile_uuid_to_location: BTreeMap::new(), [INFO] [stdout] 26 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 184 | Ok(value) => { return (name.unwrap().to_string(),value); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - Ok(value) => { return (name.unwrap().to_string(),value); }, [INFO] [stdout] 184 + Ok(value) => { (name.unwrap().to_string(),value)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return population as f32 / area as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return population as f32 / area as f32; [INFO] [stdout] 33 + population as f32 / area as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | Err(_) => { return (name.unwrap().to_string(),0); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - Err(_) => { return (name.unwrap().to_string(),0); } [INFO] [stdout] 185 + Err(_) => { (name.unwrap().to_string(),0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:47:3 [INFO] [stdout] | [INFO] [stdout] 47 | return self.mobile_uuid_to_location.get(&uuid).copied(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self.mobile_uuid_to_location.get(&uuid).copied(); [INFO] [stdout] 47 + self.mobile_uuid_to_location.get(&uuid).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | fn parse_name(key: &String) -> (String,usize) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 168 - fn parse_name(key: &String) -> (String,usize) [INFO] [stdout] 168 + fn parse_name(key: &str) -> (String,usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:52:3 [INFO] [stdout] | [INFO] [stdout] 52 | return self.mobile_uuid_to_location.contains_key(&uuid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return self.mobile_uuid_to_location.contains_key(&uuid); [INFO] [stdout] 52 + self.mobile_uuid_to_location.contains_key(&uuid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:209:3 [INFO] [stdout] | [INFO] [stdout] 209 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return None; [INFO] [stdout] 209 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:57:3 [INFO] [stdout] | [INFO] [stdout] 57 | return self.map.is_mobile_at_location(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return self.map.is_mobile_at_location(x,y); [INFO] [stdout] 57 + self.map.is_mobile_at_location(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn fetch_mobile_by_name(&mut self, key: &String) -> Option > [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 189 ~ pub fn fetch_mobile_by_name(&mut self, key: &str) -> Option > [INFO] [stdout] 190 | { [INFO] [stdout] 191 | let mut which = 0; [INFO] [stdout] 192 | let mut idx = 0; [INFO] [stdout] 193 ~ let mut lower_case_key = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:69:57 [INFO] [stdout] | [INFO] [stdout] 69 | Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); return true; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); return true; } [INFO] [stdout] 69 + Some((mobile,x,y)) => { self.add_mobile(mobile,x,y); true} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:234:3 [INFO] [stdout] | [INFO] [stdout] 234 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return None; [INFO] [stdout] 234 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 70 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - _ => { return false; } [INFO] [stdout] 70 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:212:44 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn fetch_item_by_name(&mut self, key: &String) -> Option > [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 ~ pub fn fetch_item_by_name(&mut self, key: &str) -> Option > [INFO] [stdout] 213 | { [INFO] [stdout] ... [INFO] [stdout] 216 | let mut i = 0; [INFO] [stdout] 217 ~ let mut lower_case_key = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/location.rs:273:11 [INFO] [stdout] | [INFO] [stdout] 273 | assert!(location.has_mobiles() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!location.has_mobiles()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:79:3 [INFO] [stdout] | [INFO] [stdout] 79 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return mobile; [INFO] [stdout] 79 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/location.rs:275:11 [INFO] [stdout] | [INFO] [stdout] 275 | assert!(location.has_mobiles() == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `location.has_mobiles()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 94 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return mobile; [INFO] [stdout] 94 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 96 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - _ => { return None; } [INFO] [stdout] 96 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:105:3 [INFO] [stdout] | [INFO] [stdout] 105 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return mobile; [INFO] [stdout] 105 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:121:6 [INFO] [stdout] | [INFO] [stdout] 121 | return Some(uuid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Some(uuid); [INFO] [stdout] 121 + Some(uuid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:125:6 [INFO] [stdout] | [INFO] [stdout] 125 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 125 - return None; [INFO] [stdout] 125 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:142:3 [INFO] [stdout] | [INFO] [stdout] 142 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return item; [INFO] [stdout] 142 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:150:3 [INFO] [stdout] | [INFO] [stdout] 150 | return item; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return item; [INFO] [stdout] 150 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 30 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return map; [INFO] [stdout] 30 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:155:3 [INFO] [stdout] | [INFO] [stdout] 155 | return self.map.get_location_description(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return self.map.get_location_description(x,y); [INFO] [stdout] 155 + self.map.get_location_description(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/world.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 160 | return self.map.get_location_type(x,y); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return self.map.get_location_type(x,y); [INFO] [stdout] 160 + self.map.get_location_type(x,y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:35:3 [INFO] [stdout] | [INFO] [stdout] 35 | return self.location_by_position.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return self.location_by_position.len(); [INFO] [stdout] 35 + self.location_by_position.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:43:24 [INFO] [stdout] | [INFO] [stdout] 43 | Some(location) => { return location.has_mobiles(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - Some(location) => { return location.has_mobiles(); }, [INFO] [stdout] 43 + Some(location) => { location.has_mobiles()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - _ => { return false; } [INFO] [stdout] 44 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | Some(location) => { return location.location_type; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Some(location) => { return location.location_type; }, [INFO] [stdout] 53 + Some(location) => { location.location_type}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 54 | _ => { return LocationTypeCode::Unexplored; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - _ => { return LocationTypeCode::Unexplored; } [INFO] [stdout] 54 + _ => { LocationTypeCode::Unexplored} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/location.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | items: Vec > [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | Some(location) => { return location.description(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - Some(location) => { return location.description(); }, [INFO] [stdout] 63 + Some(location) => { location.description()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return self.description(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.description(); [INFO] [stdout] 33 + self.description() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:64:11 [INFO] [stdout] | [INFO] [stdout] 64 | _ => { return "Unexplored".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - _ => { return "Unexplored".to_string(); } [INFO] [stdout] 64 + _ => { "Unexplored".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:51:3 [INFO] [stdout] | [INFO] [stdout] 51 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result; [INFO] [stdout] 51 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | Some(location) => return location, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - Some(location) => return location, [INFO] [stdout] 75 + Some(location) => location, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | _ => return self.make_new_location(x,y), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - _ => return self.make_new_location(x,y), [INFO] [stdout] 76 + _ => self.make_new_location(x,y), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:99:3 [INFO] [stdout] | [INFO] [stdout] 99 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return count; [INFO] [stdout] 99 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:111:4 [INFO] [stdout] | [INFO] [stdout] 111 | return Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())); [INFO] [stdout] 111 + Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:54:33 [INFO] [stdout] | [INFO] [stdout] 54 | fn get_name(&self) -> String { return self.description.clone(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - fn get_name(&self) -> String { return self.description.clone(); } [INFO] [stdout] 54 + fn get_name(&self) -> String { self.description.clone()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:62:3 [INFO] [stdout] | [INFO] [stdout] 62 | return !self.mobiles.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return !self.mobiles.is_empty(); [INFO] [stdout] 62 + !self.mobiles.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:72:3 [INFO] [stdout] | [INFO] [stdout] 72 | return Some(self.items.remove(index)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Some(self.items.remove(index)); [INFO] [stdout] 72 + Some(self.items.remove(index)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] 118 + Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/location.rs:67:6 [INFO] [stdout] | [INFO] [stdout] 67 | if self.items.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:84:3 [INFO] [stdout] | [INFO] [stdout] 84 | return self.fetch_mobile_by_guid(key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return self.fetch_mobile_by_guid(key); [INFO] [stdout] 84 + self.fetch_mobile_by_guid(key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 122 + Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 126 + Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] 130 + Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/location.rs:78:6 [INFO] [stdout] | [INFO] [stdout] 78 | if keys.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `keys.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return result; [INFO] [stdout] 104 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 106 | _ => { return result; } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - _ => { return result; } [INFO] [stdout] 106 + _ => { result} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/map.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | / { [INFO] [stdout] 122 | | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/map.rs:125:4 [INFO] [stdout] | [INFO] [stdout] 125 | / { [INFO] [stdout] 126 | | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/map.rs:139:27 [INFO] [stdout] | [INFO] [stdout] 139 | visitor.visit_location(&mut location,messages); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:176:3 [INFO] [stdout] | [INFO] [stdout] 176 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return result; [INFO] [stdout] 176 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:167:32 [INFO] [stdout] | [INFO] [stdout] 167 | LocationTypeCode::Town => result.push_str("T"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('T')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:168:34 [INFO] [stdout] | [INFO] [stdout] 168 | LocationTypeCode::Forest => result.push_str("-"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:169:37 [INFO] [stdout] | [INFO] [stdout] 169 | LocationTypeCode::DeepWoods => result.push_str("*"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:170:33 [INFO] [stdout] | [INFO] [stdout] 170 | LocationTypeCode::Hills => result.push_str("^"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:171:38 [INFO] [stdout] | [INFO] [stdout] 171 | LocationTypeCode::Unexplored => result.push_str(" "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:174:4 [INFO] [stdout] | [INFO] [stdout] 174 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LocationTypeCode` which implements the `Copy` trait [INFO] [stdout] --> src/location.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | location_type: code.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/map.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | LocationTypeCode::Town => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/map.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/location.rs:123:19 [INFO] [stdout] | [INFO] [stdout] 121 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 122 | { [INFO] [stdout] 123 | self.add_item(item.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/map.rs:203:32 [INFO] [stdout] | [INFO] [stdout] 203 | LocationTypeCode::Forest => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/map.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:139:3 [INFO] [stdout] | [INFO] [stdout] 139 | return self.mobiles.remove(&key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return self.mobiles.remove(&key); [INFO] [stdout] 139 + self.mobiles.remove(&key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 184 | Ok(value) => { return (name.unwrap().to_string(),value); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - Ok(value) => { return (name.unwrap().to_string(),value); }, [INFO] [stdout] 184 + Ok(value) => { (name.unwrap().to_string(),value)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/mobile.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub inventory: Vec >, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | Err(_) => { return (name.unwrap().to_string(),0); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - Err(_) => { return (name.unwrap().to_string(),0); } [INFO] [stdout] 185 + Err(_) => { (name.unwrap().to_string(),0)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 94 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return result; [INFO] [stdout] 94 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | fn parse_name(key: &String) -> (String,usize) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 168 - fn parse_name(key: &String) -> (String,usize) [INFO] [stdout] 168 + fn parse_name(key: &str) -> (String,usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:209:3 [INFO] [stdout] | [INFO] [stdout] 209 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 209 - return None; [INFO] [stdout] 209 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:189:46 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn fetch_mobile_by_name(&mut self, key: &String) -> Option > [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 189 ~ pub fn fetch_mobile_by_name(&mut self, key: &str) -> Option > [INFO] [stdout] 190 | { [INFO] [stdout] 191 | let mut which = 0; [INFO] [stdout] 192 | let mut idx = 0; [INFO] [stdout] 193 ~ let mut lower_case_key = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:81:64 [INFO] [stdout] | [INFO] [stdout] 81 | result += &(", dmg: ".to_string()+&(self.damage.to_string())+&"/".to_string()+&(self.max_hit_points().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/location.rs:234:3 [INFO] [stdout] | [INFO] [stdout] 234 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return None; [INFO] [stdout] 234 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/location.rs:212:44 [INFO] [stdout] | [INFO] [stdout] 212 | pub fn fetch_item_by_name(&mut self, key: &String) -> Option > [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 ~ pub fn fetch_item_by_name(&mut self, key: &str) -> Option > [INFO] [stdout] 213 | { [INFO] [stdout] ... [INFO] [stdout] 216 | let mut i = 0; [INFO] [stdout] 217 ~ let mut lower_case_key = key.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:99:3 [INFO] [stdout] | [INFO] [stdout] 99 | return self.description.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return self.description.clone(); [INFO] [stdout] 99 + self.description.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:104:3 [INFO] [stdout] | [INFO] [stdout] 104 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return self.name.clone(); [INFO] [stdout] 104 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 30 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return map; [INFO] [stdout] 30 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:35:3 [INFO] [stdout] | [INFO] [stdout] 35 | return self.location_by_position.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return self.location_by_position.len(); [INFO] [stdout] 35 + self.location_by_position.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:157:3 [INFO] [stdout] | [INFO] [stdout] 157 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return true; [INFO] [stdout] 157 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:114:41 [INFO] [stdout] | [INFO] [stdout] 114 | let mut file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:43:24 [INFO] [stdout] | [INFO] [stdout] 43 | Some(location) => { return location.has_mobiles(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - Some(location) => { return location.has_mobiles(); }, [INFO] [stdout] 43 + Some(location) => { location.has_mobiles()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/mobile.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | ... match key.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | _ => { return false; } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - _ => { return false; } [INFO] [stdout] 44 + _ => { false} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:162:41 [INFO] [stdout] | [INFO] [stdout] 162 | let mut file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | Some(location) => { return location.location_type; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Some(location) => { return location.location_type; }, [INFO] [stdout] 53 + Some(location) => { location.location_type}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:165:3 [INFO] [stdout] | [INFO] [stdout] 165 | let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 165 - let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] 165 + wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 54 | _ => { return LocationTypeCode::Unexplored; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - _ => { return LocationTypeCode::Unexplored; } [INFO] [stdout] 54 + _ => { LocationTypeCode::Unexplored} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["name",&self.name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | Some(location) => { return location.description(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - Some(location) => { return location.description(); }, [INFO] [stdout] 63 + Some(location) => { location.description()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:166:3 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 166 - let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] 166 + wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:64:11 [INFO] [stdout] | [INFO] [stdout] 64 | _ => { return "Unexplored".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - _ => { return "Unexplored".to_string(); } [INFO] [stdout] 64 + _ => { "Unexplored".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:166:28 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["id",&self.id.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 75 | Some(location) => return location, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - Some(location) => return location, [INFO] [stdout] 75 + Some(location) => location, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 167 - let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] 167 + wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | _ => return self.make_new_location(x,y), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - _ => return self.make_new_location(x,y), [INFO] [stdout] 76 + _ => self.make_new_location(x,y), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:167:28 [INFO] [stdout] | [INFO] [stdout] 167 | let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["str",&self.strength.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:99:3 [INFO] [stdout] | [INFO] [stdout] 99 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return count; [INFO] [stdout] 99 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:168:3 [INFO] [stdout] | [INFO] [stdout] 168 | let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 168 - let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] 168 + wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:111:4 [INFO] [stdout] | [INFO] [stdout] 111 | return Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())); [INFO] [stdout] 111 + Box::new(Location::new(x,y,LocationTypeCode::Forest,"In the forest".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:168:28 [INFO] [stdout] | [INFO] [stdout] 168 | let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dex",&self.dexterity.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 169 - let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] 169 + wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] 118 + Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["con",&self.constitution.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 122 + Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:170:3 [INFO] [stdout] | [INFO] [stdout] 170 | let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 170 - let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] 170 + wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 126 + Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["chr",&self.charisma.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())); [INFO] [stdout] 130 + Box::new(Location::new(x,y,LocationTypeCode::Hills,"In the hills".to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:171:3 [INFO] [stdout] | [INFO] [stdout] 171 | let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 171 - let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] 171 + wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/map.rs:121:4 [INFO] [stdout] | [INFO] [stdout] 121 | / { [INFO] [stdout] 122 | | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/map.rs:125:4 [INFO] [stdout] | [INFO] [stdout] 125 | / { [INFO] [stdout] 126 | | return Box::new(Location::new(x,y,LocationTypeCode::DeepWoods,"In the deep woods".to_string())); [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:171:28 [INFO] [stdout] | [INFO] [stdout] 171 | let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["int",&self.intelligence.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:172:3 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 172 - let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] 172 + wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["wis",&self.wisdom.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:173:3 [INFO] [stdout] | [INFO] [stdout] 173 | let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 173 - let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] 173 + wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["xp",&self.xp.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:174:3 [INFO] [stdout] | [INFO] [stdout] 174 | let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 174 - let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] 174 + wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/map.rs:139:27 [INFO] [stdout] | [INFO] [stdout] 139 | visitor.visit_location(&mut location,messages); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:176:3 [INFO] [stdout] | [INFO] [stdout] 176 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return result; [INFO] [stdout] 176 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:167:32 [INFO] [stdout] | [INFO] [stdout] 167 | LocationTypeCode::Town => result.push_str("T"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('T')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:168:34 [INFO] [stdout] | [INFO] [stdout] 168 | LocationTypeCode::Forest => result.push_str("-"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:169:37 [INFO] [stdout] | [INFO] [stdout] 169 | LocationTypeCode::DeepWoods => result.push_str("*"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:170:33 [INFO] [stdout] | [INFO] [stdout] 170 | LocationTypeCode::Hills => result.push_str("^"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:171:38 [INFO] [stdout] | [INFO] [stdout] 171 | LocationTypeCode::Unexplored => result.push_str(" "), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/map.rs:174:4 [INFO] [stdout] | [INFO] [stdout] 174 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/mobile.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub inventory: Vec >, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:174:28 [INFO] [stdout] | [INFO] [stdout] 174 | let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dmg",&self.damage.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:175:3 [INFO] [stdout] | [INFO] [stdout] 175 | let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 175 - let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] 175 + wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["hp",&self.max_hit_points().to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:176:3 [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 176 - let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] 176 + wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:94:3 [INFO] [stdout] | [INFO] [stdout] 94 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return result; [INFO] [stdout] 94 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["combat",&self.combat.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:177:3 [INFO] [stdout] | [INFO] [stdout] 177 | let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 177 - let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] 177 + wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:177:28 [INFO] [stdout] | [INFO] [stdout] 177 | let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["steal",&self.steal.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:178:3 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] 178 + wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:178:28 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["perception",&self.perception.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 179 - let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] 179 + wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:179:28 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["leatherwork",&self.leatherwork.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:180:3 [INFO] [stdout] | [INFO] [stdout] 180 | let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 180 - let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] 180 + wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:180:28 [INFO] [stdout] | [INFO] [stdout] 180 | let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["metalwork",&self.metalwork.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:181:3 [INFO] [stdout] | [INFO] [stdout] 181 | let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 181 - let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] 181 + wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["woodcraft",&self.woodcraft.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:182:3 [INFO] [stdout] | [INFO] [stdout] 182 | let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 182 - let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] 182 + wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:182:28 [INFO] [stdout] | [INFO] [stdout] 182 | let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["knowledge",&self.knowledge.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:183:3 [INFO] [stdout] | [INFO] [stdout] 183 | let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 183 - let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] 183 + wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:81:64 [INFO] [stdout] | [INFO] [stdout] 81 | result += &(", dmg: ".to_string()+&(self.damage.to_string())+&"/".to_string()+&(self.max_hit_points().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["stealth",&self.stealth.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | let _ = wtr.flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 184 - let _ = wtr.flush().unwrap(); [INFO] [stdout] 184 + wtr.flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:198:3 [INFO] [stdout] | [INFO] [stdout] 198 | return damage_applied; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return damage_applied; [INFO] [stdout] 198 + damage_applied [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:203:45 [INFO] [stdout] | [INFO] [stdout] 203 | let mut old_file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:205:45 [INFO] [stdout] | [INFO] [stdout] 205 | let mut new_file_name = self.name.clone()+&".dead".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `".dead"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:99:3 [INFO] [stdout] | [INFO] [stdout] 99 | return self.description.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return self.description.clone(); [INFO] [stdout] 99 + self.description.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:217:3 [INFO] [stdout] | [INFO] [stdout] 217 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return 0; [INFO] [stdout] 217 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:104:3 [INFO] [stdout] | [INFO] [stdout] 104 | return self.name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return self.name.clone(); [INFO] [stdout] 104 + self.name.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:229:3 [INFO] [stdout] | [INFO] [stdout] 229 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return false; [INFO] [stdout] 229 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:157:3 [INFO] [stdout] | [INFO] [stdout] 157 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return true; [INFO] [stdout] 157 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:241:3 [INFO] [stdout] | [INFO] [stdout] 241 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return false; [INFO] [stdout] 241 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:114:41 [INFO] [stdout] | [INFO] [stdout] 114 | let mut file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:253:3 [INFO] [stdout] | [INFO] [stdout] 253 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return false; [INFO] [stdout] 253 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> src/mobile.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | ... match key.as_ref() [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:265:3 [INFO] [stdout] | [INFO] [stdout] 265 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return false; [INFO] [stdout] 265 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:277:3 [INFO] [stdout] | [INFO] [stdout] 277 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return false; [INFO] [stdout] 277 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:289:3 [INFO] [stdout] | [INFO] [stdout] 289 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return false; [INFO] [stdout] 289 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:301:3 [INFO] [stdout] | [INFO] [stdout] 301 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return false; [INFO] [stdout] 301 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:313:3 [INFO] [stdout] | [INFO] [stdout] 313 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return false; [INFO] [stdout] 313 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:162:41 [INFO] [stdout] | [INFO] [stdout] 162 | let mut file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:165:3 [INFO] [stdout] | [INFO] [stdout] 165 | let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 165 - let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] 165 + wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:330:3 [INFO] [stdout] | [INFO] [stdout] 330 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - return result; [INFO] [stdout] 330 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:165:28 [INFO] [stdout] | [INFO] [stdout] 165 | let _ = wtr.write_record(&["name",&self.name]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["name",&self.name]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:166:3 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 166 - let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] 166 + wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:166:28 [INFO] [stdout] | [INFO] [stdout] 166 | let _ = wtr.write_record(&["id",&self.id.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["id",&self.id.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 167 - let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] 167 + wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:167:28 [INFO] [stdout] | [INFO] [stdout] 167 | let _ = wtr.write_record(&["str",&self.strength.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["str",&self.strength.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 350 | return 10; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return 10; [INFO] [stdout] 350 + 10 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:168:3 [INFO] [stdout] | [INFO] [stdout] 168 | let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 168 - let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] 168 + wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:168:28 [INFO] [stdout] | [INFO] [stdout] 168 | let _ = wtr.write_record(&["dex",&self.dexterity.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dex",&self.dexterity.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:356:3 [INFO] [stdout] | [INFO] [stdout] 356 | return 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll(); [INFO] [stdout] 356 + 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:169:3 [INFO] [stdout] | [INFO] [stdout] 169 | let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 169 - let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] 169 + wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:361:3 [INFO] [stdout] | [INFO] [stdout] 361 | return self.roll_skill(self.strength,self.combat); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return self.roll_skill(self.strength,self.combat); [INFO] [stdout] 361 + self.roll_skill(self.strength,self.combat) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:366:3 [INFO] [stdout] | [INFO] [stdout] 366 | return self.roll_skill(self.dexterity,self.steal); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return self.roll_skill(self.dexterity,self.steal); [INFO] [stdout] 366 + self.roll_skill(self.dexterity,self.steal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:371:3 [INFO] [stdout] | [INFO] [stdout] 371 | return self.roll_skill(self.dexterity,self.stealth); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return self.roll_skill(self.dexterity,self.stealth); [INFO] [stdout] 371 + self.roll_skill(self.dexterity,self.stealth) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:376:3 [INFO] [stdout] | [INFO] [stdout] 376 | return self.roll_skill(self.intelligence,self.knowledge); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - return self.roll_skill(self.intelligence,self.knowledge); [INFO] [stdout] 376 + self.roll_skill(self.intelligence,self.knowledge) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:381:3 [INFO] [stdout] | [INFO] [stdout] 381 | return self.roll_skill(self.wisdom,self.perception); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return self.roll_skill(self.wisdom,self.perception); [INFO] [stdout] 381 + self.roll_skill(self.wisdom,self.perception) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:386:3 [INFO] [stdout] | [INFO] [stdout] 386 | return self.roll_skill(self.intelligence,self.metalwork); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 386 - return self.roll_skill(self.intelligence,self.metalwork); [INFO] [stdout] 386 + self.roll_skill(self.intelligence,self.metalwork) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:391:3 [INFO] [stdout] | [INFO] [stdout] 391 | return self.roll_skill(self.intelligence,self.leatherwork); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return self.roll_skill(self.intelligence,self.leatherwork); [INFO] [stdout] 391 + self.roll_skill(self.intelligence,self.leatherwork) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:396:3 [INFO] [stdout] | [INFO] [stdout] 396 | return self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 396 - return self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)); [INFO] [stdout] 396 + self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:401:3 [INFO] [stdout] | [INFO] [stdout] 401 | return self.roll_skill(self.intelligence,self.woodcraft); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return self.roll_skill(self.intelligence,self.woodcraft); [INFO] [stdout] 401 + self.roll_skill(self.intelligence,self.woodcraft) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:406:3 [INFO] [stdout] | [INFO] [stdout] 406 | return self.id; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return self.id; [INFO] [stdout] 406 + self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:412:3 [INFO] [stdout] | [INFO] [stdout] 412 | return self.actions_used <= self.actions_per_tick; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return self.actions_used <= self.actions_per_tick; [INFO] [stdout] 412 + self.actions_used <= self.actions_per_tick [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:427:3 [INFO] [stdout] | [INFO] [stdout] 427 | return self.max_damage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return self.max_damage; [INFO] [stdout] 427 + self.max_damage [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | let _ = wtr.write_record(&["con",&self.constitution.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["con",&self.constitution.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:437:3 [INFO] [stdout] | [INFO] [stdout] 437 | return self.fetch_item_by_position(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return self.fetch_item_by_position(index); [INFO] [stdout] 437 + self.fetch_item_by_position(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:442:3 [INFO] [stdout] | [INFO] [stdout] 442 | return self.fetch_item_by_position(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return self.fetch_item_by_position(0); [INFO] [stdout] 442 + self.fetch_item_by_position(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:462:3 [INFO] [stdout] | [INFO] [stdout] 462 | return Some(item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 462 - return Some(item); [INFO] [stdout] 462 + Some(item) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ItemCategoryCode` which implements the `Copy` trait [INFO] [stdout] --> src/mobile.rs:452:19 [INFO] [stdout] | [INFO] [stdout] 452 | let slot_code = item.category_code.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `item.category_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:170:3 [INFO] [stdout] | [INFO] [stdout] 170 | let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 170 - let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] 170 + wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 170 | let _ = wtr.write_record(&["chr",&self.charisma.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["chr",&self.charisma.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:171:3 [INFO] [stdout] | [INFO] [stdout] 171 | let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 171 - let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] 171 + wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:474:7 [INFO] [stdout] | [INFO] [stdout] 474 | return "You eat the ".to_owned()+&item.get_name(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return "You eat the ".to_owned()+&item.get_name(); [INFO] [stdout] 474 + "You eat the ".to_owned()+&item.get_name() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:479:7 [INFO] [stdout] | [INFO] [stdout] 479 | return "You cannot eat that!".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - return "You cannot eat that!".to_string(); [INFO] [stdout] 479 + "You cannot eat that!".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:482:14 [INFO] [stdout] | [INFO] [stdout] 482 | None => { return "Eat what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - None => { return "Eat what?".to_string(); } [INFO] [stdout] 482 + None => { "Eat what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:501:3 [INFO] [stdout] | [INFO] [stdout] 501 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 501 - return None; [INFO] [stdout] 501 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:171:28 [INFO] [stdout] | [INFO] [stdout] 171 | let _ = wtr.write_record(&["int",&self.intelligence.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["int",&self.intelligence.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:515:3 [INFO] [stdout] | [INFO] [stdout] 515 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 515 - return None; [INFO] [stdout] 515 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:172:3 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 172 - let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] 172 + wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/mobile.rs:518:44 [INFO] [stdout] | [INFO] [stdout] 518 | pub fn has_room_for_item(&mut self, item: &Box) -> bool [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:172:28 [INFO] [stdout] | [INFO] [stdout] 172 | let _ = wtr.write_record(&["wis",&self.wisdom.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["wis",&self.wisdom.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:522:32 [INFO] [stdout] | [INFO] [stdout] 522 | ItemCategoryCode::Misc => { return self.misc_items_slots > 0; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 522 - ItemCategoryCode::Misc => { return self.misc_items_slots > 0; }, [INFO] [stdout] 522 + ItemCategoryCode::Misc => { self.misc_items_slots > 0}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:523:34 [INFO] [stdout] | [INFO] [stdout] 523 | ItemCategoryCode::Weapon => { return !self.is_armed; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 523 - ItemCategoryCode::Weapon => { return !self.is_armed; }, [INFO] [stdout] 523 + ItemCategoryCode::Weapon => { !self.is_armed}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:524:33 [INFO] [stdout] | [INFO] [stdout] 524 | ItemCategoryCode::Armor => { return !self.is_armored; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 524 - ItemCategoryCode::Armor => { return !self.is_armored; }, [INFO] [stdout] 524 + ItemCategoryCode::Armor => { !self.is_armored}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ItemCategoryCode` which implements the `Copy` trait [INFO] [stdout] --> src/mobile.rs:530:19 [INFO] [stdout] | [INFO] [stdout] 530 | let slot_code = item.category_code.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `item.category_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:545:3 [INFO] [stdout] | [INFO] [stdout] 545 | return self.wanders || self.aggressive || self.collects; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 545 - return self.wanders || self.aggressive || self.collects; [INFO] [stdout] 545 + self.wanders || self.aggressive || self.collects [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:173:3 [INFO] [stdout] | [INFO] [stdout] 173 | let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 173 - let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] 173 + wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:173:28 [INFO] [stdout] | [INFO] [stdout] 173 | let _ = wtr.write_record(&["xp",&self.xp.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["xp",&self.xp.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:174:3 [INFO] [stdout] | [INFO] [stdout] 174 | let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 174 - let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] 174 + wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:174:28 [INFO] [stdout] | [INFO] [stdout] 174 | let _ = wtr.write_record(&["dmg",&self.damage.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["dmg",&self.damage.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:175:3 [INFO] [stdout] | [INFO] [stdout] 175 | let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 175 - let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] 175 + wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:175:28 [INFO] [stdout] | [INFO] [stdout] 175 | let _ = wtr.write_record(&["hp",&self.max_hit_points().to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["hp",&self.max_hit_points().to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:176:3 [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 176 - let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] 176 + wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:552:3 [INFO] [stdout] | [INFO] [stdout] 552 | / return Box::new( [INFO] [stdout] 553 | | Mobile [INFO] [stdout] 554 | | { [INFO] [stdout] 555 | | id: uid::new(), [INFO] [stdout] ... | [INFO] [stdout] 591 | | collects: false [INFO] [stdout] 592 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 ~ Box::new( [INFO] [stdout] 553 ~ Mobile [INFO] [stdout] 554 ~ { [INFO] [stdout] 555 ~ id: uid::new(), [INFO] [stdout] 556 ~ name: name.clone(), [INFO] [stdout] 557 ~ name_with_article: article.clone()+" "+&name, [INFO] [stdout] 558 ~ description: "You see ".to_string()+&article+" "+name+".", [INFO] [stdout] 559 ~ arrive_prefix: article.clone()+" "+name+" arrives", [INFO] [stdout] 560 ~ leave_prefix: article.clone()+" "+name+" leaves", [INFO] [stdout] 561 ~ strength: 10, [INFO] [stdout] 562 ~ dexterity: 10, [INFO] [stdout] 563 ~ constitution: 10, [INFO] [stdout] 564 ~ max_damage: 10, [INFO] [stdout] 565 ~ intelligence: 10, [INFO] [stdout] 566 ~ wisdom: 10, [INFO] [stdout] 567 ~ charisma: 10, [INFO] [stdout] 568 ~ luck: 0, [INFO] [stdout] 569 ~ xp: 0, [INFO] [stdout] 570 ~ combat: 0, [INFO] [stdout] 571 ~ steal: 0, [INFO] [stdout] 572 ~ perception: 0, [INFO] [stdout] 573 ~ leatherwork: 0, [INFO] [stdout] 574 ~ metalwork: 0, [INFO] [stdout] 575 ~ woodcraft: 0, [INFO] [stdout] 576 ~ knowledge: 0, [INFO] [stdout] 577 ~ stealth: 0, [INFO] [stdout] 578 ~ damage: 0, [INFO] [stdout] 579 ~ actions_per_tick: 1, [INFO] [stdout] 580 ~ actions_used: 0, [INFO] [stdout] 581 ~ wielded: "fist".to_string(), [INFO] [stdout] 582 ~ damage_dice: Dice { number: 1, die: 2 }, [INFO] [stdout] 583 ~ inventory: Vec::new(), [INFO] [stdout] 584 ~ misc_items_slots: 10, [INFO] [stdout] 585 ~ is_armed: false, [INFO] [stdout] 586 ~ is_armored: false, [INFO] [stdout] 587 ~ frequency: Mobile::routine_task(), [INFO] [stdout] 588 ~ armor: 0, [INFO] [stdout] 589 ~ wanders: false, [INFO] [stdout] 590 ~ aggressive: false, [INFO] [stdout] 591 ~ collects: false [INFO] [stdout] 592 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mobile.rs:557:44 [INFO] [stdout] | [INFO] [stdout] 557 | name_with_article: article.clone()+" "+&name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:612:3 [INFO] [stdout] | [INFO] [stdout] 612 | return character; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return character; [INFO] [stdout] 612 + character [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:637:20 [INFO] [stdout] | [INFO] [stdout] 635 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 636 | { [INFO] [stdout] 637 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:639:3 [INFO] [stdout] | [INFO] [stdout] 639 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 639 - return mobile; [INFO] [stdout] 639 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:660:3 [INFO] [stdout] | [INFO] [stdout] 660 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 660 - return mobile; [INFO] [stdout] 660 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:682:3 [INFO] [stdout] | [INFO] [stdout] 682 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 682 - return mobile; [INFO] [stdout] 682 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:693:3 [INFO] [stdout] | [INFO] [stdout] 693 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 693 - return mobile; [INFO] [stdout] 693 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:710:20 [INFO] [stdout] | [INFO] [stdout] 708 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 709 | { [INFO] [stdout] 710 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:712:3 [INFO] [stdout] | [INFO] [stdout] 712 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 712 - return mobile; [INFO] [stdout] 712 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:176:28 [INFO] [stdout] | [INFO] [stdout] 176 | let _ = wtr.write_record(&["combat",&self.combat.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["combat",&self.combat.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:177:3 [INFO] [stdout] | [INFO] [stdout] 177 | let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 177 - let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] 177 + wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:177:28 [INFO] [stdout] | [INFO] [stdout] 177 | let _ = wtr.write_record(&["steal",&self.steal.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["steal",&self.steal.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:178:3 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 178 - let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] 178 + wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:178:28 [INFO] [stdout] | [INFO] [stdout] 178 | let _ = wtr.write_record(&["perception",&self.perception.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["perception",&self.perception.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 179 - let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] 179 + wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:179:28 [INFO] [stdout] | [INFO] [stdout] 179 | let _ = wtr.write_record(&["leatherwork",&self.leatherwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["leatherwork",&self.leatherwork.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:180:3 [INFO] [stdout] | [INFO] [stdout] 180 | let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 180 - let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] 180 + wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:180:28 [INFO] [stdout] | [INFO] [stdout] 180 | let _ = wtr.write_record(&["metalwork",&self.metalwork.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["metalwork",&self.metalwork.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:181:3 [INFO] [stdout] | [INFO] [stdout] 181 | let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 181 - let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] 181 + wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | let _ = wtr.write_record(&["woodcraft",&self.woodcraft.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["woodcraft",&self.woodcraft.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:182:3 [INFO] [stdout] | [INFO] [stdout] 182 | let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 182 - let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] 182 + wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:182:28 [INFO] [stdout] | [INFO] [stdout] 182 | let _ = wtr.write_record(&["knowledge",&self.knowledge.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["knowledge",&self.knowledge.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:183:3 [INFO] [stdout] | [INFO] [stdout] 183 | let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 183 - let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] 183 + wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mobile.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | let _ = wtr.write_record(&["stealth",&self.stealth.to_string()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["stealth",&self.stealth.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/mobile.rs:184:3 [INFO] [stdout] | [INFO] [stdout] 184 | let _ = wtr.flush().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 184 - let _ = wtr.flush().unwrap(); [INFO] [stdout] 184 + wtr.flush().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:198:3 [INFO] [stdout] | [INFO] [stdout] 198 | return damage_applied; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return damage_applied; [INFO] [stdout] 198 + damage_applied [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:203:45 [INFO] [stdout] | [INFO] [stdout] 203 | let mut old_file_name = self.name.clone()+&".csv".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `".csv"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:728:20 [INFO] [stdout] | [INFO] [stdout] 726 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 727 | { [INFO] [stdout] 728 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/mobile.rs:205:45 [INFO] [stdout] | [INFO] [stdout] 205 | let mut new_file_name = self.name.clone()+&".dead".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `".dead"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:217:3 [INFO] [stdout] | [INFO] [stdout] 217 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return 0; [INFO] [stdout] 217 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:229:3 [INFO] [stdout] | [INFO] [stdout] 229 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return false; [INFO] [stdout] 229 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:730:3 [INFO] [stdout] | [INFO] [stdout] 730 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 730 - return mobile; [INFO] [stdout] 730 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:744:3 [INFO] [stdout] | [INFO] [stdout] 744 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 - return mobile; [INFO] [stdout] 744 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:756:3 [INFO] [stdout] | [INFO] [stdout] 756 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 756 - return mobile; [INFO] [stdout] 756 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:770:3 [INFO] [stdout] | [INFO] [stdout] 770 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 770 - return mobile; [INFO] [stdout] 770 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:792:3 [INFO] [stdout] | [INFO] [stdout] 792 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 792 - return mobile; [INFO] [stdout] 792 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:807:3 [INFO] [stdout] | [INFO] [stdout] 807 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 807 - return mobile; [INFO] [stdout] 807 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:241:3 [INFO] [stdout] | [INFO] [stdout] 241 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return false; [INFO] [stdout] 241 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:253:3 [INFO] [stdout] | [INFO] [stdout] 253 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 253 - return false; [INFO] [stdout] 253 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:265:3 [INFO] [stdout] | [INFO] [stdout] 265 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 - return false; [INFO] [stdout] 265 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:277:3 [INFO] [stdout] | [INFO] [stdout] 277 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return false; [INFO] [stdout] 277 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:289:3 [INFO] [stdout] | [INFO] [stdout] 289 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return false; [INFO] [stdout] 289 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:301:3 [INFO] [stdout] | [INFO] [stdout] 301 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 - return false; [INFO] [stdout] 301 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:313:3 [INFO] [stdout] | [INFO] [stdout] 313 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 313 - return false; [INFO] [stdout] 313 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:330:3 [INFO] [stdout] | [INFO] [stdout] 330 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 330 - return result; [INFO] [stdout] 330 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:350:3 [INFO] [stdout] | [INFO] [stdout] 350 | return 10; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return 10; [INFO] [stdout] 350 + 10 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:356:3 [INFO] [stdout] | [INFO] [stdout] 356 | return 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll(); [INFO] [stdout] 356 + 5*(Mobile::attribute_modifier(attribute)+skill)+self.luck+die.roll() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:361:3 [INFO] [stdout] | [INFO] [stdout] 361 | return self.roll_skill(self.strength,self.combat); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return self.roll_skill(self.strength,self.combat); [INFO] [stdout] 361 + self.roll_skill(self.strength,self.combat) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:366:3 [INFO] [stdout] | [INFO] [stdout] 366 | return self.roll_skill(self.dexterity,self.steal); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return self.roll_skill(self.dexterity,self.steal); [INFO] [stdout] 366 + self.roll_skill(self.dexterity,self.steal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:371:3 [INFO] [stdout] | [INFO] [stdout] 371 | return self.roll_skill(self.dexterity,self.stealth); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return self.roll_skill(self.dexterity,self.stealth); [INFO] [stdout] 371 + self.roll_skill(self.dexterity,self.stealth) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:376:3 [INFO] [stdout] | [INFO] [stdout] 376 | return self.roll_skill(self.intelligence,self.knowledge); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - return self.roll_skill(self.intelligence,self.knowledge); [INFO] [stdout] 376 + self.roll_skill(self.intelligence,self.knowledge) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:381:3 [INFO] [stdout] | [INFO] [stdout] 381 | return self.roll_skill(self.wisdom,self.perception); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 381 - return self.roll_skill(self.wisdom,self.perception); [INFO] [stdout] 381 + self.roll_skill(self.wisdom,self.perception) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:386:3 [INFO] [stdout] | [INFO] [stdout] 386 | return self.roll_skill(self.intelligence,self.metalwork); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 386 - return self.roll_skill(self.intelligence,self.metalwork); [INFO] [stdout] 386 + self.roll_skill(self.intelligence,self.metalwork) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:391:3 [INFO] [stdout] | [INFO] [stdout] 391 | return self.roll_skill(self.intelligence,self.leatherwork); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 391 - return self.roll_skill(self.intelligence,self.leatherwork); [INFO] [stdout] 391 + self.roll_skill(self.intelligence,self.leatherwork) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:396:3 [INFO] [stdout] | [INFO] [stdout] 396 | return self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 396 - return self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)); [INFO] [stdout] 396 + self.roll_skill(self.intelligence,max(self.leatherwork,self.woodcraft)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:401:3 [INFO] [stdout] | [INFO] [stdout] 401 | return self.roll_skill(self.intelligence,self.woodcraft); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return self.roll_skill(self.intelligence,self.woodcraft); [INFO] [stdout] 401 + self.roll_skill(self.intelligence,self.woodcraft) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:406:3 [INFO] [stdout] | [INFO] [stdout] 406 | return self.id; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - return self.id; [INFO] [stdout] 406 + self.id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:412:3 [INFO] [stdout] | [INFO] [stdout] 412 | return self.actions_used <= self.actions_per_tick; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - return self.actions_used <= self.actions_per_tick; [INFO] [stdout] 412 + self.actions_used <= self.actions_per_tick [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:427:3 [INFO] [stdout] | [INFO] [stdout] 427 | return self.max_damage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return self.max_damage; [INFO] [stdout] 427 + self.max_damage [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:437:3 [INFO] [stdout] | [INFO] [stdout] 437 | return self.fetch_item_by_position(index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - return self.fetch_item_by_position(index); [INFO] [stdout] 437 + self.fetch_item_by_position(index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:442:3 [INFO] [stdout] | [INFO] [stdout] 442 | return self.fetch_item_by_position(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 442 - return self.fetch_item_by_position(0); [INFO] [stdout] 442 + self.fetch_item_by_position(0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:462:3 [INFO] [stdout] | [INFO] [stdout] 462 | return Some(item); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 462 - return Some(item); [INFO] [stdout] 462 + Some(item) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ItemCategoryCode` which implements the `Copy` trait [INFO] [stdout] --> src/mobile.rs:452:19 [INFO] [stdout] | [INFO] [stdout] 452 | let slot_code = item.category_code.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `item.category_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:474:7 [INFO] [stdout] | [INFO] [stdout] 474 | return "You eat the ".to_owned()+&item.get_name(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return "You eat the ".to_owned()+&item.get_name(); [INFO] [stdout] 474 + "You eat the ".to_owned()+&item.get_name() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:479:7 [INFO] [stdout] | [INFO] [stdout] 479 | return "You cannot eat that!".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - return "You cannot eat that!".to_string(); [INFO] [stdout] 479 + "You cannot eat that!".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:482:14 [INFO] [stdout] | [INFO] [stdout] 482 | None => { return "Eat what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - None => { return "Eat what?".to_string(); } [INFO] [stdout] 482 + None => { "Eat what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:501:3 [INFO] [stdout] | [INFO] [stdout] 501 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 501 - return None; [INFO] [stdout] 501 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:515:3 [INFO] [stdout] | [INFO] [stdout] 515 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 515 - return None; [INFO] [stdout] 515 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:822:3 [INFO] [stdout] | [INFO] [stdout] 822 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 822 - return mobile; [INFO] [stdout] 822 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:826:33 [INFO] [stdout] | [INFO] [stdout] 826 | pub fn trivial_task() -> i16 { return 5*5; } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 826 - pub fn trivial_task() -> i16 { return 5*5; } [INFO] [stdout] 826 + pub fn trivial_task() -> i16 { 5*5} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:827:30 [INFO] [stdout] | [INFO] [stdout] 827 | pub fn easy_task() -> i16 { return 5*10; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 827 - pub fn easy_task() -> i16 { return 5*10; } [INFO] [stdout] 827 + pub fn easy_task() -> i16 { 5*10} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:828:33 [INFO] [stdout] | [INFO] [stdout] 828 | pub fn routine_task() -> i16 { return 5*15; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 828 - pub fn routine_task() -> i16 { return 5*15; } [INFO] [stdout] 828 + pub fn routine_task() -> i16 { 5*15} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:829:33 [INFO] [stdout] | [INFO] [stdout] 829 | pub fn skilled_task() -> i16 { return 5*20; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 829 - pub fn skilled_task() -> i16 { return 5*20; } [INFO] [stdout] 829 + pub fn skilled_task() -> i16 { 5*20} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:830:38 [INFO] [stdout] | [INFO] [stdout] 830 | pub fn very_skilled_task() -> i16 { return 5*25; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 830 - pub fn very_skilled_task() -> i16 { return 5*25; } [INFO] [stdout] 830 + pub fn very_skilled_task() -> i16 { 5*25} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:831:32 [INFO] [stdout] | [INFO] [stdout] 831 | pub fn heroic_task() -> i16 { return 5*30; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 831 - pub fn heroic_task() -> i16 { return 5*30; } [INFO] [stdout] 831 + pub fn heroic_task() -> i16 { 5*30} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/mobile.rs:518:44 [INFO] [stdout] | [INFO] [stdout] 518 | pub fn has_room_for_item(&mut self, item: &Box) -> bool [INFO] [stdout] | ^^^^^^^^^^ help: try: `&Item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:522:32 [INFO] [stdout] | [INFO] [stdout] 522 | ItemCategoryCode::Misc => { return self.misc_items_slots > 0; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 522 - ItemCategoryCode::Misc => { return self.misc_items_slots > 0; }, [INFO] [stdout] 522 + ItemCategoryCode::Misc => { self.misc_items_slots > 0}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:523:34 [INFO] [stdout] | [INFO] [stdout] 523 | ItemCategoryCode::Weapon => { return !self.is_armed; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 523 - ItemCategoryCode::Weapon => { return !self.is_armed; }, [INFO] [stdout] 523 + ItemCategoryCode::Weapon => { !self.is_armed}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:524:33 [INFO] [stdout] | [INFO] [stdout] 524 | ItemCategoryCode::Armor => { return !self.is_armored; }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 524 - ItemCategoryCode::Armor => { return !self.is_armored; }, [INFO] [stdout] 524 + ItemCategoryCode::Armor => { !self.is_armored}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ItemCategoryCode` which implements the `Copy` trait [INFO] [stdout] --> src/mobile.rs:530:19 [INFO] [stdout] | [INFO] [stdout] 530 | let slot_code = item.category_code.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `item.category_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:545:3 [INFO] [stdout] | [INFO] [stdout] 545 | return self.wanders || self.aggressive || self.collects; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 545 - return self.wanders || self.aggressive || self.collects; [INFO] [stdout] 545 + self.wanders || self.aggressive || self.collects [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:552:3 [INFO] [stdout] | [INFO] [stdout] 552 | / return Box::new( [INFO] [stdout] 553 | | Mobile [INFO] [stdout] 554 | | { [INFO] [stdout] 555 | | id: uid::new(), [INFO] [stdout] ... | [INFO] [stdout] 591 | | collects: false [INFO] [stdout] 592 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 ~ Box::new( [INFO] [stdout] 553 ~ Mobile [INFO] [stdout] 554 ~ { [INFO] [stdout] 555 ~ id: uid::new(), [INFO] [stdout] 556 ~ name: name.clone(), [INFO] [stdout] 557 ~ name_with_article: article.clone()+" "+&name, [INFO] [stdout] 558 ~ description: "You see ".to_string()+&article+" "+name+".", [INFO] [stdout] 559 ~ arrive_prefix: article.clone()+" "+name+" arrives", [INFO] [stdout] 560 ~ leave_prefix: article.clone()+" "+name+" leaves", [INFO] [stdout] 561 ~ strength: 10, [INFO] [stdout] 562 ~ dexterity: 10, [INFO] [stdout] 563 ~ constitution: 10, [INFO] [stdout] 564 ~ max_damage: 10, [INFO] [stdout] 565 ~ intelligence: 10, [INFO] [stdout] 566 ~ wisdom: 10, [INFO] [stdout] 567 ~ charisma: 10, [INFO] [stdout] 568 ~ luck: 0, [INFO] [stdout] 569 ~ xp: 0, [INFO] [stdout] 570 ~ combat: 0, [INFO] [stdout] 571 ~ steal: 0, [INFO] [stdout] 572 ~ perception: 0, [INFO] [stdout] 573 ~ leatherwork: 0, [INFO] [stdout] 574 ~ metalwork: 0, [INFO] [stdout] 575 ~ woodcraft: 0, [INFO] [stdout] 576 ~ knowledge: 0, [INFO] [stdout] 577 ~ stealth: 0, [INFO] [stdout] 578 ~ damage: 0, [INFO] [stdout] 579 ~ actions_per_tick: 1, [INFO] [stdout] 580 ~ actions_used: 0, [INFO] [stdout] 581 ~ wielded: "fist".to_string(), [INFO] [stdout] 582 ~ damage_dice: Dice { number: 1, die: 2 }, [INFO] [stdout] 583 ~ inventory: Vec::new(), [INFO] [stdout] 584 ~ misc_items_slots: 10, [INFO] [stdout] 585 ~ is_armed: false, [INFO] [stdout] 586 ~ is_armored: false, [INFO] [stdout] 587 ~ frequency: Mobile::routine_task(), [INFO] [stdout] 588 ~ armor: 0, [INFO] [stdout] 589 ~ wanders: false, [INFO] [stdout] 590 ~ aggressive: false, [INFO] [stdout] 591 ~ collects: false [INFO] [stdout] 592 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mobile.rs:557:44 [INFO] [stdout] | [INFO] [stdout] 557 | name_with_article: article.clone()+" "+&name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:612:3 [INFO] [stdout] | [INFO] [stdout] 612 | return character; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return character; [INFO] [stdout] 612 + character [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:637:20 [INFO] [stdout] | [INFO] [stdout] 635 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 636 | { [INFO] [stdout] 637 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:639:3 [INFO] [stdout] | [INFO] [stdout] 639 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 639 - return mobile; [INFO] [stdout] 639 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:660:3 [INFO] [stdout] | [INFO] [stdout] 660 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 660 - return mobile; [INFO] [stdout] 660 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:682:3 [INFO] [stdout] | [INFO] [stdout] 682 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 682 - return mobile; [INFO] [stdout] 682 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:693:3 [INFO] [stdout] | [INFO] [stdout] 693 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 693 - return mobile; [INFO] [stdout] 693 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:710:20 [INFO] [stdout] | [INFO] [stdout] 708 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 709 | { [INFO] [stdout] 710 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:712:3 [INFO] [stdout] | [INFO] [stdout] 712 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 712 - return mobile; [INFO] [stdout] 712 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `treasure` after checking its variant with `is_some` [INFO] [stdout] --> src/mobile.rs:728:20 [INFO] [stdout] | [INFO] [stdout] 726 | if treasure.is_some() [INFO] [stdout] | --------------------- help: try: `if let Some() = treasure` [INFO] [stdout] 727 | { [INFO] [stdout] 728 | mobile.add_item(treasure.unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:730:3 [INFO] [stdout] | [INFO] [stdout] 730 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 730 - return mobile; [INFO] [stdout] 730 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:744:3 [INFO] [stdout] | [INFO] [stdout] 744 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 - return mobile; [INFO] [stdout] 744 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:756:3 [INFO] [stdout] | [INFO] [stdout] 756 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 756 - return mobile; [INFO] [stdout] 756 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:770:3 [INFO] [stdout] | [INFO] [stdout] 770 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 770 - return mobile; [INFO] [stdout] 770 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:792:3 [INFO] [stdout] | [INFO] [stdout] 792 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 792 - return mobile; [INFO] [stdout] 792 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:807:3 [INFO] [stdout] | [INFO] [stdout] 807 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 807 - return mobile; [INFO] [stdout] 807 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:822:3 [INFO] [stdout] | [INFO] [stdout] 822 | return mobile; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 822 - return mobile; [INFO] [stdout] 822 + mobile [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:826:33 [INFO] [stdout] | [INFO] [stdout] 826 | pub fn trivial_task() -> i16 { return 5*5; } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 826 - pub fn trivial_task() -> i16 { return 5*5; } [INFO] [stdout] 826 + pub fn trivial_task() -> i16 { 5*5} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:827:30 [INFO] [stdout] | [INFO] [stdout] 827 | pub fn easy_task() -> i16 { return 5*10; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 827 - pub fn easy_task() -> i16 { return 5*10; } [INFO] [stdout] 827 + pub fn easy_task() -> i16 { 5*10} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:828:33 [INFO] [stdout] | [INFO] [stdout] 828 | pub fn routine_task() -> i16 { return 5*15; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 828 - pub fn routine_task() -> i16 { return 5*15; } [INFO] [stdout] 828 + pub fn routine_task() -> i16 { 5*15} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:829:33 [INFO] [stdout] | [INFO] [stdout] 829 | pub fn skilled_task() -> i16 { return 5*20; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 829 - pub fn skilled_task() -> i16 { return 5*20; } [INFO] [stdout] 829 + pub fn skilled_task() -> i16 { 5*20} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:830:38 [INFO] [stdout] | [INFO] [stdout] 830 | pub fn very_skilled_task() -> i16 { return 5*25; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 830 - pub fn very_skilled_task() -> i16 { return 5*25; } [INFO] [stdout] 830 + pub fn very_skilled_task() -> i16 { 5*25} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mobile.rs:831:32 [INFO] [stdout] | [INFO] [stdout] 831 | pub fn heroic_task() -> i16 { return 5*30; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 831 - pub fn heroic_task() -> i16 { return 5*30; } [INFO] [stdout] 831 + pub fn heroic_task() -> i16 { 5*30} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 30 | / return EventList [INFO] [stdout] 31 | | { [INFO] [stdout] 32 | | even_event_queue: LinkedList::new(), [INFO] [stdout] 33 | | odd_event_queue: LinkedList::new(), [INFO] [stdout] 34 | | is_odd : false [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ EventList [INFO] [stdout] 31 ~ { [INFO] [stdout] 32 ~ even_event_queue: LinkedList::new(), [INFO] [stdout] 33 ~ odd_event_queue: LinkedList::new(), [INFO] [stdout] 34 ~ is_odd : false [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/events.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | print!("# events is {}, {} in {} \n",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 71 - print!("# events is {}, {} in {} \n",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] 71 + println!("# events is {}, {} in {} ",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | if !a_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `a_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 95 | if !b_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `b_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 109 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 110 | { [INFO] [stdout] 111 | let mut a = a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 109 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 112 | let mut b = b.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:191:38 [INFO] [stdout] | [INFO] [stdout] 191 | if a.is_some() { world.add_mobile(a.unwrap(),a_position.0,a_position.1); } [INFO] [stdout] | -------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:192:38 [INFO] [stdout] | [INFO] [stdout] 192 | if b.is_some() { world.add_mobile(b.unwrap(),b_position.0,b_position.1); } [INFO] [stdout] | -------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:210:6 [INFO] [stdout] | [INFO] [stdout] 210 | if !coordinate.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `coordinate.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 217 | None => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - None => { return; } [INFO] [stdout] 217 + None => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:252:14 [INFO] [stdout] | [INFO] [stdout] 252 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - _ => { return; } [INFO] [stdout] 252 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:325:16 [INFO] [stdout] | [INFO] [stdout] 323 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 324 | { [INFO] [stdout] 325 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/events.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / if target.name != mobile.name && mobile.use_action() [INFO] [stdout] 288 | | { [INFO] [stdout] 289 | | if target.roll_stealth() > mobile.roll_perception() [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 287 ~ if target.name != mobile.name && mobile.use_action() [INFO] [stdout] 288 ~ && target.roll_stealth() > mobile.roll_perception() [INFO] [stdout] 289 | { [INFO] [stdout] 290 | world.message_list.broadcast(mobile.name_with_article.clone()+" attacks "+&target.name_with_article+"!",xy.0,xy.1); [INFO] [stdout] 291 | event_q.insert(Box::new(CombatEvent { attacker: self.id, defender: target.get_id(), first_round: true })); [INFO] [stdout] 292 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | world.message_list.broadcast(mob_name+&" picks up a ".to_string()+&item.get_name(),xy.0,xy.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" picks up a "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:367:14 [INFO] [stdout] | [INFO] [stdout] 367 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - _ => { return; } [INFO] [stdout] 367 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:376:14 [INFO] [stdout] | [INFO] [stdout] 376 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - _ => { return; } [INFO] [stdout] 376 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:385:14 [INFO] [stdout] | [INFO] [stdout] 385 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - _ => { return; } [INFO] [stdout] 385 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:394:14 [INFO] [stdout] | [INFO] [stdout] 394 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - _ => { return; } [INFO] [stdout] 394 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:397:11 [INFO] [stdout] | [INFO] [stdout] 397 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - _ => { return; } [INFO] [stdout] 397 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:410:11 [INFO] [stdout] | [INFO] [stdout] 410 | 0 => { return Some(Mobile::dwarf_miner()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - 0 => { return Some(Mobile::dwarf_miner()); }, [INFO] [stdout] 410 + 0 => { Some(Mobile::dwarf_miner())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | 1 => { return Some(Mobile::dwarf_soldier()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - 1 => { return Some(Mobile::dwarf_soldier()); }, [INFO] [stdout] 411 + 1 => { Some(Mobile::dwarf_soldier())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:412:11 [INFO] [stdout] | [INFO] [stdout] 412 | 3 => { return Some(Mobile::orc()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - 3 => { return Some(Mobile::orc()); }, [INFO] [stdout] 412 + 3 => { Some(Mobile::orc())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:413:11 [INFO] [stdout] | [INFO] [stdout] 413 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 413 - _ => { return None; } [INFO] [stdout] 413 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:422:11 [INFO] [stdout] | [INFO] [stdout] 422 | 0 => { return Some(Mobile::goblin()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - 0 => { return Some(Mobile::goblin()); }, [INFO] [stdout] 422 + 0 => { Some(Mobile::goblin())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:423:11 [INFO] [stdout] | [INFO] [stdout] 423 | 1 => { return Some(Mobile::head_hunter()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - 1 => { return Some(Mobile::head_hunter()); }, [INFO] [stdout] 423 + 1 => { Some(Mobile::head_hunter())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:424:11 [INFO] [stdout] | [INFO] [stdout] 424 | 2 => { return Some(Mobile::bandit()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - 2 => { return Some(Mobile::bandit()); }, [INFO] [stdout] 424 + 2 => { Some(Mobile::bandit())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:425:11 [INFO] [stdout] | [INFO] [stdout] 425 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - _ => { return None; } [INFO] [stdout] 425 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:434:11 [INFO] [stdout] | [INFO] [stdout] 434 | 0 => { return Some(Mobile::rodent()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 - 0 => { return Some(Mobile::rodent()); }, [INFO] [stdout] 434 + 0 => { Some(Mobile::rodent())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:435:11 [INFO] [stdout] | [INFO] [stdout] 435 | 1 => { return Some(Mobile::lumber_jack()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - 1 => { return Some(Mobile::lumber_jack()); }, [INFO] [stdout] 435 + 1 => { Some(Mobile::lumber_jack())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:436:11 [INFO] [stdout] | [INFO] [stdout] 436 | 2 => { return Some(Mobile::rabbit()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - 2 => { return Some(Mobile::rabbit()); }, [INFO] [stdout] 436 + 2 => { Some(Mobile::rabbit())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:437:11 [INFO] [stdout] | [INFO] [stdout] 437 | 3 => { return Some(Mobile::small_woodland_creature()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - 3 => { return Some(Mobile::small_woodland_creature()); }, [INFO] [stdout] 437 + 3 => { Some(Mobile::small_woodland_creature())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:438:11 [INFO] [stdout] | [INFO] [stdout] 438 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - _ => { return None; } [INFO] [stdout] 438 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:447:11 [INFO] [stdout] | [INFO] [stdout] 447 | 0 => { return Some(Mobile::beggar()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - 0 => { return Some(Mobile::beggar()); }, [INFO] [stdout] 447 + 0 => { Some(Mobile::beggar())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:448:11 [INFO] [stdout] | [INFO] [stdout] 448 | 1 => { return Some(Mobile::foppish_dandy()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 448 - 1 => { return Some(Mobile::foppish_dandy()); }, [INFO] [stdout] 448 + 1 => { Some(Mobile::foppish_dandy())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:449:11 [INFO] [stdout] | [INFO] [stdout] 449 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - _ => { return None; } [INFO] [stdout] 449 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:30:3 [INFO] [stdout] | [INFO] [stdout] 30 | / return EventList [INFO] [stdout] 31 | | { [INFO] [stdout] 32 | | even_event_queue: LinkedList::new(), [INFO] [stdout] 33 | | odd_event_queue: LinkedList::new(), [INFO] [stdout] 34 | | is_odd : false [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 ~ EventList [INFO] [stdout] 31 ~ { [INFO] [stdout] 32 ~ even_event_queue: LinkedList::new(), [INFO] [stdout] 33 ~ odd_event_queue: LinkedList::new(), [INFO] [stdout] 34 ~ is_odd : false [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:488:3 [INFO] [stdout] | [INFO] [stdout] 488 | return WanderingMonsterEvent {}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return WanderingMonsterEvent {}; [INFO] [stdout] 488 + WanderingMonsterEvent {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | return AgeEvent {}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 525 - return AgeEvent {}; [INFO] [stdout] 525 + AgeEvent {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:542:6 [INFO] [stdout] | [INFO] [stdout] 542 | if !a_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `a_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:546:6 [INFO] [stdout] | [INFO] [stdout] 546 | if !b_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `b_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:562:16 [INFO] [stdout] | [INFO] [stdout] 560 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 561 | { [INFO] [stdout] 562 | let mut a = a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:563:16 [INFO] [stdout] | [INFO] [stdout] 560 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 563 | let mut b = b.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:572:18 [INFO] [stdout] | [INFO] [stdout] 570 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 571 | { [INFO] [stdout] 572 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:608:21 [INFO] [stdout] | [INFO] [stdout] 605 | if a.is_some() [INFO] [stdout] | -------------- help: try: `if let Some() = a` [INFO] [stdout] ... [INFO] [stdout] 608 | world.add_mobile(a.unwrap(),a_position.0,a_position.1); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:612:21 [INFO] [stdout] | [INFO] [stdout] 610 | if b.is_some() [INFO] [stdout] | -------------- help: try: `if let Some() = b` [INFO] [stdout] 611 | { [INFO] [stdout] 612 | world.add_mobile(b.unwrap(),b_position.0,b_position.1); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:670:67 [INFO] [stdout] | [INFO] [stdout] 670 | ...name_with_article.clone()+&" makes some hide armor".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes some hide armor"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:676:67 [INFO] [stdout] | [INFO] [stdout] 676 | ...mobile.name_with_article.clone()+&" ruins a corpse".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a corpse"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:708:66 [INFO] [stdout] | [INFO] [stdout] 708 | ...le.name_with_article.clone()+&" works at the forge".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" works at the forge"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:720:66 [INFO] [stdout] | [INFO] [stdout] 720 | ...e.name_with_article.clone()+&" ruins a metal ingot".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a metal ingot"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:740:65 [INFO] [stdout] | [INFO] [stdout] 740 | world.message_list.broadcast(mobile.name_with_article.clone()+&" makes ".to_string()+&successes.to_string()+ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:741:4 [INFO] [stdout] | [INFO] [stdout] 741 | &" pieces of rawhide!".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" pieces of rawhide!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:751:67 [INFO] [stdout] | [INFO] [stdout] 751 | ...e_with_article.clone()+&" makes some leather armor".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes some leather armor"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:757:67 [INFO] [stdout] | [INFO] [stdout] 757 | ...le.name_with_article.clone()+&" ruins some rawhide".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins some rawhide"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/events.rs:71:3 [INFO] [stdout] | [INFO] [stdout] 71 | print!("# events is {}, {} in {} \n",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 71 - print!("# events is {}, {} in {} \n",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] 71 + println!("# events is {}, {} in {} ",self.odd_event_queue.len(),self.even_event_queue.len(),now.elapsed().as_millis()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:91:6 [INFO] [stdout] | [INFO] [stdout] 91 | if !a_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `a_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 95 | if !b_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `b_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | world.message_list.broadcast(mobile.name_with_article.clone()+&" flakes a stone knife".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" flakes a stone knife"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:776:66 [INFO] [stdout] | [INFO] [stdout] 776 | ....name_with_article.clone()+&" ruins a bit of chert".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a bit of chert"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:784:66 [INFO] [stdout] | [INFO] [stdout] 784 | world.message_list.broadcast(mobile.name_with_article.clone()+&" sharpens a stick".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" sharpens a stick"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:790:66 [INFO] [stdout] | [INFO] [stdout] 790 | world.message_list.broadcast(mobile.name_with_article.clone()+&" ruins a stick".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a stick"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | return MessageList { msg_list: LinkedList::new() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return MessageList { msg_list: LinkedList::new() }; [INFO] [stdout] 23 + MessageList { msg_list: LinkedList::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 109 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 110 | { [INFO] [stdout] 111 | let mut a = a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 109 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 112 | let mut b = b.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return result; [INFO] [stdout] 113 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:191:38 [INFO] [stdout] | [INFO] [stdout] 191 | if a.is_some() { world.add_mobile(a.unwrap(),a_position.0,a_position.1); } [INFO] [stdout] | -------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:192:38 [INFO] [stdout] | [INFO] [stdout] 192 | if b.is_some() { world.add_mobile(b.unwrap(),b_position.0,b_position.1); } [INFO] [stdout] | -------------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:145:3 [INFO] [stdout] | [INFO] [stdout] 145 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return result; [INFO] [stdout] 145 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dice.rs:21:3 [INFO] [stdout] | [INFO] [stdout] 21 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return result; [INFO] [stdout] 21 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/uid.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return ID_COUNTER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return ID_COUNTER; [INFO] [stdout] 9 + ID_COUNTER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return false; [INFO] [stdout] 32 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:42:3 [INFO] [stdout] | [INFO] [stdout] 42 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return true; [INFO] [stdout] 42 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:54:14 [INFO] [stdout] | [INFO] [stdout] 52 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 53 | { [INFO] [stdout] 54 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:70:2 [INFO] [stdout] | [INFO] [stdout] 70 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return result; [INFO] [stdout] 70 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return "You begin making rawhide".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return "You begin making rawhide".to_string(); [INFO] [stdout] 80 + "You begin making rawhide".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return "You begin making leather armor".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return "You begin making leather armor".to_string(); [INFO] [stdout] 85 + "You begin making leather armor".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return "You begin making hide armor".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return "You begin making hide armor".to_string(); [INFO] [stdout] 90 + "You begin making hide armor".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return "You begin sharpening a stick".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return "You begin sharpening a stick".to_string(); [INFO] [stdout] 95 + "You begin sharpening a stick".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return "You begin knapping a stone".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return "You begin knapping a stone".to_string(); [INFO] [stdout] 100 + "You begin knapping a stone".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return "You begin forging a sword".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return "You begin forging a sword".to_string(); [INFO] [stdout] 105 + "You begin forging a sword".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | return "You begin forging an axe".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return "You begin forging an axe".to_string(); [INFO] [stdout] 110 + "You begin forging an axe".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return "You begin forging a pick".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return "You begin forging a pick".to_string(); [INFO] [stdout] 115 + "You begin forging a pick".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return "You begin make a shirt of chain".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return "You begin make a shirt of chain".to_string(); [INFO] [stdout] 120 + "You begin make a shirt of chain".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] 122 + _ => { "What is ".to_string()+target+&"?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:122:47 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"?"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:177:2 [INFO] [stdout] | [INFO] [stdout] 177 | return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] 177 + "You have improved at ".to_string()+&skill+"!" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:177:45 [INFO] [stdout] | [INFO] [stdout] 177 | return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] | ^^^^^^ help: change this to: `skill` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 186 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 187 | { [INFO] [stdout] 188 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:204:2 [INFO] [stdout] | [INFO] [stdout] 204 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return result; [INFO] [stdout] 204 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:185:39 [INFO] [stdout] | [INFO] [stdout] 185 | let item = mobile.fetch_item_by_name(&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:213:2 [INFO] [stdout] | [INFO] [stdout] 213 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return result; [INFO] [stdout] 213 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:223:10 [INFO] [stdout] | [INFO] [stdout] 223 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - _ => { return; } [INFO] [stdout] 223 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:219:67 [INFO] [stdout] | [INFO] [stdout] 219 | let defender = world.get_mobile_id_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - _ => { return; } [INFO] [stdout] 234 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:230:63 [INFO] [stdout] | [INFO] [stdout] 230 | let mark = world.get_mobile_id_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mobile` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:255:16 [INFO] [stdout] | [INFO] [stdout] 253 | if mobile.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = mobile` [INFO] [stdout] 254 | { [INFO] [stdout] 255 | let mobile = mobile.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:263:14 [INFO] [stdout] | [INFO] [stdout] 261 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 262 | { [INFO] [stdout] 263 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:268:2 [INFO] [stdout] | [INFO] [stdout] 268 | return "Look at what?".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return "Look at what?".to_string(); [INFO] [stdout] 268 + "Look at what?".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:64 [INFO] [stdout] | [INFO] [stdout] 252 | let mobile = world.fetch_mobile_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:260:60 [INFO] [stdout] | [INFO] [stdout] 260 | let item = world.fetch_item_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:274:2 [INFO] [stdout] | [INFO] [stdout] 274 | return world.get_location_description(position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return world.get_location_description(position.0,position.1); [INFO] [stdout] 274 + world.get_location_description(position.0,position.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:283:2 [INFO] [stdout] | [INFO] [stdout] 283 | return ("You have:\n".to_owned()+&inventory).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return ("You have:\n".to_owned()+&inventory).to_string(); [INFO] [stdout] 283 + ("You have:\n".to_owned()+&inventory).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mobile` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:294:16 [INFO] [stdout] | [INFO] [stdout] 292 | if mobile.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = mobile` [INFO] [stdout] 293 | { [INFO] [stdout] 294 | let mobile = mobile.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 305 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 306 | { [INFO] [stdout] 307 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:318:2 [INFO] [stdout] | [INFO] [stdout] 318 | return "Stat what?".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - return "Stat what?".to_string(); [INFO] [stdout] 318 + "Stat what?".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:291:64 [INFO] [stdout] | [INFO] [stdout] 291 | let mobile = world.fetch_mobile_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:304:60 [INFO] [stdout] | [INFO] [stdout] 304 | let item = world.fetch_item_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:327:2 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:385:2 [INFO] [stdout] | [INFO] [stdout] 385 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - return result; [INFO] [stdout] 385 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:210:6 [INFO] [stdout] | [INFO] [stdout] 210 | if !coordinate.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `coordinate.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:217:14 [INFO] [stdout] | [INFO] [stdout] 217 | None => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - None => { return; } [INFO] [stdout] 217 + None => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:376:26 [INFO] [stdout] | [INFO] [stdout] 376 | if clean_line.contains(&"y") [INFO] [stdout] | ^^^^ help: change this to: `"y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:397:36 [INFO] [stdout] | [INFO] [stdout] 397 | "e" => { goto(uuid,1,0,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - "e" => { goto(uuid,1,0,event_q); return String::new(); } [INFO] [stdout] 397 + "e" => { goto(uuid,1,0,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:252:14 [INFO] [stdout] | [INFO] [stdout] 252 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - _ => { return; } [INFO] [stdout] 252 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:398:37 [INFO] [stdout] | [INFO] [stdout] 398 | "w" => { goto(uuid,-1,0,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - "w" => { goto(uuid,-1,0,event_q); return String::new(); } [INFO] [stdout] 398 + "w" => { goto(uuid,-1,0,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:399:36 [INFO] [stdout] | [INFO] [stdout] 399 | "n" => { goto(uuid,0,1,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - "n" => { goto(uuid,0,1,event_q); return String::new(); } [INFO] [stdout] 399 + "n" => { goto(uuid,0,1,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | "s" => { goto(uuid,0,-1,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - "s" => { goto(uuid,0,-1,event_q); return String::new(); } [INFO] [stdout] 400 + "s" => { goto(uuid,0,-1,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | return fs::read_to_string("help.txt").expect("could not read help.txt"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return fs::read_to_string("help.txt").expect("could not read help.txt"); [INFO] [stdout] 403 + fs::read_to_string("help.txt").expect("could not read help.txt") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:410:24 [INFO] [stdout] | [INFO] [stdout] 410 | Some(target) => { return eat_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - Some(target) => { return eat_item(uuid,world,target); }, [INFO] [stdout] 410 + Some(target) => { eat_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:411:16 [INFO] [stdout] | [INFO] [stdout] 411 | None => { return "Eat what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - None => { return "Eat what?".to_string(); } [INFO] [stdout] 411 + None => { "Eat what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:419:24 [INFO] [stdout] | [INFO] [stdout] 419 | Some(target) => { return look_at(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 419 - Some(target) => { return look_at(uuid,world,target); }, [INFO] [stdout] 419 + Some(target) => { look_at(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:420:16 [INFO] [stdout] | [INFO] [stdout] 420 | None => { return look(uuid,world); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 - None => { return look(uuid,world); } [INFO] [stdout] 420 + None => { look(uuid,world)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:428:58 [INFO] [stdout] | [INFO] [stdout] 428 | Some(target) => { kill(uuid,world,event_q,&target); return String::new(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - Some(target) => { kill(uuid,world,event_q,&target); return String::new(); }, [INFO] [stdout] 428 + Some(target) => { kill(uuid,world,event_q,&target); String::new()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:429:16 [INFO] [stdout] | [INFO] [stdout] 429 | None => { return "Kill what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - None => { return "Kill what?".to_string(); } [INFO] [stdout] 429 + None => { "Kill what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:437:58 [INFO] [stdout] | [INFO] [stdout] 437 | Some(target) => { steal(uuid,world,event_q,target); return String::new(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - Some(target) => { steal(uuid,world,event_q,target); return String::new(); }, [INFO] [stdout] 437 + Some(target) => { steal(uuid,world,event_q,target); String::new()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:438:16 [INFO] [stdout] | [INFO] [stdout] 438 | None => { return "Steal from whom?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - None => { return "Steal from whom?".to_string(); } [INFO] [stdout] 438 + None => { "Steal from whom?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:446:24 [INFO] [stdout] | [INFO] [stdout] 446 | Some(target) => { return get_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 446 - Some(target) => { return get_item(uuid,world,target); }, [INFO] [stdout] 446 + Some(target) => { get_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:447:16 [INFO] [stdout] | [INFO] [stdout] 447 | None => { return "Get what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - None => { return "Get what?".to_string(); } [INFO] [stdout] 447 + None => { "Get what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:455:24 [INFO] [stdout] | [INFO] [stdout] 455 | Some(target) => { return drop_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 455 - Some(target) => { return drop_item(uuid,world,target); }, [INFO] [stdout] 455 + Some(target) => { drop_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:456:16 [INFO] [stdout] | [INFO] [stdout] 456 | None => { return "Drop what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - None => { return "Drop what?".to_string(); } [INFO] [stdout] 456 + None => { "Drop what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:464:24 [INFO] [stdout] | [INFO] [stdout] 464 | Some(target) => { return practice(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 464 - Some(target) => { return practice(uuid,world,target); }, [INFO] [stdout] 464 + Some(target) => { practice(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:465:16 [INFO] [stdout] | [INFO] [stdout] 465 | None => { return "Practice what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 465 - None => { return "Practice what?".to_string(); } [INFO] [stdout] 465 + None => { "Practice what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | return "Goodbye!".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 471 - return "Goodbye!".to_string(); [INFO] [stdout] 471 + "Goodbye!".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:478:24 [INFO] [stdout] | [INFO] [stdout] 478 | Some(target) => { return show_stats_of(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 478 - Some(target) => { return show_stats_of(uuid,world,target); }, [INFO] [stdout] 478 + Some(target) => { show_stats_of(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:325:16 [INFO] [stdout] | [INFO] [stdout] 323 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 324 | { [INFO] [stdout] 325 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:479:16 [INFO] [stdout] | [INFO] [stdout] 479 | None => { return show_stats(uuid,world); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - None => { return show_stats(uuid,world); } [INFO] [stdout] 479 + None => { show_stats(uuid,world)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | "i" => { return show_inventory(uuid,world); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 482 - "i" => { return show_inventory(uuid,world); }, [INFO] [stdout] 482 + "i" => { show_inventory(uuid,world)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:488:24 [INFO] [stdout] | [INFO] [stdout] 488 | Some(target) => { return make_item(uuid,event_q,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - Some(target) => { return make_item(uuid,event_q,target); }, [INFO] [stdout] 488 + Some(target) => { make_item(uuid,event_q,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:489:16 [INFO] [stdout] | [INFO] [stdout] 489 | None => { return "Make what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 489 - None => { return "Make what?".to_string(); } [INFO] [stdout] 489 + None => { "Make what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:494:5 [INFO] [stdout] | [INFO] [stdout] 494 | return "What?".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 494 - return "What?".to_string(); [INFO] [stdout] 494 + "What?".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:428:48 [INFO] [stdout] | [INFO] [stdout] 428 | Some(target) => { kill(uuid,world,event_q,&target); return String::new(); }, [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/events.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | / if target.name != mobile.name && mobile.use_action() [INFO] [stdout] 288 | | { [INFO] [stdout] 289 | | if target.roll_stealth() > mobile.roll_perception() [INFO] [stdout] ... | [INFO] [stdout] 294 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 287 ~ if target.name != mobile.name && mobile.use_action() [INFO] [stdout] 288 ~ && target.roll_stealth() > mobile.roll_perception() [INFO] [stdout] 289 | { [INFO] [stdout] 290 | world.message_list.broadcast(mobile.name_with_article.clone()+" attacks "+&target.name_with_article+"!",xy.0,xy.1); [INFO] [stdout] 291 | event_q.insert(Box::new(CombatEvent { attacker: self.id, defender: target.get_id(), first_round: true })); [INFO] [stdout] 292 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:546:3 [INFO] [stdout] | [INFO] [stdout] 546 | / match end [INFO] [stdout] 547 | | { [INFO] [stdout] 548 | | Some(end) => if *end == b'\n' { has_input = true; }, [INFO] [stdout] 549 | | _ => { () } [INFO] [stdout] 550 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(end) = end { if *end == b'\n' { has_input = true; } }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:622:17 [INFO] [stdout] | [INFO] [stdout] 622 | event_q.tick(&mut *world); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&mut world` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | world.message_list.broadcast(mob_name+&" picks up a ".to_string()+&item.get_name(),xy.0,xy.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" picks up a "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:367:14 [INFO] [stdout] | [INFO] [stdout] 367 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - _ => { return; } [INFO] [stdout] 367 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:376:14 [INFO] [stdout] | [INFO] [stdout] 376 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 376 - _ => { return; } [INFO] [stdout] 376 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:385:14 [INFO] [stdout] | [INFO] [stdout] 385 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - _ => { return; } [INFO] [stdout] 385 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:394:14 [INFO] [stdout] | [INFO] [stdout] 394 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - _ => { return; } [INFO] [stdout] 394 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:397:11 [INFO] [stdout] | [INFO] [stdout] 397 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - _ => { return; } [INFO] [stdout] 397 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:410:11 [INFO] [stdout] | [INFO] [stdout] 410 | 0 => { return Some(Mobile::dwarf_miner()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - 0 => { return Some(Mobile::dwarf_miner()); }, [INFO] [stdout] 410 + 0 => { Some(Mobile::dwarf_miner())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:411:11 [INFO] [stdout] | [INFO] [stdout] 411 | 1 => { return Some(Mobile::dwarf_soldier()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - 1 => { return Some(Mobile::dwarf_soldier()); }, [INFO] [stdout] 411 + 1 => { Some(Mobile::dwarf_soldier())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:412:11 [INFO] [stdout] | [INFO] [stdout] 412 | 3 => { return Some(Mobile::orc()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 412 - 3 => { return Some(Mobile::orc()); }, [INFO] [stdout] 412 + 3 => { Some(Mobile::orc())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:413:11 [INFO] [stdout] | [INFO] [stdout] 413 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 413 - _ => { return None; } [INFO] [stdout] 413 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:422:11 [INFO] [stdout] | [INFO] [stdout] 422 | 0 => { return Some(Mobile::goblin()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 422 - 0 => { return Some(Mobile::goblin()); }, [INFO] [stdout] 422 + 0 => { Some(Mobile::goblin())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:423:11 [INFO] [stdout] | [INFO] [stdout] 423 | 1 => { return Some(Mobile::head_hunter()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - 1 => { return Some(Mobile::head_hunter()); }, [INFO] [stdout] 423 + 1 => { Some(Mobile::head_hunter())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:424:11 [INFO] [stdout] | [INFO] [stdout] 424 | 2 => { return Some(Mobile::bandit()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - 2 => { return Some(Mobile::bandit()); }, [INFO] [stdout] 424 + 2 => { Some(Mobile::bandit())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:425:11 [INFO] [stdout] | [INFO] [stdout] 425 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - _ => { return None; } [INFO] [stdout] 425 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:434:11 [INFO] [stdout] | [INFO] [stdout] 434 | 0 => { return Some(Mobile::rodent()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 434 - 0 => { return Some(Mobile::rodent()); }, [INFO] [stdout] 434 + 0 => { Some(Mobile::rodent())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:435:11 [INFO] [stdout] | [INFO] [stdout] 435 | 1 => { return Some(Mobile::lumber_jack()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - 1 => { return Some(Mobile::lumber_jack()); }, [INFO] [stdout] 435 + 1 => { Some(Mobile::lumber_jack())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:436:11 [INFO] [stdout] | [INFO] [stdout] 436 | 2 => { return Some(Mobile::rabbit()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 436 - 2 => { return Some(Mobile::rabbit()); }, [INFO] [stdout] 436 + 2 => { Some(Mobile::rabbit())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:437:11 [INFO] [stdout] | [INFO] [stdout] 437 | 3 => { return Some(Mobile::small_woodland_creature()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - 3 => { return Some(Mobile::small_woodland_creature()); }, [INFO] [stdout] 437 + 3 => { Some(Mobile::small_woodland_creature())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:438:11 [INFO] [stdout] | [INFO] [stdout] 438 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - _ => { return None; } [INFO] [stdout] 438 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:447:11 [INFO] [stdout] | [INFO] [stdout] 447 | 0 => { return Some(Mobile::beggar()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - 0 => { return Some(Mobile::beggar()); }, [INFO] [stdout] 447 + 0 => { Some(Mobile::beggar())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:448:11 [INFO] [stdout] | [INFO] [stdout] 448 | 1 => { return Some(Mobile::foppish_dandy()); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 448 - 1 => { return Some(Mobile::foppish_dandy()); }, [INFO] [stdout] 448 + 1 => { Some(Mobile::foppish_dandy())}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:449:11 [INFO] [stdout] | [INFO] [stdout] 449 | _ => { return None; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - _ => { return None; } [INFO] [stdout] 449 + _ => { None} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:488:3 [INFO] [stdout] | [INFO] [stdout] 488 | return WanderingMonsterEvent {}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return WanderingMonsterEvent {}; [INFO] [stdout] 488 + WanderingMonsterEvent {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/events.rs:525:3 [INFO] [stdout] | [INFO] [stdout] 525 | return AgeEvent {}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 525 - return AgeEvent {}; [INFO] [stdout] 525 + AgeEvent {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:542:6 [INFO] [stdout] | [INFO] [stdout] 542 | if !a_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `a_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/events.rs:546:6 [INFO] [stdout] | [INFO] [stdout] 546 | if !b_location.is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `b_location.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:562:16 [INFO] [stdout] | [INFO] [stdout] 560 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 561 | { [INFO] [stdout] 562 | let mut a = a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:563:16 [INFO] [stdout] | [INFO] [stdout] 560 | if a.is_some() && b.is_some() [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 563 | let mut b = b.unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:572:18 [INFO] [stdout] | [INFO] [stdout] 570 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 571 | { [INFO] [stdout] 572 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `a` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:608:21 [INFO] [stdout] | [INFO] [stdout] 605 | if a.is_some() [INFO] [stdout] | -------------- help: try: `if let Some() = a` [INFO] [stdout] ... [INFO] [stdout] 608 | world.add_mobile(a.unwrap(),a_position.0,a_position.1); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `b` after checking its variant with `is_some` [INFO] [stdout] --> src/events.rs:612:21 [INFO] [stdout] | [INFO] [stdout] 610 | if b.is_some() [INFO] [stdout] | -------------- help: try: `if let Some() = b` [INFO] [stdout] 611 | { [INFO] [stdout] 612 | world.add_mobile(b.unwrap(),b_position.0,b_position.1); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:670:67 [INFO] [stdout] | [INFO] [stdout] 670 | ...name_with_article.clone()+&" makes some hide armor".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes some hide armor"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:676:67 [INFO] [stdout] | [INFO] [stdout] 676 | ...mobile.name_with_article.clone()+&" ruins a corpse".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a corpse"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:708:66 [INFO] [stdout] | [INFO] [stdout] 708 | ...le.name_with_article.clone()+&" works at the forge".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" works at the forge"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:720:66 [INFO] [stdout] | [INFO] [stdout] 720 | ...e.name_with_article.clone()+&" ruins a metal ingot".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a metal ingot"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:740:65 [INFO] [stdout] | [INFO] [stdout] 740 | world.message_list.broadcast(mobile.name_with_article.clone()+&" makes ".to_string()+&successes.to_string()+ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes "` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:741:4 [INFO] [stdout] | [INFO] [stdout] 741 | &" pieces of rawhide!".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" pieces of rawhide!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:751:67 [INFO] [stdout] | [INFO] [stdout] 751 | ...e_with_article.clone()+&" makes some leather armor".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" makes some leather armor"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:757:67 [INFO] [stdout] | [INFO] [stdout] 757 | ...le.name_with_article.clone()+&" ruins some rawhide".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins some rawhide"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:770:66 [INFO] [stdout] | [INFO] [stdout] 770 | world.message_list.broadcast(mobile.name_with_article.clone()+&" flakes a stone knife".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" flakes a stone knife"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:776:66 [INFO] [stdout] | [INFO] [stdout] 776 | ....name_with_article.clone()+&" ruins a bit of chert".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a bit of chert"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:784:66 [INFO] [stdout] | [INFO] [stdout] 784 | world.message_list.broadcast(mobile.name_with_article.clone()+&" sharpens a stick".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" sharpens a stick"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/events.rs:790:66 [INFO] [stdout] | [INFO] [stdout] 790 | world.message_list.broadcast(mobile.name_with_article.clone()+&" ruins a stick".to_string(),position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `" ruins a stick"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | return MessageList { msg_list: LinkedList::new() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return MessageList { msg_list: LinkedList::new() }; [INFO] [stdout] 23 + MessageList { msg_list: LinkedList::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:113:3 [INFO] [stdout] | [INFO] [stdout] 113 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return result; [INFO] [stdout] 113 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/message.rs:145:3 [INFO] [stdout] | [INFO] [stdout] 145 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - return result; [INFO] [stdout] 145 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dice.rs:21:3 [INFO] [stdout] | [INFO] [stdout] 21 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return result; [INFO] [stdout] 21 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/uid.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return ID_COUNTER; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return ID_COUNTER; [INFO] [stdout] 9 + ID_COUNTER [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return false; [INFO] [stdout] 32 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:42:3 [INFO] [stdout] | [INFO] [stdout] 42 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return true; [INFO] [stdout] 42 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:54:14 [INFO] [stdout] | [INFO] [stdout] 52 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 53 | { [INFO] [stdout] 54 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:70:2 [INFO] [stdout] | [INFO] [stdout] 70 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return result; [INFO] [stdout] 70 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return "You begin making rawhide".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return "You begin making rawhide".to_string(); [INFO] [stdout] 80 + "You begin making rawhide".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return "You begin making leather armor".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return "You begin making leather armor".to_string(); [INFO] [stdout] 85 + "You begin making leather armor".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return "You begin making hide armor".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return "You begin making hide armor".to_string(); [INFO] [stdout] 90 + "You begin making hide armor".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | return "You begin sharpening a stick".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return "You begin sharpening a stick".to_string(); [INFO] [stdout] 95 + "You begin sharpening a stick".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return "You begin knapping a stone".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return "You begin knapping a stone".to_string(); [INFO] [stdout] 100 + "You begin knapping a stone".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 105 | return "You begin forging a sword".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return "You begin forging a sword".to_string(); [INFO] [stdout] 105 + "You begin forging a sword".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | return "You begin forging an axe".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return "You begin forging an axe".to_string(); [INFO] [stdout] 110 + "You begin forging an axe".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return "You begin forging a pick".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return "You begin forging a pick".to_string(); [INFO] [stdout] 115 + "You begin forging a pick".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return "You begin make a shirt of chain".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return "You begin make a shirt of chain".to_string(); [INFO] [stdout] 120 + "You begin make a shirt of chain".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:122:10 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] 122 + _ => { "What is ".to_string()+target+&"?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:122:47 [INFO] [stdout] | [INFO] [stdout] 122 | _ => { return "What is ".to_string()+target+&"?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"?"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:177:2 [INFO] [stdout] | [INFO] [stdout] 177 | return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] 177 + "You have improved at ".to_string()+&skill+"!" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:177:45 [INFO] [stdout] | [INFO] [stdout] 177 | return "You have improved at ".to_string()+&skill+"!"; [INFO] [stdout] | ^^^^^^ help: change this to: `skill` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 186 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 187 | { [INFO] [stdout] 188 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:204:2 [INFO] [stdout] | [INFO] [stdout] 204 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return result; [INFO] [stdout] 204 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:185:39 [INFO] [stdout] | [INFO] [stdout] 185 | let item = mobile.fetch_item_by_name(&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:213:2 [INFO] [stdout] | [INFO] [stdout] 213 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return result; [INFO] [stdout] 213 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:223:10 [INFO] [stdout] | [INFO] [stdout] 223 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - _ => { return; } [INFO] [stdout] 223 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:219:67 [INFO] [stdout] | [INFO] [stdout] 219 | let defender = world.get_mobile_id_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | _ => { return; } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - _ => { return; } [INFO] [stdout] 234 + _ => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:230:63 [INFO] [stdout] | [INFO] [stdout] 230 | let mark = world.get_mobile_id_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mobile` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:255:16 [INFO] [stdout] | [INFO] [stdout] 253 | if mobile.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = mobile` [INFO] [stdout] 254 | { [INFO] [stdout] 255 | let mobile = mobile.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:263:14 [INFO] [stdout] | [INFO] [stdout] 261 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 262 | { [INFO] [stdout] 263 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:268:2 [INFO] [stdout] | [INFO] [stdout] 268 | return "Look at what?".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return "Look at what?".to_string(); [INFO] [stdout] 268 + "Look at what?".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:252:64 [INFO] [stdout] | [INFO] [stdout] 252 | let mobile = world.fetch_mobile_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:260:60 [INFO] [stdout] | [INFO] [stdout] 260 | let item = world.fetch_item_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:274:2 [INFO] [stdout] | [INFO] [stdout] 274 | return world.get_location_description(position.0,position.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 274 - return world.get_location_description(position.0,position.1); [INFO] [stdout] 274 + world.get_location_description(position.0,position.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:283:2 [INFO] [stdout] | [INFO] [stdout] 283 | return ("You have:\n".to_owned()+&inventory).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return ("You have:\n".to_owned()+&inventory).to_string(); [INFO] [stdout] 283 + ("You have:\n".to_owned()+&inventory).to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mobile` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:294:16 [INFO] [stdout] | [INFO] [stdout] 292 | if mobile.is_some() [INFO] [stdout] | ------------------- help: try: `if let Some() = mobile` [INFO] [stdout] 293 | { [INFO] [stdout] 294 | let mobile = mobile.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `item` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:307:14 [INFO] [stdout] | [INFO] [stdout] 305 | if item.is_some() [INFO] [stdout] | ----------------- help: try: `if let Some() = item` [INFO] [stdout] 306 | { [INFO] [stdout] 307 | let item = item.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:318:2 [INFO] [stdout] | [INFO] [stdout] 318 | return "Stat what?".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 318 - return "Stat what?".to_string(); [INFO] [stdout] 318 + "Stat what?".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:291:64 [INFO] [stdout] | [INFO] [stdout] 291 | let mobile = world.fetch_mobile_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:304:60 [INFO] [stdout] | [INFO] [stdout] 304 | let item = world.fetch_item_by_name(position.0,position.1,&target); [INFO] [stdout] | ^^^^^^^ help: change this to: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:327:2 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:385:2 [INFO] [stdout] | [INFO] [stdout] 385 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 385 - return result; [INFO] [stdout] 385 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:376:26 [INFO] [stdout] | [INFO] [stdout] 376 | if clean_line.contains(&"y") [INFO] [stdout] | ^^^^ help: change this to: `"y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:397:36 [INFO] [stdout] | [INFO] [stdout] 397 | "e" => { goto(uuid,1,0,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 397 - "e" => { goto(uuid,1,0,event_q); return String::new(); } [INFO] [stdout] 397 + "e" => { goto(uuid,1,0,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:398:37 [INFO] [stdout] | [INFO] [stdout] 398 | "w" => { goto(uuid,-1,0,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - "w" => { goto(uuid,-1,0,event_q); return String::new(); } [INFO] [stdout] 398 + "w" => { goto(uuid,-1,0,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:399:36 [INFO] [stdout] | [INFO] [stdout] 399 | "n" => { goto(uuid,0,1,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - "n" => { goto(uuid,0,1,event_q); return String::new(); } [INFO] [stdout] 399 + "n" => { goto(uuid,0,1,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | "s" => { goto(uuid,0,-1,event_q); return String::new(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - "s" => { goto(uuid,0,-1,event_q); return String::new(); } [INFO] [stdout] 400 + "s" => { goto(uuid,0,-1,event_q); String::new()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:403:5 [INFO] [stdout] | [INFO] [stdout] 403 | return fs::read_to_string("help.txt").expect("could not read help.txt"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return fs::read_to_string("help.txt").expect("could not read help.txt"); [INFO] [stdout] 403 + fs::read_to_string("help.txt").expect("could not read help.txt") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:410:24 [INFO] [stdout] | [INFO] [stdout] 410 | Some(target) => { return eat_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 410 - Some(target) => { return eat_item(uuid,world,target); }, [INFO] [stdout] 410 + Some(target) => { eat_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:411:16 [INFO] [stdout] | [INFO] [stdout] 411 | None => { return "Eat what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - None => { return "Eat what?".to_string(); } [INFO] [stdout] 411 + None => { "Eat what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:419:24 [INFO] [stdout] | [INFO] [stdout] 419 | Some(target) => { return look_at(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 419 - Some(target) => { return look_at(uuid,world,target); }, [INFO] [stdout] 419 + Some(target) => { look_at(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:420:16 [INFO] [stdout] | [INFO] [stdout] 420 | None => { return look(uuid,world); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 - None => { return look(uuid,world); } [INFO] [stdout] 420 + None => { look(uuid,world)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:428:58 [INFO] [stdout] | [INFO] [stdout] 428 | Some(target) => { kill(uuid,world,event_q,&target); return String::new(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 428 - Some(target) => { kill(uuid,world,event_q,&target); return String::new(); }, [INFO] [stdout] 428 + Some(target) => { kill(uuid,world,event_q,&target); String::new()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:429:16 [INFO] [stdout] | [INFO] [stdout] 429 | None => { return "Kill what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - None => { return "Kill what?".to_string(); } [INFO] [stdout] 429 + None => { "Kill what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:437:58 [INFO] [stdout] | [INFO] [stdout] 437 | Some(target) => { steal(uuid,world,event_q,target); return String::new(); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 437 - Some(target) => { steal(uuid,world,event_q,target); return String::new(); }, [INFO] [stdout] 437 + Some(target) => { steal(uuid,world,event_q,target); String::new()}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:438:16 [INFO] [stdout] | [INFO] [stdout] 438 | None => { return "Steal from whom?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 438 - None => { return "Steal from whom?".to_string(); } [INFO] [stdout] 438 + None => { "Steal from whom?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:446:24 [INFO] [stdout] | [INFO] [stdout] 446 | Some(target) => { return get_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 446 - Some(target) => { return get_item(uuid,world,target); }, [INFO] [stdout] 446 + Some(target) => { get_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:447:16 [INFO] [stdout] | [INFO] [stdout] 447 | None => { return "Get what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - None => { return "Get what?".to_string(); } [INFO] [stdout] 447 + None => { "Get what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:455:24 [INFO] [stdout] | [INFO] [stdout] 455 | Some(target) => { return drop_item(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 455 - Some(target) => { return drop_item(uuid,world,target); }, [INFO] [stdout] 455 + Some(target) => { drop_item(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:456:16 [INFO] [stdout] | [INFO] [stdout] 456 | None => { return "Drop what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - None => { return "Drop what?".to_string(); } [INFO] [stdout] 456 + None => { "Drop what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:464:24 [INFO] [stdout] | [INFO] [stdout] 464 | Some(target) => { return practice(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 464 - Some(target) => { return practice(uuid,world,target); }, [INFO] [stdout] 464 + Some(target) => { practice(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:465:16 [INFO] [stdout] | [INFO] [stdout] 465 | None => { return "Practice what?".to_string(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 465 - None => { return "Practice what?".to_string(); } [INFO] [stdout] 465 + None => { "Practice what?".to_string()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:471:5 [INFO] [stdout] | [INFO] [stdout] 471 | return "Goodbye!".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 471 - return "Goodbye!".to_string(); [INFO] [stdout] 471 + "Goodbye!".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:478:24 [INFO] [stdout] | [INFO] [stdout] 478 | Some(target) => { return show_stats_of(uuid,world,target); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 478 - Some(target) => { return show_stats_of(uuid,world,target); }, [INFO] [stdout] 478 + Some(target) => { show_stats_of(uuid,world,target)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:479:16 [INFO] [stdout] | [INFO] [stdout] 479 | None => { return show_stats(uuid,world); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 - None => { return show_stats(uuid,world); } [INFO] [stdout] 479 + None => { show_stats(uuid,world)} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 482 | "i" => { return show_inventory(uuid,world); }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [WARN] too many lines in the log, truncating it