[INFO] cloning repository https://github.com/slifer-cd/number_transformer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/slifer-cd/number_transformer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslifer-cd%2Fnumber_transformer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslifer-cd%2Fnumber_transformer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b7997ff98ecdae033be49693c304c8a715ee3772 [INFO] linting slifer-cd/number_transformer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslifer-cd%2Fnumber_transformer" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/slifer-cd/number_transformer [INFO] finished tweaking git repo https://github.com/slifer-cd/number_transformer [INFO] tweaked toml for git repo https://github.com/slifer-cd/number_transformer written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/slifer-cd/number_transformer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/slifer-cd/number_transformer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cbd6b801765f7a0b83d209b0c0dc9e5b4ceabb6eab0aeb177a39bb02fd72689 [INFO] running `Command { std: "docker" "start" "-a" "1cbd6b801765f7a0b83d209b0c0dc9e5b4ceabb6eab0aeb177a39bb02fd72689", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cbd6b801765f7a0b83d209b0c0dc9e5b4ceabb6eab0aeb177a39bb02fd72689", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cbd6b801765f7a0b83d209b0c0dc9e5b4ceabb6eab0aeb177a39bb02fd72689", kill_on_drop: false }` [INFO] [stdout] 1cbd6b801765f7a0b83d209b0c0dc9e5b4ceabb6eab0aeb177a39bb02fd72689 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a32911882344702ea02f92114a582fc9c53701b683b76f776a16748941e9a71 [INFO] running `Command { std: "docker" "start" "-a" "5a32911882344702ea02f92114a582fc9c53701b683b76f776a16748941e9a71", kill_on_drop: false }` [INFO] [stderr] Checking number_transformer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/inputs.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | / if map.contains_key(&f) { [INFO] [stdout] 7 | | f [INFO] [stdout] 8 | | } else { [INFO] [stdout] 9 | | 0 [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 5 ~ Some(f) [INFO] [stdout] 6 ~ if map.contains_key(&f) => { [INFO] [stdout] 7 | f [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/inputs.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!((ch >= '0') && (ch <= '9') || (ch >= 'A') && (ch <= 'F'))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 55 | if (ch < '0') || (ch > '7') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!('0'..='7').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if (ch < '0') || (ch > '9') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!('0'..='9').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:72:58 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='F').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/inputs.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | / if map.contains_key(&f) { [INFO] [stdout] 7 | | f [INFO] [stdout] 8 | | } else { [INFO] [stdout] 9 | | 0 [INFO] [stdout] 10 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 5 ~ Some(f) [INFO] [stdout] 6 ~ if map.contains_key(&f) => { [INFO] [stdout] 7 | f [INFO] [stdout] 8 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return binary; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return binary; [INFO] [stdout] 82 + binary [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn to_binary(number: &String, types: i32) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn to_binary(number: &String, types: i32) -> String { [INFO] [stdout] 56 + pub fn to_binary(number: &str, types: i32) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/inputs.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!((ch >= '0') && (ch <= '9') || (ch >= 'A') && (ch <= 'F'))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn to_decimal(number: &String, types: i32) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - pub fn to_decimal(number: &String, types: i32) -> String { [INFO] [stdout] 85 + pub fn to_decimal(number: &str, types: i32) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 55 | if (ch < '0') || (ch > '7') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!('0'..='7').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | if (ch < '0') || (ch > '9') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!('0'..='9').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | return octal; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return octal; [INFO] [stdout] 153 + octal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/inputs.rs:72:58 [INFO] [stdout] | [INFO] [stdout] 72 | if !((ch >= '0') && (ch <= '9')) && !((ch >= 'A') && (ch <= 'F')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='F').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/transform.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | while new_number.len() % 3 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!new_number.len().is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `insert_str()` using a single-character string literal [INFO] [stdout] --> src/transform.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | new_number.insert_str(0, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` with a character literal: `new_number.insert(0, '0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/transform.rs:151:32 [INFO] [stdout] | [INFO] [stdout] 151 | octal.push_str(map.get(&(new_number[start..end].to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_number[start..end]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/transform.rs:172:11 [INFO] [stdout] | [INFO] [stdout] 172 | while new_number.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!new_number.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] [stdout] warning: calling `insert_str()` using a single-character string literal [INFO] [stdout] --> src/transform.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | new_number.insert_str(0, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` with a character literal: `new_number.insert(0, '0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/transform.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 178 | hex.push_str(map.get(&(new_number[start..end].to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_number[start..end]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return binary; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return binary; [INFO] [stdout] 82 + binary [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn to_binary(number: &String, types: i32) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 56 - pub fn to_binary(number: &String, types: i32) -> String { [INFO] [stdout] 56 + pub fn to_binary(number: &str, types: i32) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/transform.rs:85:27 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn to_decimal(number: &String, types: i32) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - pub fn to_decimal(number: &String, types: i32) -> String { [INFO] [stdout] 85 + pub fn to_decimal(number: &str, types: i32) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | return octal; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return octal; [INFO] [stdout] 153 + octal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/transform.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | while new_number.len() % 3 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!new_number.len().is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `insert_str()` using a single-character string literal [INFO] [stdout] --> src/transform.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | new_number.insert_str(0, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` with a character literal: `new_number.insert(0, '0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/transform.rs:151:32 [INFO] [stdout] | [INFO] [stdout] 151 | octal.push_str(map.get(&(new_number[start..end].to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_number[start..end]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/transform.rs:172:11 [INFO] [stdout] | [INFO] [stdout] 172 | while new_number.len() % 4 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!new_number.len().is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `insert_str()` using a single-character string literal [INFO] [stdout] --> src/transform.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | new_number.insert_str(0, "0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` with a character literal: `new_number.insert(0, '0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/transform.rs:178:30 [INFO] [stdout] | [INFO] [stdout] 178 | hex.push_str(map.get(&(new_number[start..end].to_string())).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_number[start..end]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5a32911882344702ea02f92114a582fc9c53701b683b76f776a16748941e9a71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a32911882344702ea02f92114a582fc9c53701b683b76f776a16748941e9a71", kill_on_drop: false }` [INFO] [stdout] 5a32911882344702ea02f92114a582fc9c53701b683b76f776a16748941e9a71