[INFO] cloning repository https://github.com/slava-class/mise-command-sequencer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/slava-class/mise-command-sequencer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslava-class%2Fmise-command-sequencer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslava-class%2Fmise-command-sequencer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 41276d848a23d5fe6d16abf29a1b1dd3ba95e613 [INFO] linting slava-class/mise-command-sequencer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fslava-class%2Fmise-command-sequencer" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/slava-class/mise-command-sequencer [INFO] finished tweaking git repo https://github.com/slava-class/mise-command-sequencer [INFO] tweaked toml for git repo https://github.com/slava-class/mise-command-sequencer written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/slava-class/mise-command-sequencer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/slava-class/mise-command-sequencer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tui-input v0.14.0 [INFO] [stderr] Downloaded toml_datetime v0.7.0 [INFO] [stderr] Downloaded toml v0.9.5 [INFO] [stderr] Downloaded gzip-header v1.0.0 [INFO] [stderr] Downloaded cargo-platform v0.2.0 [INFO] [stderr] Downloaded ansi-to-tui v7.0.0 [INFO] [stderr] Downloaded cargo_metadata v0.20.0 [INFO] [stderr] Downloaded toml_parser v1.0.2 [INFO] [stderr] Downloaded coveralls-api v0.7.0 [INFO] [stderr] Downloaded llvm_profparser v0.8.3 [INFO] [stderr] Downloaded twox-hash v2.1.1 [INFO] [stderr] Downloaded cargo-util-schemas v0.2.0 [INFO] [stderr] Downloaded winnow v0.7.12 [INFO] [stderr] Downloaded cargo-tarpaulin v0.32.8 [INFO] [stderr] Downloaded serde_spanned v1.0.0 [INFO] [stderr] Downloaded toml_writer v1.0.2 [INFO] [stderr] Downloaded object v0.37.2 [INFO] [stderr] Downloaded gimli v0.32.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ddc45d9c0f920824266011eac170216255ccd7b4e3da4292a6e20d2bb46b9c76 [INFO] running `Command { std: "docker" "start" "-a" "ddc45d9c0f920824266011eac170216255ccd7b4e3da4292a6e20d2bb46b9c76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ddc45d9c0f920824266011eac170216255ccd7b4e3da4292a6e20d2bb46b9c76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddc45d9c0f920824266011eac170216255ccd7b4e3da4292a6e20d2bb46b9c76", kill_on_drop: false }` [INFO] [stdout] ddc45d9c0f920824266011eac170216255ccd7b4e3da4292a6e20d2bb46b9c76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60fffed476f389ae03a8336a34e07d281e1f4c3bbcefaf5d38e049860706732a [INFO] running `Command { std: "docker" "start" "-a" "60fffed476f389ae03a8336a34e07d281e1f4c3bbcefaf5d38e049860706732a", kill_on_drop: false }` [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling camino v1.1.10 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Compiling llvm_profparser v0.8.3 [INFO] [stderr] Checking twox-hash v2.1.1 [INFO] [stderr] Compiling object v0.37.2 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Compiling procfs v0.17.0 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking ruzstd v0.8.1 [INFO] [stderr] Checking clap_builder v4.5.42 [INFO] [stderr] Compiling cargo-tarpaulin v0.32.8 [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking toml_writer v1.0.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking gimli v0.32.0 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Checking procfs-core v0.17.0 [INFO] [stderr] Checking toml_parser v1.0.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling libssh2-sys v0.3.1 [INFO] [stderr] Compiling libgit2-sys v0.18.2+1.9.1 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking clap v4.5.42 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking ansi-to-tui v7.0.0 [INFO] [stderr] Checking tui-input v0.14.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking git2 v0.20.2 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking erased-serde v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking cargo-platform v0.2.0 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking serde-untagged v0.1.7 [INFO] [stderr] Checking mise-command-sequencer v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 344 | / if let Some(dialog_area) = self.delete_dialog_area { [INFO] [stdout] 345 | | if let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 346 | | match button { [INFO] [stdout] 347 | | DialogButton::Delete => { [INFO] [stdout] ... | [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 344 ~ if let Some(dialog_area) = self.delete_dialog_area [INFO] [stdout] 345 ~ && let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 346 | match button { [INFO] [stdout] ... [INFO] [stdout] 374 | } [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:421:17 [INFO] [stdout] | [INFO] [stdout] 421 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 422 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 423 | | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] 424 | | let task_name = &self.tasks[actual_task_index].name; [INFO] [stdout] ... | [INFO] [stdout] 464 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 421 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 422 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 423 | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] ... [INFO] [stdout] 462 | } [INFO] [stdout] 463 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:468:14 [INFO] [stdout] | [INFO] [stdout] 468 | else if row == table_start_row { [INFO] [stdout] | ______________^ [INFO] [stdout] 469 | | if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] ... | [INFO] [stdout] 501 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ else if row == table_start_row [INFO] [stdout] 469 ~ && let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] ... [INFO] [stdout] 499 | } [INFO] [stdout] 500 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:469:13 [INFO] [stdout] | [INFO] [stdout] 469 | / if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 471 | | { [INFO] [stdout] 472 | | if col >= controls_start_col && col < controls_start_col + controls_width as u16 { [INFO] [stdout] ... | [INFO] [stdout] 500 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 471 ~ && col >= controls_start_col && col < controls_start_col + controls_width as u16 { [INFO] [stdout] 472 | let relative_col = col - controls_start_col; [INFO] [stdout] ... [INFO] [stdout] 497 | } [INFO] [stdout] 498 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(dialog_area) = self.delete_dialog_area { [INFO] [stdout] 524 | | if let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 525 | | new_hover_state = [INFO] [stdout] 526 | | Some(ButtonHoverState::new(ButtonType::Dialog(button), row, col)); [INFO] [stdout] 527 | | } [INFO] [stdout] 528 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(dialog_area) = self.delete_dialog_area [INFO] [stdout] 524 ~ && let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 525 | new_hover_state = [INFO] [stdout] 526 | Some(ButtonHoverState::new(ButtonType::Dialog(button), row, col)); [INFO] [stdout] 527 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 560 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 561 | | let action_layout = [INFO] [stdout] 562 | | ActionButtonLayout::new_with_mode(actions_rect, true); // Always rename mode [INFO] [stdout] ... | [INFO] [stdout] 581 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 560 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 561 | let action_layout = [INFO] [stdout] ... [INFO] [stdout] 579 | } [INFO] [stdout] 580 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:591:17 [INFO] [stdout] | [INFO] [stdout] 591 | / if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 592 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 593 | | { [INFO] [stdout] 594 | | if col >= controls_start_col && col < controls_start_col + controls_width as u16 [INFO] [stdout] ... | [INFO] [stdout] 618 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 592 ~ self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 593 ~ && col >= controls_start_col && col < controls_start_col + controls_width as u16 [INFO] [stdout] 594 | { [INFO] [stdout] ... [INFO] [stdout] 615 | } [INFO] [stdout] 616 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:655:21 [INFO] [stdout] | [INFO] [stdout] 655 | / if new_hover_state.is_none() { [INFO] [stdout] 656 | | if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] ... | [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 655 ~ if new_hover_state.is_none() [INFO] [stdout] 656 ~ && let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] ... [INFO] [stdout] 680 | } [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:656:25 [INFO] [stdout] | [INFO] [stdout] 656 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 658 | | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] 659 | | let task_name = &self.tasks[actual_task_index].name; [INFO] [stdout] ... | [INFO] [stdout] 681 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 656 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 657 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 658 | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] ... [INFO] [stdout] 679 | } [INFO] [stdout] 680 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | / if key.kind == KeyEventKind::Press [INFO] [stdout] 17 | | && event_tx.send(AppEvent::KeyPress(key)).is_err() [INFO] [stdout] 18 | | { [INFO] [stdout] 19 | | break; [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 15 ~ Ok(Event::Key(key)) [INFO] [stdout] 16 | if key.kind == KeyEventKind::Press [INFO] [stdout] 17 | && event_tx.send(AppEvent::KeyPress(key)).is_err() [INFO] [stdout] 18 ~ => { [INFO] [stdout] 19 | break; [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | / ... if event_tx [INFO] [stdout] 25 | | ... .send(AppEvent::MouseClick { [INFO] [stdout] 26 | | ... button, [INFO] [stdout] 27 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 32 | | ... break; [INFO] [stdout] 33 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ MouseEventKind::Down(button) [INFO] [stdout] 24 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 30 | .is_err() [INFO] [stdout] 31 ~ => { [INFO] [stdout] 32 | break; [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 36 | / ... if event_tx [INFO] [stdout] 37 | | ... .send(AppEvent::MouseScroll { [INFO] [stdout] 38 | | ... direction: ScrollDirection::Up, [INFO] [stdout] 39 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 44 | | ... break; [INFO] [stdout] 45 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ MouseEventKind::ScrollUp [INFO] [stdout] 36 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 42 | .is_err() [INFO] [stdout] 43 ~ => { [INFO] [stdout] 44 | break; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 48 | / ... if event_tx [INFO] [stdout] 49 | | ... .send(AppEvent::MouseScroll { [INFO] [stdout] 50 | | ... direction: ScrollDirection::Down, [INFO] [stdout] 51 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 56 | | ... break; [INFO] [stdout] 57 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ MouseEventKind::ScrollDown [INFO] [stdout] 48 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 54 | .is_err() [INFO] [stdout] 55 ~ => { [INFO] [stdout] 56 | break; [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/sequence_builder.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / if app.sequence_state.is_running { [INFO] [stdout] 216 | | if let Some(current_step) = app.sequence_state.current_step { [INFO] [stdout] 217 | | let tasks_for_step = app.sequence_state.get_tasks_for_step(current_step); [INFO] [stdout] 218 | | if !tasks_for_step.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if app.sequence_state.is_running [INFO] [stdout] 216 ~ && let Some(current_step) = app.sequence_state.current_step { [INFO] [stdout] 217 | let tasks_for_step = app.sequence_state.get_tasks_for_step(current_step); [INFO] [stdout] ... [INFO] [stdout] 234 | } [INFO] [stdout] 235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:387:36 [INFO] [stdout] | [INFO] [stdout] 387 | fn create_action_buttons_cell(app: &App, task_index: usize) -> Cell { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 387 | fn create_action_buttons_cell(app: &App, task_index: usize) -> Cell<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:497:33 [INFO] [stdout] | [INFO] [stdout] 497 | fn create_step_button_cell(app: &App, task_index: usize, step_index: usize) -> Cell { [INFO] [stdout] | ^^^^ the lifetime is elided here ^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 497 | fn create_step_button_cell(app: &App, task_index: usize, step_index: usize) -> Cell<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:706:44 [INFO] [stdout] | [INFO] [stdout] 706 | fn create_sequence_controls_paragraph(app: &App) -> Paragraph { [INFO] [stdout] | ^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 706 | fn create_sequence_controls_paragraph(app: &App) -> Paragraph<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking cargo-util-schemas v0.2.0 [INFO] [stderr] Checking coveralls-api v0.7.0 [INFO] [stderr] Checking cargo_metadata v0.20.0 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:344:13 [INFO] [stdout] | [INFO] [stdout] 344 | / if let Some(dialog_area) = self.delete_dialog_area { [INFO] [stdout] 345 | | if let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 346 | | match button { [INFO] [stdout] 347 | | DialogButton::Delete => { [INFO] [stdout] ... | [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 344 ~ if let Some(dialog_area) = self.delete_dialog_area [INFO] [stdout] 345 ~ && let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 346 | match button { [INFO] [stdout] ... [INFO] [stdout] 374 | } [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:421:17 [INFO] [stdout] | [INFO] [stdout] 421 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 422 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 423 | | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] 424 | | let task_name = &self.tasks[actual_task_index].name; [INFO] [stdout] ... | [INFO] [stdout] 464 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 421 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 422 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 423 | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] ... [INFO] [stdout] 462 | } [INFO] [stdout] 463 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:468:14 [INFO] [stdout] | [INFO] [stdout] 468 | else if row == table_start_row { [INFO] [stdout] | ______________^ [INFO] [stdout] 469 | | if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] ... | [INFO] [stdout] 501 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ else if row == table_start_row [INFO] [stdout] 469 ~ && let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] ... [INFO] [stdout] 499 | } [INFO] [stdout] 500 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:469:13 [INFO] [stdout] | [INFO] [stdout] 469 | / if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 470 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 471 | | { [INFO] [stdout] 472 | | if col >= controls_start_col && col < controls_start_col + controls_width as u16 { [INFO] [stdout] ... | [INFO] [stdout] 500 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 471 ~ && col >= controls_start_col && col < controls_start_col + controls_width as u16 { [INFO] [stdout] 472 | let relative_col = col - controls_start_col; [INFO] [stdout] ... [INFO] [stdout] 497 | } [INFO] [stdout] 498 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(dialog_area) = self.delete_dialog_area { [INFO] [stdout] 524 | | if let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 525 | | new_hover_state = [INFO] [stdout] 526 | | Some(ButtonHoverState::new(ButtonType::Dialog(button), row, col)); [INFO] [stdout] 527 | | } [INFO] [stdout] 528 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(dialog_area) = self.delete_dialog_area [INFO] [stdout] 524 ~ && let Some(button) = get_dialog_button_at_position(dialog_area, row, col) { [INFO] [stdout] 525 | new_hover_state = [INFO] [stdout] 526 | Some(ButtonHoverState::new(ButtonType::Dialog(button), row, col)); [INFO] [stdout] 527 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 560 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 561 | | let action_layout = [INFO] [stdout] 562 | | ActionButtonLayout::new_with_mode(actions_rect, true); // Always rename mode [INFO] [stdout] ... | [INFO] [stdout] 581 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 560 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 561 | let action_layout = [INFO] [stdout] ... [INFO] [stdout] 579 | } [INFO] [stdout] 580 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:591:17 [INFO] [stdout] | [INFO] [stdout] 591 | / if let Some((controls_start_col, controls_width)) = [INFO] [stdout] 592 | | self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 593 | | { [INFO] [stdout] 594 | | if col >= controls_start_col && col < controls_start_col + controls_width as u16 [INFO] [stdout] ... | [INFO] [stdout] 618 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 592 ~ self.calculate_sequence_controls_position(table_layout) [INFO] [stdout] 593 ~ && col >= controls_start_col && col < controls_start_col + controls_width as u16 [INFO] [stdout] 594 | { [INFO] [stdout] ... [INFO] [stdout] 615 | } [INFO] [stdout] 616 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:655:21 [INFO] [stdout] | [INFO] [stdout] 655 | / if new_hover_state.is_none() { [INFO] [stdout] 656 | | if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] ... | [INFO] [stdout] 682 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 655 ~ if new_hover_state.is_none() [INFO] [stdout] 656 ~ && let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] ... [INFO] [stdout] 680 | } [INFO] [stdout] 681 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/event_handlers.rs:656:25 [INFO] [stdout] | [INFO] [stdout] 656 | / if let Some(actions_rect) = table_layout.column_rects.last() { [INFO] [stdout] 657 | | if col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 658 | | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] 659 | | let task_name = &self.tasks[actual_task_index].name; [INFO] [stdout] ... | [INFO] [stdout] 681 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 656 ~ if let Some(actions_rect) = table_layout.column_rects.last() [INFO] [stdout] 657 ~ && col >= actions_rect.x && col < actions_rect.x + actions_rect.width { [INFO] [stdout] 658 | // Check if this task is being renamed to use the correct button layout [INFO] [stdout] ... [INFO] [stdout] 679 | } [INFO] [stdout] 680 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/models/app_event.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | AppEvent::Quit => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/models/app_event.rs:68:40 [INFO] [stdout] | [INFO] [stdout] 68 | AppEvent::TaskCompleted => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/models/app_event.rs:73:31 [INFO] [stdout] | [INFO] [stdout] 73 | AppEvent::Tick => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/models/app_event.rs:127:63 [INFO] [stdout] | [INFO] [stdout] 127 | AppEvent::Sequence(SequenceEvent::RunSequence) => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/models/app_state.rs:39:46 [INFO] [stdout] | [INFO] [stdout] 39 | AppState::SequenceBuilder => assert!(true), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/models/sequence.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | assert_eq!(seq.completed_steps[0], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 273 - assert_eq!(seq.completed_steps[0], true); [INFO] [stdout] 273 + assert!(seq.completed_steps[0]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/models/sequence.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | assert_eq!(seq.completed_steps[1], false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 274 - assert_eq!(seq.completed_steps[1], false); [INFO] [stdout] 274 + assert!(!seq.completed_steps[1]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/models/sequence.rs:281:9 [INFO] [stdout] | [INFO] [stdout] 281 | assert_eq!(seq.completed_steps[1], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 281 - assert_eq!(seq.completed_steps[1], true); [INFO] [stdout] 281 + assert!(seq.completed_steps[1]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/models/sequence.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | assert_eq!(seq.completed_steps[2], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 288 - assert_eq!(seq.completed_steps[2], true); [INFO] [stdout] 288 + assert!(seq.completed_steps[2]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | / if key.kind == KeyEventKind::Press [INFO] [stdout] 17 | | && event_tx.send(AppEvent::KeyPress(key)).is_err() [INFO] [stdout] 18 | | { [INFO] [stdout] 19 | | break; [INFO] [stdout] 20 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 15 ~ Ok(Event::Key(key)) [INFO] [stdout] 16 | if key.kind == KeyEventKind::Press [INFO] [stdout] 17 | && event_tx.send(AppEvent::KeyPress(key)).is_err() [INFO] [stdout] 18 ~ => { [INFO] [stdout] 19 | break; [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 24 | / ... if event_tx [INFO] [stdout] 25 | | ... .send(AppEvent::MouseClick { [INFO] [stdout] 26 | | ... button, [INFO] [stdout] 27 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 32 | | ... break; [INFO] [stdout] 33 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ MouseEventKind::Down(button) [INFO] [stdout] 24 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 30 | .is_err() [INFO] [stdout] 31 ~ => { [INFO] [stdout] 32 | break; [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:36:29 [INFO] [stdout] | [INFO] [stdout] 36 | / ... if event_tx [INFO] [stdout] 37 | | ... .send(AppEvent::MouseScroll { [INFO] [stdout] 38 | | ... direction: ScrollDirection::Up, [INFO] [stdout] 39 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 44 | | ... break; [INFO] [stdout] 45 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ MouseEventKind::ScrollUp [INFO] [stdout] 36 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 42 | .is_err() [INFO] [stdout] 43 ~ => { [INFO] [stdout] 44 | break; [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/terminal/input.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 48 | / ... if event_tx [INFO] [stdout] 49 | | ... .send(AppEvent::MouseScroll { [INFO] [stdout] 50 | | ... direction: ScrollDirection::Down, [INFO] [stdout] 51 | | ... row: mouse.row, [INFO] [stdout] ... | [INFO] [stdout] 56 | | ... break; [INFO] [stdout] 57 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ MouseEventKind::ScrollDown [INFO] [stdout] 48 | if event_tx [INFO] [stdout] ... [INFO] [stdout] 54 | .is_err() [INFO] [stdout] 55 ~ => { [INFO] [stdout] 56 | break; [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/sequence_builder.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / if app.sequence_state.is_running { [INFO] [stdout] 216 | | if let Some(current_step) = app.sequence_state.current_step { [INFO] [stdout] 217 | | let tasks_for_step = app.sequence_state.get_tasks_for_step(current_step); [INFO] [stdout] 218 | | if !tasks_for_step.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 215 ~ if app.sequence_state.is_running [INFO] [stdout] 216 ~ && let Some(current_step) = app.sequence_state.current_step { [INFO] [stdout] 217 | let tasks_for_step = app.sequence_state.get_tasks_for_step(current_step); [INFO] [stdout] ... [INFO] [stdout] 234 | } [INFO] [stdout] 235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:387:36 [INFO] [stdout] | [INFO] [stdout] 387 | fn create_action_buttons_cell(app: &App, task_index: usize) -> Cell { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 387 | fn create_action_buttons_cell(app: &App, task_index: usize) -> Cell<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:497:33 [INFO] [stdout] | [INFO] [stdout] 497 | fn create_step_button_cell(app: &App, task_index: usize, step_index: usize) -> Cell { [INFO] [stdout] | ^^^^ the lifetime is elided here ^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 497 | fn create_step_button_cell(app: &App, task_index: usize, step_index: usize) -> Cell<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ui/sequence_builder.rs:706:44 [INFO] [stdout] | [INFO] [stdout] 706 | fn create_sequence_controls_paragraph(app: &App) -> Paragraph { [INFO] [stdout] | ^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 706 | fn create_sequence_controls_paragraph(app: &App) -> Paragraph<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `Command { std: "docker" "inspect" "60fffed476f389ae03a8336a34e07d281e1f4c3bbcefaf5d38e049860706732a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60fffed476f389ae03a8336a34e07d281e1f4c3bbcefaf5d38e049860706732a", kill_on_drop: false }` [INFO] [stdout] 60fffed476f389ae03a8336a34e07d281e1f4c3bbcefaf5d38e049860706732a