[INFO] cloning repository https://github.com/skyz1/chess-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/skyz1/chess-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskyz1%2Fchess-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskyz1%2Fchess-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5486c25ae087ebeb90bfabbd863c199a32ce852 [INFO] linting skyz1/chess-engine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskyz1%2Fchess-engine" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/skyz1/chess-engine [INFO] finished tweaking git repo https://github.com/skyz1/chess-engine [INFO] tweaked toml for git repo https://github.com/skyz1/chess-engine written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/skyz1/chess-engine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/skyz1/chess-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] warning: /workspace/builds/worker-1-tc1/source/engine/fluffy/Cargo.toml: unused manifest key: build [INFO] [stderr] help: build is a valid .cargo/config.toml key [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded chess v3.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb4333f212d7c393e81c94c311986d2cf4b2ad627e1ec2b3a4c95cc845631bc2 [INFO] running `Command { std: "docker" "start" "-a" "fb4333f212d7c393e81c94c311986d2cf4b2ad627e1ec2b3a4c95cc845631bc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb4333f212d7c393e81c94c311986d2cf4b2ad627e1ec2b3a4c95cc845631bc2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb4333f212d7c393e81c94c311986d2cf4b2ad627e1ec2b3a4c95cc845631bc2", kill_on_drop: false }` [INFO] [stdout] fb4333f212d7c393e81c94c311986d2cf4b2ad627e1ec2b3a4c95cc845631bc2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 47de54367c33d1f5ab3acb873cc24e7f24e81819f7d27b4120c41c1c626870aa [INFO] running `Command { std: "docker" "start" "-a" "47de54367c33d1f5ab3acb873cc24e7f24e81819f7d27b4120c41c1c626870aa", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] warning: /opt/rustwide/workdir/engine/fluffy/Cargo.toml: unused manifest key: build [INFO] [stderr] help: build is a valid .cargo/config.toml key [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling gimli v0.27.2 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling rustc-demangle v0.1.23 [INFO] [stderr] Compiling backtrace v0.3.67 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Checking object v0.30.4 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking addr2line v0.19.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling chess v3.2.0 [INFO] [stderr] Checking fluffy v0.1.0 (/opt/rustwide/workdir/engine/fluffy) [INFO] [stdout] warning: the feature `const_mut_refs` has been stable since 1.83.0 and no longer requires an attribute to enable [INFO] [stdout] --> engine/fluffy/src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(const_mut_refs)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `const_mut_refs` has been stable since 1.83.0 and no longer requires an attribute to enable [INFO] [stdout] --> engine/fluffy/src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(const_mut_refs)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `local_key_cell_methods` has been stable since 1.73.0 and no longer requires an attribute to enable [INFO] [stdout] --> engine/fluffy/src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(local_key_cell_methods)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `local_key_cell_methods` has been stable since 1.73.0 and no longer requires an attribute to enable [INFO] [stdout] --> engine/fluffy/src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(local_key_cell_methods)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Mate` and `Nodes` are never constructed [INFO] [stdout] --> engine/fluffy/src/engine.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum SearchLimit { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 14 | MoveTime(u64), // search for exactly x msec [INFO] [stdout] 15 | Mate(u16), // Search for a mate in x moves [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | Depth(u16), // Search only x plys [INFO] [stdout] 17 | Nodes(u64), // Search only x nodes [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SearchLimit` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `search_moves` is never read [INFO] [stdout] --> engine/fluffy/src/engine.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct SearchOptions { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 34 | pub limit: SearchLimit, [INFO] [stdout] 35 | pub search_moves: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mobility_score` is never used [INFO] [stdout] --> engine/fluffy/src/evaluation.rs:136:4 [INFO] [stdout] | [INFO] [stdout] 136 | fn mobility_score(board: &Board) -> i16 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Mate` and `Nodes` are never constructed [INFO] [stdout] --> engine/fluffy/src/engine.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub enum SearchLimit { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 14 | MoveTime(u64), // search for exactly x msec [INFO] [stdout] 15 | Mate(u16), // Search for a mate in x moves [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | Depth(u16), // Search only x plys [INFO] [stdout] 17 | Nodes(u64), // Search only x nodes [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SearchLimit` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `search_moves` is never read [INFO] [stdout] --> engine/fluffy/src/engine.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct SearchOptions { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 34 | pub limit: SearchLimit, [INFO] [stdout] 35 | pub search_moves: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mobility_score` is never used [INFO] [stdout] --> engine/fluffy/src/evaluation.rs:136:4 [INFO] [stdout] | [INFO] [stdout] 136 | fn mobility_score(board: &Board) -> i16 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | (*state).search_id += 1; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/engine.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | (*state).status = SearchStatus::Running; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | (*state).best_move = None; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | (*state).status = SearchStatus::Finished; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | (*state).status = SearchStatus::Stopped; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/engine.rs:148:29 [INFO] [stdout] | [INFO] [stdout] 148 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | (*state).search_id += 1; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/engine.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 100 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | (*state).status = SearchStatus::Running; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | (*state).best_move = None; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:157:21 [INFO] [stdout] | [INFO] [stdout] 157 | (*state).status = SearchStatus::Finished; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | (*state).status = SearchStatus::Finished; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | (*state).status = SearchStatus::Stopped; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/engine.rs:148:29 [INFO] [stdout] | [INFO] [stdout] 148 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/engine.rs:157:21 [INFO] [stdout] | [INFO] [stdout] 157 | (*state).status = SearchStatus::Finished; [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1121:30 [INFO] [stdout] | [INFO] [stdout] 1121 | if line_board.eq(&board) { [INFO] [stdout] | ^^^^^^ help: change this to: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1122:49 [INFO] [stdout] | [INFO] [stdout] 1122 | return Some(ChessMove::from_str(&chess_move).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `chess_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1124:71 [INFO] [stdout] | [INFO] [stdout] 1124 | line_board = line_board.make_move_new(ChessMove::from_str(&chess_move).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `chess_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> engine/fluffy/src/search.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | || state.search_id != search_id [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 - if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] 92 - || state.search_id != search_id [INFO] [stdout] 91 + if !(state.search_id == search_id && state.status == SearchStatus::Running) [INFO] [stdout] | [INFO] [stdout] 91 - if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] 92 - || state.search_id != search_id [INFO] [stdout] 91 + if state.search_id != search_id || state.status != SearchStatus::Running [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | (*state).best_move = Some(opening_move); [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/search.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | (*state).best_move = sort_moves( [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if state.best_move == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `state.best_move.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1121:30 [INFO] [stdout] | [INFO] [stdout] 1121 | if line_board.eq(&board) { [INFO] [stdout] | ^^^^^^ help: change this to: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1122:49 [INFO] [stdout] | [INFO] [stdout] 1122 | return Some(ChessMove::from_str(&chess_move).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `chess_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/opening_database.rs:1124:71 [INFO] [stdout] | [INFO] [stdout] 1124 | line_board = line_board.make_move_new(ChessMove::from_str(&chess_move).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `chess_move` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:83:66 [INFO] [stdout] | [INFO] [stdout] 83 | && (state.status == SearchStatus::Running || state.best_move == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `state.best_move.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | (*state).best_move = Some(legal_move); [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/fluffy/src/search.rs:100:1 [INFO] [stdout] | [INFO] [stdout] 100 | / pub fn cached_negamax( [INFO] [stdout] 101 | | board: &Board, [INFO] [stdout] 102 | | depth: usize, [INFO] [stdout] 103 | | ply_from_root: i16, [INFO] [stdout] ... | [INFO] [stdout] 108 | | history_table: &mut [[i32; 64]; 64], [INFO] [stdout] 109 | | ) -> i16 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> engine/fluffy/src/search.rs:176:1 [INFO] [stdout] | [INFO] [stdout] 176 | / pub fn negamax( [INFO] [stdout] 177 | | board: &Board, [INFO] [stdout] 178 | | depth: usize, [INFO] [stdout] 179 | | ply_from_root: i16, [INFO] [stdout] ... | [INFO] [stdout] 185 | | history_table: &mut [[i32; 64]; 64], [INFO] [stdout] 186 | | ) -> (i16, Option) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> engine/fluffy/src/search.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 91 | if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | || state.search_id != search_id [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 91 - if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] 92 - || state.search_id != search_id [INFO] [stdout] 91 + if !(state.search_id == search_id && state.status == SearchStatus::Running) [INFO] [stdout] | [INFO] [stdout] 91 - if (state.search_id == search_id && state.status != SearchStatus::Running) [INFO] [stdout] 92 - || state.search_id != search_id [INFO] [stdout] 91 + if state.search_id != search_id || state.status != SearchStatus::Running [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | (*state).best_move = Some(opening_move); [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> engine/fluffy/src/search.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let search_id = state.search_id.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.search_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | (*state).best_move = sort_moves( [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if state.best_move == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `state.best_move.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if chess_move.get_promotion() != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `chess_move.get_promotion().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `evaluated_moves` is used as a loop counter [INFO] [stdout] --> engine/fluffy/src/search.rs:293:5 [INFO] [stdout] | [INFO] [stdout] 293 | for (legal_move, relevance) in moves.iter().skip(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (evaluated_moves, (legal_move, relevance)) in (1..).zip(moves.iter().skip(1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:83:66 [INFO] [stdout] | [INFO] [stdout] 83 | && (state.status == SearchStatus::Running || state.best_move == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `state.best_move.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> engine/fluffy/src/search.rs:85:21 [INFO] [stdout] | [INFO] [stdout] 85 | (*state).best_move = Some(legal_move); [INFO] [stdout] | ^^^^^^^^ help: try: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> engine/fluffy/src/search.rs:100:1 [INFO] [stdout] | [INFO] [stdout] 100 | / pub fn cached_negamax( [INFO] [stdout] 101 | | board: &Board, [INFO] [stdout] 102 | | depth: usize, [INFO] [stdout] 103 | | ply_from_root: i16, [INFO] [stdout] ... | [INFO] [stdout] 108 | | history_table: &mut [[i32; 64]; 64], [INFO] [stdout] 109 | | ) -> i16 { [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> engine/fluffy/src/search.rs:176:1 [INFO] [stdout] | [INFO] [stdout] 176 | / pub fn negamax( [INFO] [stdout] 177 | | board: &Board, [INFO] [stdout] 178 | | depth: usize, [INFO] [stdout] 179 | | ply_from_root: i16, [INFO] [stdout] ... | [INFO] [stdout] 185 | | history_table: &mut [[i32; 64]; 64], [INFO] [stdout] 186 | | ) -> (i16, Option) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXACT` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | EXACT(Option), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Exact` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOWERBOUND` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | LOWERBOUND, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lowerbound` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UPPERBOUND` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | UPPERBOUND, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Upperbound` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> engine/fluffy/src/search.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if chess_move.get_promotion() != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `chess_move.get_promotion().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `evaluated_moves` is used as a loop counter [INFO] [stdout] --> engine/fluffy/src/search.rs:293:5 [INFO] [stdout] | [INFO] [stdout] 293 | for (legal_move, relevance) in moves.iter().skip(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (evaluated_moves, (legal_move, relevance)) in (1..).zip(moves.iter().skip(1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> engine/fluffy/src/uci.rs:55:35 [INFO] [stdout] | [INFO] [stdout] 55 | .take_while(|arg| arg.to_string() != "moves") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> engine/fluffy/src/uci.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | .take_while(|arg| arg.to_string() != "moves") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/uci.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | .and_then(|value| TVal::from_str(&value).map_err(|err| err.to_string())) [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXACT` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | EXACT(Option), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Exact` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOWERBOUND` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | LOWERBOUND, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lowerbound` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UPPERBOUND` contains a capitalized acronym [INFO] [stdout] --> engine/fluffy/src/transposition_table.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | UPPERBOUND, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Upperbound` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> engine/fluffy/src/uci.rs:55:35 [INFO] [stdout] | [INFO] [stdout] 55 | .take_while(|arg| arg.to_string() != "moves") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> engine/fluffy/src/uci.rs:62:35 [INFO] [stdout] | [INFO] [stdout] 62 | .take_while(|arg| arg.to_string() != "moves") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `*arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/evaluation.rs:139:38 [INFO] [stdout] | [INFO] [stdout] 139 | let movegen = MoveGen::new_legal(&board); [INFO] [stdout] | ^^^^^^ help: change this to: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/uci.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | .and_then(|value| TVal::from_str(&value).map_err(|err| err.to_string())) [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> engine/fluffy/src/evaluation.rs:139:38 [INFO] [stdout] | [INFO] [stdout] 139 | let movegen = MoveGen::new_legal(&board); [INFO] [stdout] | ^^^^^^ help: change this to: `board` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `const_for` is declared but not used [INFO] [stdout] --> engine/fluffy/src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(const_for)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `const_for` is declared but not used [INFO] [stdout] --> engine/fluffy/src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(const_for)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.26s [INFO] running `Command { std: "docker" "inspect" "47de54367c33d1f5ab3acb873cc24e7f24e81819f7d27b4120c41c1c626870aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47de54367c33d1f5ab3acb873cc24e7f24e81819f7d27b4120c41c1c626870aa", kill_on_drop: false }` [INFO] [stdout] 47de54367c33d1f5ab3acb873cc24e7f24e81819f7d27b4120c41c1c626870aa