[INFO] cloning repository https://github.com/skandabhairava/Oxidised-Obbattu [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/skandabhairava/Oxidised-Obbattu" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskandabhairava%2FOxidised-Obbattu", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskandabhairava%2FOxidised-Obbattu'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e4341854576f1ce0feb9259cee2678eba799deb6 [INFO] linting skandabhairava/Oxidised-Obbattu against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fskandabhairava%2FOxidised-Obbattu" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/skandabhairava/Oxidised-Obbattu [INFO] finished tweaking git repo https://github.com/skandabhairava/Oxidised-Obbattu [INFO] tweaked toml for git repo https://github.com/skandabhairava/Oxidised-Obbattu written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/skandabhairava/Oxidised-Obbattu on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/skandabhairava/Oxidised-Obbattu already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ref-cast-impl v1.0.7 [INFO] [stderr] Downloaded ref-cast v1.0.7 [INFO] [stderr] Downloaded multer v2.0.2 [INFO] [stderr] Downloaded cron v0.10.1 [INFO] [stderr] Downloaded tokio-cron-scheduler v0.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b8fb1c25a1ab4943d264c0ae1b3160832fce2c3c08694a3ec2396755c43daaf0 [INFO] running `Command { std: "docker" "start" "-a" "b8fb1c25a1ab4943d264c0ae1b3160832fce2c3c08694a3ec2396755c43daaf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b8fb1c25a1ab4943d264c0ae1b3160832fce2c3c08694a3ec2396755c43daaf0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8fb1c25a1ab4943d264c0ae1b3160832fce2c3c08694a3ec2396755c43daaf0", kill_on_drop: false }` [INFO] [stdout] b8fb1c25a1ab4943d264c0ae1b3160832fce2c3c08694a3ec2396755c43daaf0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b0091e5a7474c5463040b1f5d03145cf13201c90cd3f18f6fe69cd1a964525d [INFO] running `Command { std: "docker" "start" "-a" "0b0091e5a7474c5463040b1f5d03145cf13201c90cd3f18f6fe69cd1a964525d", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling cpufeatures v0.2.2 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling itoa v1.0.2 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.27 [INFO] [stderr] Compiling futures-sink v0.3.21 [INFO] [stderr] Compiling ref-cast v1.0.7 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling once_cell v1.12.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Compiling http v0.2.8 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Compiling crypto-common v0.1.3 [INFO] [stderr] Compiling block-buffer v0.10.2 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling aead v0.4.3 [INFO] [stderr] Compiling polyval v0.5.3 [INFO] [stderr] Compiling ctr v0.8.0 [INFO] [stderr] Compiling aes v0.7.5 [INFO] [stderr] Compiling ghash v0.4.4 [INFO] [stderr] Compiling uncased v0.9.7 [INFO] [stderr] Compiling want v0.3.0 [INFO] [stderr] Compiling time v0.3.9 [INFO] [stderr] Compiling tracing v0.1.35 [INFO] [stderr] Compiling http-body v0.4.5 [INFO] [stderr] Compiling tokio v1.19.2 [INFO] [stderr] Compiling aes-gcm v0.9.4 [INFO] [stderr] Compiling hkdf v0.12.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling sha2 v0.10.2 [INFO] [stderr] Compiling tower-service v0.3.1 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling cookie v0.16.0 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Compiling futures v0.3.21 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling multer v2.0.2 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Compiling async-trait v0.1.56 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling rocket v0.5.0-rc.2 [INFO] [stderr] Checking spin v0.9.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling tokio-cron-scheduler v0.7.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking uuid v1.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Compiling hyper v0.14.19 [INFO] [stderr] Checking cron v0.10.1 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.9.1 [INFO] [stderr] Compiling devise_core v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling pear_codegen v0.2.3 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling ref-cast-impl v1.0.7 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Compiling devise_codegen v0.3.1 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Compiling devise v0.3.1 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking pear v0.2.3 [INFO] [stderr] Compiling rocket_http v0.5.0-rc.2 [INFO] [stderr] Checking serde v1.0.137 [INFO] [stderr] Compiling rocket_codegen v0.5.0-rc.2 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-stream v0.1.9 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Checking ubyte v0.10.2 [INFO] [stderr] Checking serde_json v1.0.81 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking figment v0.10.6 [INFO] [stderr] Checking obbattu-oxidised v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/board_generator.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if &buffer != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/board_generator.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if &buffer != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(0).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:100 [INFO] [stdout] | [INFO] [stdout] 181 | ...ord_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*starts_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `word_split.get(0)` [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `word_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ...with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(word_split.len() - 1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(0).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:100 [INFO] [stdout] | [INFO] [stdout] 181 | ...ord_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*starts_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `word_split.get(0)` [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `word_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ...with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(word_split.len() - 1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:118 [INFO] [stdout] | [INFO] [stdout] 182 | ...d_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*ends_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `word_split.get(word_split.len() - 1)` [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ... && {if let Some(ends_with) = &ends_with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} el... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_split.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:62 [INFO] [stdout] | [INFO] [stdout] 183 | ...le_char) = &middle_char {word_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(2).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:103 [INFO] [stdout] | [INFO] [stdout] 183 | ...ord_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*middle_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:118 [INFO] [stdout] | [INFO] [stdout] 182 | ...d_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*ends_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `word_split.get(word_split.len() - 1)` [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ... && {if let Some(ends_with) = &ends_with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} el... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_split.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:62 [INFO] [stdout] | [INFO] [stdout] 183 | ...le_char) = &middle_char {word_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(2).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:103 [INFO] [stdout] | [INFO] [stdout] 183 | ...ord_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*middle_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board_generator.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | if list_choose.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_choose.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board_generator.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | if list_choose.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_choose.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] 302 | | || (horz == None) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None && horz != None) { [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) || (horz == None) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] 302 | | || (horz == None) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None && horz != None) { [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) || (horz == None) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `top.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | || (right == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:298:16 [INFO] [stdout] | [INFO] [stdout] 298 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 300 | || (down == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `down.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | || (vert == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `vert.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | || (horz == None) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `horz.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `top.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | || (right == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:298:16 [INFO] [stdout] | [INFO] [stdout] 298 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 300 | || (down == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `down.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | || (vert == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `vert.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | || (horz == None) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `horz.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `signal` [INFO] [stdout] --> src/main.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 225 | #[cfg(feature = "signal")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `signal` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `signal` [INFO] [stdout] --> src/main.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 225 | #[cfg(feature = "signal")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `signal` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/board_generator.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if &buffer != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(0).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:100 [INFO] [stdout] | [INFO] [stdout] 181 | ...ord_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*starts_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `word_split.get(0)` [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `word_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ...with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(word_split.len() - 1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:118 [INFO] [stdout] | [INFO] [stdout] 182 | ...d_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*ends_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `word_split.get(word_split.len() - 1)` [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ... && {if let Some(ends_with) = &ends_with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} el... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_split.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:62 [INFO] [stdout] | [INFO] [stdout] 183 | ...le_char) = &middle_char {word_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(2).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:103 [INFO] [stdout] | [INFO] [stdout] 183 | ...ord_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*middle_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board_generator.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | if list_choose.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_choose.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] 302 | | || (horz == None) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None && horz != None) { [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) || (horz == None) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `top.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | || (right == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:298:16 [INFO] [stdout] | [INFO] [stdout] 298 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 300 | || (down == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `down.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | || (vert == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `vert.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | || (horz == None) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `horz.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | if solved == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `solved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / return Err( [INFO] [stdout] 90 | | RawJson( [INFO] [stdout] 91 | | to_string( [INFO] [stdout] 92 | | &json!({ [INFO] [stdout] ... | [INFO] [stdout] 100 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ Err( [INFO] [stdout] 90 + RawJson( [INFO] [stdout] 91 + to_string( [INFO] [stdout] 92 + &json!({ [INFO] [stdout] 93 + "answers": null, [INFO] [stdout] 94 + "answers_to_show": null, [INFO] [stdout] 95 + "questions": null, [INFO] [stdout] 96 + "OBBATTU_COUNT": null [INFO] [stdout] 97 + }) [INFO] [stdout] 98 + ).unwrap() [INFO] [stdout] 99 + ) [INFO] [stdout] 100 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | async fn index<'r>() -> CacheResponder { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/board_generator.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if &buffer != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(0).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:181:100 [INFO] [stdout] | [INFO] [stdout] 181 | ...ord_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*starts_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `word_split.get(0)` [INFO] [stdout] --> src/board_generator.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... {if let Some(starts_with) = &starts_with {word_split.get(0).unwrap().to_owned() == starts_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `word_split.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ...with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(word_split.len() - 1).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:182:118 [INFO] [stdout] | [INFO] [stdout] 182 | ...d_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*ends_with` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `word_split.get(word_split.len() - 1)` [INFO] [stdout] --> src/board_generator.rs:182:58 [INFO] [stdout] | [INFO] [stdout] 182 | ... && {if let Some(ends_with) = &ends_with {word_split.get(word_split.len() - 1).unwrap().to_owned() == ends_with.to_owned()} el... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `word_split.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:62 [INFO] [stdout] | [INFO] [stdout] 183 | ...le_char) = &middle_char {word_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*word_split.get(2).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/board_generator.rs:183:103 [INFO] [stdout] | [INFO] [stdout] 183 | ...ord_split.get(2).unwrap().to_owned() == middle_char.to_owned()} else {true}} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*middle_char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board_generator.rs:222:8 [INFO] [stdout] | [INFO] [stdout] 222 | if list_choose.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list_choose.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] 302 | | || (horz == None) { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None && horz != None) { [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 302 - || (horz == None) { [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) || (horz == None) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] 301 | | || (vert == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None && vert != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 301 - || (vert == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) || (vert == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] 300 | | || (down == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None && down != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 300 - || (down == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) || (down == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ___________^ [INFO] [stdout] 297 | | || (right == None) [INFO] [stdout] 298 | | || (left == None) [INFO] [stdout] 299 | | || (left == None) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while !(top != None && right != None && left != None) [INFO] [stdout] | [INFO] [stdout] 296 - while (top == None) [INFO] [stdout] 297 - || (right == None) [INFO] [stdout] 298 - || (left == None) [INFO] [stdout] 299 - || (left == None) [INFO] [stdout] 296 + while (top == None) || (right == None) || (left == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:296:11 [INFO] [stdout] | [INFO] [stdout] 296 | while (top == None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `top.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | || (right == None) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `right.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:298:16 [INFO] [stdout] | [INFO] [stdout] 298 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 299 | || (left == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `left.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 300 | || (down == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `down.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:301:16 [INFO] [stdout] | [INFO] [stdout] 301 | || (vert == None) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `vert.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/board_generator.rs:302:16 [INFO] [stdout] | [INFO] [stdout] 302 | || (horz == None) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `horz.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | if solved == true{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `solved` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / return Err( [INFO] [stdout] 90 | | RawJson( [INFO] [stdout] 91 | | to_string( [INFO] [stdout] 92 | | &json!({ [INFO] [stdout] ... | [INFO] [stdout] 100 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 ~ Err( [INFO] [stdout] 90 + RawJson( [INFO] [stdout] 91 + to_string( [INFO] [stdout] 92 + &json!({ [INFO] [stdout] 93 + "answers": null, [INFO] [stdout] 94 + "answers_to_show": null, [INFO] [stdout] 95 + "questions": null, [INFO] [stdout] 96 + "OBBATTU_COUNT": null [INFO] [stdout] 97 + }) [INFO] [stdout] 98 + ).unwrap() [INFO] [stdout] 99 + ) [INFO] [stdout] 100 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:104:16 [INFO] [stdout] | [INFO] [stdout] 104 | async fn index<'r>() -> CacheResponder { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "0b0091e5a7474c5463040b1f5d03145cf13201c90cd3f18f6fe69cd1a964525d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b0091e5a7474c5463040b1f5d03145cf13201c90cd3f18f6fe69cd1a964525d", kill_on_drop: false }` [INFO] [stdout] 0b0091e5a7474c5463040b1f5d03145cf13201c90cd3f18f6fe69cd1a964525d