[INFO] cloning repository https://github.com/sjrsjz/onion-py [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sjrsjz/onion-py" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjrsjz%2Fonion-py", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjrsjz%2Fonion-py'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0d41fb110bffa7d10142fafd2021f7f429bea4d1 [INFO] linting sjrsjz/onion-py against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjrsjz%2Fonion-py" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sjrsjz/onion-py [INFO] finished tweaking git repo https://github.com/sjrsjz/onion-py [INFO] tweaked toml for git repo https://github.com/sjrsjz/onion-py written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sjrsjz/onion-py on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sjrsjz/onion-py already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-build-config v0.25.1 [INFO] [stderr] Downloaded pyo3-macros v0.25.1 [INFO] [stderr] Downloaded rust-arc-gc v0.2.1 [INFO] [stderr] Downloaded pyo3-async-runtimes v0.25.0 [INFO] [stderr] Downloaded onion-frontend v0.2.1 [INFO] [stderr] Downloaded pyo3-ffi v0.25.1 [INFO] [stderr] Downloaded onion-vm v0.2.4 [INFO] [stderr] Downloaded pyo3-macros-backend v0.25.1 [INFO] [stderr] Downloaded pyo3 v0.25.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2dfe16fbd0e01230ab5fef5c9f2c95148218ef41f92257fe1051bc99fbbe8e72 [INFO] running `Command { std: "docker" "start" "-a" "2dfe16fbd0e01230ab5fef5c9f2c95148218ef41f92257fe1051bc99fbbe8e72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2dfe16fbd0e01230ab5fef5c9f2c95148218ef41f92257fe1051bc99fbbe8e72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dfe16fbd0e01230ab5fef5c9f2c95148218ef41f92257fe1051bc99fbbe8e72", kill_on_drop: false }` [INFO] [stdout] 2dfe16fbd0e01230ab5fef5c9f2c95148218ef41f92257fe1051bc99fbbe8e72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77eb738b45b125becc091e20566c3e2a40df0c4be18947c4067d0fcf16a088a5 [INFO] running `Command { std: "docker" "start" "-a" "77eb738b45b125becc091e20566c3e2a40df0c4be18947c4067d0fcf16a088a5", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling pyo3-build-config v0.25.1 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking rust-arc-gc v0.2.1 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Compiling pyo3-macros-backend v0.25.1 [INFO] [stderr] Compiling pyo3-ffi v0.25.1 [INFO] [stderr] Compiling pyo3 v0.25.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Compiling pyo3-macros v0.25.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking onion-vm v0.2.4 [INFO] [stderr] Checking pyo3-async-runtimes v0.25.0 [INFO] [stderr] Checking onion-frontend v0.2.1 [INFO] [stderr] Checking onion-py v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:363:13 [INFO] [stdout] | [INFO] [stdout] 363 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/script/stdlib/mod.rs:363:13 [INFO] [stdout] | [INFO] [stdout] 363 | function: function, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pycallable.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/pycallable.rs:48:65 [INFO] [stdout] | [INFO] [stdout] 47 | if !result.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 48 | return StepResult::Error(pyerr_to_runtime_error(result.unwrap_err(), py)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/pycallable.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|obj| PyOnionObject::from_rust(obj)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyOnionObject::from_rust` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pycallable.rs:180:37 [INFO] [stdout] | [INFO] [stdout] 180 | ... return StepResult::Error(pyerr_to_runtime_error(e, py)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return StepResult::Error(pyerr_to_runtime_error(e, py)); [INFO] [stdout] 180 + StepResult::Error(pyerr_to_runtime_error(e, py)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pyo3::Py` [INFO] [stdout] --> src/pycallable.rs:176:65 [INFO] [stdout] | [INFO] [stdout] 176 | ... match py_object_to_onion_object(py, py_obj.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `py_obj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/script/stdlib/math.rs:251:20 [INFO] [stdout] | [INFO] [stdout] 251 | if val < -1.0 || val > 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(-1.0..=1.0).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/script/stdlib/math.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | if val < -1.0 || val > 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(-1.0..=1.0).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/pycallable.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if !result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/pycallable.rs:48:65 [INFO] [stdout] | [INFO] [stdout] 47 | if !result.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 48 | return StepResult::Error(pyerr_to_runtime_error(result.unwrap_err(), py)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/pycallable.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | .map(|obj| PyOnionObject::from_rust(obj)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyOnionObject::from_rust` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pycallable.rs:180:37 [INFO] [stdout] | [INFO] [stdout] 180 | ... return StepResult::Error(pyerr_to_runtime_error(e, py)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return StepResult::Error(pyerr_to_runtime_error(e, py)); [INFO] [stdout] 180 + StepResult::Error(pyerr_to_runtime_error(e, py)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pyo3::Py` [INFO] [stdout] --> src/pycallable.rs:176:65 [INFO] [stdout] | [INFO] [stdout] 176 | ... match py_object_to_onion_object(py, py_obj.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `.into()`: `py_obj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/script/stdlib/math.rs:251:20 [INFO] [stdout] | [INFO] [stdout] 251 | if val < -1.0 || val > 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(-1.0..=1.0).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/script/stdlib/math.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | if val < -1.0 || val > 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(-1.0..=1.0).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/script/mod.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / match VMInstructionPackage::validate(vm_instructions_package) { [INFO] [stdout] 73 | | Err(e) => return Err(format!("Invalid VM instruction package: {}", e)), [INFO] [stdout] 74 | | Ok(_) => {} [INFO] [stdout] 75 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(e) = VMInstructionPackage::validate(vm_instructions_package) { return Err(format!("Invalid VM instruction package: {}", e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return RuntimeError::CustomValue( [INFO] [stdout] 27 | | OnionObject::Custom(Arc::new(OnionPyObject { [INFO] [stdout] 28 | | inner: match e.into_py_any(py) { [INFO] [stdout] 29 | | Ok(obj) => obj, [INFO] [stdout] ... | [INFO] [stdout] 38 | | .into(), [INFO] [stdout] 39 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ RuntimeError::CustomValue( [INFO] [stdout] 27 + OnionObject::Custom(Arc::new(OnionPyObject { [INFO] [stdout] 28 + inner: match e.into_py_any(py) { [INFO] [stdout] 29 + Ok(obj) => obj, [INFO] [stdout] 30 + Err(e) => { [INFO] [stdout] 31 + return RuntimeError::DetailedError( [INFO] [stdout] 32 + format!("Failed to call Python coroutine: {}", e).into(), [INFO] [stdout] 33 + ); [INFO] [stdout] 34 + } [INFO] [stdout] 35 + }, [INFO] [stdout] 36 + })) [INFO] [stdout] 37 + .stabilize() [INFO] [stdout] 38 + .into(), [INFO] [stdout] 39 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 181 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 182 | | format!("Object is not a Range: {:?}", obj).into(), [INFO] [stdout] 183 | | ) [INFO] [stdout] 184 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 181 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 182 + format!("Object is not a Range: {:?}", obj).into(), [INFO] [stdout] 183 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:200:30 [INFO] [stdout] | [INFO] [stdout] 200 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 201 | | format!("Object is not a Tuple: {:?}", obj).into(), [INFO] [stdout] 202 | | ) [INFO] [stdout] 203 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 200 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 201 + format!("Object is not a Tuple: {:?}", obj).into(), [INFO] [stdout] 202 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:219:30 [INFO] [stdout] | [INFO] [stdout] 219 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 220 | | format!("Object is not a Pair: {:?}", obj).into(), [INFO] [stdout] 221 | | ) [INFO] [stdout] 222 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 219 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 220 + format!("Object is not a Pair: {:?}", obj).into(), [INFO] [stdout] 221 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:238:30 [INFO] [stdout] | [INFO] [stdout] 238 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 239 | | format!("Object is not a Named: {:?}", obj).into(), [INFO] [stdout] 240 | | ) [INFO] [stdout] 241 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 238 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 239 + format!("Object is not a Named: {:?}", obj).into(), [INFO] [stdout] 240 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/script/mod.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / match VMInstructionPackage::validate(vm_instructions_package) { [INFO] [stdout] 73 | | Err(e) => return Err(format!("Invalid VM instruction package: {}", e)), [INFO] [stdout] 74 | | Ok(_) => {} [INFO] [stdout] 75 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(e) = VMInstructionPackage::validate(vm_instructions_package) { return Err(format!("Invalid VM instruction package: {}", e)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / return RuntimeError::CustomValue( [INFO] [stdout] 27 | | OnionObject::Custom(Arc::new(OnionPyObject { [INFO] [stdout] 28 | | inner: match e.into_py_any(py) { [INFO] [stdout] 29 | | Ok(obj) => obj, [INFO] [stdout] ... | [INFO] [stdout] 38 | | .into(), [INFO] [stdout] 39 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 ~ RuntimeError::CustomValue( [INFO] [stdout] 27 + OnionObject::Custom(Arc::new(OnionPyObject { [INFO] [stdout] 28 + inner: match e.into_py_any(py) { [INFO] [stdout] 29 + Ok(obj) => obj, [INFO] [stdout] 30 + Err(e) => { [INFO] [stdout] 31 + return RuntimeError::DetailedError( [INFO] [stdout] 32 + format!("Failed to call Python coroutine: {}", e).into(), [INFO] [stdout] 33 + ); [INFO] [stdout] 34 + } [INFO] [stdout] 35 + }, [INFO] [stdout] 36 + })) [INFO] [stdout] 37 + .stabilize() [INFO] [stdout] 38 + .into(), [INFO] [stdout] 39 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:181:30 [INFO] [stdout] | [INFO] [stdout] 181 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 182 | | format!("Object is not a Range: {:?}", obj).into(), [INFO] [stdout] 183 | | ) [INFO] [stdout] 184 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 181 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 182 + format!("Object is not a Range: {:?}", obj).into(), [INFO] [stdout] 183 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:200:30 [INFO] [stdout] | [INFO] [stdout] 200 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 201 | | format!("Object is not a Tuple: {:?}", obj).into(), [INFO] [stdout] 202 | | ) [INFO] [stdout] 203 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 200 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 201 + format!("Object is not a Tuple: {:?}", obj).into(), [INFO] [stdout] 202 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:219:30 [INFO] [stdout] | [INFO] [stdout] 219 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 220 | | format!("Object is not a Pair: {:?}", obj).into(), [INFO] [stdout] 221 | | ) [INFO] [stdout] 222 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 219 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 220 + format!("Object is not a Pair: {:?}", obj).into(), [INFO] [stdout] 221 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `onion_vm::lambda::runnable::RuntimeError` [INFO] [stdout] --> src/lib.rs:238:30 [INFO] [stdout] | [INFO] [stdout] 238 | _ => Err(RuntimeError::InvalidType( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 239 | | format!("Object is not a Named: {:?}", obj).into(), [INFO] [stdout] 240 | | ) [INFO] [stdout] 241 | | .into()), [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 238 ~ _ => Err(RuntimeError::InvalidType( [INFO] [stdout] 239 + format!("Object is not a Named: {:?}", obj).into(), [INFO] [stdout] 240 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pyo3::Py` [INFO] [stdout] --> src/lib.rs:665:64 [INFO] [stdout] | [INFO] [stdout] 665 | Ok(OnionObject::Custom(Arc::new(OnionPyObject { inner: obj.into() })).stabilize()) [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `obj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:689:45 [INFO] [stdout] | [INFO] [stdout] 689 | let work_dir_pathbuf = work_dir.map(|path| std::path::PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `std::path::PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pyo3::Py` [INFO] [stdout] --> src/lib.rs:665:64 [INFO] [stdout] | [INFO] [stdout] 665 | Ok(OnionObject::Custom(Arc::new(OnionPyObject { inner: obj.into() })).stabilize()) [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `obj` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lib.rs:689:45 [INFO] [stdout] | [INFO] [stdout] 689 | let work_dir_pathbuf = work_dir.map(|path| std::path::PathBuf::from(path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `std::path::PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.99s [INFO] running `Command { std: "docker" "inspect" "77eb738b45b125becc091e20566c3e2a40df0c4be18947c4067d0fcf16a088a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77eb738b45b125becc091e20566c3e2a40df0c4be18947c4067d0fcf16a088a5", kill_on_drop: false }` [INFO] [stdout] 77eb738b45b125becc091e20566c3e2a40df0c4be18947c4067d0fcf16a088a5