[INFO] cloning repository https://github.com/sjkim1127/Nexuscore_MCP [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sjkim1127/Nexuscore_MCP" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjkim1127%2FNexuscore_MCP", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjkim1127%2FNexuscore_MCP'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c55de9d1b66766dabdb00d3e3f8888acd8e4732f [INFO] linting sjkim1127/Nexuscore_MCP against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsjkim1127%2FNexuscore_MCP" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/sjkim1127/Nexuscore_MCP [INFO] finished tweaking git repo https://github.com/sjkim1127/Nexuscore_MCP [INFO] tweaked toml for git repo https://github.com/sjkim1127/Nexuscore_MCP written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sjkim1127/Nexuscore_MCP on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sjkim1127/Nexuscore_MCP already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xz v0.1.0 [INFO] [stderr] Downloaded frida-build v0.17.1 [INFO] [stderr] Downloaded tonic-prost v0.14.5 [INFO] [stderr] Downloaded scroll_derive v0.13.1 [INFO] [stderr] Downloaded hyper-tungstenite v0.19.0 [INFO] [stderr] Downloaded rmcp-macros v0.11.0 [INFO] [stderr] Downloaded yara v0.31.0 [INFO] [stderr] Downloaded scroll v0.13.0 [INFO] [stderr] Downloaded frida v0.17.1 [INFO] [stderr] Downloaded tokio-tungstenite v0.28.0 [INFO] [stderr] Downloaded tokio-graceful v0.2.2 [INFO] [stderr] Downloaded mockito v1.7.1 [INFO] [stderr] Downloaded tungstenite v0.28.0 [INFO] [stderr] Downloaded tracing-opentelemetry v0.32.1 [INFO] [stderr] Downloaded capstone v0.14.0 [INFO] [stderr] Downloaded tonic v0.14.5 [INFO] [stderr] Downloaded async-compression v0.4.41 [INFO] [stderr] Downloaded hudsucker v0.24.0 [INFO] [stderr] Downloaded pastey v0.2.0 [INFO] [stderr] Downloaded rmcp v0.11.0 [INFO] [stderr] Downloaded moka v0.12.14 [INFO] [stderr] Downloaded bindgen v0.68.1 [INFO] [stderr] Downloaded goblin v0.10.4 [INFO] [stderr] Downloaded quinn-proto v0.11.14 [INFO] [stderr] Downloaded aws-lc-rs v1.16.1 [INFO] [stderr] Downloaded compression-codecs v0.4.37 [INFO] [stderr] Downloaded opentelemetry-http v0.31.0 [INFO] [stderr] Downloaded rc4 v0.1.0 [INFO] [stderr] Downloaded tracing-appender v0.2.4 [INFO] [stderr] Downloaded unicorn-engine v2.1.5 [INFO] [stderr] Downloaded sled v0.34.7 [INFO] [stderr] Downloaded frida-sys v0.17.1 [INFO] [stderr] Downloaded iced-x86 v1.21.0 [INFO] [stderr] Downloaded yara-sys v0.31.0 [INFO] [stderr] Downloaded unicorn-engine-sys v2.1.5 [INFO] [stderr] Downloaded capstone-sys v0.18.0 [INFO] [stderr] Downloaded aws-lc-sys v0.38.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed87e8edaaaf31ebca5740af5671b5f1673a1d004f78cbeca92a1bee469709db [INFO] running `Command { std: "docker" "start" "-a" "ed87e8edaaaf31ebca5740af5671b5f1673a1d004f78cbeca92a1bee469709db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed87e8edaaaf31ebca5740af5671b5f1673a1d004f78cbeca92a1bee469709db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed87e8edaaaf31ebca5740af5671b5f1673a1d004f78cbeca92a1bee469709db", kill_on_drop: false }` [INFO] [stdout] ed87e8edaaaf31ebca5740af5671b5f1673a1d004f78cbeca92a1bee469709db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc7567897969c2e07fc21256daa5b1c5b511b7640bf492bec56ee20945c5b701 [INFO] running `Command { std: "docker" "start" "-a" "bc7567897969c2e07fc21256daa5b1c5b511b7640bf492bec56ee20945c5b701", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling zmij v1.0.13 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling aws-lc-rs v1.16.1 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Compiling bindgen v0.68.1 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling oid-registry v0.8.1 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling itoa v1.0.15 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Compiling pastey v0.2.0 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking rc4 v0.1.0 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking iced-x86 v1.21.0 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Checking inventory v0.3.22 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking similar v2.7.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Checking which v8.0.0 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling aws-lc-sys v0.38.0 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling asn1-rs-derive v0.6.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling schemars_derive v1.2.0 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking compression-codecs v0.4.37 [INFO] [stderr] Compiling scroll_derive v0.13.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling rmcp-macros v0.11.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking asn1-rs v0.7.1 [INFO] [stderr] Checking scroll v0.13.0 [INFO] [stderr] Checking goblin v0.10.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking der-parser v10.0.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking moka v0.12.14 [INFO] [stderr] Checking x509-parser v0.18.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-graceful v0.2.2 [INFO] [stderr] Checking async-compression v0.4.41 [INFO] [stderr] Compiling yara-sys v0.31.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking rcgen v0.14.7 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking schemars v1.2.0 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking rmcp v0.11.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking yara v0.31.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking mockito v1.7.1 [INFO] [stderr] Checking reqwest v0.12.26 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tungstenite v0.28.0 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking tokio-tungstenite v0.28.0 [INFO] [stderr] Checking hyper-tungstenite v0.19.0 [INFO] [stderr] Checking hudsucker v0.24.0 [INFO] [stderr] Checking nexuscore_mcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NexusCoreServer` [INFO] [stdout] --> src/server.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | let mut tools: HashMap> = HashMap::new(); [INFO] [stdout] 16 | | for reg in inventory::iter:: { [INFO] [stdout] 17 | | let tool = (reg.create)(); [INFO] [stdout] ... | [INFO] [stdout] 20 | | Self { tools } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for NexusCoreServer { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/server.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | let args_map = param.arguments.unwrap_or_else(serde_json::Map::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `s` [INFO] [stdout] --> src/tools/malware/analysis/config_extractor.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | for i in 0..=255 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 155 - for i in 0..=255 { [INFO] [stdout] 155 + for (i, ) in s.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tools/malware/analysis/doc_analyzer.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 93 | } else if suspicious.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!suspicious.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:134:35 [INFO] [stdout] | [INFO] [stdout] 134 | Value::String(line["RESULT_HEX:".len()..].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | if line.starts_with("RESULT_HEX:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some() = line.strip_prefix("RESULT_HEX:") { [INFO] [stdout] 132 | final_res.insert( [INFO] [stdout] 133 | "decrypted_hex".to_string(), [INFO] [stdout] 134 ~ Value::String(.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:139:35 [INFO] [stdout] | [INFO] [stdout] 139 | Value::String(line["RESULT_STR:".len()..].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | } else if line.starts_with("RESULT_STR:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 136 ~ } else if let Some() = line.strip_prefix("RESULT_STR:") { [INFO] [stdout] 137 | final_res.insert( [INFO] [stdout] 138 | "decrypted_text".to_string(), [INFO] [stdout] 139 ~ Value::String(.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/tools/malware/analysis/yara_gen.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if byte >= 0x20 && byte < 0x7F { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tools/malware/analysis/yara_gen.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | candidates.sort_by(|a, b| b.len().cmp(&a.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 - candidates.sort_by(|a, b| b.len().cmp(&a.len())); [INFO] [stdout] 145 + candidates.sort_by_key(|b| std::cmp::Reverse(b.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NexusCoreServer` [INFO] [stdout] --> src/server.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | let mut tools: HashMap> = HashMap::new(); [INFO] [stdout] 16 | | for reg in inventory::iter:: { [INFO] [stdout] 17 | | let tool = (reg.create)(); [INFO] [stdout] ... | [INFO] [stdout] 20 | | Self { tools } [INFO] [stdout] 21 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for NexusCoreServer { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/server.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | let args_map = param.arguments.unwrap_or_else(serde_json::Map::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JobManager` [INFO] [stdout] --> src/utils/jobs.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | jobs: Mutex::new(HashMap::new()), [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for JobManager { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `s` [INFO] [stdout] --> src/tools/malware/analysis/config_extractor.rs:155:18 [INFO] [stdout] | [INFO] [stdout] 155 | for i in 0..=255 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 155 - for i in 0..=255 { [INFO] [stdout] 155 + for (i, ) in s.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tools/malware/analysis/doc_analyzer.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 93 | } else if suspicious.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!suspicious.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:134:35 [INFO] [stdout] | [INFO] [stdout] 134 | Value::String(line["RESULT_HEX:".len()..].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | if line.starts_with("RESULT_HEX:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some() = line.strip_prefix("RESULT_HEX:") { [INFO] [stdout] 132 | final_res.insert( [INFO] [stdout] 133 | "decrypted_hex".to_string(), [INFO] [stdout] 134 ~ Value::String(.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:139:35 [INFO] [stdout] | [INFO] [stdout] 139 | Value::String(line["RESULT_STR:".len()..].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/tools/malware/analysis/python_sandbox.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | } else if line.starts_with("RESULT_STR:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 136 ~ } else if let Some() = line.strip_prefix("RESULT_STR:") { [INFO] [stdout] 137 | final_res.insert( [INFO] [stdout] 138 | "decrypted_text".to_string(), [INFO] [stdout] 139 ~ Value::String(.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PerfMetrics` [INFO] [stdout] --> src/utils/logging.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / pub fn new() -> Self { [INFO] [stdout] 102 | | Self { [INFO] [stdout] 103 | | tool_calls: std::sync::atomic::AtomicU64::new(0), [INFO] [stdout] 104 | | cache_hits: std::sync::atomic::AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 100 + impl Default for PerfMetrics { [INFO] [stdout] 101 + fn default() -> Self { [INFO] [stdout] 102 + Self::new() [INFO] [stdout] 103 + } [INFO] [stdout] 104 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/logging.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | METRICS.get_or_init(|| PerfMetrics::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PerfMetrics::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/tools/malware/analysis/yara_gen.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if byte >= 0x20 && byte < 0x7F { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x20..0x7F).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tools/malware/analysis/yara_gen.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | candidates.sort_by(|a, b| b.len().cmp(&a.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 - candidates.sort_by(|a, b| b.len().cmp(&a.len())); [INFO] [stdout] 145 + candidates.sort_by_key(|b| std::cmp::Reverse(b.len())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StreamManager` [INFO] [stdout] --> src/utils/streaming.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | let dump_dir = PathBuf::from("logs/dumps"); [INFO] [stdout] 14 | | if !dump_dir.exists() { [INFO] [stdout] 15 | | fs::create_dir_all(&dump_dir).unwrap_or(()); [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | Self { dump_dir } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for StreamManager { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `JobManager` [INFO] [stdout] --> src/utils/jobs.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | jobs: Mutex::new(HashMap::new()), [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for JobManager { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PerfMetrics` [INFO] [stdout] --> src/utils/logging.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | / pub fn new() -> Self { [INFO] [stdout] 102 | | Self { [INFO] [stdout] 103 | | tool_calls: std::sync::atomic::AtomicU64::new(0), [INFO] [stdout] 104 | | cache_hits: std::sync::atomic::AtomicU64::new(0), [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 100 + impl Default for PerfMetrics { [INFO] [stdout] 101 + fn default() -> Self { [INFO] [stdout] 102 + Self::new() [INFO] [stdout] 103 + } [INFO] [stdout] 104 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/logging.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | METRICS.get_or_init(|| PerfMetrics::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PerfMetrics::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `StreamManager` [INFO] [stdout] --> src/utils/streaming.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | let dump_dir = PathBuf::from("logs/dumps"); [INFO] [stdout] 14 | | if !dump_dir.exists() { [INFO] [stdout] 15 | | fs::create_dir_all(&dump_dir).unwrap_or(()); [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | Self { dump_dir } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for StreamManager { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 14s [INFO] running `Command { std: "docker" "inspect" "bc7567897969c2e07fc21256daa5b1c5b511b7640bf492bec56ee20945c5b701", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc7567897969c2e07fc21256daa5b1c5b511b7640bf492bec56ee20945c5b701", kill_on_drop: false }` [INFO] [stdout] bc7567897969c2e07fc21256daa5b1c5b511b7640bf492bec56ee20945c5b701