[INFO] cloning repository https://github.com/sishevchenko/rust_rest_api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sishevchenko/rust_rest_api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsishevchenko%2Frust_rest_api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsishevchenko%2Frust_rest_api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88df6a4ccc5cda0ab402c572336838806860c8a6 [INFO] linting sishevchenko/rust_rest_api against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsishevchenko%2Frust_rest_api" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sishevchenko/rust_rest_api [INFO] finished tweaking git repo https://github.com/sishevchenko/rust_rest_api [INFO] tweaked toml for git repo https://github.com/sishevchenko/rust_rest_api written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sishevchenko/rust_rest_api on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sishevchenko/rust_rest_api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sqlx-macros v0.8.5 [INFO] [stderr] Downloaded errno v0.3.11 [INFO] [stderr] Downloaded pgvector v0.4.0 [INFO] [stderr] Downloaded sea-orm-migration v1.1.11 [INFO] [stderr] Downloaded sea-query-binder v0.7.0 [INFO] [stderr] Downloaded inherent v1.0.12 [INFO] [stderr] Downloaded sea-orm-cli v1.1.12 [INFO] [stderr] Downloaded icu_properties v2.0.0 [INFO] [stderr] Downloaded async-executor v1.13.2 [INFO] [stderr] Downloaded async-io v2.4.1 [INFO] [stderr] Downloaded hyper-util v0.1.11 [INFO] [stderr] Downloaded sqlx-mysql v0.8.5 [INFO] [stderr] Downloaded bigdecimal v0.4.8 [INFO] [stderr] Downloaded rust_decimal v1.37.1 [INFO] [stderr] Downloaded sqlx-postgres v0.8.5 [INFO] [stderr] Downloaded icu_properties_data v2.0.0 [INFO] [stderr] Downloaded rkyv v0.7.45 [INFO] [stderr] Downloaded sqlx v0.8.5 [INFO] [stderr] Downloaded async-std v1.13.1 [INFO] [stderr] Downloaded sea-query v0.32.5 [INFO] [stderr] Downloaded sqlx-core v0.8.5 [INFO] [stderr] Downloaded sqlx-sqlite v0.8.5 [INFO] [stderr] Downloaded openssl v0.10.72 [INFO] [stderr] Downloaded polling v3.8.0 [INFO] [stderr] Downloaded sea-orm-macros v1.1.11 [INFO] [stderr] Downloaded base64ct v1.7.3 [INFO] [stderr] Downloaded sqlx-macros-core v0.8.5 [INFO] [stderr] Downloaded tempfile v3.19.1 [INFO] [stderr] Downloaded whoami v1.6.0 [INFO] [stderr] Downloaded rkyv_derive v0.7.45 [INFO] [stderr] Downloaded value-bag v1.11.1 [INFO] [stderr] Downloaded sea-query-derive v0.4.3 [INFO] [stderr] Downloaded sea-schema v0.16.2 [INFO] [stderr] Downloaded sea-orm v1.1.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10180f4f0b4263fe7bfaad2cfb09138ff034d2b8fa83b0251c67cb15c7cd9354 [INFO] running `Command { std: "docker" "start" "-a" "10180f4f0b4263fe7bfaad2cfb09138ff034d2b8fa83b0251c67cb15c7cd9354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10180f4f0b4263fe7bfaad2cfb09138ff034d2b8fa83b0251c67cb15c7cd9354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10180f4f0b4263fe7bfaad2cfb09138ff034d2b8fa83b0251c67cb15c7cd9354", kill_on_drop: false }` [INFO] [stdout] 10180f4f0b4263fe7bfaad2cfb09138ff034d2b8fa83b0251c67cb15c7cd9354 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec786add98b31732c5d6036382850b9cafb53f7d127c5ea0b0fb322db7a06d08 [INFO] running `Command { std: "docker" "start" "-a" "ec786add98b31732c5d6036382850b9cafb53f7d127c5ea0b0fb322db7a06d08", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking value-bag v1.11.1 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling cc v1.2.21 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling icu_properties_data v2.0.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Checking icu_properties v2.0.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling bigdecimal v0.4.8 [INFO] [stderr] Compiling rust_decimal v1.37.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling openssl-sys v0.9.108 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking base64ct v1.7.3 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking crc v3.3.0 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tokio v1.45.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking uuid v1.16.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking tinyvec v1.9.0 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking whoami v1.6.0 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling sea-query-derive v0.4.3 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Compiling inherent v1.0.12 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking sea-query v0.32.5 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Compiling sea-bae v0.2.1 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking sqlx-core v0.8.5 [INFO] [stderr] Compiling ouroboros_macro v0.18.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Compiling rustversion v1.0.20 [INFO] [stderr] Checking ouroboros v0.18.5 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling sea-orm-macros v1.1.11 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking sqlx-postgres v0.8.5 [INFO] [stderr] Checking sqlx-mysql v0.8.5 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling sea-schema-derive v0.3.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking polling v3.8.0 [INFO] [stderr] Checking sea-orm-cli v1.1.12 [INFO] [stderr] Checking sea-schema v0.16.2 [INFO] [stderr] Checking async-io v2.4.1 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking async-std v1.13.1 [INFO] [stderr] Checking axum v0.8.4 [INFO] [stderr] Checking sqlx-sqlite v0.8.5 [INFO] [stderr] Checking sqlx v0.8.5 [INFO] [stderr] Checking sea-query-binder v0.7.0 [INFO] [stderr] Checking sea-orm v1.1.11 [INFO] [stderr] Checking sea-orm-migration v1.1.11 [INFO] [stderr] Checking migration v0.1.0 (/opt/rustwide/workdir/migration) [INFO] [stderr] Checking api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated items `new`, `get_host`, and `get_port` are never used [INFO] [stdout] --> src/config.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Config { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 8 | pub fn new(host: String, port: u16) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn get_host(&self) -> &String { &self.host } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | pub fn get_port(&self) -> &u16 { &self.port } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/db.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl ApiDB { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 39 | pub fn new(host: String, port: Option) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/urls.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | / let routers = Router::new() [INFO] [stdout] 8 | | .merge(get_post_routers()); [INFO] [stdout] | |___________________________________- unnecessary `let` binding [INFO] [stdout] 9 | routers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ Router::new() [INFO] [stdout] 9 + .merge(get_post_routers()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/posts/routers.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 16 | / let router = Router::new() [INFO] [stdout] 17 | | .route("/posts", get(posts_list)) [INFO] [stdout] 18 | | .route("/post", post(create_post)); [INFO] [stdout] | |___________________________________________- unnecessary `let` binding [INFO] [stdout] 19 | router [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 16 ~ [INFO] [stdout] 17 ~ Router::new() [INFO] [stdout] 18 + .route("/posts", get(posts_list)) [INFO] [stdout] 19 + .route("/post", post(create_post)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/posts/services.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for PostService { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Self {} [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub struct PostService {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::MySql; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::MySql; [INFO] [stdout] 17 + Self::MySql [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | return Self::PostgreSql; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Self::PostgreSql; [INFO] [stdout] 19 + Self::PostgreSql [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Self::Sqlite; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Self::Sqlite; [INFO] [stdout] 21 + Self::Sqlite [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if !self.pool.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.pool.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/db.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 53 | let port = self.port.clone().unwrap_or(SupportsDBType::PostgreSql as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/db.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | let port = self.port.clone().unwrap_or(SupportsDBType::MySql as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / match result.err() { [INFO] [stdout] 48 | | Some(err) => { [INFO] [stdout] 49 | | println!("Error: {err}"); [INFO] [stdout] 50 | | exit(1); [INFO] [stdout] 51 | | }, [INFO] [stdout] 52 | | _ => (), [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Some(err) = result.err() { [INFO] [stdout] 48 + println!("Error: {err}"); [INFO] [stdout] 49 + exit(1); [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_host`, and `get_port` are never used [INFO] [stdout] --> src/config.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Config { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 8 | pub fn new(host: String, port: u16) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn get_host(&self) -> &String { &self.host } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | pub fn get_port(&self) -> &u16 { &self.port } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/db.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 38 | impl ApiDB { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 39 | pub fn new(host: String, port: Option) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/urls.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 7 | / let routers = Router::new() [INFO] [stdout] 8 | | .merge(get_post_routers()); [INFO] [stdout] | |___________________________________- unnecessary `let` binding [INFO] [stdout] 9 | routers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ Router::new() [INFO] [stdout] 9 + .merge(get_post_routers()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/posts/routers.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 16 | / let router = Router::new() [INFO] [stdout] 17 | | .route("/posts", get(posts_list)) [INFO] [stdout] 18 | | .route("/post", post(create_post)); [INFO] [stdout] | |___________________________________________- unnecessary `let` binding [INFO] [stdout] 19 | router [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 16 ~ [INFO] [stdout] 17 ~ Router::new() [INFO] [stdout] 18 + .route("/posts", get(posts_list)) [INFO] [stdout] 19 + .route("/post", post(create_post)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/posts/services.rs:61:1 [INFO] [stdout] | [INFO] [stdout] 61 | / impl Default for PostService { [INFO] [stdout] 62 | | fn default() -> Self { [INFO] [stdout] 63 | | Self {} [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub struct PostService {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::MySql; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::MySql; [INFO] [stdout] 17 + Self::MySql [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | return Self::PostgreSql; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Self::PostgreSql; [INFO] [stdout] 19 + Self::PostgreSql [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/db.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Self::Sqlite; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Self::Sqlite; [INFO] [stdout] 21 + Self::Sqlite [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/db.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if !self.pool.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.pool.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/db.rs:53:28 [INFO] [stdout] | [INFO] [stdout] 53 | let port = self.port.clone().unwrap_or(SupportsDBType::PostgreSql as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/db.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | let port = self.port.clone().unwrap_or(SupportsDBType::MySql as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / match result.err() { [INFO] [stdout] 48 | | Some(err) => { [INFO] [stdout] 49 | | println!("Error: {err}"); [INFO] [stdout] 50 | | exit(1); [INFO] [stdout] 51 | | }, [INFO] [stdout] 52 | | _ => (), [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Some(err) = result.err() { [INFO] [stdout] 48 + println!("Error: {err}"); [INFO] [stdout] 49 + exit(1); [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 05s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "ec786add98b31732c5d6036382850b9cafb53f7d127c5ea0b0fb322db7a06d08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec786add98b31732c5d6036382850b9cafb53f7d127c5ea0b0fb322db7a06d08", kill_on_drop: false }` [INFO] [stdout] ec786add98b31732c5d6036382850b9cafb53f7d127c5ea0b0fb322db7a06d08