[INFO] cloning repository https://github.com/sirfredrick/rust-sorting [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sirfredrick/rust-sorting" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsirfredrick%2Frust-sorting", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsirfredrick%2Frust-sorting'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8ef0a0540e0109932f75dd5385cf53715f23457c [INFO] linting sirfredrick/rust-sorting against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsirfredrick%2Frust-sorting" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sirfredrick/rust-sorting [INFO] finished tweaking git repo https://github.com/sirfredrick/rust-sorting [INFO] tweaked toml for git repo https://github.com/sirfredrick/rust-sorting written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sirfredrick/rust-sorting on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sirfredrick/rust-sorting already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: lib.rand [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fcd9d5fc5ddf5029adb55f92b843c30eac5089ce990e8820212ea573c8d7776 [INFO] running `Command { std: "docker" "start" "-a" "2fcd9d5fc5ddf5029adb55f92b843c30eac5089ce990e8820212ea573c8d7776", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fcd9d5fc5ddf5029adb55f92b843c30eac5089ce990e8820212ea573c8d7776", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fcd9d5fc5ddf5029adb55f92b843c30eac5089ce990e8820212ea573c8d7776", kill_on_drop: false }` [INFO] [stdout] 2fcd9d5fc5ddf5029adb55f92b843c30eac5089ce990e8820212ea573c8d7776 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 363e37fd1553300afdce4cab1cce306a9ee0cce9d09031b940391bd966954dad [INFO] running `Command { std: "docker" "start" "-a" "363e37fd1553300afdce4cab1cce306a9ee0cce9d09031b940391bd966954dad", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: lib.rand [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking sorting v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn merge(vect: &mut Vec, start: usize, middle: usize, end: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn merge(vect: &mut Vec, start: usize, middle: usize, end: usize) { [INFO] [stdout] 32 + fn merge(vect: &mut [i32], start: usize, middle: usize, end: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/lib.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / for i in 0..size1 { [INFO] [stdout] 43 | | left[i] = vect[start + i]; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `left[..size1].copy_from_slice(&vect[start..(size1 + start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn bubble_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - pub fn bubble_sort(vect: &mut Vec) { [INFO] [stdout] 88 + pub fn bubble_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `vect` manually [INFO] [stdout] --> src/lib.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | / let temp = vect[j]; [INFO] [stdout] 98 | | vect[j] = vect[j + 1]; [INFO] [stdout] 99 | | vect[j + 1] = temp; [INFO] [stdout] | |_______________________________________^ help: try: `vect.swap(j, j + 1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:113:29 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn gnome_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 113 - pub fn gnome_sort(vect: &mut Vec) { [INFO] [stdout] 113 + pub fn gnome_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | pos = pos + 1 [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `vect` manually [INFO] [stdout] --> src/lib.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | / let temp = vect[pos]; [INFO] [stdout] 120 | | vect[pos] = vect[pos - 1]; [INFO] [stdout] 121 | | vect[pos - 1] = temp; [INFO] [stdout] | |_____________________________________^ help: try: `vect.swap(pos, pos - 1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | pos = pos - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn bogo_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - pub fn bogo_sort(vect: &mut Vec) { [INFO] [stdout] 131 + pub fn bogo_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an outer doc comment and does not apply to the parent module or crate [INFO] [stdout] --> src/lib.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | ///! Test module for the sorting algorithms. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_doc_comments [INFO] [stdout] = note: `#[warn(clippy::suspicious_doc_comments)]` on by default [INFO] [stdout] help: use an inner doc comment to document the parent module or crate [INFO] [stdout] | [INFO] [stdout] 149 - ///! Test module for the sorting algorithms. [INFO] [stdout] 149 + //! Test module for the sorting algorithms. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 32 | fn merge(vect: &mut Vec, start: usize, middle: usize, end: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn merge(vect: &mut Vec, start: usize, middle: usize, end: usize) { [INFO] [stdout] 32 + fn merge(vect: &mut [i32], start: usize, middle: usize, end: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/lib.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / for i in 0..size1 { [INFO] [stdout] 43 | | left[i] = vect[start + i]; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: try replacing the loop by: `left[..size1].copy_from_slice(&vect[start..(size1 + start)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:88:30 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn bubble_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 88 - pub fn bubble_sort(vect: &mut Vec) { [INFO] [stdout] 88 + pub fn bubble_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `vect` manually [INFO] [stdout] --> src/lib.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 97 | / let temp = vect[j]; [INFO] [stdout] 98 | | vect[j] = vect[j + 1]; [INFO] [stdout] 99 | | vect[j + 1] = temp; [INFO] [stdout] | |_______________________________________^ help: try: `vect.swap(j, j + 1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:113:29 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn gnome_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 113 - pub fn gnome_sort(vect: &mut Vec) { [INFO] [stdout] 113 + pub fn gnome_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | pos = pos + 1 [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `vect` manually [INFO] [stdout] --> src/lib.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | / let temp = vect[pos]; [INFO] [stdout] 120 | | vect[pos] = vect[pos - 1]; [INFO] [stdout] 121 | | vect[pos - 1] = temp; [INFO] [stdout] | |_____________________________________^ help: try: `vect.swap(pos, pos - 1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | pos = pos - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:131:28 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn bogo_sort(vect: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - pub fn bogo_sort(vect: &mut Vec) { [INFO] [stdout] 131 + pub fn bogo_sort(vect: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/bin.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !line.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `line.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/bin.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if !val.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `line` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/bin.rs:33:25 [INFO] [stdout] | [INFO] [stdout] 31 | if !line.is_err() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 32 | // Unwrap the String [INFO] [stdout] 33 | let line2 = line.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `val` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/bin.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 43 | if !val.is_err() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 44 | // Unwrap and add the i32 to `vector` [INFO] [stdout] 45 | vector.push(val.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | 'S' | 's' | _ if { !vector.is_empty() } => { merge_sort(&mut vector, 0, length - 1) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | 'O' | 'o' | _ if { !vector.is_empty() } => { bubble_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | 'R' | 'r' | _ if { !vector.is_empty() } => { gnome_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | 'T' | 't' | _ if { !vector.is_empty() } => { bogo_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/bin.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | io::stdin().read_line(&mut input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = io::stdin().read_line(&mut input); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/bin.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if !line.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `line.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/bin.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | if !val.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `val.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `line` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/bin.rs:33:25 [INFO] [stdout] | [INFO] [stdout] 31 | if !line.is_err() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 32 | // Unwrap the String [INFO] [stdout] 33 | let line2 = line.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `val` after checking its variant with `is_err` [INFO] [stdout] --> src/bin/bin.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 43 | if !val.is_err() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 44 | // Unwrap and add the i32 to `vector` [INFO] [stdout] 45 | vector.push(val.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | 'S' | 's' | _ if { !vector.is_empty() } => { merge_sort(&mut vector, 0, length - 1) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | 'O' | 'o' | _ if { !vector.is_empty() } => { bubble_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | 'R' | 'r' | _ if { !vector.is_empty() } => { gnome_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bin/bin.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | 'T' | 't' | _ if { !vector.is_empty() } => { bogo_sort(&mut vector) }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/bin/bin.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | io::stdin().read_line(&mut input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = io::stdin().read_line(&mut input); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.49s [INFO] running `Command { std: "docker" "inspect" "363e37fd1553300afdce4cab1cce306a9ee0cce9d09031b940391bd966954dad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "363e37fd1553300afdce4cab1cce306a9ee0cce9d09031b940391bd966954dad", kill_on_drop: false }` [INFO] [stdout] 363e37fd1553300afdce4cab1cce306a9ee0cce9d09031b940391bd966954dad