[INFO] cloning repository https://github.com/simpukr/rust-brainfuck
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/simpukr/rust-brainfuck" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimpukr%2Frust-brainfuck", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimpukr%2Frust-brainfuck'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] a13060e7525f1d6b1fd599fa7be8d64c5779429e
[INFO] linting simpukr/rust-brainfuck against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimpukr%2Frust-brainfuck" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/simpukr/rust-brainfuck
[INFO] finished tweaking git repo https://github.com/simpukr/rust-brainfuck
[INFO] tweaked toml for git repo https://github.com/simpukr/rust-brainfuck written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/simpukr/rust-brainfuck on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/simpukr/rust-brainfuck already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0953e588e37c4b1674c04af74bc3b1903304cbab92b826a6c4c6e4ac681d42b6
[INFO] running `Command { std: "docker" "start" "-a" "0953e588e37c4b1674c04af74bc3b1903304cbab92b826a6c4c6e4ac681d42b6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0953e588e37c4b1674c04af74bc3b1903304cbab92b826a6c4c6e4ac681d42b6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0953e588e37c4b1674c04af74bc3b1903304cbab92b826a6c4c6e4ac681d42b6", kill_on_drop: false }`
[INFO] [stdout] 0953e588e37c4b1674c04af74bc3b1903304cbab92b826a6c4c6e4ac681d42b6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 3315946ed29b7498a51c56bddd558c3fd11ced11e2ae2c180093c699fe73981c
[INFO] running `Command { std: "docker" "start" "-a" "3315946ed29b7498a51c56bddd558c3fd11ced11e2ae2c180093c699fe73981c", kill_on_drop: false }`
[INFO] [stderr]     Checking rust-brainfuck v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/args.rs:16:28
[INFO] [stdout]    |
[INFO] [stdout] 16 |         return Ok(Config { files: files });
[INFO] [stdout]    |                            ^^^^^^^^^^^^ help: replace it with: `files`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:39:24
[INFO] [stdout]    |
[INFO] [stdout] 39 |             Some(b) => (return *b),
[INFO] [stdout]    |                        ^         ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 39 -             Some(b) => (return *b),
[INFO] [stdout] 39 +             Some(b) => return *b ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |             None => (0),
[INFO] [stdout]    |                     ^ ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 40 -             None => (0),
[INFO] [stdout] 40 +             None => 0 ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:50:24
[INFO] [stdout]    |
[INFO] [stdout] 50 |             Some(b) => (*b = data),
[INFO] [stdout]    |                        ^         ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 50 -             Some(b) => (*b = data),
[INFO] [stdout] 50 +             Some(b) => *b = data ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/token.rs:84:13
[INFO] [stdout]    |
[INFO] [stdout] 84 |             tokens: tokens,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/args.rs:16:28
[INFO] [stdout]    |
[INFO] [stdout] 16 |         return Ok(Config { files: files });
[INFO] [stdout]    |                            ^^^^^^^^^^^^ help: replace it with: `files`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:39:24
[INFO] [stdout]    |
[INFO] [stdout] 39 |             Some(b) => (return *b),
[INFO] [stdout]    |                        ^         ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 39 -             Some(b) => (return *b),
[INFO] [stdout] 39 +             Some(b) => return *b ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |             None => (0),
[INFO] [stdout]    |                     ^ ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 40 -             None => (0),
[INFO] [stdout] 40 +             None => 0 ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around match arm expression
[INFO] [stdout]   --> src/memory.rs:50:24
[INFO] [stdout]    |
[INFO] [stdout] 50 |             Some(b) => (*b = data),
[INFO] [stdout]    |                        ^         ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 50 -             Some(b) => (*b = data),
[INFO] [stdout] 50 +             Some(b) => *b = data ,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/token.rs:84:13
[INFO] [stdout]    |
[INFO] [stdout] 84 |             tokens: tokens,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `name` is never read
[INFO] [stdout]  --> src/files.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct File {
[INFO] [stdout]   |            ---- field in this struct
[INFO] [stdout] 4 |     pub name: String,
[INFO] [stdout]   |         ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/args.rs:14:9
[INFO] [stdout]    |
[INFO] [stdout] 14 |         return Err(format!("less number of arguments."));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -         return Err(format!("less number of arguments."));
[INFO] [stdout] 14 +         Err(format!("less number of arguments."))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/args.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 |         return Ok(Config { files: files });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -         return Ok(Config { files: files });
[INFO] [stdout] 16 +         Ok(Config { files: files })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/args.rs:13:8
[INFO] [stdout]    |
[INFO] [stdout] 13 |     if files.len() < 1 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/args.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |         return Err(format!("less number of arguments."));
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"less number of arguments.".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/files.rs:12:13
[INFO] [stdout]    |
[INFO] [stdout] 12 | /             return Ok(File {
[INFO] [stdout] 13 | |                 name: name.clone(),
[INFO] [stdout] 14 | |                 data: s,
[INFO] [stdout] 15 | |             });
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 ~             Ok(File {
[INFO] [stdout] 13 +                 name: name.clone(),
[INFO] [stdout] 14 +                 data: s,
[INFO] [stdout] 15 ~             })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/files.rs:17:19
[INFO] [stdout]    |
[INFO] [stdout] 17 |         Err(_) => return Err(format!("Cannot read file {}", name)),
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -         Err(_) => return Err(format!("Cannot read file {}", name)),
[INFO] [stdout] 17 +         Err(_) => Err(format!("Cannot read file {}", name)),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/memory.rs:9:9
[INFO] [stdout]    |
[INFO] [stdout]  9 | /         return Memory {
[INFO] [stdout] 10 | |             foreward: vec![0],
[INFO] [stdout] 11 | |             backward: Vec::new(),
[INFO] [stdout] 12 | |             pointer: 0,
[INFO] [stdout] 13 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout]  9 ~         Memory {
[INFO] [stdout] 10 +             foreward: vec![0],
[INFO] [stdout] 11 +             backward: Vec::new(),
[INFO] [stdout] 12 +             pointer: 0,
[INFO] [stdout] 13 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/memory.rs:25:15
[INFO] [stdout]    |
[INFO] [stdout] 25 |         while !(self.foreward.len() as isize > self.pointer) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.foreward.len() as isize <= self.pointer)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/memory.rs:28:15
[INFO] [stdout]    |
[INFO] [stdout] 28 |         while !(self.backward.len() as isize >= -self.pointer) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.backward.len() as isize) < -self.pointer)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/memory.rs:39:24
[INFO] [stdout]    |
[INFO] [stdout] 39 |             Some(b) => (return *b),
[INFO] [stdout]    |                        ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -             Some(b) => (return *b),
[INFO] [stdout] 39 +             Some(b) => *b,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]   --> src/program.rs:26:17
[INFO] [stdout]    |
[INFO] [stdout] 26 | /                 for byte in stdin().lock().bytes() {
[INFO] [stdout] 27 | |                     if let Ok(b) = byte {
[INFO] [stdout] 28 | |                         memory.set_data(b);
[INFO] [stdout] 29 | |                         break;
[INFO] [stdout] 30 | |                     }
[INFO] [stdout] 31 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]   --> src/program.rs:27:21
[INFO] [stdout]    |
[INFO] [stdout] 27 | /                     if let Ok(b) = byte {
[INFO] [stdout] 28 | |                         memory.set_data(b);
[INFO] [stdout] 29 | |                         break;
[INFO] [stdout] 30 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]    = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~                 for b in stdin().lock().bytes().flatten() {
[INFO] [stdout] 27 +                     memory.set_data(b);
[INFO] [stdout] 28 +                     break;
[INFO] [stdout] 29 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/program.rs:80:5
[INFO] [stdout]    |
[INFO] [stdout] 80 |     return program;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -     return program;
[INFO] [stdout] 80 +     program
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return tmp;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return tmp;
[INFO] [stdout] 28 +         tmp
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 | /         return Ok(TokenProgram {
[INFO] [stdout] 84 | |             tokens: tokens,
[INFO] [stdout] 85 | |             counter: 0,
[INFO] [stdout] 86 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 ~         Ok(TokenProgram {
[INFO] [stdout] 84 +             tokens: tokens,
[INFO] [stdout] 85 +             counter: 0,
[INFO] [stdout] 86 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return Err(format!("Braces mismatch \n{}", positions));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return Err(format!("Braces mismatch \n{}", positions));
[INFO] [stdout] 99 +         Err(format!("Braces mismatch \n{}", positions))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/token.rs:82:8
[INFO] [stdout]    |
[INFO] [stdout] 82 |     if braces.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `braces.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:13:44
[INFO] [stdout]    |
[INFO] [stdout] 13 |         files.push(extract(files::get_file(&name), "IO Error"));
[INFO] [stdout]    |                                            ^^^^^ help: change this to: `name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:30:18
[INFO] [stdout]    |
[INFO] [stdout] 30 |         Ok(d) => return d,
[INFO] [stdout]    |                  ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         Ok(d) => return d,
[INFO] [stdout] 30 +         Ok(d) => d,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `name` is never read
[INFO] [stdout]  --> src/files.rs:4:9
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct File {
[INFO] [stdout]   |            ---- field in this struct
[INFO] [stdout] 4 |     pub name: String,
[INFO] [stdout]   |         ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/args.rs:14:9
[INFO] [stdout]    |
[INFO] [stdout] 14 |         return Err(format!("less number of arguments."));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -         return Err(format!("less number of arguments."));
[INFO] [stdout] 14 +         Err(format!("less number of arguments."))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/args.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 |         return Ok(Config { files: files });
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -         return Ok(Config { files: files });
[INFO] [stdout] 16 +         Ok(Config { files: files })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/args.rs:13:8
[INFO] [stdout]    |
[INFO] [stdout] 13 |     if files.len() < 1 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/args.rs:14:20
[INFO] [stdout]    |
[INFO] [stdout] 14 |         return Err(format!("less number of arguments."));
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"less number of arguments.".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/files.rs:12:13
[INFO] [stdout]    |
[INFO] [stdout] 12 | /             return Ok(File {
[INFO] [stdout] 13 | |                 name: name.clone(),
[INFO] [stdout] 14 | |                 data: s,
[INFO] [stdout] 15 | |             });
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 ~             Ok(File {
[INFO] [stdout] 13 +                 name: name.clone(),
[INFO] [stdout] 14 +                 data: s,
[INFO] [stdout] 15 ~             })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/files.rs:17:19
[INFO] [stdout]    |
[INFO] [stdout] 17 |         Err(_) => return Err(format!("Cannot read file {}", name)),
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -         Err(_) => return Err(format!("Cannot read file {}", name)),
[INFO] [stdout] 17 +         Err(_) => Err(format!("Cannot read file {}", name)),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/memory.rs:9:9
[INFO] [stdout]    |
[INFO] [stdout]  9 | /         return Memory {
[INFO] [stdout] 10 | |             foreward: vec![0],
[INFO] [stdout] 11 | |             backward: Vec::new(),
[INFO] [stdout] 12 | |             pointer: 0,
[INFO] [stdout] 13 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout]  9 ~         Memory {
[INFO] [stdout] 10 +             foreward: vec![0],
[INFO] [stdout] 11 +             backward: Vec::new(),
[INFO] [stdout] 12 +             pointer: 0,
[INFO] [stdout] 13 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/memory.rs:25:15
[INFO] [stdout]    |
[INFO] [stdout] 25 |         while !(self.foreward.len() as isize > self.pointer) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.foreward.len() as isize <= self.pointer)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/memory.rs:28:15
[INFO] [stdout]    |
[INFO] [stdout] 28 |         while !(self.backward.len() as isize >= -self.pointer) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.backward.len() as isize) < -self.pointer)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/memory.rs:39:24
[INFO] [stdout]    |
[INFO] [stdout] 39 |             Some(b) => (return *b),
[INFO] [stdout]    |                        ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 39 -             Some(b) => (return *b),
[INFO] [stdout] 39 +             Some(b) => *b,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]   --> src/program.rs:26:17
[INFO] [stdout]    |
[INFO] [stdout] 26 | /                 for byte in stdin().lock().bytes() {
[INFO] [stdout] 27 | |                     if let Ok(b) = byte {
[INFO] [stdout] 28 | |                         memory.set_data(b);
[INFO] [stdout] 29 | |                         break;
[INFO] [stdout] 30 | |                     }
[INFO] [stdout] 31 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]   --> src/program.rs:27:21
[INFO] [stdout]    |
[INFO] [stdout] 27 | /                     if let Ok(b) = byte {
[INFO] [stdout] 28 | |                         memory.set_data(b);
[INFO] [stdout] 29 | |                         break;
[INFO] [stdout] 30 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]    = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~                 for b in stdin().lock().bytes().flatten() {
[INFO] [stdout] 27 +                     memory.set_data(b);
[INFO] [stdout] 28 +                     break;
[INFO] [stdout] 29 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/program.rs:80:5
[INFO] [stdout]    |
[INFO] [stdout] 80 |     return program;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 80 -     return program;
[INFO] [stdout] 80 +     program
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return tmp;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return tmp;
[INFO] [stdout] 28 +         tmp
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 | /         return Ok(TokenProgram {
[INFO] [stdout] 84 | |             tokens: tokens,
[INFO] [stdout] 85 | |             counter: 0,
[INFO] [stdout] 86 | |         });
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 ~         Ok(TokenProgram {
[INFO] [stdout] 84 +             tokens: tokens,
[INFO] [stdout] 85 +             counter: 0,
[INFO] [stdout] 86 ~         })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/token.rs:99:9
[INFO] [stdout]    |
[INFO] [stdout] 99 |         return Err(format!("Braces mismatch \n{}", positions));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -         return Err(format!("Braces mismatch \n{}", positions));
[INFO] [stdout] 99 +         Err(format!("Braces mismatch \n{}", positions))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/token.rs:82:8
[INFO] [stdout]    |
[INFO] [stdout] 82 |     if braces.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `braces.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:13:44
[INFO] [stdout]    |
[INFO] [stdout] 13 |         files.push(extract(files::get_file(&name), "IO Error"));
[INFO] [stdout]    |                                            ^^^^^ help: change this to: `name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:30:18
[INFO] [stdout]    |
[INFO] [stdout] 30 |         Ok(d) => return d,
[INFO] [stdout]    |                  ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 30 -         Ok(d) => return d,
[INFO] [stdout] 30 +         Ok(d) => d,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "3315946ed29b7498a51c56bddd558c3fd11ced11e2ae2c180093c699fe73981c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3315946ed29b7498a51c56bddd558c3fd11ced11e2ae2c180093c699fe73981c", kill_on_drop: false }`
[INFO] [stdout] 3315946ed29b7498a51c56bddd558c3fd11ced11e2ae2c180093c699fe73981c