[INFO] cloning repository https://github.com/simplysabir/smolcase [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/simplysabir/smolcase" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimplysabir%2Fsmolcase", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimplysabir%2Fsmolcase'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8cd2c0afe508cbd437da52338106210dd7d5f880 [INFO] linting simplysabir/smolcase against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimplysabir%2Fsmolcase" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/simplysabir/smolcase [INFO] finished tweaking git repo https://github.com/simplysabir/smolcase [INFO] tweaked toml for git repo https://github.com/simplysabir/smolcase written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/simplysabir/smolcase on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/simplysabir/smolcase already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rtoolbox v0.0.3 [INFO] [stderr] Downloaded hostname v0.4.1 [INFO] [stderr] Downloaded chacha20 v0.9.1 [INFO] [stderr] Downloaded dialoguer v0.10.4 [INFO] [stderr] Downloaded rpassword v7.4.0 [INFO] [stderr] Downloaded libz-sys v1.1.22 [INFO] [stderr] Downloaded openssl-src v300.5.1+3.5.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46733d6644051310944003fe997a702bcd7962548349de592151491f2491d429 [INFO] running `Command { std: "docker" "start" "-a" "46733d6644051310944003fe997a702bcd7962548349de592151491f2491d429", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46733d6644051310944003fe997a702bcd7962548349de592151491f2491d429", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46733d6644051310944003fe997a702bcd7962548349de592151491f2491d429", kill_on_drop: false }` [INFO] [stdout] 46733d6644051310944003fe997a702bcd7962548349de592151491f2491d429 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 567c1e4e493b63f7cd84be0298e6326479579b26cdc2c4d011ae9d05348499ec [INFO] running `Command { std: "docker" "start" "-a" "567c1e4e493b63f7cd84be0298e6326479579b26cdc2c4d011ae9d05348499ec", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking rtoolbox v0.0.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking hostname v0.4.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rpassword v7.4.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Compiling openssl-src v300.5.1+3.5.1 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking smolcase v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `colored::*` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use colored::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::credential_manager::CredentialManager` [INFO] [stdout] --> src/commands/setup.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::credential_manager::CredentialManager; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `colored::*` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use colored::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/config.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/credential_manager.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{Result, anyhow}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/credential_manager.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/credential_manager.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/crypto.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Time` [INFO] [stdout] --> src/git.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | use git2::{Repository, Signature, Time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::credential_manager::CredentialManager` [INFO] [stdout] --> src/commands/setup.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::credential_manager::CredentialManager; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/config.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use serde_yaml; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow` [INFO] [stdout] --> src/credential_manager.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use anyhow::{Result, anyhow}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/credential_manager.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/credential_manager.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize` and `Serialize` [INFO] [stdout] --> src/crypto.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | use serde::{Deserialize, Serialize}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Time` [INFO] [stdout] --> src/git.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | use git2::{Repository, Signature, Time}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/ui.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/ui.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use std::io::{self, Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `env` [INFO] [stdout] --> src/commands/apply.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | env: Option, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_env` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `env` [INFO] [stdout] --> src/commands/run.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub async fn execute(env: Option, command: Vec) -> Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_env` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `env` [INFO] [stdout] --> src/commands/apply.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | env: Option, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_env` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repo_path` [INFO] [stdout] --> src/commands/setup.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let repo_path = if let Some(repo) = repo { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repo_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `env` [INFO] [stdout] --> src/commands/run.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub async fn execute(env: Option, command: Vec) -> Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_env` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repo_path` [INFO] [stdout] --> src/commands/setup.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let repo_path = if let Some(repo) = repo { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_repo_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_username` is never used [INFO] [stdout] --> src/credential_manager.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl CredentialManager { [INFO] [stdout] | ---------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn get_username(cached_creds: &LocalCredentials) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `select` and `progress_bar` are never used [INFO] [stdout] --> src/ui.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl UI { [INFO] [stdout] | ------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn select(prompt: &str, items: &[&str]) -> Result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn progress_bar(len: u64, msg: &str) -> ProgressBar { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/apply.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 32 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 32 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 36 | } [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/apply.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | | user_found = true; [INFO] [stdout] 35 | | username = cached_username.clone(); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 33 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | user_found = true; [INFO] [stdout] 35 | username = cached_username.clone(); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/apply.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | / private_config [INFO] [stdout] 68 | | .groups [INFO] [stdout] 69 | | .get(group) [INFO] [stdout] 70 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 70 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 70 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/export.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 25 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 25 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 29 | } [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/export.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | | user_found = true; [INFO] [stdout] 28 | | username = cached_username.clone(); [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 26 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | user_found = true; [INFO] [stdout] 28 | username = cached_username.clone(); [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/export.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | / private_config [INFO] [stdout] 62 | | .groups [INFO] [stdout] 63 | | .get(group) [INFO] [stdout] 64 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 64 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 64 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/get.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 26 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 26 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 30 | } [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/get.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | | user_found = true; [INFO] [stdout] 29 | | username = cached_username.clone(); [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 27 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | user_found = true; [INFO] [stdout] 29 | username = cached_username.clone(); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/get.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / private_config [INFO] [stdout] 56 | | .groups [INFO] [stdout] 57 | | .get(group) [INFO] [stdout] 58 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 58 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 58 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_username` is never used [INFO] [stdout] --> src/credential_manager.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl CredentialManager { [INFO] [stdout] | ---------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn get_username(cached_creds: &LocalCredentials) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `select` and `progress_bar` are never used [INFO] [stdout] --> src/ui.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 8 | impl UI { [INFO] [stdout] | ------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn select(prompt: &str, items: &[&str]) -> Result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn progress_bar(len: u64, msg: &str) -> ProgressBar { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/init.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / if use_git { [INFO] [stdout] 57 | | if UI::confirm("Add GitHub/GitLab remote now?")? { [INFO] [stdout] 58 | | let remote = UI::input("Repository URL (e.g., https://github.com/user/secrets)")?; [INFO] [stdout] 59 | | if !remote.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if use_git [INFO] [stdout] 57 ~ && UI::confirm("Add GitHub/GitLab remote now?")? { [INFO] [stdout] 58 | let remote = UI::input("Repository URL (e.g., https://github.com/user/secrets)")?; [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/apply.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 32 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 32 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 36 | } [INFO] [stdout] 37 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/apply.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 33 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | | user_found = true; [INFO] [stdout] 35 | | username = cached_username.clone(); [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 33 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 34 | user_found = true; [INFO] [stdout] 35 | username = cached_username.clone(); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/apply.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 67 | / private_config [INFO] [stdout] 68 | | .groups [INFO] [stdout] 69 | | .get(group) [INFO] [stdout] 70 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 70 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 70 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/init.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | / if let Some(remote_url) = git_remote { [INFO] [stdout] 172 | | if UI::confirm(&format!("Add remote origin: {}?", remote_url))? { [INFO] [stdout] 173 | | std::process::Command::new("git") [INFO] [stdout] 174 | | .args(&["remote", "add", "origin", &remote_url]) [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ if let Some(remote_url) = git_remote [INFO] [stdout] 172 ~ && UI::confirm(&format!("Add remote origin: {}?", remote_url))? { [INFO] [stdout] 173 | std::process::Command::new("git") [INFO] [stdout] ... [INFO] [stdout] 179 | UI::info("Run 'git push -u origin main' to push to remote"); [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/init.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | .args(&["remote", "add", "origin", &remote_url]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["remote", "add", "origin", &remote_url]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/export.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 25 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 25 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 29 | } [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/export.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 26 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | | user_found = true; [INFO] [stdout] 28 | | username = cached_username.clone(); [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 26 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 27 | user_found = true; [INFO] [stdout] 28 | username = cached_username.clone(); [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/export.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | / private_config [INFO] [stdout] 62 | | .groups [INFO] [stdout] 63 | | .get(group) [INFO] [stdout] 64 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 64 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 64 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/run.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 28 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 28 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 32 | } [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/run.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | | user_found = true; [INFO] [stdout] 31 | | username = cached_username.clone(); [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 29 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | user_found = true; [INFO] [stdout] 31 | username = cached_username.clone(); [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/get.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 26 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 26 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 30 | } [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/get.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 27 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | | user_found = true; [INFO] [stdout] 29 | | username = cached_username.clone(); [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 27 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 28 | user_found = true; [INFO] [stdout] 29 | username = cached_username.clone(); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/get.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / private_config [INFO] [stdout] 56 | | .groups [INFO] [stdout] 57 | | .get(group) [INFO] [stdout] 58 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 58 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 58 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/run.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | / private_config [INFO] [stdout] 64 | | .groups [INFO] [stdout] 65 | | .get(group) [INFO] [stdout] 66 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 66 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/commands/setup.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | let repo_name = repo [INFO] [stdout] | _____________________________^ [INFO] [stdout] 13 | | .split('/') [INFO] [stdout] 14 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 - .last() [INFO] [stdout] 14 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/status.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | if !cached_creds.master_key.is_some() || !cached_creds.user_password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_creds.master_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/status.rs:116:46 [INFO] [stdout] | [INFO] [stdout] 116 | if !cached_creds.master_key.is_some() || !cached_creds.user_password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_creds.user_password.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/init.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | / if use_git { [INFO] [stdout] 57 | | if UI::confirm("Add GitHub/GitLab remote now?")? { [INFO] [stdout] 58 | | let remote = UI::input("Repository URL (e.g., https://github.com/user/secrets)")?; [INFO] [stdout] 59 | | if !remote.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if use_git [INFO] [stdout] 57 ~ && UI::confirm("Add GitHub/GitLab remote now?")? { [INFO] [stdout] 58 | let remote = UI::input("Repository URL (e.g., https://github.com/user/secrets)")?; [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/init.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | / if let Some(remote_url) = git_remote { [INFO] [stdout] 172 | | if UI::confirm(&format!("Add remote origin: {}?", remote_url))? { [INFO] [stdout] 173 | | std::process::Command::new("git") [INFO] [stdout] 174 | | .args(&["remote", "add", "origin", &remote_url]) [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ if let Some(remote_url) = git_remote [INFO] [stdout] 172 ~ && UI::confirm(&format!("Add remote origin: {}?", remote_url))? { [INFO] [stdout] 173 | std::process::Command::new("git") [INFO] [stdout] ... [INFO] [stdout] 179 | UI::info("Run 'git push -u origin main' to push to remote"); [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/commands/init.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | .args(&["remote", "add", "origin", &remote_url]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["remote", "add", "origin", &remote_url]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/run.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / if let Some(cached_username) = &cached_creds.username { [INFO] [stdout] 28 | | if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | | user_found = true; [INFO] [stdout] ... | [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if let Some(cached_username) = &cached_creds.username [INFO] [stdout] 28 ~ && let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] ... [INFO] [stdout] 32 | } [INFO] [stdout] 33 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/commands/run.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(user) = private_config.users.get(cached_username) { [INFO] [stdout] 29 | | if CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | | user_found = true; [INFO] [stdout] 31 | | username = cached_username.clone(); [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(user) = private_config.users.get(cached_username) [INFO] [stdout] 29 ~ && CryptoManager::verify_password(&user_password, &user.password_hash)? { [INFO] [stdout] 30 | user_found = true; [INFO] [stdout] 31 | username = cached_username.clone(); [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/commands/run.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | / private_config [INFO] [stdout] 64 | | .groups [INFO] [stdout] 65 | | .get(group) [INFO] [stdout] 66 | | .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 66 - .map_or(false, |g| g.members.contains(&username)) [INFO] [stdout] 66 + .is_some_and(|g| g.members.contains(&username)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/commands/setup.rs:12:29 [INFO] [stdout] | [INFO] [stdout] 12 | let repo_name = repo [INFO] [stdout] | _____________________________^ [INFO] [stdout] 13 | | .split('/') [INFO] [stdout] 14 | | .last() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 14 - .last() [INFO] [stdout] 14 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/status.rs:116:8 [INFO] [stdout] | [INFO] [stdout] 116 | if !cached_creds.master_key.is_some() || !cached_creds.user_password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_creds.master_key.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands/status.rs:116:46 [INFO] [stdout] | [INFO] [stdout] 116 | if !cached_creds.master_key.is_some() || !cached_creds.user_password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_creds.user_password.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(password) = &cached_creds.admin_password { [INFO] [stdout] 76 | | if !password.is_empty() { [INFO] [stdout] 77 | | return Ok(password.clone()); [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ if let Some(password) = &cached_creds.admin_password [INFO] [stdout] 76 ~ && !password.is_empty() { [INFO] [stdout] 77 | return Ok(password.clone()); [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / if let Some(password) = &cached_creds.user_password { [INFO] [stdout] 85 | | if !password.is_empty() { [INFO] [stdout] 86 | | return Ok(password.clone()); [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if let Some(password) = &cached_creds.user_password [INFO] [stdout] 85 ~ && !password.is_empty() { [INFO] [stdout] 86 | return Ok(password.clone()); [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / if let Some(key) = &cached_creds.master_key { [INFO] [stdout] 94 | | if !key.is_empty() { [INFO] [stdout] 95 | | return Ok(key.clone()); [INFO] [stdout] 96 | | } [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 93 ~ if let Some(key) = &cached_creds.master_key [INFO] [stdout] 94 ~ && !key.is_empty() { [INFO] [stdout] 95 | return Ok(key.clone()); [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Some(username) = &cached_creds.username { [INFO] [stdout] 103 | | if !username.is_empty() { [INFO] [stdout] 104 | | return Ok(username.clone()); [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some(username) = &cached_creds.username [INFO] [stdout] 103 ~ && !username.is_empty() { [INFO] [stdout] 104 | return Ok(username.clone()); [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(password) = &cached_creds.admin_password { [INFO] [stdout] 76 | | if !password.is_empty() { [INFO] [stdout] 77 | | return Ok(password.clone()); [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 75 ~ if let Some(password) = &cached_creds.admin_password [INFO] [stdout] 76 ~ && !password.is_empty() { [INFO] [stdout] 77 | return Ok(password.clone()); [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / if let Some(password) = &cached_creds.user_password { [INFO] [stdout] 85 | | if !password.is_empty() { [INFO] [stdout] 86 | | return Ok(password.clone()); [INFO] [stdout] 87 | | } [INFO] [stdout] 88 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ if let Some(password) = &cached_creds.user_password [INFO] [stdout] 85 ~ && !password.is_empty() { [INFO] [stdout] 86 | return Ok(password.clone()); [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / if let Some(key) = &cached_creds.master_key { [INFO] [stdout] 94 | | if !key.is_empty() { [INFO] [stdout] 95 | | return Ok(key.clone()); [INFO] [stdout] 96 | | } [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 93 ~ if let Some(key) = &cached_creds.master_key [INFO] [stdout] 94 ~ && !key.is_empty() { [INFO] [stdout] 95 | return Ok(key.clone()); [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/credential_manager.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Some(username) = &cached_creds.username { [INFO] [stdout] 103 | | if !username.is_empty() { [INFO] [stdout] 104 | | return Ok(username.clone()); [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some(username) = &cached_creds.username [INFO] [stdout] 103 ~ && !username.is_empty() { [INFO] [stdout] 104 | return Ok(username.clone()); [INFO] [stdout] 105 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/types.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for EncryptedData { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | salt: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 35 + #[derive(Default)] [INFO] [stdout] 36 | pub struct EncryptedData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/types.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | / impl Default for EncryptedData { [INFO] [stdout] 41 | | fn default() -> Self { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | salt: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 35 + #[derive(Default)] [INFO] [stdout] 36 | pub struct EncryptedData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 01s [INFO] running `Command { std: "docker" "inspect" "567c1e4e493b63f7cd84be0298e6326479579b26cdc2c4d011ae9d05348499ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "567c1e4e493b63f7cd84be0298e6326479579b26cdc2c4d011ae9d05348499ec", kill_on_drop: false }` [INFO] [stdout] 567c1e4e493b63f7cd84be0298e6326479579b26cdc2c4d011ae9d05348499ec